Coduo\TuTu\Request\Path\Parser::extractPlaceholders()

Complexity

Conditions	4
Paths	5

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function extractPlaceholders(Request $request, $pathPattern)
    {
        preg_match_all('#\{\w+\}#', $pathPattern, $placeholders, PREG_OFFSET_CAPTURE | PREG_SET_ORDER);

        if (!count($placeholders)) {
            return array();
        }

        $placeholderNames = array();
        foreach ($placeholders as $placeholderMatch) {

The expression $placeholders of type null|array<integer,array<integer,string>> is not guaranteed to be traversable. How about adding an additional type check?

            $placeholder = $placeholderMatch[0][0];
            $placeholderNames[] = substr($placeholder, 1, -1);
            $pathPattern = str_replace($placeholder, '__PLACEHOLDER__', $pathPattern);
        }

        $pathPattern = '/^' . str_replace('__PLACEHOLDER__', '([^\/]*)', preg_quote($pathPattern, '/')) . '$/i';

        if (0 === preg_match($pathPattern, $request->getPathInfo(), $matches)) {
            return array();
        }

        return array_combine(
            $placeholderNames,
            array_slice($matches, 1, count($placeholders))
        );
    }
}