Completed
Push — master ( c5de01...c9c19d )
by
unknown
07:34 queued 05:10
created

ParameterMatchingPolicy   A

Complexity

Total Complexity 10

Size/Duplication

Total Lines 45
Duplicated Lines 37.78 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 10
lcom 1
cbo 2
dl 17
loc 45
rs 10
c 0
b 0
f 0

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 0 4 1
D match() 17 27 9

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Coduo\TuTu\Request;
4
5
use Coduo\PHPMatcher\Matcher;
6
use Coduo\TuTu\Config\Element;
7
use Symfony\Component\HttpFoundation\Request;
8
9
class ParameterMatchingPolicy implements MatchingPolicy
10
{
11
    /**
12
     * @var \Coduo\PHPMatcher\Matcher
13
     */
14
    private $phpMatcher;
15
16
    public function __construct(Matcher $phpMatcher)
17
    {
18
        $this->phpMatcher = $phpMatcher;
19
    }
20
21
    /**
22
     * @param Request $request
23
     * @param Element $config
24
     * @return boolean
25
     */
26
    public function match(Request $request, Element $config)
27
    {
28
        if (!$config->getRequest()->hasBodyParameters() && !$config->getRequest()->hasQueryParameters()) {
29
            return true;
30
        }
31
32 View Code Duplication
        foreach ($config->getRequest()->getQueryParameters() as $name => $valuePattern) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
33
            if (!$request->query->has($name)) {
34
                return false;
35
            }
36
            if (!$this->phpMatcher->match($request->query->get($name), $valuePattern)) {
37
                return false;
38
            }
39
        }
40
41 View Code Duplication
        foreach ($config->getRequest()->getBodyParameters() as $name => $valuePattern) {
0 ignored issues
show
Duplication introduced by
This code seems to be duplicated across your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
42
            if (!$request->request->has($name)) {
43
                return false;
44
            }
45
46
            if (!$this->phpMatcher->match($request->request->get($name), $valuePattern)) {
47
                return false;
48
            }
49
        }
50
51
        return true;
52
    }
53
}
54