Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
29 | View Code Duplication | class Message implements \ArrayAccess |
|
|
|||
30 | { |
||
31 | /** @} */ |
||
32 | |||
33 | use EntityAccess; |
||
34 | |||
35 | /** |
||
36 | * \brief Get text parameter if it is set. |
||
37 | * @return string If set or <code>null</code> otherwise. |
||
38 | */ |
||
39 | 3 | public function getText() : string |
|
43 | |||
44 | /** |
||
45 | * \brief Get the chat ID where the result comes from. |
||
46 | * @return $chat_id Chat ID. |
||
47 | */ |
||
48 | 3 | public function getChatID() |
|
52 | |||
53 | 3 | public function getMessageId() : int |
|
57 | } |
||
58 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.