ClientResource::__construct() - Code Metrics - Inspection of "refactor: separate requests and responses in folde..." - DansMaCulotte/monetico-php - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f4ebb6...c31285 )

by Gaël

created 2019-08-27 14:29 UTC

ClientResource::__construct() A

↳ Parent: ClientResource

Complexity

Conditions	1
Paths	1

Size

Total Lines	77
Code Lines	38

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	38
nc	1
nop	37
dl	0
loc	77
rs	9.312
c	0
b	0
f	0

How to fix Long Method Many Parameters

<?php

namespace DansMaCulotte\Monetico\Resources;

class ClientResource
{
    /** @var array */
    public $data = [];

    /**
     * Client constructor.
     *
     * @param string|null $civility
     * @param string|null $name
     * @param string|null $firstName
     * @param string|null $lastName
     * @param string|null $middleName
     * @param string|null $address
     * @param string|null $addressLine1
     * @param string|null $addressLine2
     * @param string|null $addressLine3
     * @param string|null $city
     * @param string|null $postalCode
     * @param string|null $country
     * @param string|null $stateOrProvince
     * @param string|null $countrySubdivision
     * @param string|null $email
     * @param string|null $birthLastName
     * @param string|null $birthCity
     * @param string|null $birthPostalCode
     * @param string|null $birthCountry
     * @param string|null $birthStateOrProvince
     * @param string|null $birthCountrySubdivision
     * @param string|null $birthdate
     * @param string|null $phone
     * @param string|null $nationalIDNumber
     * @param string|null $suspiciousAccountActivity
     * @param string|null $authenticationMethod
     * @param string|null $authenticationTimestamp
     * @param string|null $priorAuthenticationMethod
     * @param string|null $priorAuthenticationTimestamp
     * @param string|null $paymentMeanAge
     * @param string|null $lastYearTransactions
     * @param string|null $last24HoursTransactions
     * @param string|null $addCardNbLast24Hours
     * @param string|null $last6MonthsPurchase
     * @param string|null $lastPasswordChange
     * @param string|null $accountAge
     * @param string|null $lastAccountModification
     */
    public function __construct(
        string $civility = null,
        string $name = null,
        string $firstName = null,
        string $lastName = null,
        string $middleName = null,
        string $address = null,
        string $addressLine1 = null,
        string $addressLine2 = null,
        string $addressLine3 = null,
        string $city = null,
        string $postalCode = null,
        string $country = null,
        string $stateOrProvince = null,
        string $countrySubdivision = null,
        string $email = null,
        string $birthLastName = null,
        string $birthCity = null,
        string $birthPostalCode = null,
        string $birthCountry = null,
        string $birthStateOrProvince = null,
        string $birthCountrySubdivision = null,
        string $birthdate = null,
        string $phone = null,
        string $nationalIDNumber = null,
        string $suspiciousAccountActivity = null,
        string $authenticationMethod = null,
        string $authenticationTimestamp = null,
        string $priorAuthenticationMethod = null,
        string $priorAuthenticationTimestamp = null,
        string $paymentMeanAge = null,
        string $lastYearTransactions = null,
        string $last24HoursTransactions = null,
        string $addCardNbLast24Hours = null,
        string $last6MonthsPurchase = null,
        string $lastPasswordChange = null,
        string $accountAge = null,
        string $lastAccountModification = null
    ) {
        $this->data = [
            'civility' => $civility,
            'name' => $name,
            'firstName' => $firstName,
            'lastName' => $lastName,
            'middleName' => $middleName,
            'address' => $address,
            'addressLine1' => $addressLine1,
            'addressLine2' => $addressLine2,
            'addressLine3' => $addressLine3,
            'city' => $city,
            'postalCode' => $postalCode,
            'country' => $country,
            'stateOrProvince' => $stateOrProvince,
            'countrySubdivision' => $countrySubdivision,
            'email' => $email,
            'birthLastName' => $birthLastName,
            'birthCity' => $birthCity,
            'birthPostalCode' => $birthPostalCode,
            'birthCountry' => $birthCountry,
            'birthStateOrProvince' => $birthStateOrProvince,
            'birthCountrySubdivision' => $birthCountrySubdivision,
            'birthdate' => $birthdate,
            'phone' => $phone,
            'nationalIDNumber' => $nationalIDNumber,
            'suspiciousAccountActivity' => $suspiciousAccountActivity,
            'authenticationMethod' => $authenticationMethod,
            'authenticationTimestamp' => $authenticationTimestamp,
            'priorAuthenticationMethod' => $priorAuthenticationMethod,
            'priorAuthenticationTimestamp' => $priorAuthenticationTimestamp,
            'paymentMeanAge' => $paymentMeanAge,
            'lastYearTransactions' => $lastYearTransactions,
            'last24HoursTransactions' => $last24HoursTransactions,
            'addCardNbLast24Hours' => $addCardNbLast24Hours,
            'last6MonthsPurchase' => $last6MonthsPurchase,
            'lastPasswordChange' => $lastPasswordChange,
            'accountAge' => $accountAge,
            'lastAccountModification' => $lastAccountModification,
        ];
    }
}


1			<?php
2
3			namespace DansMaCulotte\Monetico\Resources;
4
5			class ClientResource
6			{
7			/** @var array */
8			public $data = [];
9
10			/**
11			* Client constructor.
12			*
13			* @param string\|null $civility
14			* @param string\|null $name
15			* @param string\|null $firstName
16			* @param string\|null $lastName
17			* @param string\|null $middleName
18			* @param string\|null $address
19			* @param string\|null $addressLine1
20			* @param string\|null $addressLine2
21			* @param string\|null $addressLine3
22			* @param string\|null $city
23			* @param string\|null $postalCode
24			* @param string\|null $country
25			* @param string\|null $stateOrProvince
26			* @param string\|null $countrySubdivision
27			* @param string\|null $email
28			* @param string\|null $birthLastName
29			* @param string\|null $birthCity
30			* @param string\|null $birthPostalCode
31			* @param string\|null $birthCountry
32			* @param string\|null $birthStateOrProvince
33			* @param string\|null $birthCountrySubdivision
34			* @param string\|null $birthdate
35			* @param string\|null $phone
36			* @param string\|null $nationalIDNumber
37			* @param string\|null $suspiciousAccountActivity
38			* @param string\|null $authenticationMethod
39			* @param string\|null $authenticationTimestamp
40			* @param string\|null $priorAuthenticationMethod
41			* @param string\|null $priorAuthenticationTimestamp
42			* @param string\|null $paymentMeanAge
43			* @param string\|null $lastYearTransactions
44			* @param string\|null $last24HoursTransactions
45			* @param string\|null $addCardNbLast24Hours
46			* @param string\|null $last6MonthsPurchase
47			* @param string\|null $lastPasswordChange
48			* @param string\|null $accountAge
49			* @param string\|null $lastAccountModification
50			*/
51			public function __construct(
52			string $civility = null,
53			string $name = null,
54			string $firstName = null,
55			string $lastName = null,
56			string $middleName = null,
57			string $address = null,
58			string $addressLine1 = null,
59			string $addressLine2 = null,
60			string $addressLine3 = null,
61			string $city = null,
62			string $postalCode = null,
63			string $country = null,
64			string $stateOrProvince = null,
65			string $countrySubdivision = null,
66			string $email = null,
67			string $birthLastName = null,
68			string $birthCity = null,
69			string $birthPostalCode = null,
70			string $birthCountry = null,
71			string $birthStateOrProvince = null,
72			string $birthCountrySubdivision = null,
73			string $birthdate = null,
74			string $phone = null,
75			string $nationalIDNumber = null,
76			string $suspiciousAccountActivity = null,
77			string $authenticationMethod = null,
78			string $authenticationTimestamp = null,
79			string $priorAuthenticationMethod = null,
80			string $priorAuthenticationTimestamp = null,
81			string $paymentMeanAge = null,
82			string $lastYearTransactions = null,
83			string $last24HoursTransactions = null,
84			string $addCardNbLast24Hours = null,
85			string $last6MonthsPurchase = null,
86			string $lastPasswordChange = null,
87			string $accountAge = null,
88			string $lastAccountModification = null
89			) {
90			$this->data = [
91			'civility' => $civility,
92			'name' => $name,
93			'firstName' => $firstName,
94			'lastName' => $lastName,
95			'middleName' => $middleName,
96			'address' => $address,
97			'addressLine1' => $addressLine1,
98			'addressLine2' => $addressLine2,
99			'addressLine3' => $addressLine3,
100			'city' => $city,
101			'postalCode' => $postalCode,
102			'country' => $country,
103			'stateOrProvince' => $stateOrProvince,
104			'countrySubdivision' => $countrySubdivision,
105			'email' => $email,
106			'birthLastName' => $birthLastName,
107			'birthCity' => $birthCity,
108			'birthPostalCode' => $birthPostalCode,
109			'birthCountry' => $birthCountry,
110			'birthStateOrProvince' => $birthStateOrProvince,
111			'birthCountrySubdivision' => $birthCountrySubdivision,
112			'birthdate' => $birthdate,
113			'phone' => $phone,
114			'nationalIDNumber' => $nationalIDNumber,
115			'suspiciousAccountActivity' => $suspiciousAccountActivity,
116			'authenticationMethod' => $authenticationMethod,
117			'authenticationTimestamp' => $authenticationTimestamp,
118			'priorAuthenticationMethod' => $priorAuthenticationMethod,
119			'priorAuthenticationTimestamp' => $priorAuthenticationTimestamp,
120			'paymentMeanAge' => $paymentMeanAge,
121			'lastYearTransactions' => $lastYearTransactions,
122			'last24HoursTransactions' => $last24HoursTransactions,
123			'addCardNbLast24Hours' => $addCardNbLast24Hours,
124			'last6MonthsPurchase' => $last6MonthsPurchase,
125			'lastPasswordChange' => $lastPasswordChange,
126			'accountAge' => $accountAge,
127			'lastAccountModification' => $lastAccountModification,
128			];
129			}
130			}
131

DansMaCulotte / monetico-php

Push — master ( f4ebb6...c31285 )

ClientResource::__construct() A

Complexity

Size

Duplication

Importance

How to fix Long Method Many Parameters

Long Method

Many Parameters

Duplication Side-by-Side

Filter issues like