Database::connection() - Code Metrics - Inspection of "Add Scrutinizer badge" - Daniel-Griffiths/vertex - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Branch — master (16012d)

by Daniel

created 2017-06-12 18:59 UTC

Database::connection() A

↳ Parent: Database

Complexity

Conditions	3
Paths	5

Size

Total Lines	15
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	5
nop	1

<?php

namespace Vertex\Core;

use Vertex\Core\Traits\SingletonTrait;
use Exception;
use PDO;

class Database
{
    use SingletonTrait;

    /**
     * Connect to the appropriate database
     * based on the details specified in
     * the configuration file.
     * 
     * @param  array  $config 
     * @return PDO       
     */
    public function connection(array $config)
    {
        if ($config['enabled'] == 'false') {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        try{
            $instance = new PDO($this->loadConfig($config), $config['mysql']['username'], $config['mysql']['password']);
            $instance->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
            $instance->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_OBJ);
            return $instance;
        } catch (PDOException $e) {

            die($e->getMessage());

        }
    }

    /**
     * Load the configuration.
     * 
     * @param  array  $config 
     * @return PDO
     */
    public function loadConfig(array $config)
    {
        switch ($config['connection']) {
            case 'mysql':
                return $connection = 'mysql:host=' . $config['mysql']['host'] . ';dbname=' . $config['mysql']['database'];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            case 'sqlite':
                return $connection = 'sqlite:' . __DIR__ . '/database/' . $config['sqlite']['database'] . '.sqlite';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            default:
                throw new Exception('Connection type not supported');
        }
    }
}


1			<?php
2
3			namespace Vertex\Core;
4
5			use Vertex\Core\Traits\SingletonTrait;
6			use Exception;
7			use PDO;
8
9			class Database
10			{
11			use SingletonTrait;
12
13			/**
14			* Connect to the appropriate database
15			* based on the details specified in
16			* the configuration file.
17			*
18			* @param array $config
19			* @return PDO
20			*/
21			public function connection(array $config)
22			{
23			if ($config['enabled'] == 'false') {
24			return false;
			0 ignored issues – show Bug Best Practice introduced 2017-06-12 19:01 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type documented by `Vertex\Core\Database::connection` of type `PDO\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
25			}
26
27			try{
28			$instance = new PDO($this->loadConfig($config), $config['mysql']['username'], $config['mysql']['password']);
29			$instance->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
30			$instance->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_OBJ);
31			return $instance;
32			} catch (PDOException $e) {
			0 ignored issues – show Bug introduced 2017-06-12 19:01 UTC by Report Bug Copy Issue Report The class `Vertex\Core\PDOException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
33			die($e->getMessage());
			0 ignored issues – show Coding Style Compatibility introduced 2017-06-12 19:01 UTC by Report Bug Copy Issue Report The method `connection()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
34			}
35			}
36
37			/**
38			* Load the configuration.
39			*
40			* @param array $config
41			* @return PDO
42			*/
43			public function loadConfig(array $config)
44			{
45			switch ($config['connection']) {
46			case 'mysql':
47			return $connection = 'mysql:host=' . $config['mysql']['host'] . ';dbname=' . $config['mysql']['database'];
			0 ignored issues – show Unused Code introduced 2017-06-12 19:01 UTC by Report Bug Copy Issue Report `$connection` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
48			case 'sqlite':
49			return $connection = 'sqlite:' . __DIR__ . '/database/' . $config['sqlite']['database'] . '.sqlite';
			0 ignored issues – show Unused Code introduced 2017-06-12 19:01 UTC by Report Bug Copy Issue Report `$connection` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
50			default:
51			throw new Exception('Connection type not supported');
52			}
53			}
54			}
55

Daniel-Griffiths / vertex

Branch — master (16012d)

Database::connection() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like