TableSchemaSubscriber::getSubscribedEvents() - Code Metrics - Inspection of "Adding TODOs related to next major release" - DamienHarper/auditor - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — multiple-schemas-support ( 638643 )

by Damien

created 2022-11-22 17:23 UTC

TableSchemaSubscriber::getSubscribedEvents() A

↳ Parent: TableSchemaSubscriber

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	1
c	1
b	0
f	0
dl	0
loc	3
rs	10
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace DH\Auditor\Provider\Doctrine\Persistence\Event;

use DH\Auditor\Provider\Doctrine\DoctrineProvider;
use DH\Auditor\Provider\Doctrine\Persistence\Schema\SchemaManager;
use DH\Auditor\Provider\Doctrine\Service\StorageService;
use Doctrine\Common\EventSubscriber;
use Doctrine\ORM\Event\LoadClassMetadataEventArgs;

class TableSchemaSubscriber implements EventSubscriber
{
    private DoctrineProvider $provider;

    public function __construct(DoctrineProvider $provider)
    {
        $this->provider = $provider;
    }

    public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void
    {
        $classMetadata = $eventArgs->getClassMetadata();
        if (!$classMetadata->isInheritanceTypeSingleTable() || $classMetadata->getName() === $classMetadata->rootEntityName) {

            $schemaManager = new SchemaManager($this->provider);
            $storageService = $this->provider->getStorageServiceForEntity($classMetadata->getName());

            \assert($storageService instanceof StorageService);
            $platform = $storageService->getEntityManager()->getConnection()->getDatabasePlatform();
            if (!$platform->supportsSchemas()) {
                $classMetadata->setPrimaryTable([
                    'name' => $schemaManager->resolveTableName($classMetadata->getTableName(), $classMetadata->getSchemaName() ?? '', $platform),
                    'schema' => '',
                ]);
            }
        }
    }

    public function getSubscribedEvents()
    {
        return ['loadClassMetadata'];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace DH\Auditor\Provider\Doctrine\Persistence\Event;
6
7			use DH\Auditor\Provider\Doctrine\DoctrineProvider;
8			use DH\Auditor\Provider\Doctrine\Persistence\Schema\SchemaManager;
9			use DH\Auditor\Provider\Doctrine\Service\StorageService;
10			use Doctrine\Common\EventSubscriber;
11			use Doctrine\ORM\Event\LoadClassMetadataEventArgs;
12
13			class TableSchemaSubscriber implements EventSubscriber
14			{
15			private DoctrineProvider $provider;
16
17			public function __construct(DoctrineProvider $provider)
18			{
19			$this->provider = $provider;
20			}
21
22			public function loadClassMetadata(LoadClassMetadataEventArgs $eventArgs): void
23			{
24			$classMetadata = $eventArgs->getClassMetadata();
25			if (!$classMetadata->isInheritanceTypeSingleTable() \|\| $classMetadata->getName() === $classMetadata->rootEntityName) {
			0 ignored issues – show Bug introduced 2022-11-22 17:31 UTC by Report Bug Copy Issue Report Accessing `rootEntityName` on the interface `Doctrine\Persistence\Mapping\ClassMetadata` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
26			$schemaManager = new SchemaManager($this->provider);
27			$storageService = $this->provider->getStorageServiceForEntity($classMetadata->getName());
28
29			\assert($storageService instanceof StorageService);
30			$platform = $storageService->getEntityManager()->getConnection()->getDatabasePlatform();
31			if (!$platform->supportsSchemas()) {
32			$classMetadata->setPrimaryTable([
33			'name' => $schemaManager->resolveTableName($classMetadata->getTableName(), $classMetadata->getSchemaName() ?? '', $platform),
34			'schema' => '',
35			]);
36			}
37			}
38			}
39
40			public function getSubscribedEvents()
41			{
42			return ['loadClassMetadata'];
43			}
44			}
45

DamienHarper / auditor

Push — multiple-schemas-support ( 638643 )

TableSchemaSubscriber::getSubscribedEvents() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like