Issues in Options.php (master) - Issues in master - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Issues (128)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

application/views/User/Options.php (4 issues)

Labels

Documentation 4

Severity

Minor 4

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<div class="row" style="margin-top: 4px;">
	<div class="col-sm-2">&nbsp;</div>
	<div class="col-sm-8">
		<div id="options-userscript">
			<h3>Userscript Options</h3>

			<div id="userscript-check" style="line-height: 22px" class="alert alert-danger" role="alert" data-version="<?=USERSCRIPT_VERSION?>">
				Userscript is not enabled/installed!<br/>
				Check the <a href="https://trackr.moe/help">help page</a> for how to get set up.
			</div>

			<div id="api-key-div">
				<a id="generate-api-key" href="#" onclick="return false">Generate/Reset</a>
				|
				<a id="restore-api-key" href="#" title="Use this when you want are wanting to use the userscript across multiple machines" onclick="return false">Restore</a>
				|
				API Key: <strong><span id="api-key">not set</span></strong>
			</div>
		</div>
	</div>
	<div class="col-sm-2">&nbsp;</div>
</div>

<div class="row" style="margin-top: 4px;">
	<div class="col-sm-2">&nbsp;</div>
	<div class="col-sm-8">
		<div id="options-site">
			<h3>Site Options</h3>

			<?=form_open('', ['method' => 'POST'])?>
				<div id="options-theme">
					<div class="form-group">
						<div class="form-group">
							<div class="input-group">
								<div class="input-group-prepend">
									<span class="input-group-text">Site Theme</span>
								</div>
								<?=form_dropdown('theme', $theme_option, $theme_option_selected, ['class' => 'custom-select'])?>
							</div>
						</div>
					</div>
				</div>

				<br/>

				<div id="options-custom-categories">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">
									<?=form_checkbox('category_custom_1', 'enabled', $category_custom_1, ['data-has-series' => $category_custom_1_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
									Custom Category 1:
								</span>
							</div>
							<input type="text" class="form-control" id="category_custom_1_text" placeholder="Custom 1" name="category_custom_1_text" style="width: auto" maxlength="16" value="<?=$category_custom_1_text?>">
						</div>
					</div>
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">
									<?=form_checkbox('category_custom_2', 'enabled', $category_custom_2, ['data-has-series' => $category_custom_2_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
									Custom Category 2:
								</span>
							</div>
							<input type="text" class="form-control" id="category_custom_2_text" placeholder="Custom 2" name="category_custom_2_text" style="width: auto" maxlength="16" value="<?=$category_custom_2_text?>">
						</div>
					</div>
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">
									<?=form_checkbox('category_custom_3', 'enabled', $category_custom_3, ['data-has-series' => $category_custom_3_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
									Custom Category 3:
								</span>
							</div>
							<input type="text" class="form-control" id="category_custom_3_text" placeholder="Custom 3" name="category_custom_3_text" style="width: auto" maxlength="16" value="<?=$category_custom_3_text?>">
						</div>
					</div>
				</div>

				<div id="options-default-category">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">Default Series Category</span>
							</div>
							<?=form_dropdown('default_series_category', $default_series_category, $default_series_category_selected, ['class' => 'custom-select'])?>
						</div>
					</div>
				</div>

				<br />

				<div id="options-countdown-timer">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">Live Countdown Timer&nbsp;<i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="right" title="Live Countdown Timer.<br>Turn off to reducing CPU usage when tab is left open in background."></i></span>
							</div>
							<div class="input-group-append">
								<div class="btn-group btn-group-toggle" data-toggle="buttons">
									<label class="btn btn-primary <?=(isset($enable_live_countdown_timer_enabled['checked']) ? 'active' : '')?>">
										<?=form_radio($enable_live_countdown_timer_enabled)?> Enabled
									</label>
									<label class="btn btn-primary <?=(isset($enable_live_countdown_timer_disabled['checked']) ? 'active' : '')?>">
										<?=form_radio($enable_live_countdown_timer_disabled)?> Disabled
									</label>
								</div>
							</div>
						</div>
					</div>
				</div>

				<div id="options-list-sort">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">List Sort Order</span>
							</div>
							<?=form_dropdown('list_sort_type', $list_sort_type, $list_sort_type_selected, ['class' => 'custom-select'])?>
							<?=form_dropdown('list_sort_order', $list_sort_order, $list_sort_order_selected, ['class' => 'custom-select'])?>
						</div>
					</div>
				</div>

				<div id="options-public-list">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">Enable Public List (<a href="<?=base_url("list/{$username}.html")?>">HTML</a> | <a href="<?=base_url("list/{$username}.json")?>">JSON</a> | <a href="<?=base_url("list/{$username}.csv")?>">CSV</a>)</span>
							</div>
							<div class="input-group-append">
								<div class="btn-group btn-group-toggle" data-toggle="buttons">
									<label class="btn btn-primary <?=(isset($enable_public_list_enabled['checked']) ? 'active' : '')?>">
										<?=form_radio($enable_public_list_enabled)?>
										<span>Enabled</span>
									</label>
									<label class="btn btn-primary <?=(isset($enable_public_list_disabled['checked']) ? 'active' : '')?>">
										<?=form_radio($enable_public_list_disabled)?>
										<span>Disabled</span>
									</label>
								</div>
							</div>
						</div>
					</div>
				</div>

				<div id="options-mal-sync">
					<div class="form-group">
						<div class="input-group">
							<div class="input-group-prepend">
								<span class="input-group-text">Enable MAL Sync&nbsp;<i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This requires users to <i>manually</i> set the MAL id for syncing to work for that series.<br>In some cases we already have the MAL id set on the backend (and will be noted as such).<br><br>Only chapter number will be set."></i></span>
							</div>
							<div class="input-group-append">
								<div class="btn-group btn-group-toggle" data-toggle="buttons">
									<label class="btn btn-primary <?=(isset($mal_sync_disabled['checked']) ? 'active' : '')?>">
										<?=form_radio($mal_sync_disabled)?>
										<span>Disabled</span>
									</label>
									<label class="btn btn-primary <?=(isset($mal_sync_csrf['checked']) ? 'active' : '')?>">
										<?=form_radio($mal_sync_csrf)?>
										<span>CSRF <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This uses CSRF (Cross Site Request Forgery) to allow us to use MAL's internal API to update.<br>It requires the user to be logged into MAL for it to work properly."></i></span>
									</label>
									<label class="btn btn-primary <?=(isset($mal_sync_api['checked']) ? 'active' : '')?> disabled" >
										<!--<?=form_radio($mal_sync_api)?>-->
										<span>API <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This uses the MAL API to update.<br>This requires us to store your MAL details <i>in your browser</i> in <b>plain text</b>, but it does mean you don't have to be logged in on MAL."></i></span>
									</label>
								</div>
							</div>
						</div>
					</div>
				</div>

				<?=form_submit(...array(NULL, 'Save Settings', array('class' => 'btn btn-success')))?>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			</form>
		</div>
	</div>
	<div class="col-sm-2">&nbsp;</div>
</div>


1			<div class="row" style="margin-top: 4px;">
2			<div class="col-sm-2"> </div>
3			<div class="col-sm-8">
4			<div id="options-userscript">
5			<h3>Userscript Options</h3>
6
7			<div id="userscript-check" style="line-height: 22px" class="alert alert-danger" role="alert" data-version="<?=USERSCRIPT_VERSION?>">
8			Userscript is not enabled/installed!<br/>
9			Check the <a href="https://trackr.moe/help">help page</a> for how to get set up.
10			</div>
11
12			<div id="api-key-div">
13			<a id="generate-api-key" href="#" onclick="return false">Generate/Reset</a>
14			\|
15			<a id="restore-api-key" href="#" title="Use this when you want are wanting to use the userscript across multiple machines" onclick="return false">Restore</a>
16			\|
17			API Key: <strong><span id="api-key">not set</span></strong>
18			</div>
19			</div>
20			</div>
21			<div class="col-sm-2"> </div>
22			</div>
23
24			<div class="row" style="margin-top: 4px;">
25			<div class="col-sm-2"> </div>
26			<div class="col-sm-8">
27			<div id="options-site">
28			<h3>Site Options</h3>
29
30			<?=form_open('', ['method' => 'POST'])?>
31			<div id="options-theme">
32			<div class="form-group">
33			<div class="form-group">
34			<div class="input-group">
35			<div class="input-group-prepend">
36			<span class="input-group-text">Site Theme</span>
37			</div>
38			<?=form_dropdown('theme', $theme_option, $theme_option_selected, ['class' => 'custom-select'])?>
39			</div>
40			</div>
41			</div>
42			</div>
43
44			<br/>
45
46			<div id="options-custom-categories">
47			<div class="form-group">
48			<div class="input-group">
49			<div class="input-group-prepend">
50			<span class="input-group-text">
51			<?=form_checkbox('category_custom_1', 'enabled', $category_custom_1, ['data-has-series' => $category_custom_1_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
			0 ignored issues – show Documentation introduced 2018-02-14 14:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('data-has-series' ...m; margin-right: 4px;')` is of type `array<string,string,{"style":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52			Custom Category 1:
53			</span>
54			</div>
55			<input type="text" class="form-control" id="category_custom_1_text" placeholder="Custom 1" name="category_custom_1_text" style="width: auto" maxlength="16" value="<?=$category_custom_1_text?>">
56			</div>
57			</div>
58			<div class="form-group">
59			<div class="input-group">
60			<div class="input-group-prepend">
61			<span class="input-group-text">
62			<?=form_checkbox('category_custom_2', 'enabled', $category_custom_2, ['data-has-series' => $category_custom_2_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
			0 ignored issues – show Documentation introduced 2018-02-14 14:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('data-has-series' ...m; margin-right: 4px;')` is of type `array<string,string,{"style":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
63			Custom Category 2:
64			</span>
65			</div>
66			<input type="text" class="form-control" id="category_custom_2_text" placeholder="Custom 2" name="category_custom_2_text" style="width: auto" maxlength="16" value="<?=$category_custom_2_text?>">
67			</div>
68			</div>
69			<div class="form-group">
70			<div class="input-group">
71			<div class="input-group-prepend">
72			<span class="input-group-text">
73			<?=form_checkbox('category_custom_3', 'enabled', $category_custom_3, ['data-has-series' => $category_custom_3_has_series, 'style' => 'vertical-align: bottom; margin-right: 4px;'])?>
			0 ignored issues – show Documentation introduced 2018-02-14 14:51 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('data-has-series' ...m; margin-right: 4px;')` is of type `array<string,string,{"style":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
74			Custom Category 3:
75			</span>
76			</div>
77			<input type="text" class="form-control" id="category_custom_3_text" placeholder="Custom 3" name="category_custom_3_text" style="width: auto" maxlength="16" value="<?=$category_custom_3_text?>">
78			</div>
79			</div>
80			</div>
81
82			<div id="options-default-category">
83			<div class="form-group">
84			<div class="input-group">
85			<div class="input-group-prepend">
86			<span class="input-group-text">Default Series Category</span>
87			</div>
88			<?=form_dropdown('default_series_category', $default_series_category, $default_series_category_selected, ['class' => 'custom-select'])?>
89			</div>
90			</div>
91			</div>
92
93			<br />
94
95			<div id="options-countdown-timer">
96			<div class="form-group">
97			<div class="input-group">
98			<div class="input-group-prepend">
99			<span class="input-group-text">Live Countdown Timer <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="right" title="Live Countdown Timer.<br>Turn off to reducing CPU usage when tab is left open in background."></i></span>
100			</div>
101			<div class="input-group-append">
102			<div class="btn-group btn-group-toggle" data-toggle="buttons">
103			<label class="btn btn-primary <?=(isset($enable_live_countdown_timer_enabled['checked']) ? 'active' : '')?>">
104			<?=form_radio($enable_live_countdown_timer_enabled)?> Enabled
105			</label>
106			<label class="btn btn-primary <?=(isset($enable_live_countdown_timer_disabled['checked']) ? 'active' : '')?>">
107			<?=form_radio($enable_live_countdown_timer_disabled)?> Disabled
108			</label>
109			</div>
110			</div>
111			</div>
112			</div>
113			</div>
114
115			<div id="options-list-sort">
116			<div class="form-group">
117			<div class="input-group">
118			<div class="input-group-prepend">
119			<span class="input-group-text">List Sort Order</span>
120			</div>
121			<?=form_dropdown('list_sort_type', $list_sort_type, $list_sort_type_selected, ['class' => 'custom-select'])?>
122			<?=form_dropdown('list_sort_order', $list_sort_order, $list_sort_order_selected, ['class' => 'custom-select'])?>
123			</div>
124			</div>
125			</div>
126
127			<div id="options-public-list">
128			<div class="form-group">
129			<div class="input-group">
130			<div class="input-group-prepend">
131			<span class="input-group-text">Enable Public List (<a href="<?=base_url("list/{$username}.html")?>">HTML</a> \| <a href="<?=base_url("list/{$username}.json")?>">JSON</a> \| <a href="<?=base_url("list/{$username}.csv")?>">CSV</a>)</span>
132			</div>
133			<div class="input-group-append">
134			<div class="btn-group btn-group-toggle" data-toggle="buttons">
135			<label class="btn btn-primary <?=(isset($enable_public_list_enabled['checked']) ? 'active' : '')?>">
136			<?=form_radio($enable_public_list_enabled)?>
137			<span>Enabled</span>
138			</label>
139			<label class="btn btn-primary <?=(isset($enable_public_list_disabled['checked']) ? 'active' : '')?>">
140			<?=form_radio($enable_public_list_disabled)?>
141			<span>Disabled</span>
142			</label>
143			</div>
144			</div>
145			</div>
146			</div>
147			</div>
148
149			<div id="options-mal-sync">
150			<div class="form-group">
151			<div class="input-group">
152			<div class="input-group-prepend">
153			<span class="input-group-text">Enable MAL Sync <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This requires users to <i>manually</i> set the MAL id for syncing to work for that series.<br>In some cases we already have the MAL id set on the backend (and will be noted as such).<br><br>Only chapter number will be set."></i></span>
154			</div>
155			<div class="input-group-append">
156			<div class="btn-group btn-group-toggle" data-toggle="buttons">
157			<label class="btn btn-primary <?=(isset($mal_sync_disabled['checked']) ? 'active' : '')?>">
158			<?=form_radio($mal_sync_disabled)?>
159			<span>Disabled</span>
160			</label>
161			<label class="btn btn-primary <?=(isset($mal_sync_csrf['checked']) ? 'active' : '')?>">
162			<?=form_radio($mal_sync_csrf)?>
163			<span>CSRF <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This uses CSRF (Cross Site Request Forgery) to allow us to use MAL's internal API to update.<br>It requires the user to be logged into MAL for it to work properly."></i></span>
164			</label>
165			<label class="btn btn-primary <?=(isset($mal_sync_api['checked']) ? 'active' : '')?> disabled" >
166			<!--<?=form_radio($mal_sync_api)?>-->
167			<span>API <i class="fa fa-question-circle" aria-hidden="true" data-toggle="tooltip" data-placement="top" title="This uses the MAL API to update.<br>This requires us to store your MAL details <i>in your browser</i> in <b>plain text</b>, but it does mean you don't have to be logged in on MAL."></i></span>
168			</label>
169			</div>
170			</div>
171			</div>
172			</div>
173			</div>
174
175			<?=form_submit(...array(NULL, 'Save Settings', array('class' => 'btn btn-success')))?>
			0 ignored issues – show Documentation introduced 2016-09-19 03:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array(NULL, 'Save Settin... => 'btn btn-success'))` is of type `array<integer,null\|strin...class\":\"string\"}>"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
176			</form>
177			</div>
178			</div>
179			<div class="col-sm-2"> </div>
180			</div>
181

DakuTree / manga-tracker

Issues (128)

Security Analysis not enabled

application/views/User/Options.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like