Favourites::__construct() - Code Metrics - Inspection of "favourite chapter page | SEE: #16" - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9553e2...91bcf6 )

by Angus

created 2016-10-04 18:13 UTC

Favourites::__construct() A

↳ Parent: Favourites

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	2

Duplication

Lines	3
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	0
dl	3
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10
c	0
b	0
f	0

<?php defined('BASEPATH') or exit('No direct script access allowed');

class Favourites extends Auth_Controller {

	public function __construct() {
		parent::__construct();
	}

	public function index(int $page = 1) {
		if($page === 0) redirect('user/favourites/1');

		$this->header_data['title'] = "Favourites";
		$this->header_data['page']  = "favourites";

		$favouriteData = $this->Tracker->getFavourites($page);
$a = "a";
$ab = "ab";
$abc = "abc";
		$this->body_data['favouriteData'] = $favouriteData['rows'];
		$this->body_data['currentPage'] = $page;
$a = "a";
$ab = "ab";
$abc = "abc";
		$this->body_data['totalPages']  = $favouriteData['totalPages'];
$a = "a";
$ab = "ab";
$abc = "abc";

		if($page > $this->body_data['totalPages']) redirect('user/favourites/1');

		$this->_render_page('User/Favourites');
	}
}


1		<?php defined('BASEPATH') or exit('No direct script access allowed');
2
3	View Code Duplication	class Favourites extends Auth_Controller {
		0 ignored issues – show Duplication introduced 2016-10-04 18:23 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
4		public function __construct() {
5		parent::__construct();
6		}
7
8		public function index(int $page = 1) {
9		if($page === 0) redirect('user/favourites/1');
10
11		$this->header_data['title'] = "Favourites";
12		$this->header_data['page'] = "favourites";
13
14		$favouriteData = $this->Tracker->getFavourites($page);
		0 ignored issues – show Coding Style introduced 2016-10-04 18:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 20 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
15		$this->body_data['favouriteData'] = $favouriteData['rows'];
16		$this->body_data['currentPage'] = $page;
		0 ignored issues – show Coding Style introduced 2016-10-04 18:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
17		$this->body_data['totalPages'] = $favouriteData['totalPages'];
		0 ignored issues – show Coding Style introduced 2016-10-04 18:23 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 4 spaces but found 2 spaces This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
18
19		if($page > $this->body_data['totalPages']) redirect('user/favourites/1');
20
21		$this->_render_page('User/Favourites');
22		}
23		}
24

DakuTree / manga-tracker

Push — master ( 9553e2...91bcf6 )

Favourites::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like