Userscript

Complexity

Total Complexity

19

Size/Duplication

Total Lines	117
Duplicated Lines	22.22 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

37.04%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	22	5
B	update()	13	24	5
A	report_bug()	13	20	4
B	favourite()	0	23	5

<?php defined('BASEPATH') or exit('No direct script access allowed');

class Userscript extends AJAX_Controller {
	private $userID;

	public function __construct() {
		parent::__construct();

		$this->load->library('vendor/Limiter');
		$this->load->library('form_validation');

		//500 requests per hour to either AJAX request.
		if($this->limiter->limit('tracker_userscript', 500)) {
			$this->output->set_status_header('429', 'Rate limit reached'); //rate limited reached
		}

		//API Key is required for all AJAX requests
		//We're not using set_rules here since we can't run form_validation twice.
		if($this->form_validation->required($this->input->post('api-key')) && ctype_alnum($this->input->post('api-key'))) {
			$this->userID = $this->User->get_id_from_api_key($this->input->post('api-key'));
			if(!$this->userID) {
				$this->output->set_status_header('400', 'Invalid API Key');
			}
		} else {
			$this->output->set_status_header('400', 'Missing/invalid parameters.');
		}
	}

	/**
	 * This is the main update URL for the userscript.
	 *
	 * REQ_PARAMS: api-key, manga[site], manga[title], manga[chapter]
	 * METHOD:     POST
	 * URL:        /ajax/userscript/update
	 */
	public function update() {
		if($this->output->is_custom_header_set()) { $this->output->reset_status_header(); return; }
		if($this->limiter->limit('tracker_userscript_bug', 250)) {
			$this->output->set_status_header('429', 'Rate limit reached'); //rate limited reached
		} else {
			$this->form_validation->set_rules('manga[site]', 'Manga [Site]', 'required');
			$this->form_validation->set_rules('manga[title]', 'Manga [Title]', 'required');
			$this->form_validation->set_rules('manga[chapter]', 'Manga [Chapter]', 'required');

			if($this->form_validation->run() === TRUE) {

This code seems to be duplicated across your project.

				$manga = $this->input->post('manga');

				$success = $this->Tracker->updateTracker($this->userID, $manga['site'], $manga['title'], $manga['chapter']);
				if($success) {
					$this->output->set_status_header('200'); //Success!
				} else {
					//TODO: We should probably try and have more verbose errors here. Return via JSON or something.
					$this->output->set_status_header('400', 'Unable to update?');
				}
			} else {
				$this->output->set_status_header('400', 'Missing/invalid parameters.');
			}
		}
	}

	/**
	 * Report a bug via userscript.
	 *
	 * REQ_PARAMS: api-key, bug[url], bug[text]
	 * METHOD:     POST
	 * URL:        /ajax/userscript/report_bug
	 */
	public function report_bug() {
		$this->load->library('user_agent');
		if($this->output->is_custom_header_set()) { $this->output->reset_status_header(); return; }
		$this->form_validation->set_rules('bug[url]',  'Bug [URL]',  'required');
		$this->form_validation->set_rules('bug[text]', 'Bug [Text]', 'required');

		if($this->form_validation->run() === TRUE) {

This code seems to be duplicated across your project.

			$bug = $this->input->post('bug');

			//Preferably, I'd like to validate this in some way, but it's a bit too easy to bypass
			$success = $this->Tracker->reportBug($bug['text'], NULL, $bug['url']);
			if($success) {
				$this->output->set_status_header('200'); //Success!
			} else {
				$this->output->set_status_header('400', 'Unable to report bug?');
			}
		} else {
			$this->output->set_status_header('400', 'Missing/invalid parameters.');
		}
	}

	/**
	 * Favourite a chapter via the userscript.
	 *
	 * REQ_PARAMS: api-key, manga[site], manga[title], manga[chapter]
	 * METHOD:     POST
	 * URL:        /ajax/userscript/favourite
	 */
	public function favourite() {
		if($this->output->is_custom_header_set()) { $this->output->reset_status_header(); return; }
		if($this->limiter->limit('tracker_userscript_favourite', 250)) {
			$this->output->set_status_header('429', 'Rate limit reached'); //rate limited reached
		} else {
			$this->form_validation->set_rules('manga[site]', 'Manga [Site]', 'required');
			$this->form_validation->set_rules('manga[title]', 'Manga [Title]', 'required');
			$this->form_validation->set_rules('manga[chapter]', 'Manga [Chapter]', 'required');

			if($this->form_validation->run() === TRUE) {
				$manga = $this->input->post('manga');

				$success = $this->Tracker->favouriteChapter($this->userID, $manga['site'], $manga['title'], $manga['chapter']);
				if($success['bool']) {
					$this->output->set_status_header('200', $success['status']); //Success!
				} else {
					$this->output->set_status_header('400', $success['status']);
				}
			} else {
				$this->output->set_status_header('400', 'Missing/invalid parameters.');
			}
		}
	}
}