Tracker_Category_Model::setByID() - Code Metrics - Inspection of "Increased MangaFox page delay up to .75s from .6s..." - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45893c...373238 )

by Angus

created 2017-01-08 09:49 UTC

Tracker_Category_Model::setByID() A

↳ Parent: Tracker_Category_Model

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	6

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	3
dl	8
loc	8
ccs	0
cts	0
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');

class Tracker_Category_Model extends Tracker_Base_Model {
	public function __construct() {
		parent::__construct();
	}

	public function setByID(int $userID, int $chapterID, string $category) : bool {
		$success = $this->db->set(['category' => $category, 'active' => 'Y', 'last_updated' => NULL])
		                    ->where('user_id', $userID)
		                    ->where('id', $chapterID)
		                    ->update('tracker_chapters');

		return (bool) $success;
	}

	public function setByIDList(array $idList, string $category) : array {
		/*
		 * 0 = Success
		 * 1 = Invalid IDs
		 * 2 = Invalid category
		 */
		$status = ['code' => 0];

		if(in_array($category, array_keys($this->enabledCategories))) {
			foreach($idList as $id) {
				if(!(ctype_digit($id) && $this->setByID($this->User->id, (int) $id, $category))) {
					$status['code'] = 1;
				} else {
					//Category update was successful, update history too.
					$this->History->userUpdateCategory((int) $id, $category);
				}
			}
		} else {
			$status['code'] = 2;
		}

		return $status;
	}

	public function getUsed(int $userID) : array {
		$query = $this->db->distinct()
		                  ->select('category')
		                  ->from('tracker_chapters')
		                  ->where('tracker_chapters.active', 'Y')
		                  ->where('user_id', $userID)
		                  ->get();

		return array_column($query->result_array(), 'category');
	}
}


1			<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
2
3			class Tracker_Category_Model extends Tracker_Base_Model {
4	112		public function __construct() {
5	112		parent::__construct();
6	112		}
7
8		View Code Duplication	public function setByID(int $userID, int $chapterID, string $category) : bool {
9			$success = $this->db->set(['category' => $category, 'active' => 'Y', 'last_updated' => NULL])
10			->where('user_id', $userID)
11			->where('id', $chapterID)
12			->update('tracker_chapters');
13
14			return (bool) $success;
15			}
16
17			public function setByIDList(array $idList, string $category) : array {
18			/*
19			* 0 = Success
20			* 1 = Invalid IDs
21			* 2 = Invalid category
22			*/
23			$status = ['code' => 0];
24
25			if(in_array($category, array_keys($this->enabledCategories))) {
26		View Code Duplication	foreach($idList as $id) {
27			if(!(ctype_digit($id) && $this->setByID($this->User->id, (int) $id, $category))) {
28			$status['code'] = 1;
29			} else {
30			//Category update was successful, update history too.
31			$this->History->userUpdateCategory((int) $id, $category);
32			}
33			}
34			} else {
35			$status['code'] = 2;
36			}
37
38			return $status;
39			}
40
41			public function getUsed(int $userID) : array {
42			$query = $this->db->distinct()
43			->select('category')
44			->from('tracker_chapters')
45			->where('tracker_chapters.active', 'Y')
46			->where('user_id', $userID)
47			->get();
48
49			return array_column($query->result_array(), 'category');
50			}
51			}
52

DakuTree / manga-tracker

Push — master ( 45893c...373238 )

Tracker_Category_Model::setByID() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like