FallenAngelsScans::getChapterData() - Code Metrics - Inspection of "FallenAngelsScans + Mangaichi Scanlation Division..." - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#132)

unknown

created 2017-07-28 01:18 UTC

FallenAngelsScans::getChapterData() A

↳ Parent: FallenAngelsScans

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	7
ccs	0
cts	4
cp	0
crap	2
rs	9.4285
c	0
b	0
f	0

<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');

class FallenAngelsScans extends Base_Site_Model {
	public $titleFormat   = '/^[a-zA-Z0-9_-]+$/';
	public $chapterFormat = '/^[0-9\.]+$/';

	public function getFullTitleURL(string $title_url) : string {
		return "https://manga.fascans.com/manga/{$title_url}";
	}

	public function getChapterData(string $title_url, string $chapter) : array {
		$chapter_parts = explode('/', $chapter);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		return [
			'url'    => $this->getFullTitleURL($title_url).'/'.$chapter,
			'number' => "c{$chapter}"
		];
	}

	public function getTitleData(string $title_url, bool $firstGet = FALSE) : ?array {
		$titleData = [];

		$fullURL = $this->getFullTitleURL($title_url);

		$content = $this->get_content($fullURL);
		
		$data = $this->parseTitleDataDOM(
			$content,
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
			$title_url,
			"//h2[@class='widget-title']",
			"//ul[contains(@class, 'chapters')]/li[1]/h5/a[1]",
			"div[@class='date-chapter-title-rtl']",
			"",
			"Whoops, looks like something went wrong."
		);
		if($data) {
			$titleData['title'] = trim($data['nodes_title']->textContent);

			$titleData['latest_chapter'] = preg_replace('/^.*\/([0-9\.]+)$/', '$1', (string) $data['nodes_chapter']->getAttribute('href'));

			$dateString = $data['nodes_latest']->nodeValue;
			$titleData['last_updated'] =  date("Y-m-d H:i:s", strtotime(preg_replace('/ (-|\[A\]).*$/', '', $dateString)));
		}

		return (!empty($titleData) ? $titleData : NULL);
	}
}


1			<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
2
3			class FallenAngelsScans extends Base_Site_Model {
4			public $titleFormat = '/^[a-zA-Z0-9_-]+$/';
5			public $chapterFormat = '/^[0-9\.]+$/';
6
7			public function getFullTitleURL(string $title_url) : string {
8			return "https://manga.fascans.com/manga/{$title_url}";
9			}
10
11			public function getChapterData(string $title_url, string $chapter) : array {
12			$chapter_parts = explode('/', $chapter);
			0 ignored issues – show Unused Code introduced 2017-07-27 23:53 UTC by Report Bug Copy Issue Report `$chapter_parts` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
13			return [
14			'url' => $this->getFullTitleURL($title_url).'/'.$chapter,
15			'number' => "c{$chapter}"
16			];
17			}
18
19			public function getTitleData(string $title_url, bool $firstGet = FALSE) : ?array {
20			$titleData = [];
21
22			$fullURL = $this->getFullTitleURL($title_url);
23
24			$content = $this->get_content($fullURL);
25
26			$data = $this->parseTitleDataDOM(
27			$content,
			0 ignored issues – show Security Bug introduced 2017-04-19 16:44 UTC by Report Bug Copy Issue Report It seems like `$content` defined by `$this->get_content($fullURL)` on line `24` can also be of type `false`; however, `Base_Site_Model::parseTitleDataDOM()` does only seem to accept `array`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
28			$title_url,
29			"//h2[@class='widget-title']",
30			"//ul[contains(@class, 'chapters')]/li[1]/h5/a[1]",
31			"div[@class='date-chapter-title-rtl']",
32			"",
33			"Whoops, looks like something went wrong."
34			);
35			if($data) {
36			$titleData['title'] = trim($data['nodes_title']->textContent);
37
38			$titleData['latest_chapter'] = preg_replace('/^.*\/([0-9\.]+)$/', '$1', (string) $data['nodes_chapter']->getAttribute('href'));
39
40			$dateString = $data['nodes_latest']->nodeValue;
41			$titleData['last_updated'] = date("Y-m-d H:i:s", strtotime(preg_replace('/ (-\|\[A\]).*$/', '', $dateString)));
42			}
43
44			return (!empty($titleData) ? $titleData : NULL);
45			}
46			}
47

DakuTree / manga-tracker

Pull Request — master (#132)

FallenAngelsScans::getChapterData() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like