DakuTree / manga-tracker

application/controllers/Import_AMR.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php defined('BASEPATH') OR exit('No direct script access allowed');
+<?php defined('BASEPATH') or exit('No direct script access allowed');
 
 class Import_AMR extends User_Controller {
 	public function __construct() {

application/controllers/TitleHistory.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php defined('BASEPATH') OR exit('No direct script access allowed');
+<?php defined('BASEPATH') or exit('No direct script access allowed');
 
 class TitleHistory extends Auth_Controller {
 	public function __construct() {

Braces +3 added lines, -1 removed lines

@@ -23,7 +23,9 @@
 			$this->body_data['totalPages']  = $historyData['totalPages'];
 			$this->body_data['titleID']     = (int) $titleID;
 
-			if($page > $this->body_data['totalPages'] && $page > 1) redirect("/history/{$titleID}/1");
+			if($page > $this->body_data['totalPages'] && $page > 1) {
+				redirect("/history/{$titleID}/1");
+			}
 
 			$this->_render_page("TitleHistory");
 

application/models/Tracker_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 include_once APPPATH.'models/Tracker/Tracker_Base_Model.php';
 foreach (glob(APPPATH.'models/Tracker/*.php') as $filename) {

Spacing +1 added lines, -1 removed lines

@@ -1,7 +1,7 @@
 <?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
 
 include_once APPPATH.'models/Tracker/Tracker_Base_Model.php';
-foreach (glob(APPPATH.'models/Tracker/*.php') as $filename) {
+foreach(glob(APPPATH.'models/Tracker/*.php') as $filename) {
 	/** @noinspection PhpIncludeInspection */
 	include_once $filename;
 }

application/models/History_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 class History_Model extends CI_Model {
 	public function __construct() {

Spacing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
 			foreach($result as $row) {
 				$arrRow = [];
 
-				$arrRow['updated_at']  = $row->updated_at;
+				$arrRow['updated_at'] = $row->updated_at;
 
 				$newChapterData = $this->Tracker->sites->{$row->site_class}->getChapterData($row->title_url, $row->new_chapter);
 				$arrRow['new_chapter']      = "<a href=\"{$newChapterData['url']}\">{$newChapterData['number']}</a>";

application/models/Tracker/Tracker_Stats_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 class Tracker_Stats_Model extends Tracker_Base_Model {
 	public function __construct() {

Spacing +1 added lines, -1 removed lines

@@ -28,7 +28,7 @@
 				], FALSE)
 				->from('tracker_chapters')
 				->join('tracker_titles', 'tracker_titles.id = tracker_chapters.title_id', 'left')
-				->join('tracker_sites','tracker_titles.site_id = tracker_sites.id', 'left')
+				->join('tracker_sites', 'tracker_titles.site_id = tracker_sites.id', 'left')
 				->where('tracker_sites.status', 'enabled')
 				->group_by('tracker_chapters.title_id')
 				->having('count > 1')

application/models/Tracker/Tracker_Portation_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 //http://english.stackexchange.com/a/141735
 class Tracker_Portation_Model extends Tracker_Base_Model {

Spacing +8 added lines, -8 removed lines

@@ -61,7 +61,7 @@ 
 
 		$arr = [];
 		if($query->num_rows() > 0) {
-			foreach ($query->result() as $row) {
+			foreach($query->result() as $row) {
 				$arr[$row->category][] = [
 					'site'            => $row->site,
 					'title_url'       => $row->title_url,
@@ -94,15 +94,15 @@ 
 		$enclosure_esc = preg_quote($enclosure, '/');
 
 		$output = array();
-		foreach ($fields as $field) {
-			if ($field === NULL && $nullToMysqlNull) {
+		foreach($fields as $field) {
+			if($field === NULL && $nullToMysqlNull) {
 				$output[] = 'NULL';
 				continue;
 			}
 
 			// Enclose fields containing $delimiter, $enclosure or whitespace
-			if ($encloseAll || preg_match("/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field)) {
-				$output[] = $enclosure . str_replace($enclosure, $enclosure . $enclosure, $field) . $enclosure;
+			if($encloseAll || preg_match("/(?:${delimiter_esc}|${enclosure_esc}|\s)/", $field)) {
+				$output[] = $enclosure.str_replace($enclosure, $enclosure.$enclosure, $field).$enclosure;
 			} else {
 				$output[] = $field;
 			}
@@ -116,10 +116,10 @@ 
 			$csvArr[] = $headers;
 		}
 
-		foreach ($fields as $field) {
-			$csvArr[] = $this->arrayToCSV($field, $delimiter, $enclosure,$encloseAll,$nullToMysqlNull);
+		foreach($fields as $field) {
+			$csvArr[] = $this->arrayToCSV($field, $delimiter, $enclosure, $encloseAll, $nullToMysqlNull);
 		}
 
-		return implode(PHP_EOL,$csvArr);
+		return implode(PHP_EOL, $csvArr);
 	}
 }

application/models/Tracker/Tracker_Favourites_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 class Tracker_Favourites_Model extends Tracker_Base_Model {
 	public function __construct() {

Indentation +10 added lines, -10 removed lines

@@ -71,32 +71,32 @@
 
 			////We need the series to be tracked
 			$idCQuery = $this->db->select('id')
-			                     ->where('user_id', $userID)
-			                     ->where('title_id', $titleID)
-			                     ->get('tracker_chapters');
+								 ->where('user_id', $userID)
+								 ->where('title_id', $titleID)
+								 ->get('tracker_chapters');
 			if(!($idCQuery->num_rows() > 0)) {
 				//NOTE: This pretty much repeats a lot of what we already did above. Is there a better way to do this?
 				$this->Tracker->list->update($userID, $site, $title, $chapter, FALSE);
 
 				$idCQuery = $this->db->select('id')
-				                     ->where('user_id', $userID)
-				                     ->where('title_id', $titleID)
-				                     ->get('tracker_chapters');
+									 ->where('user_id', $userID)
+									 ->where('title_id', $titleID)
+									 ->get('tracker_chapters');
 			}
 			if($idCQuery->num_rows() > 0) {
 				$idCQueryRow = $idCQuery->row();
 
 				//Check if it is already favourited
 				$idFQuery = $this->db->select('id')
-				                     ->where('chapter_id', $idCQueryRow->id)
-				                     ->where('chapter', $chapter)
-				                     ->get('tracker_favourites');
+									 ->where('chapter_id', $idCQueryRow->id)
+									 ->where('chapter', $chapter)
+									 ->get('tracker_favourites');
 				if($idFQuery->num_rows() > 0) {
 					//Chapter is already favourited, so remove it from DB
 					$idFQueryRow = $idFQuery->row();
 
 					$isSuccess = (bool) $this->db->where('id', $idFQueryRow->id)
-					                             ->delete('tracker_favourites');
+												 ->delete('tracker_favourites');
 
 					if($isSuccess) {
 						$success = array(

Spacing +4 added lines, -4 removed lines

@@ -14,8 +14,8 @@ 
 			          tf.chapter, tf.updated_at', FALSE)
 			->from('tracker_favourites AS tf')
 			->join('tracker_chapters AS tc', 'tf.chapter_id = tc.id', 'left')
-			->join('tracker_titles AS tt',   'tc.title_id = tt.id',   'left')
-			->join('tracker_sites AS ts',    'tt.site_id = ts.id',    'left')
+			->join('tracker_titles AS tt', 'tc.title_id = tt.id', 'left')
+			->join('tracker_sites AS ts', 'tt.site_id = ts.id', 'left')
 			->where('tc.user_id', $this->User->id) //CHECK: Is this inefficient? Would it be better to have a user_id column in tracker_favourites?
 			->order_by('tf.id DESC')
 			->limit($rowsPerPage, ($rowsPerPage * ($page - 1)))
@@ -50,8 +50,8 @@ 
 			          tf.chapter, tf.updated_at', FALSE)
 			->from('tracker_favourites AS tf')
 			->join('tracker_chapters AS tc', 'tf.chapter_id = tc.id', 'left')
-			->join('tracker_titles AS tt',   'tc.title_id = tt.id',   'left')
-			->join('tracker_sites AS ts',    'tt.site_id = ts.id',    'left')
+			->join('tracker_titles AS tt', 'tc.title_id = tt.id', 'left')
+			->join('tracker_sites AS ts', 'tt.site_id = ts.id', 'left')
 			->where('tc.user_id', $this->User->id) //CHECK: Is this inefficient? Would it be better to have a user_id column in tracker_favourites?
 			->order_by('tf.id DESC')
 			->get();

application/models/Tracker/Tracker_Base_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 class Tracker_Base_Model extends CI_Model {
 	public $sites;

Spacing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 			$this->enabledCategories['custom3'] = $this->User_Options->get('category_custom_3_text');
 		}
 
-		foreach (glob(APPPATH.'models/Tracker/Sites/*.php') as $filename) {
+		foreach(glob(APPPATH.'models/Tracker/Sites/*.php') as $filename) {
 			/** @noinspection PhpIncludeInspection */
 			include_once $filename;
 		}

application/models/Tracker/Tracker_Admin_Model.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
+<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
 
 class Tracker_Admin_Model extends Tracker_Base_Model {
 	public function __construct() {

Indentation +24 added lines, -24 removed lines

@@ -159,8 +159,8 @@ 
 						//Make sure last_checked is always updated on successful run.
 						//CHECK: Is there a reason we aren't just doing this in updateByID?
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $row->title_id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->title_id)
+								 ->update('tracker_titles');
 
 						print " - ({$titleData['latest_chapter']})\n";
 					} else {
@@ -174,8 +174,8 @@ 
 						//Make sure last_checked is always updated on successful run.
 						//CHECK: Is there a reason we aren't just doing this in updateByID?
 						$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-						         ->where('id', $row->title_id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->title_id)
+								 ->update('tracker_titles');
 
 						print " - (No chapters found?)\n";
 					} else {
@@ -203,10 +203,10 @@ 
 	 */
 	public function updateCustom() {
 		$query = $this->db->select('*')
-		                  ->from('tracker_sites')
-		                  ->where('tracker_sites.status', 'enabled')
-		                  ->where('tracker_sites.use_custom', 'Y')
-		                  ->get();
+						  ->from('tracker_sites')
+						  ->where('tracker_sites.status', 'enabled')
+						  ->where('tracker_sites.use_custom', 'Y')
+						  ->get();
 
 		$sites = $query->result_array();
 		foreach ($sites as $site) {
@@ -223,8 +223,8 @@ 
 									//Make sure last_checked is always updated on successful run.
 									//CHECK: Is there a reason we aren't just doing this in updateByID?
 									$this->db->set('last_checked', 'CURRENT_TIMESTAMP', FALSE)
-									         ->where('id', $titleID)
-									         ->update('tracker_titles');
+											 ->where('id', $titleID)
+											 ->update('tracker_titles');
 
 									print " - ({$titleData['latest_chapter']})\n";
 								} else {
@@ -253,13 +253,13 @@ 
 
 	public function refollowCustom() {
 		$query = $this->db->select('tracker_titles.id, tracker_titles.title_url, tracker_sites.site_class')
-		                  ->from('tracker_titles')
-		                  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
-		                  ->where('tracker_titles.followed','N')
-		                  ->where('tracker_titles !=', '255')
-		                  ->where('tracker_sites.status', 'enabled')
-		                  ->where('tracker_sites.use_custom', 'Y')
-		                  ->get();
+						  ->from('tracker_titles')
+						  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
+						  ->where('tracker_titles.followed','N')
+						  ->where('tracker_titles !=', '255')
+						  ->where('tracker_sites.status', 'enabled')
+						  ->where('tracker_sites.use_custom', 'Y')
+						  ->get();
 
 		if($query->num_rows() > 0) {
 			foreach($query->result() as $row) {
@@ -270,8 +270,8 @@ 
 
 					if(!empty($titleData)) {
 						$this->db->set($titleData)
-						         ->where('id', $row->id)
-						         ->update('tracker_titles');
+								 ->where('id', $row->id)
+								 ->update('tracker_titles');
 
 						print "> {$row->site_class}:{$row->id}:{$row->title_url} FOLLOWED\n";
 					} else {
@@ -291,14 +291,14 @@ 
 		$date = $temp_now->format('Y-m-d');
 
 		$query = $this->db->select('1')
-		                  ->from('site_stats')
-		                  ->where('date', $date)
-		                  ->get();
+						  ->from('site_stats')
+						  ->where('date', $date)
+						  ->get();
 
 		if($query->num_rows() > 0) {
 			$this->db->set('total_requests', 'total_requests+1', FALSE)
-			         ->where('date', $date)
-			         ->update('site_stats');
+					 ->where('date', $date)
+					 ->update('site_stats');
 		} else {
 			$this->db->insert('site_stats', [
 				'date'           => $date,

Spacing +6 added lines, -6 removed lines

@@ -79,8 +79,8 @@ 
 		if($query->num_rows() > 0) {
 			$hardRateLimit  = 500; //This is to avoid any possible IP bans by cache breaking again.
 			$siteRateLimits = [];
-			foreach ($query->result() as $row) {
-				if(!array_key_exists($row->site_class,$siteRateLimits)) {
+			foreach($query->result() as $row) {
+				if(!array_key_exists($row->site_class, $siteRateLimits)) {
 					$siteRateLimits[$row->site_class] = 0;
 				}
 				$siteRateLimits[$row->site_class]++;
@@ -142,7 +142,7 @@ 
 		$query = $query->get();
 
 		if($query->num_rows() > 0) {
-			foreach ($query->result() as $row) {
+			foreach($query->result() as $row) {
 				$this->handleUpdate($row);
 			}
 		}
@@ -220,10 +220,10 @@ 
 		                  ->get();
 
 		$sites = $query->result_array();
-		foreach ($sites as $site) {
+		foreach($sites as $site) {
 			$siteClass = $this->sites->{$site['site_class']};
 			if($titleDataList = $siteClass->doCustomUpdate()) {
-				foreach ($titleDataList as $titleURL => $titleData) {
+				foreach($titleDataList as $titleURL => $titleData) {
 					$titleURL = (string) $titleURL; //Number only keys get converted to int for some reason, so we need to fix that.
 					print "> {$titleData['title']} <{$site['site_class']}>"; //Print this prior to doing anything so we can more easily find out if something went wrong
 					if(is_array($titleData) && !is_null($titleData['latest_chapter'])) {
@@ -266,7 +266,7 @@ 
 		$query = $this->db->select('tracker_titles.id, tracker_titles.title_url, tracker_sites.site_class')
 		                  ->from('tracker_titles')
 		                  ->join('tracker_sites', 'tracker_sites.id = tracker_titles.site_id', 'left')
-		                  ->where('tracker_titles.followed','N')
+		                  ->where('tracker_titles.followed', 'N')
 		                  ->where('tracker_titles !=', '255')
 		                  ->where('tracker_sites.status', 'enabled')
 		                  ->where('tracker_sites.use_custom', 'Y')

Braces +4 added lines, -3 removed lines

@@ -84,7 +84,9 @@ 
 					$siteRateLimits[$row->site_class] = 0;
 				}
 				$siteRateLimits[$row->site_class]++;
-				if($siteRateLimits[$row->site_class] > $hardRateLimit) continue;
+				if($siteRateLimits[$row->site_class] > $hardRateLimit) {
+					continue;
+				}
 
 				$this->handleUpdate($row);
 			}
@@ -192,8 +194,7 @@ 
 						print " - Something went wrong?\n";
 					}
 				}
-			}
-			else {
+			} else {
 				//TODO: We should have some way to handle this in the site models.
 				if($row->site_class !== 'MangaKakarot') {
 					log_message('error', "{$row->site_class} | {$row->title} ({$row->title_url}) | Failed to update.");