Tracker_Issue_Model::report() - Code Metrics - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

Tracker_Issue_Model::report() B
last analyzed 2019-07-29 17:50 UTC

↳ Parent: Tracker_Issue_Model

Complexity

Conditions	6
Paths	32

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	42

Importance

Changes

Metric	Value
cc	6
nc	32
nop	3
dl	0
loc	22
rs	8.9457
c	0
b	0
f	0
ccs	0
cts	15
cp	0
crap	42

<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');

class Tracker_Issue_Model extends Tracker_Base_Model {
	public function __construct() {
		parent::__construct();
	}


	public function report(string $text, $userID = NULL, $url = NULL) : bool {
		$this->load->library('email');

		//This is pretty barebones issue reporting, and honestly not a great way to do it, but it works for now (until the Github is public).
		$body = "".
		        (!is_null($url) && !empty($url) ? "URL: ".htmlspecialchars(substr($url, 0, 255))."<br>\n" : "").
		        "Submitted by: ".$this->input->ip_address().(!is_null($userID) ? "| {$userID}" : "")."<br>\n".
		        "<br>Bug report: ".htmlspecialchars(substr($text, 0, 1000));

		$success = TRUE;
		$this->email->from('[email protected]', $this->config->item('site_title', 'ion_auth'));
		if($this->User->id) {
			$this->email->reply_to($this->User->email);
		}
		$this->email->to('[email protected]');
		$this->email->subject($this->config->item('site_title', 'ion_auth')." - Issue Report");
		$this->email->message($body);
		if(!$this->email->send()) {
$a = canBeFalseAndNull();

// Instead of
if ( ! $a) { }

// Better use one of the explicit versions:
if ($a !== null) { }
if ($a !== false) { }
if ($a !== null && $a !== false) { }
			$success = FALSE;
		}
		return $success;
	}

}


1		<?php declare(strict_types=1); defined('BASEPATH') OR exit('No direct script access allowed');
2
3		class Tracker_Issue_Model extends Tracker_Base_Model {
4	96	public function __construct() {
5	96	parent::__construct();
6	96	}
7
8
9		public function report(string $text, $userID = NULL, $url = NULL) : bool {
10		$this->load->library('email');
11
12		//This is pretty barebones issue reporting, and honestly not a great way to do it, but it works for now (until the Github is public).
13		$body = "".
14		(!is_null($url) && !empty($url) ? "URL: ".htmlspecialchars(substr($url, 0, 255))."<br>\n" : "").
15		"Submitted by: ".$this->input->ip_address().(!is_null($userID) ? "\| {$userID}" : "")."<br>\n".
16		"<br>Bug report: ".htmlspecialchars(substr($text, 0, 1000));
17
18		$success = TRUE;
19		$this->email->from('[email protected]', $this->config->item('site_title', 'ion_auth'));
20		if($this->User->id) {
21		$this->email->reply_to($this->User->email);
22		}
23		$this->email->to('[email protected]');
24		$this->email->subject($this->config->item('site_title', 'ion_auth')." - Issue Report");
25		$this->email->message($body);
26		if(!$this->email->send()) {
		0 ignored issues – show Bug Best Practice introduced 2017-01-08 09:51 UTC by Report Bug Copy Issue Report The expression `$this->email->send()` of type `null\|boolean` is loosely compared to `false`; this is ambiguous if the boolean can be false. You might want to explicitly use `!== null` instead. If an expression can have both `false`, and `null` as possible values. It is generally a good practice to always use strict comparison to clearly distinguish between those two values. $a = canBeFalseAndNull(); // Instead of if ( ! $a) { } // Better use one of the explicit versions: if ($a !== null) { } if ($a !== false) { } if ($a !== null && $a !== false) { } Loading history...
27		$success = FALSE;
28		}
29		return $success;
30		}
31
32		}
33

DakuTree / manga-tracker

Tracker_Issue_Model::report() B last analyzed 2019-07-29 17:50 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

Tracker_Issue_Model::report() B
last analyzed 2019-07-29 17:50 UTC