MY_Loader::database() - Code Metrics - DakuTree/manga-tracker - Measure and Improve Code Quality continuously with Scrutinizer

MY_Loader::database() A
last analyzed 2019-07-29 17:50 UTC

↳ Parent: MY_Loader

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.0625

Importance

Changes

Metric	Value
cc	2
nc	2
nop	3
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
ccs	3
cts	4
cp	0.75
crap	2.0625

<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');

class MY_Loader extends CI_Loader {
	public function __construct() {
		parent::__construct();
	}

	/**
	 * Database Loader extension, to load our version of the caching engine
	 *
	 * @access   public
	 *
	 * @param    string  $params         the DB credentials
	 * @param    bool    $return         whether to return the DB object
	 * @param    bool    $active_record  whether to enable active record (this allows us to override the config setting)
	 *
	 * @return   object
	 */
	public function database($params = '', $return = FALSE, $active_record = NULL) {
		// load our version of the CI_DB_Cache class. The database library checks
		// if this class is already loaded before instantiating it. Loading it now
		// makes sure our version is used when a controller enables query caching
		if(!class_exists('CI_DB_Cache')) {
			@include(APPPATH . 'libraries/MY_DB_cache.php');
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
		}

		// call the parent method to retain the CI functionality
		return parent::database($params, $return, $active_record);
	}
}


1		<?php declare(strict_types=1); defined('BASEPATH') or exit('No direct script access allowed');
2
3		class MY_Loader extends CI_Loader {
4	96	public function __construct() {
5	96	parent::__construct();
6	96	}
7
8		/**
9		* Database Loader extension, to load our version of the caching engine
10		*
11		* @access public
12		*
13		* @param string $params the DB credentials
14		* @param bool $return whether to return the DB object
15		* @param bool $active_record whether to enable active record (this allows us to override the config setting)
16		*
17		* @return object
18		*/
19	96	public function database($params = '', $return = FALSE, $active_record = NULL) {
20		// load our version of the CI_DB_Cache class. The database library checks
21		// if this class is already loaded before instantiating it. Loading it now
22		// makes sure our version is used when a controller enables query caching
23	96	if(!class_exists('CI_DB_Cache')) {
24		@include(APPPATH . 'libraries/MY_DB_cache.php');
		0 ignored issues – show Security Best Practice introduced 2016-11-21 16:35 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
25		}
26
27		// call the parent method to retain the CI functionality
28	96	return parent::database($params, $return, $active_record);
29		}
30		}
31

DakuTree / manga-tracker

MY_Loader::database() A last analyzed 2019-07-29 17:50 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MY_Loader::database() A
last analyzed 2019-07-29 17:50 UTC