Daimona / BotRiconferme

includes/TaskDataProvider.php

Spacing +18 added lines, -20 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -15,14 +15,14 @@ 
 	/** @var array[] */
 	private $allUsers;
 	/** @var PageRiconferma[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 
 	/**
 	 * Get the full content of the JSON users list
 	 *
 	 * @return array[]
 	 */
-	public function getUsersList() : array {
+	public function getUsersList () : array {
 		if ( $this->allUsers === null ) {
 			$this->getLogger()->debug( 'Retrieving users list' );
 			$this->allUsers = PageBotList::get()->getAdminsList();
@@ -36,9 +36,9 @@ 
 	 *
 	 * @return array[]
 	 */
-	public function getUsersToProcess() : array {
+	public function getUsersToProcess () : array {
 		if ( $this->processUsers === null ) {
-			$this->processUsers = [];
+			$this->processUsers = [ ];
 			foreach ( $this->getUsersList() as $user => $groups ) {
 				$timestamp = $this->getValidTimestamp( $groups );
 
@@ -60,13 +60,11 @@ 
 	 * @param array $groups
 	 * @return int
 	 */
-	private function getValidTimestamp( array $groups ) : int {
+	private function getValidTimestamp ( array $groups ) : int {
 		$checkuser = isset( $groups[ 'checkuser' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
 		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
 
 		$timestamp = max( $bureaucrat, $checkuser );
 		if ( $timestamp === 0 ) {
@@ -80,7 +78,7 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getOpenPages() : array {
+	public function getOpenPages () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$mainTitle = $this->getConfig()->get( 'main-page-title' );
@@ -94,10 +92,10 @@ 
 
 			$res = RequestBase::newFromParams( $params )->execute();
 			$pages = $res->query->pages;
-			$list = [];
+			$list = [ ];
 			foreach ( reset( $pages )->templates as $page ) {
 				if ( preg_match( "!$mainTitle\/[^\/]+\/\d!", $page->title ) ) {
-					$list[] = new PageRiconferma( $page->title );
+					$list[ ] = new PageRiconferma( $page->title );
 				}
 			}
 		}
@@ -110,14 +108,14 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getPagesToClose() : array {
+	public function getPagesToClose () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$allPages = $this->getOpenPages();
-			$list = [];
+			$list = [ ];
 			foreach ( $allPages as $page ) {
 				if ( time() > $page->getEndTimestamp() ) {
-					$list[] = $page;
+					$list[ ] = $page;
 				}
 			}
 		}
@@ -129,21 +127,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) {
+	public function removeUser ( string $name ) {
 		unset( $this->processUsers[ $name ] );
 	}
 
 	/**
 	 * @return PageRiconferma[]
 	 */
-	public function getCreatedPages() : array {
+	public function getCreatedPages () : array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	public function addCreatedPages( PageRiconferma $page ) {
-		$this->createdPages[] = $page;
+	public function addCreatedPages ( PageRiconferma $page ) {
+		$this->createdPages[ ] = $page;
 	}
 }

includes/Message.php

Spacing +16 added lines, -16 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @param string $key
 	 */
-	public function __construct( string $key ) {
+	public function __construct ( string $key ) {
 		$this->key = $key;
 		$this->value = Config::getInstance()->getWikiMessage( $key );
 	}
@@ -23,7 +23,7 @@ 
 	 * @param array $args
 	 * @return self
 	 */
-	public function params( array $args ) : self {
+	public function params ( array $args ) : self {
 		$this->value = strtr( $this->value, $args );
 		return $this;
 	}
@@ -31,7 +31,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function text() : string {
+	public function text () : string {
 		$this->parsePlurals();
 		return $this->value;
 	}
@@ -39,7 +39,7 @@ 
 	/**
 	 * Replace {{$plur|<amount>|sing|plur}}
 	 */
-	protected function parsePlurals() {
+	protected function parsePlurals () {
 		$reg = '!\{\{$plur|(?P<amount>\d+)|(?P<sing>[^}|]+)|(?P<plur>[^|}]+)}}!';
 
 		if ( preg_match( $reg, $this->value ) === 0 ) {
@@ -48,7 +48,7 @@ 
 		$this->value = preg_replace_callback(
 			$reg,
 			function ( $matches ) {
-				return intval( $matches['amount'] ) > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
+				return intval( $matches[ 'amount' ] ) > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
 			},
 			$this->value
 		);
@@ -60,7 +60,7 @@ 
 	 * @param int $timestamp
 	 * @return string
 	 */
-	public static function getTimeWithArticle( int $timestamp ) : string {
+	public static function getTimeWithArticle ( int $timestamp ) : string {
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
 		$timeString = strftime( '%e %B alle %R', $timestamp );
 		// Remove the left space if day has a single digit
@@ -78,16 +78,16 @@ 
 	 * @return int
 	 * @todo Is there a better way?
 	 */
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
 		$bits = strptime( $timeString, '%e %m %Y alle %H:%M' );
 		$timestamp = mktime(
-			$bits['tm_hour'],
-			$bits['tm_min'],
+			$bits[ 'tm_hour' ],
+			$bits[ 'tm_min' ],
 			0,
-			$bits['tm_mon'] + 1,
-			$bits['tm_mday'],
-			$bits['tm_year'] + 1900
+			$bits[ 'tm_mon' ] + 1,
+			$bits[ 'tm_mday' ],
+			$bits[ 'tm_year' ] + 1900
 		);
 		setlocale( LC_TIME, $oldLoc );
 
@@ -102,12 +102,12 @@ 
 	 * @param string $emptyText
 	 * @return string
 	 */
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
 		if ( count( $data ) > 1 ) {
 			$last = array_pop( $data );
 			$ret = implode( ', ', $data ) . " e $last";
 		} elseif ( $data ) {
-			$ret = $data[0];
+			$ret = $data[ 0 ];
 		} else {
 			$ret = $emptyText;
 		}
@@ -115,7 +115,7 @@ 
 		return $ret;
 	}
 
-	public function __toString() {
+	public function __toString () {
 		return $this->text();
 	}
 }

includes/Bot.php

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -11,7 +11,7 @@ 
 
 	const VERSION = 1.0;
 
-	public function __construct() {
+	public function __construct () {
 		$this->logger = new Logger;
 	}
 
@@ -21,7 +21,7 @@ 
 	 * @param string $mode
 	 * @param string|null $name
 	 */
-	private function run( string $mode = TaskManager::MODE_COMPLETE, string $name = null ) {
+	private function run ( string $mode = TaskManager::MODE_COMPLETE, string $name = null ) {
 		$activity = $mode === TaskManager::MODE_COMPLETE ? TaskManager::MODE_COMPLETE : "$mode $name";
 		$this->logger->info( "Starting $activity" );
 		$manager = new TaskManager;
@@ -37,7 +37,7 @@ 
 	/**
 	 * Entry point for the whole process
 	 */
-	public function runAll() {
+	public function runAll () {
 		$this->run();
 	}
 
@@ -46,7 +46,7 @@ 
 	 *
 	 * @param string $task
 	 */
-	public function runTask( string $task ) {
+	public function runTask ( string $task ) {
 		$this->run( TaskManager::MODE_TASK, $task );
 	}
 
@@ -55,7 +55,7 @@ 
 	 *
 	 * @param string $subtask
 	 */
-	public function runSubtask( string $subtask ) {
+	public function runSubtask ( string $subtask ) {
 		$this->run( TaskManager::MODE_SUBTASK, $subtask );
 	}
 }

includes/TaskManager.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -54,7 +54,7 @@ 
 	 * @param string|null $name Only used in MODE_TASK and MODE_SUBTASK
 	 * @return TaskResult
 	 */
-	public function run( string $mode, string $name = null ) : TaskResult {
+	public function run ( string $mode, string $name = null ) : TaskResult {
 		$this->provider = new TaskDataProvider;
 
 		if ( $mode === self::MODE_COMPLETE ) {
@@ -71,7 +71,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	protected function runAllTasks() : TaskResult {
+	protected function runAllTasks () : TaskResult {
 		if ( self::getLastFullRunDate() === date( 'd/m/Y' ) ) {
 			// Really avoid executing twice the same day
 			return new TaskResult( TaskResult::STATUS_ERROR, [ 'A full run was already executed today.' ] );
@@ -102,7 +102,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runTask( string $name ) : TaskResult {
+	protected function runTask ( string $name ) : TaskResult {
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
 		}
@@ -117,7 +117,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $name ) : TaskResult {
+	protected function runSubtask ( string $name ) : TaskResult {
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
 		}
@@ -131,7 +131,7 @@ 
 	 * @return string|null d/m/Y or null if no last run registered
 	 * @fixme Is this even necessary?
 	 */
-	public static function getLastFullRunDate() : ?string {
+	public static function getLastFullRunDate () : ?string {
 		if ( file_exists( self::LOG_FILE ) ) {
 			return file_get_contents( self::LOG_FILE ) ?: null;
 		} else {
@@ -145,7 +145,7 @@ 
 	 * @param string $class
 	 * @return Task
 	 */
-	private function getTaskInstance( string $class ) : Task {
+	private function getTaskInstance ( string $class ) : Task {
 		return new $class( $this->provider );
 	}
 
@@ -155,11 +155,11 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		return new $class( $this->provider );
 	}
 
-	public static function setLastFullRunDate() {
+	public static function setLastFullRunDate () {
 		file_put_contents( self::LOG_FILE, date( 'd/m/Y' ) );
 	}
 }

includes/Task/Subtask/UpdatesAround.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 
 		if ( !$pages ) {
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToMainPage( array $pages ) {
+	protected function addToMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -64,7 +64,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToVotazioni( array $pages ) {
+	protected function addToVotazioni ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to votes: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -93,7 +93,7 @@ 
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $content, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $content, 1 );
 		}
 
 		$summary = $this->msg( 'vote-page-summary' )
@@ -112,7 +112,7 @@ 
 	 *
 	 * @param int $amount
 	 */
-	protected function addToNews( int $amount ) {
+	protected function addToNews ( int $amount ) {
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
 		$newsPage = new Page( $this->getConfig()->get( 'news-page-title' ) );
 
@@ -125,7 +125,7 @@ 
 			throw new TaskException( 'Param not found in news page' );
 		}
 
-		$newNum = (int)$matches[2] + $amount;
+		$newNum = (int)$matches[ 2 ] + $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = $this->msg( 'news-page-summary' )

includes/Task/Subtask/Subtask.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -11,7 +11,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'subtask';
 	}
 }

includes/Task/StartVote.php

Spacing +16 added lines, -16 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,15 +15,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -37,12 +37,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ) : int {
-		$actualPages = [];
+	protected function processPages ( array $pages ) : int {
+		$actualPages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
-				$actualPages[] = $page;
+				$actualPages[ ] = $page;
 			}
 		}
 
@@ -60,7 +60,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) {
+	protected function openVote ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -99,13 +99,13 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotePage( array $pages ) {
+	protected function updateVotePage ( array $pages ) {
 		$votePage = new Page( $this->getConfig()->get( 'vote-page-title' ) );
 		$content = $votePage->getContent();
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 		$titleReg = implode( '|', $titles );
 		$search = "!^\*.+ La \[\[($titleReg)\|procedura]] termina.+\n!gm";
@@ -128,14 +128,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $newContent, $matches ) === 0 ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $newContent, 1 );
 		}
 
 		$summary = $this->msg( 'vote-start-vote-page-summary' )
@@ -157,7 +157,7 @@ 
 	 * @see UpdatesAround::addToNews()
 	 * @see SimpleUpdates::updateNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = new Page( $this->getConfig()->get( 'news-page-title' ) );
 
@@ -172,8 +172,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = intval( $newsPage->getMatch( $regTac )[2] ) - $amount ?: '';
-		$newVot = intval( $newsPage->getMatch( $regVot )[2] ) + $amount ?: '';
+		$newTac = intval( $newsPage->getMatch( $regTac )[ 2 ] ) - $amount ?: '';
+		$newVot = intval( $newsPage->getMatch( $regVot )[ 2 ] ) + $amount ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

includes/Task/TaskBase.php

Spacing +10 added lines, -10 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -11,7 +11,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -20,14 +20,14 @@ 
 	 *
 	 * @param TaskDataProvider $dataProvider
 	 */
-	final public function __construct( TaskDataProvider $dataProvider ) {
+	final public function __construct ( TaskDataProvider $dataProvider ) {
 		set_exception_handler( [ $this, 'handleException' ] );
 		set_error_handler( [ $this, 'handleError' ] );
 		parent::__construct();
 		$this->dataProvider = $dataProvider;
 	}
 
-	public function __destruct() {
+	public function __destruct () {
 		restore_error_handler();
 		restore_exception_handler();
 	}
@@ -37,7 +37,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	final public function run() : TaskResult {
+	final public function run () : TaskResult {
 		$class = ( new \ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -68,14 +68,14 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal() : int;
+	abstract protected function runInternal () : int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract public function getOperationName() : string;
+	abstract public function getOperationName () : string;
 
 	/**
 	 * Exception handler.
@@ -83,7 +83,7 @@ 
 	 * @param \Throwable $ex
 	 * @protected
 	 */
-	public function handleException( \Throwable $ex ) {
+	public function handleException ( \Throwable $ex ) {
 		$this->getLogger()->error(
 			get_class( $ex ) . ': ' .
 			$ex->getMessage() . "\nTrace:\n" .
@@ -100,14 +100,14 @@ 
 	 * @param int $errline
 	 * @protected
 	 */
-	public function handleError( $errno, $errstr, $errfile, $errline ) {
+	public function handleError ( $errno, $errstr, $errfile, $errline ) {
 		throw new \ErrorException( $errstr, 0, $errno, $errfile, $errline );
 	}
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider() : TaskDataProvider {
+	protected function getDataProvider () : TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

includes/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,13 +14,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap() : array;
+	abstract protected function getSubtasksMap () : array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $subtask ) : TaskResult {
+	protected function runSubtask ( string $subtask ) : TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new \InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -33,7 +33,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'task';
 	}
 
@@ -43,7 +43,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		return new $class( $this->getDataProvider() );
 	}
 }