Daimona / BotRiconferme

includes/Task/StartVote.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -16,15 +16,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -38,12 +38,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ) : int {
-		$actualPages = [];
+	protected function processPages ( array $pages ) : int {
+		$actualPages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
-				$actualPages[] = $page;
+				$actualPages[ ] = $page;
 			}
 		}
 
@@ -61,7 +61,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) {
+	protected function openVote ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -100,7 +100,7 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotePage( array $pages ) {
+	protected function updateVotePage ( array $pages ) {
 		$votePage = new Page( $this->getConfig()->get( 'vote-page-title' ) );
 		$content = $votePage->getContent();
 
@@ -127,14 +127,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $newContent, $matches ) === 0 ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $newContent, 1 );
 		}
 
 		$summary = $this->msg( 'vote-start-vote-page-summary' )
@@ -156,7 +156,7 @@ 
 	 * @see UpdatesAround::addToNews()
 	 * @see SimpleUpdates::updateNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = new Page( $this->getConfig()->get( 'news-page-title' ) );
 
@@ -171,8 +171,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = intval( $newsPage->getMatch( $regTac )[2] ) - $amount ?: '';
-		$newVot = intval( $newsPage->getMatch( $regVot )[2] ) + $amount ?: '';
+		$newTac = intval( $newsPage->getMatch( $regTac )[ 2 ] ) - $amount ?: '';
+		$newVot = intval( $newsPage->getMatch( $regVot )[ 2 ] ) + $amount ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

includes/Wiki/User.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -16,21 +16,21 @@ 
 	/**
 	 * @param string $name
 	 */
-	public function __construct( string $name ) {
+	public function __construct ( string $name ) {
 		$this->name = $name;
 	}
 
 	/**
 	 * @return string
 	 */
-	public function getName() : string {
+	public function getName () : string {
 		return $this->name;
 	}
 
 	/**
 	 * @return string[]
 	 */
-	public function getGroups() : array {
+	public function getGroups () : array {
 		if ( $this->groups === null ) {
 			$usersList = PageBotList::get()->getAdminsList();
 			$this->groups = array_keys( $usersList[ $this->name ] );
@@ -44,7 +44,7 @@ 
 	 * @param string $groupName
 	 * @return bool
 	 */
-	public function inGroup( string $groupName ) : bool {
+	public function inGroup ( string $groupName ) : bool {
 		return in_array( $groupName, $this->getGroups() );
 	}
 
@@ -53,14 +53,14 @@ 
 	 *
 	 * @inheritDoc
 	 */
-	public function getRegex() : string {
+	public function getRegex () : string {
 		return str_replace( ' ', '[ _]', preg_quote( $this->name ) );
 	}
 
 	/**
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		return $this->name;
 	}
 }

includes/Wiki/Page/Page.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki\Page;
 
@@ -21,7 +21,7 @@ 
 	 * @param string $title
 	 * @param string $domain The site where the page lives, if different from default
 	 */
-	public function __construct( string $title, string $domain = DEFAULT_URL ) {
+	public function __construct ( string $title, string $domain = DEFAULT_URL ) {
 		$this->title = $title;
 		$this->controller = new Controller( $domain );
 	}
@@ -29,7 +29,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function getTitle() : string {
+	public function getTitle () : string {
 		return $this->title;
 	}
 
@@ -39,7 +39,7 @@ 
 	 * @param int|null $section A section number to retrieve the content of that section
 	 * @return string
 	 */
-	public function getContent( int $section = null ) : string {
+	public function getContent ( int $section = null ) : string {
 		if ( $this->content === null ) {
 			$this->content = $this->controller->getPageContent( $this->title, $section );
 		}
@@ -51,16 +51,16 @@ 
 	 *
 	 * @param array $params
 	 */
-	public function edit( array $params ) {
+	public function edit ( array $params ) {
 		$params = [
 			'title' => $this->getTitle()
 		] + $params;
 
 		$this->controller->editPage( $params );
-		if ( isset( $params['text'] ) ) {
-			$this->content = $params['text'];
-		} elseif ( isset( $params['appendtext'] ) ) {
-			$this->content .= $params['appendtext'];
+		if ( isset( $params[ 'text' ] ) ) {
+			$this->content = $params[ 'text' ];
+		} elseif ( isset( $params[ 'appendtext' ] ) ) {
+			$this->content .= $params[ 'appendtext' ];
 		} else {
 			// Clear the cache anyway
 			( new Logger )->warning( 'Resetting content cache. Params: ' . var_export( $params, true ) );
@@ -74,7 +74,7 @@ 
 	 * @param string $regex
 	 * @return bool
 	 */
-	public function matches( string $regex ) : bool {
+	public function matches ( string $regex ) : bool {
 		return (bool)preg_match( $regex, $this->getContent() );
 	}
 
@@ -86,8 +86,8 @@ 
 	 * @return string[]
 	 * @throws \Exception
 	 */
-	public function getMatch( string $regex ) : array {
-		$ret = [];
+	public function getMatch ( string $regex ) : array {
+		$ret = [ ];
 		if ( preg_match( $regex, $this->getContent(), $ret ) === 0 ) {
 			throw new \Exception( 'The content does not match the given regex' );
 		}
@@ -99,7 +99,7 @@ 
 	 *
 	 * @inheritDoc
 	 */
-	public function getRegex() : string {
+	public function getRegex () : string {
 		return str_replace( ' ', '[ _]', preg_quote( $this->title ) );
 	}
 
@@ -108,7 +108,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		return $this->getTitle();
 	}
 }

includes/Wiki/Element.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -11,7 +11,7 @@ 
 	 *
 	 * @return string
 	 */
-	abstract public function getRegex() : string;
+	abstract public function getRegex () : string;
 
 	/**
 	 * Get a regex matching any element in the given array
@@ -20,10 +20,10 @@ 
 	 * @return string
 	 * @fixme Is this the right place?
 	 */
-	public static function regexFromArray( array $elements ) : string {
-		$bits = [];
+	public static function regexFromArray ( array $elements ) : string {
+		$bits = [ ];
 		foreach ( $elements as $el ) {
-			$bits[] = $el->getRegex();
+			$bits[ ] = $el->getRegex();
 		}
 		return '(?:' . implode( '|', $bits ) . ')';
 	}

includes/Message.php

Spacing +11 added lines, -11 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @param string $key
 	 */
-	public function __construct( string $key ) {
+	public function __construct ( string $key ) {
 		$this->key = $key;
 		$this->value = Config::getInstance()->getWikiMessage( $key );
 	}
@@ -23,7 +23,7 @@ 
 	 * @param array $args
 	 * @return self
 	 */
-	public function params( array $args ) : self {
+	public function params ( array $args ) : self {
 		$this->value = strtr( $this->value, $args );
 		return $this;
 	}
@@ -31,7 +31,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function text() : string {
+	public function text () : string {
 		$this->parsePlurals();
 		return $this->value;
 	}
@@ -39,7 +39,7 @@ 
 	/**
 	 * Replace {{$plur|<amount>|sing|plur}}
 	 */
-	protected function parsePlurals() {
+	protected function parsePlurals () {
 		$reg = '!\{\{\$plur\|(?P<amount>\d+)\|(?P<sing>[^}|]+)\|(?P<plur>[^|}]+)}}!';
 
 		if ( preg_match( $reg, $this->value ) === 0 ) {
@@ -48,7 +48,7 @@ 
 		$this->value = preg_replace_callback(
 			$reg,
 			function ( $matches ) {
-				return intval( $matches['amount'] ) > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
+				return intval( $matches[ 'amount' ] ) > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
 			},
 			$this->value
 		);
@@ -60,7 +60,7 @@ 
 	 * @param int $timestamp
 	 * @return string
 	 */
-	public static function getTimeWithArticle( int $timestamp ) : string {
+	public static function getTimeWithArticle ( int $timestamp ) : string {
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
 		$timeString = strftime( '%e %B alle %R', $timestamp );
 		// Remove the left space if day has a single digit
@@ -77,7 +77,7 @@ 
 	 * @param string $timeString
 	 * @return int
 	 */
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
 		$months = [
 			'gennaio' => 'January',
 			'febbraio' => 'February',
@@ -107,12 +107,12 @@ 
 	 * @param string $emptyText
 	 * @return string
 	 */
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
 		if ( count( $data ) > 1 ) {
 			$last = array_pop( $data );
 			$ret = implode( ', ', $data ) . " e $last";
 		} elseif ( $data ) {
-			$ret = (string)$data[0];
+			$ret = (string)$data[ 0 ];
 		} else {
 			$ret = $emptyText;
 		}
@@ -120,7 +120,7 @@ 
 		return $ret;
 	}
 
-	public function __toString() {
+	public function __toString () {
 		return $this->text();
 	}
 }

includes/Task/Subtask/SimpleUpdates.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -34,7 +34,7 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ) {
+	protected function updateVotazioni ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', $pages )
 		);
@@ -66,7 +66,7 @@ 
 	 * @param array $pages
 	 * @see UpdatesAround::addToNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -89,8 +89,8 @@ 
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
 		$voteMatches = $newsPage->getMatch( $voteReg );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -108,7 +108,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAdminList( array $pages ) {
+	protected function updateAdminList ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating admin list: ' . implode( ', ', $pages )
 		);
@@ -116,17 +116,17 @@ 
 		$newContent = $adminsPage->getContent();
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$reg = '!(\{\{Amministratore\/riga\|' . $user->getRegex() . ".+\| *)\d+( *\|[ \w]*\}\}\n)!";
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 				// Remove the line
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user->getName();
+				$removeNames[ ] = $user->getName();
 			} else {
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
-				$riconfNames[] = $user->getName();
+				$riconfNames[ ] = $user->getName();
 			}
 		}
 
@@ -146,12 +146,12 @@ 
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateCUList( array $pages ) {
+	protected function updateCUList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if CU list needs updating.' );
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( $user->inGroup( 'checkuser' ) ) {
@@ -159,10 +159,10 @@ 
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 					// Remove the line
 					$newContent = preg_replace( $reg, '', $newContent );
-					$removeNames[] = $user->getName();
+					$removeNames[ ] = $user->getName();
 				} else {
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
-					$riconfNames[] = $user->getName();
+					$riconfNames[ ] = $user->getName();
 				}
 			}
 		}

includes/TaskManager.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -52,7 +52,7 @@ 
 	 * @param string|null $name Only used in MODE_TASK and MODE_SUBTASK
 	 * @return TaskResult
 	 */
-	public function run( string $mode, string $name = null ) : TaskResult {
+	public function run ( string $mode, string $name = null ) : TaskResult {
 		$this->provider = new TaskDataProvider;
 
 		if ( $mode === self::MODE_COMPLETE ) {
@@ -69,7 +69,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	protected function runAllTasks() : TaskResult {
+	protected function runAllTasks () : TaskResult {
 		$orderedList = [
 			'update-list',
 			'start-new',
@@ -91,7 +91,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runTask( string $name ) : TaskResult {
+	protected function runTask ( string $name ) : TaskResult {
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
 		}
@@ -106,7 +106,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $name ) : TaskResult {
+	protected function runSubtask ( string $name ) : TaskResult {
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
 		}
@@ -121,7 +121,7 @@ 
 	 * @param string $class
 	 * @return Task
 	 */
-	private function getTaskInstance( string $class ) : Task {
+	private function getTaskInstance ( string $class ) : Task {
 		return new $class( $this->provider );
 	}
 
@@ -131,7 +131,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		return new $class( $this->provider );
 	}
 }

includes/TaskDataProvider.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -14,16 +14,16 @@ 
 	/** @var array[] */
 	private $processUsers;
 	/** @var PageRiconferma[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 
 	/**
 	 * Get a list of users to execute tasks on.
 	 *
 	 * @return array[]
 	 */
-	public function getUsersToProcess() : array {
+	public function getUsersToProcess () : array {
 		if ( $this->processUsers === null ) {
-			$this->processUsers = [];
+			$this->processUsers = [ ];
 			foreach ( PageBotList::get()->getAdminsList() as $user => $groups ) {
 				if ( array_intersect_key( $groups, [ 'override-perm', 'override' ] ) ) {
 					// A one-time override takes precedence
@@ -51,7 +51,7 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getOpenPages() : array {
+	public function getOpenPages () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$mainTitle = $this->getConfig()->get( 'main-page-title' );
@@ -65,10 +65,10 @@ 
 
 			$pages = RequestBase::newFromParams( $params )->execute()->query->pages;
 			$reg = ( new Page( $mainTitle ) )->getRegex();
-			$list = [];
+			$list = [ ];
 			foreach ( reset( $pages )->templates as $page ) {
 				if ( preg_match( "!$reg\/[^\/]+\/\d!", $page->title ) ) {
-					$list[] = new PageRiconferma( $page->title );
+					$list[ ] = new PageRiconferma( $page->title );
 				}
 			}
 		}
@@ -81,14 +81,14 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getPagesToClose() : array {
+	public function getPagesToClose () : array {
 		static $list = null;
 		if ( $list === null ) {
 			$allPages = $this->getOpenPages();
-			$list = [];
+			$list = [ ];
 			foreach ( $allPages as $page ) {
 				if ( time() > $page->getEndTimestamp() ) {
-					$list[] = $page;
+					$list[ ] = $page;
 				}
 			}
 		}
@@ -100,21 +100,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) {
+	public function removeUser ( string $name ) {
 		unset( $this->processUsers[ $name ] );
 	}
 
 	/**
 	 * @return PageRiconferma[]
 	 */
-	public function getCreatedPages() : array {
+	public function getCreatedPages () : array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	public function addCreatedPages( PageRiconferma $page ) {
-		$this->createdPages[] = $page;
+	public function addCreatedPages ( PageRiconferma $page ) {
+		$this->createdPages[ ] = $page;
 	}
 }

includes/Task/UpdateList.php

Spacing +22 added lines, -22 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -19,15 +19,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$this->actualList = $this->getActualAdmins();
 		$this->botList = PageBotList::get()->getAdminsList();
 
@@ -56,7 +56,7 @@ 
 	/**
 	 * @return array
 	 */
-	protected function getActualAdmins() : array {
+	protected function getActualAdmins () : array {
 		$this->getLogger()->debug( 'Retrieving admins - API' );
 		$params = [
 			'action' => 'query',
@@ -74,8 +74,8 @@ 
 	 * @param \stdClass $data
 	 * @return array
 	 */
-	protected function extractAdmins( \stdClass $data ) : array {
-		$ret = [];
+	protected function extractAdmins ( \stdClass $data ) : array {
+		$ret = [ ];
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
 		foreach ( $data->query->allusers as $u ) {
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -92,22 +92,22 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getMissingGroups() : array {
-		$missing = [];
+	protected function getMissingGroups () : array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$groupsList = [];
+			$groupsList = [ ];
 			if ( !isset( $this->botList[ $adm ] ) ) {
 				$groupsList = $groups;
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
+			} elseif ( count( $groups ) > count( $this->botList[ $adm ] ) ) {
 				// Only some groups are missing
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
+				$groupsList = array_diff_key( $groups, $this->botList[ $adm ] );
 			}
 
 			foreach ( $groupsList as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -122,7 +122,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ) : string {
+	protected function getFlagDate ( string $admin, string $group ) : string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$url = DEFAULT_URL;
@@ -157,7 +157,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
 		$ts = null;
 		foreach ( $data->query->logevents as $entry ) {
 			if ( !isset( $entry->params ) ) {
@@ -179,8 +179,8 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getExtraGroups() : array {
-		$extra = [];
+	protected function getExtraGroups () : array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			// These are not groups
 			unset( $groups[ 'override' ], $groups[ 'override-perm' ] );
@@ -200,7 +200,7 @@ 
 	 * @param array[] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ) : array {
+	protected function getNewContent ( array $missing, array $extra ) : array {
 		$newContent = $this->botList;
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {
@@ -225,15 +225,15 @@ 
 	 * @param array[] $newContent
 	 * @return array[]
 	 */
-	protected function removeOverrides( array $newContent ) : array {
-		$removed = [];
+	protected function removeOverrides ( array $newContent ) : array {
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			$ts = PageBotList::getValidTimestamp( $groups );
 			if ( date( 'd/m', $ts ) === date( 'd/m', strtotime( '- 1 days' ) ) &&
-				isset( $newContent[ $user ]['override'] )
+				isset( $newContent[ $user ][ 'override' ] )
 			) {
 				unset( $newContent[ $user ][ 'override' ] );
-				$removed[] = $user;
+				$removed[ ] = $user;
 			}
 		}