Daimona / BotRiconferme

includes/Request/RequestBase.php

Spacing +22 added lines, -22 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -29,14 +29,14 @@ 
 	/** @var string */
 	protected $method = 'GET';
 	/** @var string[] */
-	protected $newCookies = [];
+	protected $newCookies = [ ];
 
 	/**
 	 * Use self::newFromParams, which will provide the right class to use
 	 *
 	 * @param array $params
 	 */
-	protected function __construct( array $params ) {
+	protected function __construct ( array $params ) {
 		$this->params = [ 'format' => 'json' ] + $params;
 		$this->url = DEFAULT_URL;
 	}
@@ -47,7 +47,7 @@ 
 	 * @param array $params
 	 * @return self
 	 */
-	public static function newFromParams( array $params ) : self {
+	public static function newFromParams ( array $params ) : self {
 		if ( extension_loaded( 'curl' ) ) {
 			$ret = new CurlRequest( $params );
 		} else {
@@ -61,7 +61,7 @@ 
 	 *
 	 * @return self For chaining
 	 */
-	public function setPost() : self {
+	public function setPost () : self {
 		$this->method = 'POST';
 		return $this;
 	}
@@ -72,7 +72,7 @@ 
 	 * @param string $url
 	 * @return self for chaining
 	 */
-	public function setUrl( string $url ) : self {
+	public function setUrl ( string $url ) : self {
 		$this->url = $url;
 		return $this;
 	}
@@ -82,14 +82,14 @@ 
 	 *
 	 * @return \stdClass
 	 */
-	public function execute() : \stdClass {
+	public function execute () : \stdClass {
 		$curParams = $this->params;
-		$sets = [];
+		$sets = [ ];
 		do {
 			$res = $this->makeRequestInternal( $curParams );
 
 			$this->handleErrorAndWarnings( $res );
-			$sets[] = $res;
+			$sets[ ] = $res;
 
 			$finished = true;
 			if ( isset( $res->continue ) ) {
@@ -107,9 +107,9 @@ 
 	 * @param array $params
 	 * @return \stdClass
 	 */
-	private function makeRequestInternal( array $params ) : \stdClass {
+	private function makeRequestInternal ( array $params ) : \stdClass {
 		if ( $this->method === 'POST' ) {
-			$params['maxlag'] = self::MAXLAG;
+			$params[ 'maxlag' ] = self::MAXLAG;
 		}
 		$params = http_build_query( $params );
 
@@ -125,17 +125,17 @@ 
 	 * @param string $params
 	 * @return string
 	 */
-	abstract protected function reallyMakeRequest( string $params ) : string;
+	abstract protected function reallyMakeRequest ( string $params ) : string;
 
 	/**
 	 * After a request, set cookies for the next ones
 	 *
 	 * @param array $cookies
 	 */
-	protected function setCookies( array $cookies ) {
+	protected function setCookies ( array $cookies ) {
 		foreach ( $cookies as $cookie ) {
 			$bits = explode( ';', $cookie );
-			list( $name, $value ) = explode( '=', $bits[0] );
+			list( $name, $value ) = explode( '=', $bits[ 0 ] );
 			self::$cookiesToSet[ $name ] = $value;
 		}
 	}
@@ -146,7 +146,7 @@ 
 	 * @param \stdClass $res
 	 * @throws APIRequestException
 	 */
-	protected function handleErrorAndWarnings( $res ) {
+	protected function handleErrorAndWarnings ( $res ) {
 		if ( isset( $res->error ) ) {
 			switch ( $res->error->code ) {
 				case 'missingtitle':
@@ -172,7 +172,7 @@ 
 	 * @param \stdClass[] $sets
 	 * @return \stdClass
 	 */
-	private function mergeSets( array $sets ) : \stdClass {
+	private function mergeSets ( array $sets ) : \stdClass {
 		// Use the first set as template
 		$ret = array_shift( $sets );
 
@@ -189,7 +189,7 @@ 
 	 * @param array|\stdClass $second
 	 * @return array|\stdClass array
 	 */
-	private function recursiveMerge( $first, $second ) {
+	private function recursiveMerge ( $first, $second ) {
 		$ret = $first;
 		if ( is_array( $second ) ) {
 			$ret = is_array( $first ) ? array_merge_recursive( $first, $second ) : $second;
@@ -207,14 +207,14 @@ 
 	 *
 	 * @return array
 	 */
-	protected function getHeaders() :array {
+	protected function getHeaders () :array {
 		$ret = self::HEADERS;
 		if ( self::$cookiesToSet ) {
-			$cookies = [];
+			$cookies = [ ];
 			foreach ( self::$cookiesToSet as $cname => $cval ) {
-				$cookies[] = trim( "$cname=$cval" );
+				$cookies[ ] = trim( "$cname=$cval" );
 			}
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
+			$ret[ ] = 'Cookie: ' . implode( '; ', $cookies );
 		}
 		return $ret;
 	}
@@ -225,7 +225,7 @@ 
 	 * @param array $headers
 	 * @return string
 	 */
-	protected function buildHeadersString( array $headers ) : string {
+	protected function buildHeadersString ( array $headers ) : string {
 		$ret = '';
 		foreach ( $headers as $header ) {
 			$ret .= "$header\r\n";

includes/Request/NativeRequest.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -9,7 +9,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function reallyMakeRequest( string $params ) : string {
+	protected function reallyMakeRequest ( string $params ) : string {
 		$context = [
 			'http' => [
 				'method' => $this->method,
@@ -18,7 +18,7 @@ 
 		];
 		$url = $this->url;
 		if ( $this->method === 'POST' ) {
-			$context['http']['content'] = $params;
+			$context[ 'http' ][ 'content' ] = $params;
 		} else {
 			$url = "$url?$params";
 		}
@@ -27,8 +27,8 @@ 
 
 		foreach ( $http_response_header as $header ) {
 			$bits = explode( ':', $header, 2 );
-			if ( trim( $bits[0] ) === 'Set-Cookie' ) {
-				$this->newCookies[] = $bits[1];
+			if ( trim( $bits[ 0 ] ) === 'Set-Cookie' ) {
+				$this->newCookies[ ] = $bits[ 1 ];
 			}
 		}
 

includes/Bot.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -11,14 +11,14 @@ 
 
 	const VERSION = 1.0;
 
-	public function __construct() {
+	public function __construct () {
 		$this->logger = new Logger;
 	}
 
 	/**
 	 * Entry point for the whole process
 	 */
-	public function run() {
+	public function run () {
 		$this->logger->info( 'Starting full process.' );
 		$manager = new TaskManager;
 		$res = $manager->run( TaskManager::MODE_COMPLETE );
@@ -35,7 +35,7 @@ 
 	 *
 	 * @param string $task
 	 */
-	public function runTask( string $task ) {
+	public function runTask ( string $task ) {
 		$this->logger->info( "Starting single task $task." );
 		$manager = new TaskManager;
 		$res = $manager->run( TaskManager::MODE_TASK, $task );
@@ -52,7 +52,7 @@ 
 	 *
 	 * @param string $subtask
 	 */
-	public function runSubtask( string $subtask ) {
+	public function runSubtask ( string $subtask ) {
 		$this->logger->info( "Starting single subtask $subtask." );
 		$manager = new TaskManager;
 		$res = $manager->run( TaskManager::MODE_SUBTASK, $subtask );

includes/TaskManager.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -47,7 +47,7 @@ 
 	 * @param string|null $name Only used in MODE_TASK and MODE_SUBTASK
 	 * @return TaskResult
 	 */
-	public function run( int $mode, string $name = null ) : TaskResult {
+	public function run ( int $mode, string $name = null ) : TaskResult {
 		$this->provider = new TaskDataProvider;
 
 		if ( $mode === self::MODE_COMPLETE ) {
@@ -64,7 +64,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	protected function runAllTasks() : TaskResult {
+	protected function runAllTasks () : TaskResult {
 		if ( self::getLastFullRunDate() === date( 'd/m/Y' ) ) {
 			// Really avoid executing twice the same day
 			return new TaskResult( TaskResult::STATUS_ERROR, [ 'A full run was already executed today.' ] );
@@ -95,7 +95,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runTask( string $name ) : TaskResult {
+	protected function runTask ( string $name ) : TaskResult {
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
 		}
@@ -110,7 +110,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $name ) : TaskResult {
+	protected function runSubtask ( string $name ) : TaskResult {
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
 		}
@@ -124,7 +124,7 @@ 
 	 * @return string|null d/m/Y or null if no last run registered
 	 * @fixme Is this even necessary?
 	 */
-	public static function getLastFullRunDate() : ?string {
+	public static function getLastFullRunDate () : ?string {
 		if ( file_exists( self::LOG_FILE ) ) {
 			return file_get_contents( self::LOG_FILE ) ?: null;
 		} else {
@@ -138,7 +138,7 @@ 
 	 * @param string $class
 	 * @return Task
 	 */
-	private function getTaskInstance( string $class ) : Task {
+	private function getTaskInstance ( string $class ) : Task {
 		return new $class( $this->provider );
 	}
 
@@ -148,11 +148,11 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		return new $class( $this->provider );
 	}
 
-	public static function setLastFullRunDate() {
+	public static function setLastFullRunDate () {
 		file_put_contents( self::LOG_FILE, date( 'd/m/Y' ) );
 	}
 }

run.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 /**
  * Entry point for the bot, called by CLI
  */
@@ -37,7 +37,7 @@ 
 
 /* URL (for debugging purpose) */
 $urlParam = getopt( '', [ 'force-url:' ] );
-$url = $urlParam['force-url'] ?? 'https://it.wikipedia.org/w/api.php';
+$url = $urlParam[ 'force-url' ] ?? 'https://it.wikipedia.org/w/api.php';
 
 define( 'DEFAULT_URL', $url );
 
@@ -87,9 +87,9 @@ 
 
 if ( count( $taskOpts ) === 2 ) {
 	throw new InvalidArgumentException( 'Cannot specify both task and subtask.' );
-} elseif ( isset( $taskOpts['task'] ) ) {
+} elseif ( isset( $taskOpts[ 'task' ] ) ) {
 	$bot->runTask( $taskOpts[ 'task' ] );
-} elseif ( isset( $taskOpts['subtask'] ) ) {
+} elseif ( isset( $taskOpts[ 'subtask' ] ) ) {
 	$bot->runSubtask( $taskOpts[ 'subtask' ] );
 } else {
 	$bot->run();

includes/Page/PageBotList.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Page;
 
@@ -11,7 +11,7 @@ 
 	/**
 	 * @private Use self::get()
 	 */
-	public function __construct() {
+	public function __construct () {
 		parent::__construct( Config::getInstance()->get( 'list-title' ) );
 	}
 
@@ -20,7 +20,7 @@ 
 	 *
 	 * @return self
 	 */
-	public static function get() : self {
+	public static function get () : self {
 		static $instance = null;
 		if ( $instance === null ) {
 			$instance = new self;
@@ -33,7 +33,7 @@ 
 	 *
 	 * @return array[]
 	 */
-	public function getAdminsList() : array {
+	public function getAdminsList () : array {
 		return json_decode( $this->getContent(), true );
 	}
 }

includes/Page/Page.php

Spacing +13 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Page;
 
@@ -20,7 +20,7 @@ 
 	 * @param string $title
 	 * @param string $domain The site where the page lives, if different from default
 	 */
-	public function __construct( string $title, string $domain = DEFAULT_URL ) {
+	public function __construct ( string $title, string $domain = DEFAULT_URL ) {
 		$this->title = $title;
 		$this->controller = new WikiController( $domain );
 	}
@@ -28,7 +28,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function getTitle() : string {
+	public function getTitle () : string {
 		return $this->title;
 	}
 
@@ -38,7 +38,7 @@ 
 	 * @param int|null $section A section number to retrieve the content of that section
 	 * @return string
 	 */
-	public function getContent( int $section = null ) : string {
+	public function getContent ( int $section = null ) : string {
 		if ( $this->content === null ) {
 			$this->content = $this->controller->getPageContent( $this->title, $section );
 		}
@@ -50,16 +50,16 @@ 
 	 *
 	 * @param array $params
 	 */
-	public function edit( array $params ) {
+	public function edit ( array $params ) {
 		$params = [
 			'title' => $this->getTitle()
 		] + $params;
 
 		$this->controller->editPage( $params );
-		if ( isset( $params['text'] ) ) {
-			$this->content = $params['text'];
-		} elseif ( isset( $params['appendtext'] ) ) {
-			$this->content .= $params['appendtext'];
+		if ( isset( $params[ 'text' ] ) ) {
+			$this->content = $params[ 'text' ];
+		} elseif ( isset( $params[ 'appendtext' ] ) ) {
+			$this->content .= $params[ 'appendtext' ];
 		} else {
 			// Clear the cache anyway
 			( new Logger )->warning( 'Resetting content cache. Params: ' . var_export( $params, true ) );
@@ -73,7 +73,7 @@ 
 	 * @param string $regex
 	 * @return bool
 	 */
-	public function matches( string $regex ) : bool {
+	public function matches ( string $regex ) : bool {
 		return preg_match( $regex, $this->getContent() ) !== false;
 	}
 
@@ -85,8 +85,8 @@ 
 	 * @return string[]
 	 * @throws \Exception
 	 */
-	public function getMatch( string $regex ) : array {
-		$ret = [];
+	public function getMatch ( string $regex ) : array {
+		$ret = [ ];
 		if ( preg_match( $regex, $this->getContent(), $ret ) === false ) {
 			throw new \Exception;
 		}
@@ -98,7 +98,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		return $this->getTitle();
 	}
 }

includes/Task/CloseOld.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$orderedList = [
 			'close-pages',
 			'archive-pages',
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'archive-pages' => ArchivePages::class,
 			'close-pages' => ClosePages::class,

includes/Task/UpdateList.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -18,15 +18,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$this->actualList = $this->getActualAdmins();
 		$this->botList = $this->getDataProvider()->getUsersList();
 
@@ -55,7 +55,7 @@ 
 	/**
 	 * @return array
 	 */
-	protected function getActualAdmins() : array {
+	protected function getActualAdmins () : array {
 		$this->getLogger()->debug( 'Retrieving admins - API' );
 		$params = [
 			'action' => 'query',
@@ -73,8 +73,8 @@ 
 	 * @param \stdClass $data
 	 * @return array
 	 */
-	protected function extractAdmins( \stdClass $data ) : array {
-		$ret = [];
+	protected function extractAdmins ( \stdClass $data ) : array {
+		$ret = [ ];
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
 		foreach ( $data->query->allusers as $u ) {
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -91,22 +91,22 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getMissingGroups() : array {
-		$missing = [];
+	protected function getMissingGroups () : array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$groupsList = [];
+			$groupsList = [ ];
 			if ( !isset( $this->botList[ $adm ] ) ) {
 				$groupsList = $groups;
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
+			} elseif ( count( $groups ) > count( $this->botList[ $adm ] ) ) {
 				// Only some groups are missing
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
+				$groupsList = array_diff_key( $groups, $this->botList[ $adm ] );
 			}
 
 			foreach ( $groupsList as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -121,7 +121,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ) : string {
+	protected function getFlagDate ( string $admin, string $group ) : string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$url = DEFAULT_URL;
@@ -156,7 +156,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
 		$ts = null;
 		foreach ( $data->query->logevents as $entry ) {
 			if ( !isset( $entry->params ) ) {
@@ -178,8 +178,8 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getExtraGroups() : array {
-		$extra = [];
+	protected function getExtraGroups () : array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			if ( !isset( $this->actualList[ $name ] ) ) {
 				$extra[ $name ] = $groups;
@@ -197,7 +197,7 @@ 
 	 * @param array[] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ) : array {
+	protected function getNewContent ( array $missing, array $extra ) : array {
 		$newContent = $this->botList;
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {