Daimona / BotRiconferme

includes/TaskHelper/TaskResult.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\TaskHelper;
 
@@ -21,7 +21,7 @@ 
 	 * @param int $status One of the Task::STATUS_* constants
 	 * @param string[] $errors
 	 */
-	public function __construct( int $status, array $errors = [] ) {
+	public function __construct ( int $status, array $errors = [ ] ) {
 		$this->status = $status;
 		$this->errors = $errors;
 	}
@@ -29,7 +29,7 @@ 
 	/**
 	 * @return int
 	 */
-	public function getStatus() : int {
+	public function getStatus () : int {
 		return $this->status;
 	}
 
@@ -37,14 +37,14 @@ 
 	 * @return string[]
 	 * @suppress PhanUnreferencedPublicMethod
 	 */
-	public function getErrors() : array {
+	public function getErrors () : array {
 		return $this->errors;
 	}
 
 	/**
 	 * @param TaskResult $that
 	 */
-	public function merge( TaskResult $that ) : void {
+	public function merge ( TaskResult $that ) : void {
 		$this->status |= $that->status;
 		$this->errors = array_merge( $this->errors, $that->errors );
 	}
@@ -52,15 +52,15 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		if ( $this->isOK() ) {
 			$stat = 'OK';
 			$errs = "\tNo errors.";
 		} else {
 			$stat = 'ERROR';
-			$formattedErrs = [];
+			$formattedErrs = [ ];
 			foreach ( $this->errors as $err ) {
-				$formattedErrs[] = "\t - $err";
+				$formattedErrs[ ] = "\t - $err";
 			}
 			$errs = implode( "\n", $formattedErrs );
 		}
@@ -72,7 +72,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isOK() : bool {
+	public function isOK () : bool {
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
 	}
 }

run.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 /**
  * Entry point for the bot, called by CLI
  */

includes/Task/TaskBase.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -28,7 +28,7 @@ 
 	 * @param MessageProvider $mp
 	 * @param PageBotList $pbl
 	 */
-	final public function __construct(
+	final public function __construct (
 		LoggerInterface $logger,
 		WikiGroup $wikiGroup,
 		TaskDataProvider $dataProvider,
@@ -44,7 +44,7 @@ 
 	 *
 	 * @return \BotRiconferme\TaskHelper\TaskResult
 	 */
-	final public function run() : TaskResult {
+	final public function run () : TaskResult {
 		$class = ( new \ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -75,19 +75,19 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal() : int;
+	abstract protected function runInternal () : int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract public function getOperationName() : string;
+	abstract public function getOperationName () : string;
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider() : TaskDataProvider {
+	protected function getDataProvider () : TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

includes/Bot.php

Spacing +11 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -33,7 +33,7 @@ 
 	/**
 	 * @param CLI $cli
 	 */
-	public function __construct( CLI $cli ) {
+	public function __construct ( CLI $cli ) {
 		$this->cli = $cli;
 		$this->initialize();
 	}
@@ -41,7 +41,7 @@ 
 	/**
 	 * Initialize all members.
 	 */
-	private function initialize() : void {
+	private function initialize () : void {
 		$simpleLogger = new SimpleLogger();
 		$this->createWikiGroup( $simpleLogger );
 		$this->messageProvider = new MessageProvider(
@@ -55,14 +55,14 @@ 
 	/**
 	 * Main entry point
 	 */
-	public function run() : void {
+	public function run () : void {
 		$taskOpt = $this->cli->getTaskOpt();
 		$type = current( array_keys( $taskOpt ) );
 		try {
 			if ( $type === 'task' ) {
-				$this->runInternal( TaskManager::MODE_TASK, $taskOpt['task'] );
+				$this->runInternal( TaskManager::MODE_TASK, $taskOpt[ 'task' ] );
 			} elseif ( $type === 'subtask' ) {
-				$this->runInternal( TaskManager::MODE_SUBTASK, $taskOpt['subtask'] );
+				$this->runInternal( TaskManager::MODE_SUBTASK, $taskOpt[ 'subtask' ] );
 			} else {
 				$this->runInternal();
 			}
@@ -76,7 +76,7 @@ 
 	/**
 	 * @param LoggerInterface $baseLogger
 	 */
-	private function createWikiGroup( LoggerInterface $baseLogger ) : void {
+	private function createWikiGroup ( LoggerInterface $baseLogger ) : void {
 		// FIXME Hardcoded
 		$url = $this->cli->getURL() ?? 'https://it.wikipedia.org/w/api.php';
 		$localUserIdentifier = '@itwiki';
@@ -100,7 +100,7 @@ 
 	 *
 	 * @param IFlushingAwareLogger $baseLogger
 	 */
-	private function createMainLogger( IFlushingAwareLogger $baseLogger ) : void {
+	private function createMainLogger ( IFlushingAwareLogger $baseLogger ) : void {
 		$mainWiki = $this->wikiGroup->getMainWiki();
 		$mp = $this->messageProvider;
 		$errTitle = $this->cli->getOpt( 'error-title' );
@@ -127,7 +127,7 @@ 
 	/**
 	 * Create the Config
 	 */
-	private function initConfig() : void {
+	private function initConfig () : void {
 		$wiki = $this->wikiGroup->getMainWiki();
 		try {
 			$confValues = json_decode( $wiki->getPageContent( $this->cli->getOpt( 'config-title' ) ), true );
@@ -144,7 +144,7 @@ 
 	 * @param string $mode
 	 * @param string|null $name
 	 */
-	private function runInternal(
+	private function runInternal (
 		string $mode = TaskManager::MODE_COMPLETE,
 		string $name = null
 	) : void {
@@ -164,8 +164,7 @@ 
 		$base = "Execution of $activity";
 		if ( $res->isOK() ) {
 			$msg = $res->getStatus() === TaskResult::STATUS_NOTHING ?
-				': nothing to do' :
-				' completed successfully';
+				': nothing to do' : ' completed successfully';
 			$this->mainLogger->info( $base . $msg );
 		} else {
 			$this->mainLogger->error( "$base failed.\n$res" );

includes/Exception/BlockedException.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 

includes/Task/Subtask/FailedUpdates.php

Spacing +19 added lines, -19 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -16,7 +16,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$failed = $this->getFailures();
 		if ( !$failed ) {
 			return TaskResult::STATUS_NOTHING;
@@ -41,12 +41,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures() : array {
-		$ret = [];
+	private function getFailures () : array {
+		$ret = [ ];
 		$allPages = $this->getDataProvider()->getPagesToClose();
 		foreach ( $allPages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -55,7 +55,7 @@ 
 	/**
 	 * @param User[] $users
 	 */
-	protected function updateBurList( array $users ) : void {
+	protected function updateBurList ( array $users ) : void {
 		$this->getLogger()->info( 'Updating bur list. Removing: ' . implode( ', ', $users ) );
 		$remList = RegexUtils::regexFromArray( '!', ...$users );
 		$burList = $this->getPage( $this->getOpt( 'bur-list-title' ) );
@@ -78,7 +78,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) : void {
+	protected function requestRemoval ( array $pages ) : void {
 		$this->getLogger()->info( 'Requesting flag removal for: ' . implode( ', ', $pages ) );
 
 		$metaWiki = $this->getWikiGroup()->getCentralWiki();
@@ -115,15 +115,15 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) : void {
+	protected function updateAnnunci ( array $pages ) : void {
 		$this->getLogger()->info( 'Updating annunci' );
 		$section = 1;
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUserName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $this->msg( 'annunci-text' )->params( [ '$user' => $user ] )->text();
 		}
 
@@ -155,16 +155,16 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) : void {
+	protected function updateUltimeNotizie ( array $pages ) : void {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = $this->getPage( $this->getOpt( 'ultimenotizie-page-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		$msg = $this->msg( 'ultimenotizie-text' );
 		foreach ( $pages as $page ) {
 			$user = $page->getUserName();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= $msg->params( [ '$user' => $user, '$title' => $page->getTitle() ] )->text();
 		}
 
@@ -192,7 +192,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateTimeline( array $pages ) : void {
+	protected function updateTimeline ( array $pages ) : void {
 		$this->getLogger()->info( 'Updating timeline' );
 		$timelinePage = $this->getPage( $this->getOpt( 'timeline-page-title' ) );
 		$content = $timelinePage->getContent();
@@ -220,7 +220,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	private function updateCronologia( array $pages ) : void {
+	private function updateCronologia ( array $pages ) : void {
 		$this->getLogger()->info( 'Updating cronologia' );
 		$timelinePage = $this->getPage( $this->getOpt( 'cronologia-page-title' ) );
 		$content = $timelinePage->getContent();
@@ -247,7 +247,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	private function blockOnPrivate( array $pages ) : void {
+	private function blockOnPrivate ( array $pages ) : void {
 		$this->getLogger()->info( 'Blocking on private wiki: ' . implode( ', ', $pages ) );
 
 		$privWiki = $this->getWikiGroup()->getPrivateWiki();
@@ -264,12 +264,12 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return User[]
 	 */
-	private function getFailedBureaucrats( array $pages ) : array {
-		$ret = [];
+	private function getFailedBureaucrats ( array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			$user = $this->getUser( $page->getUserName() );
 			if ( $user->inGroup( 'bureaucrat' ) ) {
-				$ret[] = $user;
+				$ret[ ] = $user;
 			}
 		}
 		return $ret;

includes/Wiki/WikiGroup.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -18,7 +18,7 @@ 
 	 * @param Wiki $centralWiki
 	 * @param Wiki $privateWiki
 	 */
-	public function __construct( Wiki $mainWiki, Wiki $centralWiki, Wiki $privateWiki ) {
+	public function __construct ( Wiki $mainWiki, Wiki $centralWiki, Wiki $privateWiki ) {
 		$this->mainWiki = $mainWiki;
 		$this->centralWiki = $centralWiki;
 		$this->privateWiki = $privateWiki;
@@ -27,21 +27,21 @@ 
 	/**
 	 * @return Wiki
 	 */
-	public function getMainWiki() : Wiki {
+	public function getMainWiki () : Wiki {
 		return $this->mainWiki;
 	}
 
 	/**
 	 * @return Wiki
 	 */
-	public function getCentralWiki() : Wiki {
+	public function getCentralWiki () : Wiki {
 		return $this->centralWiki;
 	}
 
 	/**
 	 * @return Wiki
 	 */
-	public function getPrivateWiki() : Wiki {
+	public function getPrivateWiki () : Wiki {
 		return $this->privateWiki;
 	}
 }

includes/Task/StartVote.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,15 +14,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -36,13 +36,13 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ) : int {
-		$donePages = [];
+	protected function processPages ( array $pages ) : int {
+		$donePages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
 				$this->updateBasePage( $page );
-				$donePages[] = $page;
+				$donePages[ ] = $page;
 			}
 		}
 
@@ -60,7 +60,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ) : void {
+	protected function openVote ( PageRiconferma $page ) : void {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -99,12 +99,12 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see OpenUpdates::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ) : void {
+	protected function updateVotazioni ( array $pages ) : void {
 		$votePage = $this->getPage( $this->getOpt( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $this->getUser( $page->getUserName() );
+			$users[ ] = $this->getUser( $page->getUserName() );
 		}
 		$usersReg = RegexUtils::regexFromArray( '!', ...$users );
 
@@ -138,7 +138,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see \BotRiconferme\Task\Subtask\ClosePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) : void {
+	protected function updateBasePage ( PageRiconferma $page ) : void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -165,7 +165,7 @@ 
 	 * @see SimpleUpdates::updateNews()
 	 * @see OpenUpdates::addToNews()
 	 */
-	protected function updateNews( int $amount ) : void {
+	protected function updateNews ( int $amount ) : void {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
 
@@ -180,8 +180,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = ( (int)$newsPage->getMatch( $regTac )[2] - $amount ) ?: '';
-		$newVot = ( (int)$newsPage->getMatch( $regVot )[2] + $amount ) ?: '';
+		$newTac = ( (int)$newsPage->getMatch( $regTac )[ 2 ] - $amount ) ?: '';
+		$newVot = ( (int)$newsPage->getMatch( $regVot )[ 2 ] + $amount ) ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

includes/Task/Subtask/ClosePages.php

Spacing +5 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -35,7 +35,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) : void {
+	protected function addVoteCloseText ( PageRiconferma $page ) : void {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!u';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -50,7 +50,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) : void {
+	protected function updateBasePage ( PageRiconferma $page ) : void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -62,8 +62,7 @@ 
 		$current = $basePage->getContent();
 
 		$outcomeText = ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione di riconferma: $outcomeText" : 'riconferma tacita';
 
 		$newContent = preg_replace( '/^(#: *)(votazione di )?riconferma in corso/m', '$1' . $text, $current );