StartVote::updateVotePage() - Code Metrics - Inspection of "newClass" - Daimona/BotRiconferme - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 33a572...6f44ea )

by Daimona

created 2019-04-05 11:20 UTC

StartVote::updateVotePage() B

↳ Parent: StartVote

Complexity

Conditions	6
Paths	12

Size

Total Lines	57
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
eloc	37
nc	12
nop	1
dl	0
loc	57
rs	8.7057
c	0
b	0
f	0

How to fix Long Method

<?php declare( strict_types=1 );

namespace BotRiconferme\Task;

use BotRiconferme\Exception\TaskException;
use BotRiconferme\PageRiconferma;
use BotRiconferme\TaskResult;
use BotRiconferme\WikiController;

/**
 * Start a vote if there are >= 15 opposing comments
 */
class StartVote extends Task {
	/**
	 * @inheritDoc
	 */
	public function run() : TaskResult {
		$this->getLogger()->info( 'Starting task StartVote' );

		$pages = $this->getDataProvider()->getOpenPages();

		if ( $pages ) {
			$this->processPages( $pages );
		} else {
			$this->getLogger()->info( 'No open procedures.' );
		}

		$this->getLogger()->info( 'Task StartVote completed successfully' );
		return new TaskResult( self::STATUS_OK );
	}

	/**
	 * @param PageRiconferma[] $pages
	 */
	protected function processPages( array $pages ) {
		$actualPages = [];
		foreach ( $pages as $page ) {
			if ( $page->hasOpposition() && !$page->isVote() ) {
				$this->openVote( $page );
				$actualPages[] = $page;
			}
		}

		if ( $actualPages ) {
			$this->updateVotePage( $actualPages );
			$this->updateNews( count( $actualPages ) );
		} else {
			$this->getLogger()->info( 'No votes to open' );
		}
	}

	/**
	 * Start the vote for the given page
	 *
	 * @param PageRiconferma $page
	 */
	protected function openVote( PageRiconferma $page ) {
		$this->getLogger()->info( "Starting vote on $page" );

		$content = $page->getContent();

		$newContent = preg_replace(
			'!^La procedura di riconferma tacita .+!m',
			'<del>$0</del>',
			$content
		);

		$newContent = preg_replace(
			'/<!-- SEZIONE DA UTILIZZARE PER L\'EVENTUALE VOTAZIONE DI RICONFERMA.*\n/',
			'',
			$newContent
		);

		$newContent = preg_replace(
			'!(==== *Favorevoli alla riconferma *====\n\#[\s.]+)\n-->!',
			'$1',
			$newContent
		);

		$params = [
			'title' => $page->getTitle(),
			'text' => $newContent,
			'summary' => $this->getConfig()->get( 'vote-start-summary' )
		];

		$this->getController()->editPage( $params );
	}

	/**
	 * Update [[WP:Wikipediano/Votazioni]]
	 *
	 * @param PageRiconferma[] $pages
	 * @see ClosePages::updateVote()
	 * @see UpdatesAround::addVote()
	 */
	protected function updateVotePage( array $pages ) {
		$votePage = $this->getConfig()->get( 'ric-vote-page' );
		$content = $this->getController()->getPageContent( $votePage );

		$titles = [];
		foreach ( $pages as $page ) {
			$titles[] = preg_quote( $page->getTitle() );
		}
		$titleReg = implode( '|', $titles );
		$search = "!^\*.+ La \[\[($titleReg)\|procedura]] termina.+\n!gm";

		$newContent = preg_replace( $search, '', $content );
		// Make sure the last line ends with a full stop
		$sectionReg = '!(^;È in corso.+riconferma tacita.+amministratori.+\n(?:\*.+[;\.]\n)+\*.+)[\.;]!m';
		$newContent = preg_replace( $sectionReg, '$1.', $newContent );

		$newLines = '';
		$time = WikiController::getTimeWithArticle( time() + ( 60 * 60 * 24 * 14 ) );
		foreach ( $pages as $page ) {
			$newLines .= "*[[Utente:{$page->getUser()}|]]. La [[{$page->getTitle()}|votazione]] termina $time;\n";
		}

		$introReg = '!^Si vota per la \[\[Wikipedia:Amministratori/Riconferma annuale.+!m';
		if ( preg_match( $introReg, strip_tags( $content ) ) ) {
			// Put before the existing ones, if they're found outside comments
			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
		} else {
			// Start section
			$matches = [];
			if ( preg_match( $introReg, $content, $matches ) === false ) {
				throw new TaskException( 'Intro not found in vote page' );
			}
			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
			// Replace semicolon with full stop
			$newLines = substr( $newLines, 0, -2 ) . ".\n";
			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
		}

		$summary = strtr(
			$this->getConfig()->get( 'vote-start-vote-page-summary' ),
			[ '$num' => count( $pages ) ]
		);
		$summary = preg_replace_callback(
			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
			function ( $matches ) {
				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
			},
			$summary
		);

		$params = [
			'title' => $votePage,
			'text' => $newContent,
			'summary' => $summary
		];

		$this->getController()->editPage( $params );
	}

	/**
	 * Template:VotazioniRCnews
	 *
	 * @param int $amount Of pages to move
	 * @see UpdatesAround::addNews()
	 * @see ClosePages::updateNews()
	 */
	protected function updateNews( int $amount ) {
		$this->getLogger()->info( "Turning $amount pages into votes" );
		$newsPage = $this->getConfig()->get( 'ric-news-page' );

		$content = $this->getController()->getPageContent( $newsPage );
		$regTac = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
		$regVot = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';

		$tacMatches = $votMatches = [];
		if ( preg_match( $regTac, $content, $tacMatches ) === false ) {
			throw new TaskException( 'Param "tacite" not found in news page' );
		}
		if ( preg_match( $regVot, $content, $votMatches ) === false ) {
			throw new TaskException( 'Param "voto" not found in news page' );
		}

		$newTac = (int)$tacMatches[2] - $amount;
		$newVot = (int)$votMatches[2] + $amount;

		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

		$summary = strtr(
			$this->getConfig()->get( 'vote-start-news-page-summary' ),
			[ '$num' => $amount ]
		);
		$summary = preg_replace_callback(
			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
			function ( $matches ) {
				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
			},
			$summary
		);

		$params = [
			'title' => $newsPage,
			'text' => $newContent,
			'summary' => $summary
		];

		$this->getController()->editPage( $params );
	}
}


1			<?php declare( strict_types=1 );
2
3			namespace BotRiconferme\Task;
4
5			use BotRiconferme\Exception\TaskException;
6			use BotRiconferme\PageRiconferma;
7			use BotRiconferme\TaskResult;
8			use BotRiconferme\WikiController;
9
10			/**
11			* Start a vote if there are >= 15 opposing comments
12			*/
13			class StartVote extends Task {
14			/**
15			* @inheritDoc
16			*/
17			public function run() : TaskResult {
18			$this->getLogger()->info( 'Starting task StartVote' );
19
20			$pages = $this->getDataProvider()->getOpenPages();
21
22			if ( $pages ) {
23			$this->processPages( $pages );
24			} else {
25			$this->getLogger()->info( 'No open procedures.' );
26			}
27
28			$this->getLogger()->info( 'Task StartVote completed successfully' );
29			return new TaskResult( self::STATUS_OK );
30			}
31
32			/**
33			* @param PageRiconferma[] $pages
34			*/
35			protected function processPages( array $pages ) {
36			$actualPages = [];
37			foreach ( $pages as $page ) {
38			if ( $page->hasOpposition() && !$page->isVote() ) {
39			$this->openVote( $page );
40			$actualPages[] = $page;
41			}
42			}
43
44			if ( $actualPages ) {
45			$this->updateVotePage( $actualPages );
46			$this->updateNews( count( $actualPages ) );
47			} else {
48			$this->getLogger()->info( 'No votes to open' );
49			}
50			}
51
52			/**
53			* Start the vote for the given page
54			*
55			* @param PageRiconferma $page
56			*/
57			protected function openVote( PageRiconferma $page ) {
58			$this->getLogger()->info( "Starting vote on $page" );
59
60			$content = $page->getContent();
61
62			$newContent = preg_replace(
63			'!^La procedura di riconferma tacita .+!m',
64			'<del>$0</del>',
65			$content
66			);
67
68			$newContent = preg_replace(
69			'/<!-- SEZIONE DA UTILIZZARE PER L\'EVENTUALE VOTAZIONE DI RICONFERMA.*\n/',
70			'',
71			$newContent
72			);
73
74			$newContent = preg_replace(
75			'!(==== Favorevoli alla riconferma ====\n\#[\s.]+)\n-->!',
76			'$1',
77			$newContent
78			);
79
80			$params = [
81			'title' => $page->getTitle(),
82			'text' => $newContent,
83			'summary' => $this->getConfig()->get( 'vote-start-summary' )
84			];
85
86			$this->getController()->editPage( $params );
87			}
88
89			/**
90			* Update [[WP:Wikipediano/Votazioni]]
91			*
92			* @param PageRiconferma[] $pages
93			* @see ClosePages::updateVote()
94			* @see UpdatesAround::addVote()
95			*/
96			protected function updateVotePage( array $pages ) {
97			$votePage = $this->getConfig()->get( 'ric-vote-page' );
98			$content = $this->getController()->getPageContent( $votePage );
99
100			$titles = [];
101			foreach ( $pages as $page ) {
102			$titles[] = preg_quote( $page->getTitle() );
103			}
104			$titleReg = implode( '\|', $titles );
105			$search = "!^\*.+ La \[\[($titleReg)\\|procedura]] termina.+\n!gm";
106
107			$newContent = preg_replace( $search, '', $content );
108			// Make sure the last line ends with a full stop
109			$sectionReg = '!(^;È in corso.+riconferma tacita.+amministratori.+\n(?:\.+[;\.]\n)+\.+)[\.;]!m';
110			$newContent = preg_replace( $sectionReg, '$1.', $newContent );
111
112			$newLines = '';
113			$time = WikiController::getTimeWithArticle( time() + ( 60 * 60 * 24 * 14 ) );
114			foreach ( $pages as $page ) {
115			$newLines .= "*[[Utente:{$page->getUser()}\|]]. La [[{$page->getTitle()}\|votazione]] termina $time;\n";
116			}
117
118			$introReg = '!^Si vota per la \[\[Wikipedia:Amministratori/Riconferma annuale.+!m';
119			if ( preg_match( $introReg, strip_tags( $content ) ) ) {
120			// Put before the existing ones, if they're found outside comments
121			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
122			} else {
123			// Start section
124			$matches = [];
125			if ( preg_match( $introReg, $content, $matches ) === false ) {
126			throw new TaskException( 'Intro not found in vote page' );
127			}
128			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
129			// Replace semicolon with full stop
130			$newLines = substr( $newLines, 0, -2 ) . ".\n";
131			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
132			}
133
134			$summary = strtr(
135			$this->getConfig()->get( 'vote-start-vote-page-summary' ),
136			[ '$num' => count( $pages ) ]
137			);
138			$summary = preg_replace_callback(
139			'!\{\{$plur\|(\d+)\|([^\|]+)\|([^\|]+)}}!',
140			function ( $matches ) {
141			return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
142			},
143			$summary
144			);
145
146			$params = [
147			'title' => $votePage,
148			'text' => $newContent,
149			'summary' => $summary
150			];
151
152			$this->getController()->editPage( $params );
153			}
154
155			/**
156			* Template:VotazioniRCnews
157			*
158			* @param int $amount Of pages to move
159			* @see UpdatesAround::addNews()
160			* @see ClosePages::updateNews()
161			*/
162			protected function updateNews( int $amount ) {
163			$this->getLogger()->info( "Turning $amount pages into votes" );
164			$newsPage = $this->getConfig()->get( 'ric-news-page' );
165
166			$content = $this->getController()->getPageContent( $newsPage );
167			$regTac = '!(\\| riconferme[ _]tacite[ _]amministratori = *)(\d+)!';
168			$regVot = '!(\\| riconferme[ _]voto[ _]amministratori = *)(\d+)!';
169
170			$tacMatches = $votMatches = [];
171			if ( preg_match( $regTac, $content, $tacMatches ) === false ) {
172			throw new TaskException( 'Param "tacite" not found in news page' );
173			}
174			if ( preg_match( $regVot, $content, $votMatches ) === false ) {
175			throw new TaskException( 'Param "voto" not found in news page' );
176			}
177
178			$newTac = (int)$tacMatches[2] - $amount;
179			$newVot = (int)$votMatches[2] + $amount;
180
181			$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
182			$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );
183
184			$summary = strtr(
185			$this->getConfig()->get( 'vote-start-news-page-summary' ),
186			[ '$num' => $amount ]
187			);
188			$summary = preg_replace_callback(
189			'!\{\{$plur\|(\d+)\|([^\|]+)\|([^\|]+)}}!',
190			function ( $matches ) {
191			return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
192			},
193			$summary
194			);
195
196			$params = [
197			'title' => $newsPage,
198			'text' => $newContent,
199			'summary' => $summary
200			];
201
202			$this->getController()->editPage( $params );
203			}
204			}
205

Daimona / BotRiconferme

Push — master ( 33a572...6f44ea )

StartVote::updateVotePage() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like