Passed
Push — master ( d9b4e0...efcd2b )
by Daimona
01:45
created
includes/Task/Subtask/ArchivePages.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -13,7 +13,7 @@  discard block
 block discarded – undo
13 13
 	/**
14 14
 	 * @inheritDoc
15 15
 	 */
16
-	public function runInternal() : int {
16
+	public function runInternal () : int {
17 17
 		$pages = $this->getDataProvider()->getPagesToClose();
18 18
 
19 19
 		if ( !$pages ) {
@@ -32,18 +32,18 @@  discard block
 block discarded – undo
32 32
 	 * @param PageRiconferma[] $pages
33 33
 	 * @see OpenUpdates::addToMainPage()
34 34
 	 */
35
-	protected function removeFromMainPage( array $pages ) {
35
+	protected function removeFromMainPage ( array $pages ) {
36 36
 		$this->getLogger()->info(
37 37
 			'Removing from main: ' . implode( ', ', $pages )
38 38
 		);
39 39
 
40 40
 		$mainPage = $this->getPage( $this->getOpt( 'main-page-title' ) );
41
-		$remove = [];
41
+		$remove = [ ];
42 42
 		foreach ( $pages as $page ) {
43 43
 			// Order matters here. It's not guaranteed that there'll be a newline, but avoid
44 44
 			// regexps for that single character.
45
-			$remove[] = '{{' . $page->getTitle() . "}}\n";
46
-			$remove[] = '{{' . $page->getTitle() . '}}';
45
+			$remove[ ] = '{{' . $page->getTitle() . "}}\n";
46
+			$remove[ ] = '{{' . $page->getTitle() . '}}';
47 47
 		}
48 48
 
49 49
 		$newContent = str_replace( $remove, '', $mainPage->getContent() );
@@ -72,17 +72,17 @@  discard block
 block discarded – undo
72 72
 	 *
73 73
 	 * @param PageRiconferma[] $pages
74 74
 	 */
75
-	protected function addToArchive( array $pages ) {
75
+	protected function addToArchive ( array $pages ) {
76 76
 		$this->getLogger()->info(
77 77
 			'Adding to archive: ' . implode( ', ', $pages )
78 78
 		);
79 79
 
80
-		$simple = $votes = [];
80
+		$simple = $votes = [ ];
81 81
 		foreach ( $pages as $page ) {
82 82
 			if ( $page->isVote() ) {
83
-				$votes[] = $page;
83
+				$votes[ ] = $page;
84 84
 			} else {
85
-				$simple[] = $page;
85
+				$simple[ ] = $page;
86 86
 			}
87 87
 		}
88 88
 
@@ -103,15 +103,15 @@  discard block
 block discarded – undo
103 103
 	 * @param string $archiveTitle
104 104
 	 * @param PageRiconferma[] $pages
105 105
 	 */
106
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
106
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
107 107
 		$archivePage = $this->getPage( "$archiveTitle/" . date( 'Y' ) );
108 108
 		$existed = $archivePage->exists();
109 109
 
110 110
 		$append = "\n";
111
-		$archivedList = [];
111
+		$archivedList = [ ];
112 112
 		foreach ( $pages as $page ) {
113 113
 			$append .= '{{' . $page->getTitle() . "}}\n";
114
-			$archivedList[] = $page->getUserNum();
114
+			$archivedList[ ] = $page->getUserNum();
115 115
 		}
116 116
 
117 117
 		$summary = $this->msg( 'close-archive-summary' )
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
 	 *
133 133
 	 * @param string $archiveTitle
134 134
 	 */
135
-	private function addArchiveYear( string $archiveTitle ) {
135
+	private function addArchiveYear ( string $archiveTitle ) {
136 136
 		$page = $this->getPage( $archiveTitle );
137 137
 		$year = date( 'Y' );
138 138
 
Please login to merge, or discard this patch.
includes/TaskDataProvider.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -14,7 +14,7 @@  discard block
 block discarded – undo
14 14
 	/** @var User[]|null */
15 15
 	private $processUsers;
16 16
 	/** @var PageRiconferma[] */
17
-	private $createdPages = [];
17
+	private $createdPages = [ ];
18 18
 	/** @var PageRiconferma[]|null */
19 19
 	private $openPages;
20 20
 	/** @var PageRiconferma[]|null */
@@ -25,9 +25,9 @@  discard block
 block discarded – undo
25 25
 	 *
26 26
 	 * @return User[]
27 27
 	 */
28
-	public function getUsersToProcess() : array {
28
+	public function getUsersToProcess () : array {
29 29
 		if ( $this->processUsers === null ) {
30
-			$this->processUsers = [];
30
+			$this->processUsers = [ ];
31 31
 			foreach ( PageBotList::get( $this->getWiki() )->getAdminsList() as $name => $user ) {
32 32
 				if ( $this->shouldAddUser( $user ) ) {
33 33
 					$this->processUsers[ $name ] = $user;
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
44 44
 	 * @param User $user
45 45
 	 * @return bool
46 46
 	 */
47
-	private function shouldAddUser( User $user ) : bool {
47
+	private function shouldAddUser ( User $user ) : bool {
48 48
 		$timestamp = PageBotList::getOverrideTimestamp( $user->getUserInfo() );
49 49
 		$override = $timestamp !== null;
50 50
 
@@ -62,9 +62,9 @@  discard block
 block discarded – undo
62 62
 	 *
63 63
 	 * @return PageRiconferma[]
64 64
 	 */
65
-	public function getOpenPages() : array {
65
+	public function getOpenPages () : array {
66 66
 		if ( $this->openPages === null ) {
67
-			$this->openPages = [];
67
+			$this->openPages = [ ];
68 68
 			$mainTitle = $this->getOpt( 'main-page-title' );
69 69
 			$params = [
70 70
 				'action' => 'query',
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
 			$pages = RequestBase::newFromParams( $params )->execute()->query->pages;
79 79
 			foreach ( reset( $pages )->templates as $page ) {
80 80
 				if ( preg_match( "!$titleReg/[^/]+/\d!", $page->title ) ) {
81
-					$this->openPages[] = new PageRiconferma( $page->title, $this->getWiki() );
81
+					$this->openPages[ ] = new PageRiconferma( $page->title, $this->getWiki() );
82 82
 				}
83 83
 			}
84 84
 		}
@@ -91,12 +91,12 @@  discard block
 block discarded – undo
91 91
 	 *
92 92
 	 * @return PageRiconferma[]
93 93
 	 */
94
-	public function getPagesToClose() : array {
94
+	public function getPagesToClose () : array {
95 95
 		if ( $this->pagesToClose === null ) {
96
-			$this->pagesToClose = [];
96
+			$this->pagesToClose = [ ];
97 97
 			foreach ( $this->getOpenPages() as $page ) {
98 98
 				if ( time() > $page->getEndTimestamp() ) {
99
-					$this->pagesToClose[] = $page;
99
+					$this->pagesToClose[ ] = $page;
100 100
 				}
101 101
 			}
102 102
 		}
@@ -108,21 +108,21 @@  discard block
 block discarded – undo
108 108
 	 *
109 109
 	 * @param string $name
110 110
 	 */
111
-	public function removeUser( string $name ) {
111
+	public function removeUser ( string $name ) {
112 112
 		unset( $this->processUsers[ $name ] );
113 113
 	}
114 114
 
115 115
 	/**
116 116
 	 * @return PageRiconferma[]
117 117
 	 */
118
-	public function getCreatedPages() : array {
118
+	public function getCreatedPages () : array {
119 119
 		return $this->createdPages;
120 120
 	}
121 121
 
122 122
 	/**
123 123
 	 * @param PageRiconferma $page
124 124
 	 */
125
-	public function addCreatedPage( PageRiconferma $page ) {
126
-		$this->createdPages[] = $page;
125
+	public function addCreatedPage ( PageRiconferma $page ) {
126
+		$this->createdPages[ ] = $page;
127 127
 	}
128 128
 }
Please login to merge, or discard this patch.
includes/Task/UpdateList.php 1 patch
Spacing   +30 added lines, -30 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task;
4 4
 
@@ -19,15 +19,15 @@  discard block
 block discarded – undo
19 19
 	/**
20 20
 	 * @inheritDoc
21 21
 	 */
22
-	protected function getSubtasksMap(): array {
22
+	protected function getSubtasksMap (): array {
23 23
 		// Everything is done here.
24
-		return [];
24
+		return [ ];
25 25
 	}
26 26
 
27 27
 	/**
28 28
 	 * @inheritDoc
29 29
 	 */
30
-	public function runInternal() : int {
30
+	public function runInternal () : int {
31 31
 		$this->actualList = $this->getActualAdmins();
32 32
 		$pageBotList = PageBotList::get( $this->getWiki() );
33 33
 		$this->botList = $pageBotList->getDecodedContent();
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
 	/**
55 55
 	 * @return array
56 56
 	 */
57
-	protected function getActualAdmins() : array {
57
+	protected function getActualAdmins () : array {
58 58
 		$params = [
59 59
 			'action' => 'query',
60 60
 			'list' => 'allusers',
@@ -71,8 +71,8 @@  discard block
 block discarded – undo
71 71
 	 * @param \stdClass $data
72 72
 	 * @return array
73 73
 	 */
74
-	protected function extractAdmins( \stdClass $data ) : array {
75
-		$ret = [];
74
+	protected function extractAdmins ( \stdClass $data ) : array {
75
+		$ret = [ ];
76 76
 		$blacklist = $this->getOpt( 'exclude-admins' );
77 77
 		foreach ( $data->query->allusers as $u ) {
78 78
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -89,16 +89,16 @@  discard block
 block discarded – undo
89 89
 	 *
90 90
 	 * @return array[]
91 91
 	 */
92
-	protected function getMissingGroups() : array {
93
-		$missing = [];
92
+	protected function getMissingGroups () : array {
93
+		$missing = [ ];
94 94
 		foreach ( $this->actualList as $adm => $groups ) {
95
-			$curMissing = array_diff( $groups, array_keys( $this->botList[$adm] ?? [] ) );
95
+			$curMissing = array_diff( $groups, array_keys( $this->botList[ $adm ] ?? [ ] ) );
96 96
 
97 97
 			foreach ( $curMissing as $group ) {
98 98
 				try {
99 99
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
100 100
 				} catch ( TaskException $e ) {
101
-					$this->errors[] = $e->getMessage();
101
+					$this->errors[ ] = $e->getMessage();
102 102
 				}
103 103
 			}
104 104
 		}
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
 	 * @return string
114 114
 	 * @throws TaskException
115 115
 	 */
116
-	protected function getFlagDate( string $admin, string $group ) : string {
116
+	protected function getFlagDate ( string $admin, string $group ) : string {
117 117
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
118 118
 
119 119
 		$url = DEFAULT_URL;
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 	 * @param string $group
150 150
 	 * @return string|null
151 151
 	 */
152
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
152
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
153 153
 		$ts = null;
154 154
 		foreach ( $data->query->logevents as $entry ) {
155 155
 			if (
@@ -168,8 +168,8 @@  discard block
 block discarded – undo
168 168
 	 *
169 169
 	 * @return array[]
170 170
 	 */
171
-	protected function getExtraGroups() : array {
172
-		$extra = [];
171
+	protected function getExtraGroups () : array {
172
+		$extra = [ ];
173 173
 		foreach ( $this->botList as $name => $groups ) {
174 174
 			$groups = array_diff_key( $groups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) );
175 175
 			if ( !isset( $this->actualList[ $name ] ) ) {
@@ -185,7 +185,7 @@  discard block
 block discarded – undo
185 185
 	 * @param string[] $names
186 186
 	 * @return \stdClass
187 187
 	 */
188
-	private function getRenameEntries( array $names ) : \stdClass {
188
+	private function getRenameEntries ( array $names ) : \stdClass {
189 189
 		$titles = array_map( function ( $x ) {
190 190
 			return "Utente:$x";
191 191
 		}, $names );
@@ -209,14 +209,14 @@  discard block
 block discarded – undo
209 209
 	 * @param string[] $names
210 210
 	 * @return string[] [ old_name => new_name ]
211 211
 	 */
212
-	protected function getRenamedUsers( array $names ) : array {
212
+	protected function getRenamedUsers ( array $names ) : array {
213 213
 		if ( !$names ) {
214
-			return [];
214
+			return [ ];
215 215
 		}
216 216
 		$this->getLogger()->info( 'Checking rename for ' . implode( ', ', $names ) );
217 217
 
218 218
 		$data = $this->getRenameEntries( $names );
219
-		$ret = [];
219
+		$ret = [ ];
220 220
 		foreach ( $data->query->logevents as $entry ) {
221 221
 			// 1 month is arbitrary
222 222
 			if ( strtotime( $entry->timestamp ) > strtotime( '-1 month' ) ) {
@@ -234,18 +234,18 @@  discard block
 block discarded – undo
234 234
 	 * @param array &$newContent
235 235
 	 * @param array $removed
236 236
 	 */
237
-	private function handleRenames( array &$newContent, array $removed ) : void {
237
+	private function handleRenames ( array &$newContent, array $removed ) : void {
238 238
 		$renameMap = $this->getRenamedUsers( array_keys( $removed ) );
239 239
 		foreach ( $removed as $oldName => $info ) {
240 240
 			if (
241 241
 				array_key_exists( $oldName, $renameMap ) &&
242
-				array_key_exists( $renameMap[$oldName], $newContent )
242
+				array_key_exists( $renameMap[ $oldName ], $newContent )
243 243
 			) {
244 244
 				// This user was renamed! Add this name as alias, if they're still listed
245 245
 				$newName = $renameMap[ $oldName ];
246 246
 				$this->getLogger()->info( "Found rename $oldName -> $newName" );
247
-				$aliases = array_unique( array_merge( $newContent[ $newName ]['aliases'], [ $oldName ] ) );
248
-				$newContent[ $newName ]['aliases'] = $aliases;
247
+				$aliases = array_unique( array_merge( $newContent[ $newName ][ 'aliases' ], [ $oldName ] ) );
248
+				$newContent[ $newName ][ 'aliases' ] = $aliases;
249 249
 				// Transfer overrides to the new name.
250 250
 				$overrides = array_diff_key( $info, [ 'override' => 1, 'override-perm' => 1 ] );
251 251
 				$newContent[ $newName ] = array_merge( $newContent[ $newName ], $overrides );
@@ -259,12 +259,12 @@  discard block
 block discarded – undo
259 259
 	 * @param array[] $extra
260 260
 	 * @return string[] Removed users
261 261
 	 */
262
-	private function handleExtraAndMissing(
262
+	private function handleExtraAndMissing (
263 263
 		array &$newContent,
264 264
 		array $missing,
265 265
 		array $extra
266 266
 	) : array {
267
-		$removed = [];
267
+		$removed = [ ];
268 268
 		foreach ( $newContent as $user => $groups ) {
269 269
 			if ( isset( $missing[ $user ] ) ) {
270 270
 				$newContent[ $user ] = array_merge( $groups, $missing[ $user ] );
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
 				if ( array_diff_key( $newGroups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) ) ) {
275 275
 					$newContent[ $user ] = $newGroups;
276 276
 				} else {
277
-					$removed[$user] = $newContent[$user];
277
+					$removed[ $user ] = $newContent[ $user ];
278 278
 					unset( $newContent[ $user ] );
279 279
 				}
280 280
 			}
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
 	 * @param array[] $extra
292 292
 	 * @return array[]
293 293
 	 */
294
-	protected function getNewContent( array $missing, array $extra ) : array {
294
+	protected function getNewContent ( array $missing, array $extra ) : array {
295 295
 		$newContent = $this->botList;
296 296
 
297 297
 		$removed = $this->handleExtraAndMissing( $newContent, $missing, $extra );
@@ -311,12 +311,12 @@  discard block
 block discarded – undo
311 311
 	 *
312 312
 	 * @param array[] &$newContent
313 313
 	 */
314
-	protected function removeOverrides( array &$newContent ) : void {
315
-		$removed = [];
314
+	protected function removeOverrides ( array &$newContent ) : void {
315
+		$removed = [ ];
316 316
 		foreach ( $newContent as $user => $groups ) {
317 317
 			if ( PageBotList::isOverrideExpired( $groups ) ) {
318 318
 				unset( $newContent[ $user ][ 'override' ] );
319
-				$removed[] = $user;
319
+				$removed[ ] = $user;
320 320
 			}
321 321
 		}
322 322
 
Please login to merge, or discard this patch.
includes/CLI.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme;
4 4
 
@@ -57,14 +57,14 @@  discard block
 block discarded – undo
57 57
 	/**
58 58
 	 * @return bool
59 59
 	 */
60
-	public static function isCLI() : bool {
60
+	public static function isCLI () : bool {
61 61
 		return PHP_SAPI === 'cli';
62 62
 	}
63 63
 
64 64
 	/**
65 65
 	 * Populate options and check for required ones
66 66
 	 */
67
-	public function __construct() {
67
+	public function __construct () {
68 68
 		$opts = getopt( self::SHORT_OPTS, self::LONG_OPTS );
69 69
 		$this->checkRequiredOpts( $opts );
70 70
 		$this->checkConflictingOpts( $opts );
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
 	/**
76 76
 	 * @param array $opts
77 77
 	 */
78
-	private function checkRequiredOpts( array $opts ) : void {
78
+	private function checkRequiredOpts ( array $opts ) : void {
79 79
 		$missingOpts = array_diff( self::REQUIRED_OPTS, array_keys( $opts ) );
80 80
 		if ( $missingOpts ) {
81 81
 			exit( "Required options missing: " . implode( ', ', $missingOpts ) );
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 	/**
92 92
 	 * @param array $opts
93 93
 	 */
94
-	private function checkConflictingOpts( array $opts ) : void {
94
+	private function checkConflictingOpts ( array $opts ) : void {
95 95
 		$hasPw = array_key_exists( 'password', $opts );
96 96
 		$hasPwFile = array_key_exists( 'use-password-file', $opts );
97 97
 		if ( $hasPw && $hasPwFile ) {
@@ -108,11 +108,11 @@  discard block
 block discarded – undo
108 108
 	/**
109 109
 	 * @param array &$opts
110 110
 	 */
111
-	private function canonicalize( array &$opts ) : void {
111
+	private function canonicalize ( array &$opts ) : void {
112 112
 		if ( array_key_exists( 'use-password-file', $opts ) ) {
113 113
 			$pw = trim( file_get_contents( self::PASSWORD_FILE ) );
114
-			$opts['password'] = $pw;
115
-			unset( $opts['use-password-file'] );
114
+			$opts[ 'password' ] = $pw;
115
+			unset( $opts[ 'use-password-file' ] );
116 116
 		}
117 117
 	}
118 118
 
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 	 * These are the options required by Config.
121 121
 	 * @return array
122 122
 	 */
123
-	public function getMainOpts() : array {
123
+	public function getMainOpts () : array {
124 124
 		return array_intersect_key(
125 125
 			$this->opts,
126 126
 			array_fill_keys( Config::REQUIRED_OPTS, true )
@@ -132,14 +132,14 @@  discard block
 block discarded – undo
132 132
 	 * @param mixed|null $default
133 133
 	 * @return mixed
134 134
 	 */
135
-	public function getOpt( string $opt, $default = null ) {
136
-		return $this->opts[$opt] ?? $default;
135
+	public function getOpt ( string $opt, $default = null ) {
136
+		return $this->opts[ $opt ] ?? $default;
137 137
 	}
138 138
 
139 139
 	/**
140 140
 	 * @return array Either [ 'task' => taskname ] or [ 'subtask' => subtaskname ]
141 141
 	 */
142
-	public function getTaskOpt() : array {
142
+	public function getTaskOpt () : array {
143 143
 		return array_intersect_key(
144 144
 			$this->opts,
145 145
 			[ 'task' => true, 'subtask' => true ]
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
 	/**
150 150
 	 * @return string|null
151 151
 	 */
152
-	public function getURL() : ?string {
152
+	public function getURL () : ?string {
153 153
 		return $this->getOpt( 'force-url' );
154 154
 	}
155 155
 }
Please login to merge, or discard this patch.
includes/Task/Subtask/CreatePages.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	/**
17 17
 	 * @inheritDoc
18 18
 	 */
19
-	public function runInternal() : int {
19
+	public function runInternal () : int {
20 20
 		$users = $this->getDataProvider()->getUsersToProcess();
21 21
 
22 22
 		if ( !$users ) {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 	 *
36 36
 	 * @param User $user
37 37
 	 */
38
-	protected function processUser( User $user ) {
38
+	protected function processUser ( User $user ) {
39 39
 		$this->getLogger()->info( "Processing user $user" );
40 40
 		try {
41 41
 			$num = $this->getLastPageNum( $user ) + 1;
@@ -70,14 +70,14 @@  discard block
 block discarded – undo
70 70
 	 * @return int
71 71
 	 * @throws TaskException
72 72
 	 */
73
-	protected function getLastPageNum( User $user ) : int {
73
+	protected function getLastPageNum ( User $user ) : int {
74 74
 		$this->getLogger()->debug( "Retrieving previous pages for $user" );
75 75
 
76
-		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[1];
76
+		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[ 1 ];
77 77
 
78 78
 		$prefixes = [ "$unprefixedTitle/$user/" ];
79 79
 		foreach ( $user->getAliases() as $alias ) {
80
-			$prefixes[] = "$unprefixedTitle/$alias/";
80
+			$prefixes[ ] = "$unprefixedTitle/$alias/";
81 81
 		}
82 82
 
83 83
 		$params = [
@@ -111,14 +111,14 @@  discard block
 block discarded – undo
111 111
 	 * @param string $title
112 112
 	 * @param User $user
113 113
 	 */
114
-	protected function createPage( string $title, User $user ) {
114
+	protected function createPage ( string $title, User $user ) {
115 115
 		$this->getLogger()->info( "Creating page $title" );
116 116
 		$groups = $user->getGroupsWithDates();
117 117
 		$textParams = [
118 118
 			'$user' => $user->getName(),
119
-			'$date' => $groups['sysop'],
120
-			'$burocrate' => $groups['bureaucrat'] ?? '',
121
-			'$checkuser' => $groups['checkuser'] ?? ''
119
+			'$date' => $groups[ 'sysop' ],
120
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
121
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
122 122
 		];
123 123
 
124 124
 		$params = [
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
 	 * @param Page $basePage
137 137
 	 * @param string $newText
138 138
 	 */
139
-	protected function createBasePage( Page $basePage, string $newText ) {
139
+	protected function createBasePage ( Page $basePage, string $newText ) {
140 140
 		$this->getLogger()->info( "Creating base page $basePage" );
141 141
 
142 142
 		$params = [
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 	 * @param Page $basePage
153 153
 	 * @param string $newText
154 154
 	 */
155
-	protected function updateBasePage( Page $basePage, string $newText ) {
155
+	protected function updateBasePage ( Page $basePage, string $newText ) {
156 156
 		$this->getLogger()->info( "Updating base page $basePage" );
157 157
 
158 158
 		$params = [
Please login to merge, or discard this patch.
includes/Task/Subtask/SimpleUpdates.php 1 patch
Spacing   +23 added lines, -23 removed lines patch added patch discarded remove patch
@@ -1,4 +1,4 @@  discard block
 block discarded – undo
1
-<?php declare( strict_types=1 );
1
+<?php declare(strict_types=1);
2 2
 
3 3
 namespace BotRiconferme\Task\Subtask;
4 4
 
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
 	/**
17 17
 	 * @inheritDoc
18 18
 	 */
19
-	public function runInternal() : int {
19
+	public function runInternal () : int {
20 20
 		$pages = $this->getDataProvider()->getPagesToClose();
21 21
 
22 22
 		if ( !$pages ) {
@@ -38,15 +38,15 @@  discard block
 block discarded – undo
38 38
 	 * @param PageRiconferma[] $pages
39 39
 	 * @see OpenUpdates::addToVotazioni()
40 40
 	 */
41
-	protected function updateVotazioni( array $pages ) {
41
+	protected function updateVotazioni ( array $pages ) {
42 42
 		$this->getLogger()->info(
43 43
 			'Updating votazioni: ' . implode( ', ', $pages )
44 44
 		);
45 45
 		$votePage = $this->getPage( $this->getOpt( 'vote-page-title' ) );
46 46
 
47
-		$users = [];
47
+		$users = [ ];
48 48
 		foreach ( $pages as $page ) {
49
-			$users[] = $page->getUser();
49
+			$users[ ] = $page->getUser();
50 50
 		}
51 51
 		$usersReg = Element::regexFromArray( $users );
52 52
 
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
 	 * @param array $pages
68 68
 	 * @see OpenUpdates::addToNews()
69 69
 	 */
70
-	protected function updateNews( array $pages ) {
70
+	protected function updateNews ( array $pages ) {
71 71
 		$simpleAmount = $voteAmount = 0;
72 72
 		foreach ( $pages as $page ) {
73 73
 			if ( $page->isVote() ) {
@@ -87,8 +87,8 @@  discard block
 block discarded – undo
87 87
 		$simpleMatches = $newsPage->getMatch( $simpleReg );
88 88
 		$voteMatches = $newsPage->getMatch( $voteReg );
89 89
 
90
-		$newSimp = ( (int)$simpleMatches[2] - $simpleAmount ) ?: '';
91
-		$newVote = ( (int)$voteMatches[2] - $voteAmount ) ?: '';
90
+		$newSimp = ( (int)$simpleMatches[ 2 ] - $simpleAmount ) ?: '';
91
+		$newVote = ( (int)$voteMatches[ 2 ] - $voteAmount ) ?: '';
92 92
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $newsPage->getContent() );
93 93
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
94 94
 
@@ -106,12 +106,12 @@  discard block
 block discarded – undo
106 106
 	 *
107 107
 	 * @param bool[] $outcomes
108 108
 	 */
109
-	protected function updateAdminList( array $outcomes ) {
109
+	protected function updateAdminList ( array $outcomes ) {
110 110
 		$this->getLogger()->info( 'Updating admin list' );
111 111
 		$adminsPage = $this->getPage( $this->getOpt( 'admins-list-title' ) );
112 112
 		$newContent = $adminsPage->getContent();
113 113
 
114
-		$riconfNames = $removeNames = [];
114
+		$riconfNames = $removeNames = [ ];
115 115
 		foreach ( $outcomes as $username => $confirmed ) {
116 116
 			$user = $this->getUser( $username );
117 117
 			$userReg = $user->getRegex();
@@ -123,10 +123,10 @@  discard block
 block discarded – undo
123 123
 					'${1}{{subst:#timel:Ymd}}|' . $nextDate . '$2',
124 124
 					$newContent
125 125
 				);
126
-				$riconfNames[] = $username;
126
+				$riconfNames[ ] = $username;
127 127
 			} else {
128 128
 				$newContent = preg_replace( $reg, '', $newContent );
129
-				$removeNames[] = $username;
129
+				$removeNames[ ] = $username;
130 130
 			}
131 131
 		}
132 132
 
@@ -149,17 +149,17 @@  discard block
 block discarded – undo
149 149
 	 * @param User $user
150 150
 	 * @return int
151 151
 	 */
152
-	private function getNextTs( User $user ) : int {
152
+	private function getNextTs ( User $user ) : int {
153 153
 		$userInfo = $user->getUserInfo();
154
-		if ( isset( $userInfo['override-perm'] ) ) {
154
+		if ( isset( $userInfo[ 'override-perm' ] ) ) {
155 155
 			$date = \DateTime::createFromFormat(
156 156
 				'd/m/Y',
157
-				$userInfo['override-perm'] . '/' . date( 'Y' )
157
+				$userInfo[ 'override-perm' ] . '/' . date( 'Y' )
158 158
 			);
159 159
 		} else {
160 160
 			$date = null;
161
-			if ( isset( $userInfo['override'] ) ) {
162
-				$date = \DateTime::createFromFormat( 'd/m/Y', $userInfo['override'] );
161
+			if ( isset( $userInfo[ 'override' ] ) ) {
162
+				$date = \DateTime::createFromFormat( 'd/m/Y', $userInfo[ 'override' ] );
163 163
 			}
164 164
 			if ( !$date || $date <= new \DateTime ) {
165 165
 				$ts = PageBotList::getValidFlagTimestamp( $userInfo );
@@ -175,21 +175,21 @@  discard block
 block discarded – undo
175 175
 	/**
176 176
 	 * @param bool[] $outcomes
177 177
 	 */
178
-	protected function updateCUList( array $outcomes ) {
178
+	protected function updateCUList ( array $outcomes ) {
179 179
 		$this->getLogger()->info( 'Updating CU list.' );
180 180
 		$cuList = $this->getPage( $this->getOpt( 'cu-list-title' ) );
181 181
 		$newContent = $cuList->getContent();
182 182
 
183
-		$riconfNames = $removeNames = [];
183
+		$riconfNames = $removeNames = [ ];
184 184
 		foreach ( $outcomes as $user => $confirmed ) {
185 185
 			$userReg = $this->getUser( $user )->getRegex();
186 186
 			$reg = "!(\{\{ *Checkuser *\| *$userReg *\|[^}]+\| *)[\w \d]+(}}.*\n)!";
187 187
 			if ( $confirmed ) {
188 188
 				$newContent = preg_replace( $reg, '${1}{{subst:#time:j F Y}}$2', $newContent );
189
-				$riconfNames[] = $user;
189
+				$riconfNames[ ] = $user;
190 190
 			} else {
191 191
 				$newContent = preg_replace( $reg, '', $newContent );
192
-				$removeNames[] = $user;
192
+				$removeNames[ ] = $user;
193 193
 			}
194 194
 		}
195 195
 
@@ -213,8 +213,8 @@  discard block
 block discarded – undo
213 213
 	 * @param PageRiconferma[] $pages
214 214
 	 * @return bool[]
215 215
 	 */
216
-	private function getGroupOutcomes( string $group, array $pages ) : array {
217
-		$ret = [];
216
+	private function getGroupOutcomes ( string $group, array $pages ) : array {
217
+		$ret = [ ];
218 218
 		foreach ( $pages as $page ) {
219 219
 			$user = $page->getUser();
220 220
 			if ( $user->inGroup( $group ) ) {
Please login to merge, or discard this patch.