Daimona / BotRiconferme

includes/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,13 +14,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap() : array;
+	abstract protected function getSubtasksMap () : array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return \BotRiconferme\TaskHelper\TaskResult
 	 */
-	protected function runSubtask( string $subtask ) : TaskResult {
+	protected function runSubtask ( string $subtask ) : TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new \InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -33,7 +33,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'task';
 	}
 
@@ -43,7 +43,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		/** @var Subtask $ret */
 		$ret = new $class(
 			$this->getLogger(),

includes/TaskHelper/TaskResult.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\TaskHelper;
 
@@ -21,7 +21,7 @@ 
 	 * @param int $status One of the Task::STATUS_* constants
 	 * @param string[] $errors
 	 */
-	public function __construct( int $status, array $errors = [] ) {
+	public function __construct ( int $status, array $errors = [ ] ) {
 		$this->status = $status;
 		$this->errors = $errors;
 	}
@@ -29,7 +29,7 @@ 
 	/**
 	 * @return int
 	 */
-	public function getStatus() : int {
+	public function getStatus () : int {
 		return $this->status;
 	}
 
@@ -37,14 +37,14 @@ 
 	 * @return string[]
 	 * @suppress PhanUnreferencedPublicMethod
 	 */
-	public function getErrors() : array {
+	public function getErrors () : array {
 		return $this->errors;
 	}
 
 	/**
 	 * @param TaskResult $that
 	 */
-	public function merge( TaskResult $that ) : void {
+	public function merge ( TaskResult $that ) : void {
 		$this->status |= $that->status;
 		$this->errors = array_merge( $this->errors, $that->errors );
 	}
@@ -52,15 +52,15 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		if ( $this->isOK() ) {
 			$stat = 'OK';
 			$errs = "\tNo errors.";
 		} else {
 			$stat = 'ERROR';
-			$formattedErrs = [];
+			$formattedErrs = [ ];
 			foreach ( $this->errors as $err ) {
-				$formattedErrs[] = "\t - $err";
+				$formattedErrs[ ] = "\t - $err";
 			}
 			$errs = implode( "\n", $formattedErrs );
 		}
@@ -72,7 +72,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isOK() : bool {
+	public function isOK () : bool {
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
 	}
 }

includes/TaskHelper/TaskDataProvider.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\TaskHelper;
 
@@ -15,7 +15,7 @@ 
 	/** @var User[]|null */
 	private $processUsers;
 	/** @var PageRiconferma[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 	/** @var PageRiconferma[]|null */
 	private $openPages;
 	/** @var PageRiconferma[]|null */
@@ -26,9 +26,9 @@ 
 	 *
 	 * @return User[]
 	 */
-	public function getUsersToProcess() : array {
+	public function getUsersToProcess () : array {
 		if ( $this->processUsers === null ) {
-			$this->processUsers = [];
+			$this->processUsers = [ ];
 			foreach ( $this->getBotList()->getAdminsList() as $name => $userInfo ) {
 				if ( $this->shouldAddUser( $userInfo ) ) {
 					$this->processUsers[ $name ] = new User( $userInfo, $this->getWiki() );
@@ -45,7 +45,7 @@ 
 	 * @param UserInfo $ui
 	 * @return bool
 	 */
-	private function shouldAddUser( UserInfo $ui ) : bool {
+	private function shouldAddUser ( UserInfo $ui ) : bool {
 		$timestamp = $this->getBotList()->getOverrideTimestamp( $ui );
 		$override = $timestamp !== null;
 
@@ -63,9 +63,9 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getOpenPages() : array {
+	public function getOpenPages () : array {
 		if ( $this->openPages === null ) {
-			$this->openPages = [];
+			$this->openPages = [ ];
 			$mainTitle = $this->getOpt( 'main-page-title' );
 			$params = [
 				'action' => 'query',
@@ -79,7 +79,7 @@ 
 			$pages = $this->getRequestFactory()->newFromParams( $params )->execute()->query->pages;
 			foreach ( reset( $pages )->templates as $page ) {
 				if ( preg_match( "!$titleReg/[^/]+/\d!", $page->title ) ) {
-					$this->openPages[] = new PageRiconferma( $page->title, $this->getWiki() );
+					$this->openPages[ ] = new PageRiconferma( $page->title, $this->getWiki() );
 				}
 			}
 		}
@@ -92,12 +92,12 @@ 
 	 *
 	 * @return PageRiconferma[]
 	 */
-	public function getPagesToClose() : array {
+	public function getPagesToClose () : array {
 		if ( $this->pagesToClose === null ) {
-			$this->pagesToClose = [];
+			$this->pagesToClose = [ ];
 			foreach ( $this->getOpenPages() as $page ) {
 				if ( time() > $page->getEndTimestamp() ) {
-					$this->pagesToClose[] = $page;
+					$this->pagesToClose[ ] = $page;
 				}
 			}
 		}
@@ -109,21 +109,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) : void {
+	public function removeUser ( string $name ) : void {
 		unset( $this->processUsers[ $name ] );
 	}
 
 	/**
 	 * @return PageRiconferma[]
 	 */
-	public function getCreatedPages() : array {
+	public function getCreatedPages () : array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	public function addCreatedPage( PageRiconferma $page ) : void {
-		$this->createdPages[] = $page;
+	public function addCreatedPage ( PageRiconferma $page ) : void {
+		$this->createdPages[ ] = $page;
 	}
 }

includes/Message/Message.php

Spacing +10 added lines, -10 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Message;
 
@@ -23,7 +23,7 @@ 
 	/**
 	 * @param string $value
 	 */
-	public function __construct( string $value ) {
+	public function __construct ( string $value ) {
 		$this->value = $value;
 	}
 
@@ -31,7 +31,7 @@ 
 	 * @param array $args
 	 * @return self
 	 */
-	public function params( array $args ) : self {
+	public function params ( array $args ) : self {
 		$this->value = strtr( $this->value, $args );
 		return $this;
 	}
@@ -39,7 +39,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function text() : string {
+	public function text () : string {
 		$this->parsePlurals();
 		return $this->value;
 	}
@@ -47,7 +47,7 @@ 
 	/**
 	 * Replace {{$plur|<amount>|sing|plur}}
 	 */
-	protected function parsePlurals() : void {
+	protected function parsePlurals () : void {
 		$reg = '!\{\{\$plur\|(?P<amount>\d+)\|(?P<sing>[^}|]+)\|(?P<plur>[^|}]+)}}!';
 
 		if ( preg_match( $reg, $this->value ) === 0 ) {
@@ -56,7 +56,7 @@ 
 		$this->value = preg_replace_callback(
 			$reg,
 			static function ( $matches ) {
-				return (int)$matches['amount'] > 1 ? trim( $matches['plur'] ) : trim( $matches['sing'] );
+				return (int)$matches[ 'amount' ] > 1 ? trim( $matches[ 'plur' ] ) : trim( $matches[ 'sing' ] );
 			},
 			$this->value
 		);
@@ -68,7 +68,7 @@ 
 	 * @param string $timeString Full format, e.g. "15 aprile 2019 18:27"
 	 * @return int
 	 */
-	public static function getTimestampFromLocalTime( string $timeString ) : int {
+	public static function getTimestampFromLocalTime ( string $timeString ) : int {
 		$englishTime = str_ireplace(
 			array_values( self::MONTHS ),
 			array_keys( self::MONTHS ),
@@ -86,12 +86,12 @@ 
 	 * @param string $emptyText
 	 * @return string
 	 */
-	public static function commaList( array $data, string $emptyText = 'nessuno' ) : string {
+	public static function commaList ( array $data, string $emptyText = 'nessuno' ) : string {
 		if ( count( $data ) > 1 ) {
 			$last = array_pop( $data );
 			$ret = implode( ', ', $data ) . " e $last";
 		} elseif ( $data ) {
-			$ret = (string)$data[0];
+			$ret = (string)$data[ 0 ];
 		} else {
 			$ret = $emptyText;
 		}
@@ -99,7 +99,7 @@ 
 		return $ret;
 	}
 
-	public function __toString() {
+	public function __toString () {
 		return $this->text();
 	}
 }

run.php

Spacing +1 added lines, -1 removed lines

@@ -1,4 +1,4 @@
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 /**
  * Entry point for the bot, called by CLI
  */

includes/Task/TaskBase.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -28,7 +28,7 @@ 
 	 * @param MessageProvider $mp
 	 * @param PageBotList $pbl
 	 */
-	final public function __construct(
+	final public function __construct (
 		LoggerInterface $logger,
 		WikiGroup $wikiGroup,
 		TaskDataProvider $dataProvider,
@@ -44,7 +44,7 @@ 
 	 *
 	 * @return \BotRiconferme\TaskHelper\TaskResult
 	 */
-	final public function run() : TaskResult {
+	final public function run () : TaskResult {
 		$class = ( new \ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -75,19 +75,19 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal() : int;
+	abstract protected function runInternal () : int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract public function getOperationName() : string;
+	abstract public function getOperationName () : string;
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider() : TaskDataProvider {
+	protected function getDataProvider () : TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

includes/Bot.php

Spacing +11 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -33,7 +33,7 @@ 
 	/**
 	 * @param CLI $cli
 	 */
-	public function __construct( CLI $cli ) {
+	public function __construct ( CLI $cli ) {
 		$this->cli = $cli;
 		$this->initialize();
 	}
@@ -41,7 +41,7 @@ 
 	/**
 	 * Initialize all members.
 	 */
-	private function initialize() : void {
+	private function initialize () : void {
 		$simpleLogger = new SimpleLogger();
 		$this->createWikiGroup( $simpleLogger );
 		$this->messageProvider = new MessageProvider(
@@ -55,14 +55,14 @@ 
 	/**
 	 * Main entry point
 	 */
-	public function run() : void {
+	public function run () : void {
 		$taskOpt = $this->cli->getTaskOpt();
 		$type = current( array_keys( $taskOpt ) );
 		try {
 			if ( $type === 'task' ) {
-				$this->runInternal( TaskManager::MODE_TASK, $taskOpt['task'] );
+				$this->runInternal( TaskManager::MODE_TASK, $taskOpt[ 'task' ] );
 			} elseif ( $type === 'subtask' ) {
-				$this->runInternal( TaskManager::MODE_SUBTASK, $taskOpt['subtask'] );
+				$this->runInternal( TaskManager::MODE_SUBTASK, $taskOpt[ 'subtask' ] );
 			} else {
 				$this->runInternal();
 			}
@@ -76,7 +76,7 @@ 
 	/**
 	 * @param LoggerInterface $baseLogger
 	 */
-	private function createWikiGroup( LoggerInterface $baseLogger ) : void {
+	private function createWikiGroup ( LoggerInterface $baseLogger ) : void {
 		// FIXME Hardcoded
 		$url = $this->cli->getURL() ?? 'https://it.wikipedia.org/w/api.php';
 		$localUserIdentifier = '@itwiki';
@@ -100,7 +100,7 @@ 
 	 *
 	 * @param IFlushingAwareLogger $baseLogger
 	 */
-	private function createMainLogger( IFlushingAwareLogger $baseLogger ) : void {
+	private function createMainLogger ( IFlushingAwareLogger $baseLogger ) : void {
 		$mainWiki = $this->wikiGroup->getMainWiki();
 		$mp = $this->messageProvider;
 		$errTitle = $this->cli->getOpt( 'error-title' );
@@ -127,7 +127,7 @@ 
 	/**
 	 * Create the Config
 	 */
-	private function initConfig() : void {
+	private function initConfig () : void {
 		$wiki = $this->wikiGroup->getMainWiki();
 		try {
 			$confValues = json_decode( $wiki->getPageContent( $this->cli->getOpt( 'config-title' ) ), true );
@@ -144,7 +144,7 @@ 
 	 * @param string $mode
 	 * @param string|null $name
 	 */
-	private function runInternal(
+	private function runInternal (
 		string $mode = TaskManager::MODE_COMPLETE,
 		string $name = null
 	) : void {
@@ -164,8 +164,7 @@ 
 		$base = "Execution of $activity";
 		if ( $res->isOK() ) {
 			$msg = $res->getStatus() === TaskResult::STATUS_NOTHING ?
-				': nothing to do' :
-				' completed successfully';
+				': nothing to do' : ' completed successfully';
 			$this->mainLogger->info( $base . $msg );
 		} else {
 			$this->mainLogger->error( "$base failed.\n$res" );

includes/Task/Subtask/CreatePages.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$users = $this->getDataProvider()->getUsersToProcess();
 
 		if ( !$users ) {
@@ -34,7 +34,7 @@ 
 	 *
 	 * @param User $user
 	 */
-	protected function processUser( User $user ) : void {
+	protected function processUser ( User $user ) : void {
 		$this->getLogger()->info( "Processing user $user" );
 		try {
 			$num = $this->getLastPageNum( $user ) + 1;
@@ -69,14 +69,14 @@ 
 	 * @return int
 	 * @throws TaskException
 	 */
-	protected function getLastPageNum( User $user ) : int {
+	protected function getLastPageNum ( User $user ) : int {
 		$this->getLogger()->info( "Retrieving previous pages for $user" );
 
-		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[1];
+		$unprefixedTitle = explode( ':', $this->getOpt( 'main-page-title' ), 2 )[ 1 ];
 
 		$prefixes = [ "$unprefixedTitle/$user/" ];
 		foreach ( $user->getAliases() as $alias ) {
-			$prefixes[] = "$unprefixedTitle/$alias/";
+			$prefixes[ ] = "$unprefixedTitle/$alias/";
 		}
 
 		$params = [
@@ -86,9 +86,9 @@ 
 			'apprefix' => implode( '|', $prefixes ),
 			'aplimit' => 'max'
 		];
-		$foundPages = [];
+		$foundPages = [ ];
 		foreach ( $prefixes as $prefix ) {
-			$params['apprefix'] = $prefix;
+			$params[ 'apprefix' ] = $prefix;
 			$res = $this->getRequestFactory()->newFromParams( $params )->execute();
 			$foundPages = array_merge( $foundPages, $res->query->allpages );
 		}
@@ -114,14 +114,14 @@ 
 	 * @param string $title
 	 * @param User $user
 	 */
-	protected function createPage( string $title, User $user ) : void {
+	protected function createPage ( string $title, User $user ) : void {
 		$this->getLogger()->info( "Creating page $title" );
 		$groups = $user->getGroupsWithDates();
 		$textParams = [
 			'$user' => $user->getName(),
-			'$date' => $groups['sysop'],
-			'$burocrate' => $groups['bureaucrat'] ?? '',
-			'$checkuser' => $groups['checkuser'] ?? ''
+			'$date' => $groups[ 'sysop' ],
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
 		];
 
 		$params = [
@@ -139,7 +139,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function createBasePage( Page $basePage, string $newText ) : void {
+	protected function createBasePage ( Page $basePage, string $newText ) : void {
 		$this->getLogger()->info( "Creating base page $basePage" );
 
 		$params = [
@@ -155,7 +155,7 @@ 
 	 * @param Page $basePage
 	 * @param string $newText
 	 */
-	protected function updateBasePage( Page $basePage, string $newText ) : void {
+	protected function updateBasePage ( Page $basePage, string $newText ) : void {
 		$this->getLogger()->info( "Updating base page $basePage" );
 
 		$params = [

includes/Wiki/Page/PageRiconferma.php

Spacing +21 added lines, -21 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki\Page;
 
@@ -14,7 +14,7 @@ 
 	/** @var int */
 	private $opposeSection;
 	/** @var array Counts of votes for each section */
-	private $sectionCounts = [];
+	private $sectionCounts = [ ];
 
 	// Possible outcomes of a vote
 	public const OUTCOME_OK = 0;
@@ -33,7 +33,7 @@ 
 	 * because they can vary depending on whether the page is a vote, which is relatively
 	 * expensive to know since it requires parsing the content of the page.
 	 */
-	private function defineSections() : void {
+	private function defineSections () : void {
 		$this->supportSection = $this->isVote() ? 3 : 0;
 		$this->opposeSection = $this->isVote() ? 4 : 3;
 	}
@@ -43,8 +43,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserName() : string {
-		return explode( '/', $this->title )[2];
+	public function getUserName () : string {
+		return explode( '/', $this->title )[ 2 ];
 	}
 
 	/**
@@ -52,7 +52,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return (int)end( $bits );
 	}
@@ -62,8 +62,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -71,7 +71,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		$this->defineSections();
 		return $this->getCountForSection( $this->opposeSection );
 	}
@@ -82,7 +82,7 @@ 
 	 * @return int
 	 * @throws \BadMethodCallException
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
 		}
@@ -96,13 +96,13 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		if ( !isset( $this->sectionCounts[ $secNum ] ) ) {
 			$content = $this->wiki->getPageContent( $this->title, $secNum );
 			// Let's hope that this is good enough...
-			$this->sectionCounts[$secNum] = preg_match_all( "/^# *(?![# *:]|\.\.\.$)/m", $content );
+			$this->sectionCounts[ $secNum ] = preg_match_all( "/^# *(?![# *:]|\.\.\.$)/m", $content );
 		}
-		return $this->sectionCounts[$secNum];
+		return $this->sectionCounts[ $secNum ];
 	}
 
 	/**
@@ -110,9 +110,9 @@ 
 	 *
 	 * @return int
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		return (int)$this->getMatch( $reg )[1];
+		return (int)$this->getMatch( $reg )[ 1 ];
 	}
 
 	/**
@@ -120,7 +120,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= self::REQUIRED_OPPOSE;
 	}
 
@@ -129,7 +129,7 @@ 
 	 *
 	 * @return int One of the OUTCOME_* constants
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			return self::OUTCOME_OK;
 		}
@@ -152,7 +152,7 @@ 
 	 * @throws \BadMethodCallException
 	 * @throws \LogicException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -186,7 +186,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return !$this->matches( $sectionReg );
 	}
@@ -196,7 +196,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getCreationTimestamp() : int {
+	public function getCreationTimestamp () : int {
 		return $this->wiki->getPageCreationTS( $this->title );
 	}
 
@@ -205,7 +205,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
 			$reg = "!La votazione ha inizio il.+ alle ore ([\d:]+) e ha termine il (.+) alla stessa ora!";
 			[ , $hours, $day ] = $this->getMatch( $reg );