Daimona / BotRiconferme

includes/Task/UpdateList.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -18,7 +18,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task UpdateList' );
 		$this->actualList = $this->getActualAdmins();
 		$this->botList = $this->getList();
@@ -53,7 +53,7 @@ 
 	/**
 	 * @return array
 	 */
-	protected function getActualAdmins() : array {
+	protected function getActualAdmins () : array {
 		$this->getLogger()->debug( 'Retrieving admins - API' );
 		$params = [
 			'action' => 'query',
@@ -71,8 +71,8 @@ 
 	 * @param \stdClass $data
 	 * @return array
 	 */
-	protected function extractAdmins( \stdClass $data ) : array {
-		$ret = [];
+	protected function extractAdmins ( \stdClass $data ) : array {
+		$ret = [ ];
 		$blacklist = $this->getConfig()->get( 'exclude-admins' );
 		foreach ( $data->query->allusers as $u ) {
 			if ( in_array( $u->name, $blacklist ) ) {
@@ -87,7 +87,7 @@ 
 	/**
 	 * @return array
 	 */
-	protected function getList() : array {
+	protected function getList () : array {
 		$this->getLogger()->debug( 'Retrieving admins - JSON list' );
 		$content = $this->getController()->getPageContent( $this->getConfig()->get( 'list-title' ) );
 
@@ -99,22 +99,22 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getMissingGroups() : array {
-		$missing = [];
+	protected function getMissingGroups () : array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$groupsList = [];
+			$groupsList = [ ];
 			if ( !isset( $this->botList[ $adm ] ) ) {
 				$groupsList = $groups;
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
+			} elseif ( count( $groups ) > count( $this->botList[ $adm ] ) ) {
 				// Only some groups are missing
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
+				$groupsList = array_diff_key( $groups, $this->botList[ $adm ] );
 			}
 
 			foreach ( $groupsList as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -129,7 +129,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ) : string {
+	protected function getFlagDate ( string $admin, string $group ) : string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		if ( $group === 'checkuser' ) {
@@ -169,7 +169,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( \stdClass $data, string $group ) : ?string {
+	private function extractTimestamp ( \stdClass $data, string $group ) : ?string {
 		$ts = null;
 		foreach ( $data->query->logevents as $entry ) {
 			if ( !isset( $entry->params ) ) {
@@ -191,8 +191,8 @@ 
 	 *
 	 * @return array[]
 	 */
-	protected function getExtraGroups() : array {
-		$extra = [];
+	protected function getExtraGroups () : array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			if ( !isset( $this->actualList[ $name ] ) ) {
 				$extra[ $name ] = $groups;
@@ -208,7 +208,7 @@ 
 	 *
 	 * @param array $newContent
 	 */
-	protected function doUpdateList( array $newContent ) {
+	protected function doUpdateList ( array $newContent ) {
 		$this->getLogger()->info( 'Updating admin list' );
 
 		$params = [
@@ -227,7 +227,7 @@ 
 	 * @param array[] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ) : array {
+	protected function getNewContent ( array $missing, array $extra ) : array {
 		$newContent = $this->botList;
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {

includes/Task/UserNotice.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -11,13 +11,13 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task UserNotice' );
 
 		$pages = $this->getDataProvider()->getCreatedPages();
 		$users = $this->getDataProvider()->getUsersToProcess();
 		if ( $pages && $users ) {
-			$ricNums = [];
+			$ricNums = [ ];
 			foreach ( $pages as $page ) {
 				$bits = explode( '/', $page );
 				$num = intval( array_pop( $bits ) );
@@ -41,7 +41,7 @@ 
 	 * @param string $user
 	 * @param int $ricNum
 	 */
-	protected function addMsg( string $user, int $ricNum ) {
+	protected function addMsg ( string $user, int $ricNum ) {
 		$this->getLogger()->info( "Leaving msg to $user" );
 		$msg = str_replace( '$num', "$ricNum", $this->getConfig()->get( 'user-notice-msg' ) );
 

includes/Task/CreatePages.php

Spacing +11 added lines, -11 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task CreatePages' );
 		$users = $this->getDataProvider()->getUsersToProcess();
 
@@ -35,7 +35,7 @@ 
 	 * @param string $user
 	 * @param array $groups
 	 */
-	protected function processUser( string $user, array $groups ) {
+	protected function processUser ( string $user, array $groups ) {
 		try {
 			$num = $this->getLastPageNum( $user ) + 1;
 		} catch ( TaskException $e ) {
@@ -65,9 +65,9 @@ 
 	 * @return int
 	 * @throws TaskException
 	 */
-	protected function getLastPageNum( string $user ) : int {
+	protected function getLastPageNum ( string $user ) : int {
 		$this->getLogger()->debug( "Retrieving previous pages for $user" );
-		$unprefixedTitle = explode( ':', $this->getConfig()->get( 'ric-main-page' ), 2 )[1];
+		$unprefixedTitle = explode( ':', $this->getConfig()->get( 'ric-main-page' ), 2 )[ 1 ];
 		$params = [
 			'action' => 'query',
 			'list' => 'allpages',
@@ -102,14 +102,14 @@ 
 	 * @param string $user
 	 * @param array $groups
 	 */
-	protected function createPage( string $title, string $user, array $groups ) {
+	protected function createPage ( string $title, string $user, array $groups ) {
 		$this->getLogger()->info( "Creating page $title" );
 		$text = $this->getConfig()->get( 'ric-page-text' );
 		$textParams = [
 			'$user' => $user,
-			'$date' => $groups['sysop'],
-			'$burocrate' => $groups['bureaucrat'] ?? '',
-			'$checkuser' => $groups['checkuser'] ?? ''
+			'$date' => $groups[ 'sysop' ],
+			'$burocrate' => $groups[ 'bureaucrat' ] ?? '',
+			'$checkuser' => $groups[ 'checkuser' ] ?? ''
 		];
 		$text = strtr( $text, $textParams );
 
@@ -128,7 +128,7 @@ 
 	 * @param string $title
 	 * @param string $newText
 	 */
-	protected function createBasePage( string $title, string $newText ) {
+	protected function createBasePage ( string $title, string $newText ) {
 		$this->getLogger()->info( "Creating base page $title" );
 
 		$params = [
@@ -145,7 +145,7 @@ 
 	 * @param string $title
 	 * @param string $newText
 	 */
-	protected function updateBasePage( string $title, string $newText ) {
+	protected function updateBasePage ( string $title, string $newText ) {
 		$this->getLogger()->info( "Updating base page $title" );
 
 		$params = [

includes/WikiController.php

Spacing +11 added lines, -11 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -19,7 +19,7 @@ 
 	/** @var string[] */
 	private $tokens;
 
-	public function __construct() {
+	public function __construct () {
 		$this->logger = new Logger;
 	}
 
@@ -30,7 +30,7 @@ 
 	 * @return string
 	 * @throws MissingPageException
 	 */
-	public function getPageContent( string $title ) : string {
+	public function getPageContent ( string $title ) : string {
 		$this->logger->debug( "Retrieving page $title" );
 		$params = [
 			'action' => 'query',
@@ -47,7 +47,7 @@ 
 			throw new MissingPageException( $title );
 		}
 
-		return $page->revisions[0]->slots->main->{ '*' };
+		return $page->revisions[ 0 ]->slots->main->{ '*' };
 	}
 
 	/**
@@ -56,7 +56,7 @@ 
 	 * @param array $params
 	 * @throws EditException
 	 */
-	public function editPage( array $params ) {
+	public function editPage ( array $params ) {
 		$this->login();
 
 		$params = [
@@ -75,7 +75,7 @@ 
 	 * Login wrapper. Checks if we're already logged in and clears tokens cache
 	 * @throws LoginException
 	 */
-	public function login() {
+	public function login () {
 		if ( self::$loggedIn ) {
 			$this->logger->debug( 'Already logged in' );
 			return;
@@ -102,7 +102,7 @@ 
 
 		self::$loggedIn = true;
 		// Clear tokens cache
-		$this->tokens = [];
+		$this->tokens = [ ];
 		$this->logger->info( 'Login succeeded' );
 	}
 
@@ -112,7 +112,7 @@ 
 	 * @param string $type
 	 * @return string
 	 */
-	public function getToken( string $type ) : string {
+	public function getToken ( string $type ) : string {
 		if ( !isset( $this->tokens[ $type ] ) ) {
 			$params = [
 				'action' => 'query',
@@ -135,7 +135,7 @@ 
 	 * @param string $title
 	 * @return int
 	 */
-	public function getPageCreationTS( string $title ) : int {
+	public function getPageCreationTS ( string $title ) : int {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -148,7 +148,7 @@ 
 
 		$res = ( RequestBase::newFromParams( $params ) )->execute();
 		$data = $res->query->pages;
-		return strtotime( reset( $data )->revisions[0]->timestamp );
+		return strtotime( reset( $data )->revisions[ 0 ]->timestamp );
 	}
 
 	/**
@@ -157,7 +157,7 @@ 
 	 * @param string $title
 	 * @param string $reason
 	 */
-	public function protectPage( string $title, string $reason ) {
+	public function protectPage ( string $title, string $reason ) {
 		$this->logger->info( "Protecting page $title" );
 		$this->login();
 

includes/Task/ClosePages.php

Spacing +20 added lines, -20 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$titles = $this->getPagesList();
@@ -40,13 +40,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	protected function getPagesList() : array {
+	protected function getPagesList () : array {
 		$allPages = $this->getTranscludedPages();
-		$ret = [];
+		$ret = [ ];
 		foreach ( $allPages as $page ) {
 			$created = $this->getController()->getPageCreationTS( $page );
 			if ( time() - $created <= 60 * 60 * 24 * 7 && !$this->hasOpposition( $page ) ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -57,7 +57,7 @@ 
 	 *
 	 * @return string[]
 	 */
-	protected function getTranscludedPages() : array {
+	protected function getTranscludedPages () : array {
 		$baseTitle = $this->getConfig()->get( 'ric-main-page' );
 		$params = [
 			'action' => 'query',
@@ -69,10 +69,10 @@ 
 
 		$res = RequestBase::newFromParams( $params )->execute();
 		$pages = $res->query->pages;
-		$ret = [];
+		$ret = [ ];
 		foreach ( reset( $pages )->templates as $page ) {
 			if ( preg_match( "!$baseTitle\/[^\/]+\/\d!", $page->title ) !== false ) {
-				$ret[] = $page->title;
+				$ret[ ] = $page->title;
 			}
 		}
 		return $ret;
@@ -82,7 +82,7 @@ 
 	 * @param string $page
 	 * @return bool
 	 */
-	protected function hasOpposition( string $page ) : bool {
+	protected function hasOpposition ( string $page ) : bool {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -93,7 +93,7 @@ 
 		];
 		$res = RequestBase::newFromParams( $params )->execute();
 		$page = reset( $res->query->pages );
-		$content = $page->revisions[0]->slots->main->{ '*' };
+		$content = $page->revisions[ 0 ]->slots->main->{ '*' };
 		// Let's hope that this is good enough...
 		$votes = substr_count( $content, "\n\# *(?![#*])" );
 		return $votes >= 15;
@@ -104,12 +104,12 @@ 
 	 * @param string[] $titles
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $titles ) {
+	protected function removeFromMainPage ( array $titles ) {
 		$this->getLogger()->info( 'Removing from main: ' . implode( ', ', $titles ) );
 
 		$mainPage = $this->getConfig()->get( 'ric-main-page' );
 		$content = $this->getController()->getPageContent( $mainPage );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $titles as $title ) {
 			$translations[ '{{' . $title . '}}' ] = '';
 		}
@@ -127,7 +127,7 @@ 
 	 *
 	 * @param string[] $titles
 	 */
-	protected function addToArchive( array $titles ) {
+	protected function addToArchive ( array $titles ) {
 		$this->getLogger()->info( 'Adding to archive: ' . implode( ', ', $titles ) );
 
 		$archiveTitle = $this->getConfig()->get( 'close-archive-title' );
@@ -151,7 +151,7 @@ 
 	 * @param string $title
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( string $title ) {
+	protected function updateBasePage ( string $title ) {
 		$this->getLogger()->info( "Updating base page $title" );
 
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal WTF Phan what's wrong w/ u?
@@ -172,7 +172,7 @@ 
 	 * @param string[] $titles
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $titles ) {
+	protected function updateVote ( array $titles ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
@@ -198,19 +198,19 @@ 
 	 * @throws TaskException
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Decreasing the news counter by $amount" );
 		$newsPage = $this->getConfig()->get( 'ric-news-page' );
 
 		$content = $this->getController()->getPageContent( $newsPage );
 		$reg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 
-		$matches = [];
+		$matches = [ ];
 		if ( preg_match( $reg, $content, $matches ) === false ) {
 			throw new TaskException( 'Param not found in news page' );
 		}
 
-		$newNum = (int)$matches[2] - $amount;
+		$newNum = (int)$matches[ 2 ] - $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$params = [
@@ -227,12 +227,12 @@ 
 	 *
 	 * @param string[] $titles
 	 */
-	protected function updateAdminList( array $titles ) {
+	protected function updateAdminList ( array $titles ) {
 		$listTitle = $this->getConfig()->get( 'admins-list' );
 		$content = $this->getController()->getPageContent( $listTitle );
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 		foreach ( $titles as $title ) {
-			$user = explode( '/', $title )[2];
+			$user = explode( '/', $title )[ 2 ];
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+(?= *\|(?: *pausa)? *\}\})!";
 			$content = preg_replace( $reg, '$1' . $newDate, $content );
 		}