Daimona / BotRiconferme

includes/Logger/WikiLogger.php

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Logger;
 
@@ -29,7 +29,7 @@ 
 	 * @param string $summary
 	 * @param string $minlevel
 	 */
-	public function __construct( Page $logPage, string $summary, $minlevel = LogLevel::INFO ) {
+	public function __construct ( Page $logPage, string $summary, $minlevel = LogLevel::INFO ) {
 		$this->minLevel = $this->levelToInt( $minlevel );
 		$this->logPage = $logPage;
 		$this->summary = $summary;
@@ -40,16 +40,16 @@ 
 	 * @param mixed[] $context
 	 * @suppress PhanUnusedPublicMethodParameter
 	 */
-	public function log( $level, $message, array $context = [] ) :void {
+	public function log ( $level, $message, array $context = [ ] ) :void {
 		if ( $this->levelToInt( $level ) >= $this->minLevel ) {
-			$this->buffer[] = $this->getFormattedMessage( $level, $message );
+			$this->buffer[ ] = $this->getFormattedMessage( $level, $message );
 		}
 	}
 
 	/**
 	 * @return string
 	 */
-	protected function getOutput() : string {
+	protected function getOutput () : string {
 		$line = str_repeat( '-', 80 );
 		return "\n\n" . implode( "\n", $this->buffer ) . "\n$line\n\n";
 	}
@@ -57,7 +57,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function flush() : void {
+	public function flush () : void {
 		if ( $this->buffer ) {
 			$this->logPage->edit( [
 				'appendtext' => $this->getOutput(),

includes/Logger/MultiLogger.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Logger;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @param IFlushingAwareLogger ...$loggers
 	 */
-	public function __construct( IFlushingAwareLogger ...$loggers ) {
+	public function __construct ( IFlushingAwareLogger ...$loggers ) {
 		$this->loggers = $loggers;
 	}
 
@@ -23,7 +23,7 @@ 
 	 * @param mixed[] $context
 	 * @suppress PhanUnusedPublicMethodParameter
 	 */
-	public function log( $level, $message, array $context = [] ) :void {
+	public function log ( $level, $message, array $context = [ ] ) :void {
 		foreach ( $this->loggers as $logger ) {
 			$logger->log( $level, $message );
 		}
@@ -32,7 +32,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function flush() : void {
+	public function flush () : void {
 		foreach ( $this->loggers as $logger ) {
 			$logger->flush();
 		}

includes/Logger/SimpleLogger.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Logger;
 
@@ -17,7 +17,7 @@ 
 	/**
 	 * @param string $minlevel
 	 */
-	public function __construct( $minlevel = LogLevel::INFO ) {
+	public function __construct ( $minlevel = LogLevel::INFO ) {
 		$this->minLevel = $this->levelToInt( $minlevel );
 	}
 
@@ -26,7 +26,7 @@ 
 	 * @param mixed[] $context
 	 * @suppress PhanUnusedPublicMethodParameter
 	 */
-	public function log( $level, $message, array $context = [] ) : void {
+	public function log ( $level, $message, array $context = [ ] ) : void {
 		if ( $this->levelToInt( $level ) >= $this->minLevel ) {
 			echo $this->getFormattedMessage( $level, $message ) . "\n";
 		}
@@ -35,7 +35,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function flush() : void {
+	public function flush () : void {
 		// Everything else is printed immediately
 		echo "\n" . str_repeat( '-', 80 ) . "\n\n";
 	}

includes/Wiki/User.php

Spacing +13 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Wiki;
 
@@ -23,7 +23,7 @@ 
 	 * @param UserInfo $ui
 	 * @param Wiki $wiki
 	 */
-	public function __construct( UserInfo $ui, Wiki $wiki ) {
+	public function __construct ( UserInfo $ui, Wiki $wiki ) {
 		$this->wiki = $wiki;
 		$this->name = $ui->getName();
 		$this->ui = $ui;
@@ -32,7 +32,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function getName() : string {
+	public function getName () : string {
 		return $this->name;
 	}
 
@@ -41,7 +41,7 @@ 
 	 *
 	 * @return string[]
 	 */
-	public function getGroups() : array {
+	public function getGroups () : array {
 		return $this->ui->extractGroups();
 	}
 
@@ -50,7 +50,7 @@ 
 	 *
 	 * @return string[] [ group => date ]
 	 */
-	public function getGroupsWithDates() : array {
+	public function getGroupsWithDates () : array {
 		return $this->ui->extractGroupsWithDates();
 	}
 
@@ -60,7 +60,7 @@ 
 	 * @param string $groupName
 	 * @return bool
 	 */
-	public function inGroup( string $groupName ) : bool {
+	public function inGroup ( string $groupName ) : bool {
 		return in_array( $groupName, $this->getGroups(), true );
 	}
 
@@ -69,9 +69,9 @@ 
 	 *
 	 * @inheritDoc
 	 */
-	public function getRegex( string $delimiter = '/' ) : string {
+	public function getRegex ( string $delimiter = '/' ) : string {
 		$bits = $this->getAliases();
-		$bits[] = $this->name;
+		$bits[ ] = $this->name;
 		$regexify = static function ( string $el ) use ( $delimiter ) : string {
 			return str_replace( ' ', '[ _]', preg_quote( $el, $delimiter ) );
 		};
@@ -83,14 +83,14 @@ 
 	 *
 	 * @return string[]
 	 */
-	public function getAliases() : array {
+	public function getAliases () : array {
 		return $this->ui->getAliases();
 	}
 
 	/**
 	 * @return Page
 	 */
-	public function getTalkPage() : Page {
+	public function getTalkPage () : Page {
 		return new Page( "User talk:{$this->name}", $this->wiki );
 	}
 
@@ -98,7 +98,7 @@ 
 	 * Get the default base page, e.g. WP:A/Riconferma annuale/XXX
 	 * @return Page
 	 */
-	public function getBasePage() : Page {
+	public function getBasePage () : Page {
 		$prefix = Config::getInstance()->get( 'main-page-title' );
 		return new Page( "$prefix/$this", $this->wiki );
 	}
@@ -110,7 +110,7 @@ 
 	 * @throws MissingPageException
 	 * @return Page
 	 */
-	public function getExistingBasePage() : Page {
+	public function getExistingBasePage () : Page {
 		$basePage = $this->getBasePage();
 		if ( !$basePage->exists() ) {
 			$basePage = null;
@@ -134,7 +134,7 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString() : string {
+	public function __toString () : string {
 		return $this->name;
 	}
 }

includes/CLI.php

Spacing +16 added lines, -16 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -66,14 +66,14 @@ 
 	/**
 	 * @return bool
 	 */
-	public static function isCLI() : bool {
+	public static function isCLI () : bool {
 		return PHP_SAPI === 'cli';
 	}
 
 	/**
 	 * Populate options and check for required ones
 	 */
-	public function __construct() {
+	public function __construct () {
 		$opts = getopt( self::SHORT_OPTS, self::LONG_OPTS );
 		$this->checkRequiredOpts( $opts );
 		$this->checkConflictingOpts( $opts );
@@ -84,7 +84,7 @@ 
 	/**
 	 * @param string[] $opts
 	 */
-	private function checkRequiredOpts( array $opts ) : void {
+	private function checkRequiredOpts ( array $opts ) : void {
 		$missingOpts = array_diff( self::REQUIRED_OPTS, array_keys( $opts ) );
 		if ( $missingOpts ) {
 			$this->fatal( 'Required options missing: ' . implode( ', ', $missingOpts ) );
@@ -106,7 +106,7 @@ 
 	/**
 	 * @param string[] $opts
 	 */
-	private function checkConflictingOpts( array $opts ) : void {
+	private function checkConflictingOpts ( array $opts ) : void {
 		$this->checkNotBothSet( $opts, 'password', 'use-password-file' );
 		if ( array_key_exists( 'use-password-file', $opts ) && !file_exists( self::PASSWORD_FILE ) ) {
 			$this->fatal( 'Please create the password file (' . self::PASSWORD_FILE . ')' );
@@ -127,7 +127,7 @@ 
 	 * @param string $first
 	 * @param string $second
 	 */
-	private function checkNotBothSet( array $opts, string $first, string $second ) : void {
+	private function checkNotBothSet ( array $opts, string $first, string $second ) : void {
 		if ( array_key_exists( $first, $opts ) && array_key_exists( $second, $opts ) ) {
 			$this->fatal( "Can only use one of '$first' and '$second'" );
 		}
@@ -136,23 +136,23 @@ 
 	/**
 	 * @param string[] &$opts
 	 */
-	private function canonicalize( array &$opts ) : void {
+	private function canonicalize ( array &$opts ) : void {
 		if ( array_key_exists( 'use-password-file', $opts ) ) {
 			$pw = trim( file_get_contents( self::PASSWORD_FILE ) );
-			$opts['password'] = $pw;
-			unset( $opts['use-password-file'] );
+			$opts[ 'password' ] = $pw;
+			unset( $opts[ 'use-password-file' ] );
 		}
 		if ( array_key_exists( 'use-private-password-file', $opts ) ) {
 			$pw = trim( file_get_contents( self::PRIVATE_PASSWORD_FILE ) );
-			$opts['private-password'] = $pw;
-			unset( $opts['use-private-password-file'] );
+			$opts[ 'private-password' ] = $pw;
+			unset( $opts[ 'use-private-password-file' ] );
 		}
 	}
 
 	/**
 	 * @param string $msg
 	 */
-	private function fatal( string $msg ) : void {
+	private function fatal ( string $msg ) : void {
 		exit( $msg . "\n" );
 	}
 
@@ -161,14 +161,14 @@ 
 	 * @param mixed|null $default
 	 * @return mixed
 	 */
-	public function getOpt( string $opt, $default = null ) {
-		return $this->opts[$opt] ?? $default;
+	public function getOpt ( string $opt, $default = null ) {
+		return $this->opts[ $opt ] ?? $default;
 	}
 
 	/**
 	 * @return string[] Either [ 'tasks' => name1,... ] or [ 'subtasks' => name1,... ]
 	 */
-	public function getTaskOpt() : array {
+	public function getTaskOpt () : array {
 		return array_intersect_key(
 			$this->opts,
 			[ 'tasks' => true, 'subtasks' => true ]
@@ -178,7 +178,7 @@ 
 	/**
 	 * @return string|null
 	 */
-	public function getURL() : ?string {
+	public function getURL () : ?string {
 		return $this->getOpt( 'force-url' );
 	}
 }

includes/Bot.php

Spacing +12 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -33,7 +33,7 @@ 
 	/**
 	 * @param CLI $cli
 	 */
-	public function __construct( CLI $cli ) {
+	public function __construct ( CLI $cli ) {
 		$this->cli = $cli;
 		$this->initialize();
 	}
@@ -41,7 +41,7 @@ 
 	/**
 	 * Initialize all members.
 	 */
-	private function initialize() : void {
+	private function initialize () : void {
 		$simpleLogger = new SimpleLogger();
 		$this->createWikiGroup( $simpleLogger );
 		$this->messageProvider = new MessageProvider(
@@ -55,14 +55,14 @@ 
 	/**
 	 * Main entry point
 	 */
-	public function run() : void {
+	public function run () : void {
 		$taskOpt = $this->cli->getTaskOpt();
 		$type = current( array_keys( $taskOpt ) );
 		try {
 			if ( $type === 'task' ) {
-				$this->runInternal( TaskManager::MODE_TASK, explode( ',', $taskOpt['tasks'] ) );
+				$this->runInternal( TaskManager::MODE_TASK, explode( ',', $taskOpt[ 'tasks' ] ) );
 			} elseif ( $type === 'subtask' ) {
-				$this->runInternal( TaskManager::MODE_SUBTASK, explode( ',', $taskOpt['subtasks'] ) );
+				$this->runInternal( TaskManager::MODE_SUBTASK, explode( ',', $taskOpt[ 'subtasks' ] ) );
 			} else {
 				$this->runInternal();
 			}
@@ -76,7 +76,7 @@ 
 	/**
 	 * @param LoggerInterface $baseLogger
 	 */
-	private function createWikiGroup( LoggerInterface $baseLogger ) : void {
+	private function createWikiGroup ( LoggerInterface $baseLogger ) : void {
 		// FIXME Hardcoded
 		$url = $this->cli->getURL() ?? 'https://it.wikipedia.org/w/api.php';
 		$localUserIdentifier = '@itwiki';
@@ -114,7 +114,7 @@ 
 	 *
 	 * @param IFlushingAwareLogger $baseLogger
 	 */
-	private function createMainLogger( IFlushingAwareLogger $baseLogger ) : void {
+	private function createMainLogger ( IFlushingAwareLogger $baseLogger ) : void {
 		$mainWiki = $this->wikiGroup->getMainWiki();
 		$mp = $this->messageProvider;
 		$errTitle = $this->cli->getOpt( 'error-title' );
@@ -141,7 +141,7 @@ 
 	/**
 	 * Create the Config
 	 */
-	private function initConfig() : void {
+	private function initConfig () : void {
 		$wiki = $this->wikiGroup->getMainWiki();
 		try {
 			$confValues = json_decode( $wiki->getPageContent( $this->cli->getOpt( 'config-title' ) ), true );
@@ -158,9 +158,9 @@ 
 	 * @param string $mode
 	 * @param string[] $taskNames
 	 */
-	private function runInternal(
+	private function runInternal (
 		string $mode = TaskManager::MODE_COMPLETE,
-		array $taskNames = []
+		array $taskNames = [ ]
 	) : void {
 		$activity = $mode === TaskManager::MODE_COMPLETE
 			? TaskManager::MODE_COMPLETE
@@ -180,8 +180,7 @@ 
 		$base = "Execution of $activity";
 		if ( $res->isOK() ) {
 			$msg = $res->getStatus() === TaskResult::STATUS_NOTHING ?
-				': nothing to do' :
-				' completed successfully';
+				': nothing to do' : ' completed successfully';
 			$this->mainLogger->info( $base . $msg );
 		} else {
 			$this->mainLogger->error( "$base failed.\n$res" );

includes/TaskManager.php

Spacing +10 added lines, -10 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -64,7 +64,7 @@ 
 	 * @param MessageProvider $mp
 	 * @param PageBotList $pbl
 	 */
-	public function __construct(
+	public function __construct (
 		LoggerInterface $logger,
 		WikiGroup $wikiGroup,
 		MessageProvider $mp,
@@ -89,7 +89,7 @@ 
 	 * @param string[] $tasks Only used in MODE_TASK and MODE_SUBTASK
 	 * @return TaskResult
 	 */
-	public function run( string $mode, array $tasks = [] ) : TaskResult {
+	public function run ( string $mode, array $tasks = [ ] ) : TaskResult {
 		if ( $mode === self::MODE_COMPLETE ) {
 			return $this->runAllTasks();
 		}
@@ -104,7 +104,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	protected function runAllTasks() : TaskResult {
+	protected function runAllTasks () : TaskResult {
 		$orderedList = [
 			'update-list',
 			'start-new',
@@ -121,7 +121,7 @@ 
 	 * @param string[] $tasks
 	 * @return TaskResult
 	 */
-	private function runTasks( array $tasks ) : TaskResult {
+	private function runTasks ( array $tasks ) : TaskResult {
 		$res = new TaskResult( TaskResult::STATUS_GOOD );
 		do {
 			$res->merge( $this->runTask( current( $tasks ) ) );
@@ -136,7 +136,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runTask( string $name ) : TaskResult {
+	protected function runTask ( string $name ) : TaskResult {
 		if ( !isset( self::TASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid task." );
 		}
@@ -150,7 +150,7 @@ 
 	 * @param string[] $subtasks
 	 * @return TaskResult
 	 */
-	private function runSubtasks( array $subtasks ) : TaskResult {
+	private function runSubtasks ( array $subtasks ) : TaskResult {
 		$res = new TaskResult( TaskResult::STATUS_GOOD );
 		do {
 			$res->merge( $this->runSubtask( current( $subtasks ) ) );
@@ -165,7 +165,7 @@ 
 	 * @param string $name
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $name ) : TaskResult {
+	protected function runSubtask ( string $name ) : TaskResult {
 		if ( !isset( self::SUBTASKS_MAP[ $name ] ) ) {
 			throw new \InvalidArgumentException( "'$name' is not a valid subtask." );
 		}
@@ -180,7 +180,7 @@ 
 	 * @param string $name
 	 * @return Task
 	 */
-	private function getTaskInstance( string $name ) : Task {
+	private function getTaskInstance ( string $name ) : Task {
 		$class = self::TASKS_MAP[ $name ];
 		/** @var Task $ret */
 		$ret = new $class(
@@ -199,7 +199,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		/** @var Subtask $ret */
 		$ret = new $class(
 			$this->logger,