UserNotice::addMsg() - Code Metrics - Inspection of "thirdStatus" - Daimona/BotRiconferme - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (a4e902)

by Daimona

created 2019-04-08 15:14 UTC

UserNotice::addMsg() A

↳ Parent: UserNotice

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	9
nc	1
nop	2
dl	0
loc	13
rs	9.9666
c	0
b	0
f	0

<?php declare( strict_types=1 );

namespace BotRiconferme\Task\Subtask;

/**
 * Notify the affected users
 */
class UserNotice extends Subtask {
	/**
	 * @inheritDoc
	 */
	public function runInternal() : int {
		$pages = $this->getDataProvider()->getCreatedPages();
		$users = $this->getDataProvider()->getUsersToProcess();

		if ( !$pages || !$users ) {

			return self::STATUS_NOTHING;
		}

		$ricNums = [];
		foreach ( $pages as $page ) {
			$ricNums[ $page->getUser() ] = $page->getNum();
		}

		foreach ( $users as $user => $_ ) {
			$this->addMsg( $user, $ricNums[ $user ] );
		}

		return self::STATUS_GOOD;
	}

	/**
	 * Leaves a message to the talk page
	 *
	 * @param string $user
	 * @param int $ricNum
	 */
	protected function addMsg( string $user, int $ricNum ) {
		$this->getLogger()->info( "Leaving msg to $user" );
		$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();

		$params = [
			'title' => "User talk:$user",
			'section' => 'new',
			'text' => $msg,
			'sectiontitle' => $this->getConfig()->get( 'user-notice-title' ),
			'summary' => $this->getConfig()->get( 'user-notice-summary' )
		];

		$this->getController()->editPage( $params );
	}
}


1			<?php declare( strict_types=1 );
2
3			namespace BotRiconferme\Task\Subtask;
4
5			/**
6			* Notify the affected users
7			*/
8			class UserNotice extends Subtask {
9			/**
10			* @inheritDoc
11			*/
12			public function runInternal() : int {
13			$pages = $this->getDataProvider()->getCreatedPages();
14			$users = $this->getDataProvider()->getUsersToProcess();
15
16			if ( !$pages \|\| !$users ) {
			1 ignored issue – show Bug Best Practice introduced 2019-04-08 15:16 UTC by Report Bug Copy Issue Report The expression `$pages` of type `BotRiconferme\Page\PageRiconferma[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
17			return self::STATUS_NOTHING;
18			}
19
20			$ricNums = [];
21			foreach ( $pages as $page ) {
22			$ricNums[ $page->getUser() ] = $page->getNum();
23			}
24
25			foreach ( $users as $user => $_ ) {
26			$this->addMsg( $user, $ricNums[ $user ] );
27			}
28
29			return self::STATUS_GOOD;
30			}
31
32			/**
33			* Leaves a message to the talk page
34			*
35			* @param string $user
36			* @param int $ricNum
37			*/
38			protected function addMsg( string $user, int $ricNum ) {
39			$this->getLogger()->info( "Leaving msg to $user" );
40			$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();
41
42			$params = [
43			'title' => "User talk:$user",
44			'section' => 'new',
45			'text' => $msg,
46			'sectiontitle' => $this->getConfig()->get( 'user-notice-title' ),
47			'summary' => $this->getConfig()->get( 'user-notice-summary' )
48			];
49
50			$this->getController()->editPage( $params );
51			}
52			}
53

Daimona / BotRiconferme

Branch — master (a4e902)

UserNotice::addMsg() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like