Inspection of "fix" - Daimona/BotRiconferme - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8cfe0d...80c5b5 )

by Daimona

created 2019-04-06 17:36 UTC

Status

Spacing +53 added lines, -54 removed lines patch added patch discarded remove patch

@@ -1,4 +1,4 @@  discard block
 block discarded – undo
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$pages = $this->getPagesList();
@@ -52,12 +52,12 @@  discard block
 block discarded – undo
 	 *
 	 * @return PageRiconferma[]
 	 */
-	protected function getPagesList() : array {
+	protected function getPagesList () : array {
 		$allPages = $this->getDataProvider()->getOpenPages();
-		$ret = [];
+		$ret = [ ];
 		foreach ( $allPages as $page ) {
 			if ( time() > $page->getEndTimestamp() ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -69,11 +69,11 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @return PageRiconferma[]
 	 */
-	private function getFailures( array $pages ) : array {
-		$ret = [];
+	private function getFailures ( array $pages ) : array {
+		$ret = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) {
+	protected function addVoteCloseText ( PageRiconferma $page ) {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -100,13 +100,13 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $pages ) {
+	protected function removeFromMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
 		$mainPage = new Page( $this->getConfig()->get( 'ric-main-page' ) );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $pages as $page ) {
 			$translations[ '{{' . $page->getTitle() . '}}' ] = '';
 		}
@@ -124,17 +124,17 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToArchive( array $pages ) {
+	protected function addToArchive ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 
-		$simple = $votes = [];
+		$simple = $votes = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
-				$votes[] = $page;
+				$votes[ ] = $page;
 			} else {
-				$simple[] = $page;
+				$simple[ ] = $page;
 			}
 		}
 
@@ -151,21 +151,21 @@  discard block
 block discarded – undo
 	 * @param string $archiveTitle
 	 * @param array $pages
 	 */
-	private function reallyAddToArchive( string $archiveTitle, array $pages ) {
+	private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
 		$curTitle = "$archiveTitle/" . date( 'Y' );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $pages as $page ) {
 			$append .= '{{' . $page->getTitle() . "}}\n";
-			$archivedList[] = $page->getUserNum();
+			$archivedList[ ] = $page->getUserNum();
 		}
 
 		if ( count( $archivedList ) > 1 ) {
 			$last = array_pop( $archivedList );
 			$userNums = implode( ', ', $archivedList ) . " e $last";
 		} else {
-			$userNums = $archivedList[0];
+			$userNums = $archivedList[ 0 ];
 		}
 
 		$summary = $this->msg( 'close-archive-summary' )
@@ -184,15 +184,14 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) {
+	protected function updateBasePage ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		$basePage = new Page( $page->getBaseTitle() );
 		$current = $basePage->getContent();
 
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
 
 		$newContent = str_replace( 'riconferma in corso', $text, $current );
@@ -208,16 +207,16 @@  discard block
 block discarded – undo
 	 * @param PageRiconferma[] $pages
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $pages ) {
+	protected function updateVote ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating votazioni: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
 		$votePage = new Page( $this->getConfig()->get( 'ric-vote-page' ) );
 		$content = $votePage->getContent();
 
-		$titles = [];
+		$titles = [ ];
 		foreach ( $pages as $page ) {
-			$titles[] = preg_quote( $page->getTitle() );
+			$titles[ ] = preg_quote( $page->getTitle() );
 		}
 
 		$titleReg = implode( '|', array_map( 'preg_quote', $titles ) );
@@ -248,7 +247,7 @@  discard block
 block discarded – undo
 	 * @param array $pages
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( array $pages ) {
+	protected function updateNews ( array $pages ) {
 		$simpleAmount = $voteAmount = 0;
 		foreach ( $pages as $page ) {
 			if ( $page->isVote() ) {
@@ -268,12 +267,12 @@  discard block
 block discarded – undo
 		$simpleReg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$voteReg = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$simpleMatches = $voteMatches = [];
+		$simpleMatches = $voteMatches = [ ];
 		preg_match( $simpleReg, $content, $simpleMatches );
 		preg_match( $voteReg, $content, $voteMatches );
 
-		$newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
-		$newVote = (int)$voteMatches[2] - $voteAmount ?: '';
+		$newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
+		$newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
 		$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
 		$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
 
@@ -293,7 +292,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAdminList( array $pages ) {
+	protected function updateAdminList ( array $pages ) {
 		$this->getLogger()->info(
 			'Updating admin list: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -301,17 +300,17 @@  discard block
 block discarded – undo
 		$newContent = $adminsPage->getContent();
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+( *\|(?: *pausa)? *\}\}\n)!";
 			if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 				// Remove the line
 				$newContent = preg_replace( $reg, '', $newContent );
-				$removeNames[] = $user;
+				$removeNames[ ] = $user;
 			} else {
 				$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
-				$riconfNames[] = $user;
+				$riconfNames[ ] = $user;
 			}
 		}
 
@@ -319,7 +318,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -328,7 +327,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}
@@ -351,13 +350,13 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateCUList( array $pages ) {
+	protected function updateCUList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if CU list needs updating.' );
 		$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
 		$admins = $this->getDataProvider()->getUsersList();
 		$newContent = $cuList->getContent();
 
-		$riconfNames = $removeNames = [];
+		$riconfNames = $removeNames = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
@@ -365,10 +364,10 @@  discard block
 block discarded – undo
 				if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
 					// Remove the line
 					$newContent = preg_replace( $reg, '', $newContent );
-					$removeNames[] = $user;
+					$removeNames[ ] = $user;
 				} else {
 					$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
-					$riconfNames[] = $user;
+					$riconfNames[ ] = $user;
 				}
 			}
 		}
@@ -385,7 +384,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $riconfNames );
 			$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
 		} elseif ( $riconfNames ) {
-			$riconfList = $riconfNames[0];
+			$riconfList = $riconfNames[ 0 ];
 		} else {
 			$riconfList = 'nessuno';
 		}
@@ -394,7 +393,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $removeNames );
 			$removeList = implode( ', ', $removeNames ) . " e $lastUser";
 		} elseif ( $removeNames ) {
-			$removeList = $removeNames[0];
+			$removeList = $removeNames[ 0 ];
 		} else {
 			$removeList = 'nessuno';
 		}
@@ -416,17 +415,17 @@  discard block
 block discarded – undo
 	/**
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateBurList( array $pages ) {
+	protected function updateBurList ( array $pages ) {
 		$this->getLogger()->info( 'Checking if bur list needs updating.' );
 		$admins = $this->getDataProvider()->getUsersList();
 
-		$remove = [];
+		$remove = [ ];
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
 				$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
 			) {
-				$remove[] = $user;
+				$remove[ ] = $user;
 			}
 		}
 
@@ -445,7 +444,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $remove );
 			$removeList = implode( ', ', $remove ) . " e $lastUser";
 		} else {
-			$removeList = $remove[0];
+			$removeList = $remove[ 0 ];
 		}
 
 		$summary = $this->msg( 'bur-list-update-summary' )
@@ -464,7 +463,7 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function requestRemoval( array $pages ) {
+	protected function requestRemoval ( array $pages ) {
 		$this->getLogger()->info(
 			'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
 		);
@@ -508,14 +507,14 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateAnnunci( array $pages ) {
+	protected function updateAnnunci ( array $pages ) {
 		$this->getLogger()->info( 'Updating annunci' );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "{{Breve|admin|{{subst:#time:j}}|[[Utente:$user|]] " .
 				"non è stato riconfermato [[WP:A|amministratore]].}}\n";
 		}
@@ -538,7 +537,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = $this->msg( 'annunci-summary' )
@@ -557,16 +556,16 @@  discard block
 block discarded – undo
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function updateUltimeNotizie( array $pages ) {
+	protected function updateUltimeNotizie ( array $pages ) {
 		$this->getLogger()->info( 'Updating ultime notizie' );
 		$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-title' ) );
 
-		$names = [];
+		$names = [ ];
 		$text = '';
 		foreach ( $pages as $page ) {
 			$user = $page->getUser();
 			$title = $page->getTitle();
-			$names[] = $user;
+			$names[ ] = $user;
 			$text .= "'''{{subst:#time:j F}}''': [[Utente:$user|]] non è stato [[$title|riconfermato]] " .
 				'[[WP:A|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
 		}
@@ -585,7 +584,7 @@  discard block
 block discarded – undo
 			$lastUser = array_pop( $names );
 			$namesList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$namesList = $names[0];
+			$namesList = $names[ 0 ];
 		}
 
 		$summary = $this->msg( 'ultimenotizie-summary' )

Please login to merge, or discard this patch.

		@@ -1,4 +1,4 @@ discard block
		block discarded – undo
1		-<?php declare( strict_types=1 );
	1	+<?php declare(strict_types=1);
2	2
3	3	namespace BotRiconferme\Task;
4	4
		@@ -15,7 +15,7 @@ discard block
		block discarded – undo
15	15	/**
16	16	* @inheritDoc
17	17	*/
18		- public function run() : TaskResult {
	18	+ public function run () : TaskResult {
19	19	$this->getLogger()->info( 'Starting task ClosePages' );
20	20
21	21	$pages = $this->getPagesList();
		@@ -52,12 +52,12 @@ discard block
		block discarded – undo
52	52	*
53	53	* @return PageRiconferma[]
54	54	*/
55		- protected function getPagesList() : array {
	55	+ protected function getPagesList () : array {
56	56	$allPages = $this->getDataProvider()->getOpenPages();
57		- $ret = [];
	57	+ $ret = [ ];
58	58	foreach ( $allPages as $page ) {
59	59	if ( time() > $page->getEndTimestamp() ) {
60		- $ret[] = $page;
	60	+ $ret[ ] = $page;
61	61	}
62	62	}
63	63	return $ret;
		@@ -69,11 +69,11 @@ discard block
		block discarded – undo
69	69	* @param PageRiconferma[] $pages
70	70	* @return PageRiconferma[]
71	71	*/
72		- private function getFailures( array $pages ) : array {
73		- $ret = [];
	72	+ private function getFailures ( array $pages ) : array {
	73	+ $ret = [ ];
74	74	foreach ( $pages as $page ) {
75	75	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
76		- $ret[] = $page;
	76	+ $ret[ ] = $page;
77	77	}
78	78	}
79	79	return $ret;
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	/**
83	83	* @param PageRiconferma $page
84	84	*/
85		- protected function addVoteCloseText( PageRiconferma $page ) {
	85	+ protected function addVoteCloseText ( PageRiconferma $page ) {
86	86	$content = $page->getContent();
87	87	$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
88	88	$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
		@@ -100,13 +100,13 @@ discard block
		block discarded – undo
100	100	* @param PageRiconferma[] $pages
101	101	* @see UpdatesAround::addToMainPage()
102	102	*/
103		- protected function removeFromMainPage( array $pages ) {
	103	+ protected function removeFromMainPage ( array $pages ) {
104	104	$this->getLogger()->info(
105	105	'Removing from main: ' . implode( ', ', array_map( 'strval', $pages ) )
106	106	);
107	107
108	108	$mainPage = new Page( $this->getConfig()->get( 'ric-main-page' ) );
109		- $translations = [];
	109	+ $translations = [ ];
110	110	foreach ( $pages as $page ) {
111	111	$translations[ '{{' . $page->getTitle() . '}}' ] = '';
112	112	}
		@@ -124,17 +124,17 @@ discard block
		block discarded – undo
124	124	*
125	125	* @param PageRiconferma[] $pages
126	126	*/
127		- protected function addToArchive( array $pages ) {
	127	+ protected function addToArchive ( array $pages ) {
128	128	$this->getLogger()->info(
129	129	'Adding to archive: ' . implode( ', ', array_map( 'strval', $pages ) )
130	130	);
131	131
132		- $simple = $votes = [];
	132	+ $simple = $votes = [ ];
133	133	foreach ( $pages as $page ) {
134	134	if ( $page->isVote() ) {
135		- $votes[] = $page;
	135	+ $votes[ ] = $page;
136	136	} else {
137		- $simple[] = $page;
	137	+ $simple[ ] = $page;
138	138	}
139	139	}
140	140
		@@ -151,21 +151,21 @@ discard block
		block discarded – undo
151	151	* @param string $archiveTitle
152	152	* @param array $pages
153	153	*/
154		- private function reallyAddToArchive( string $archiveTitle, array $pages ) {
	154	+ private function reallyAddToArchive ( string $archiveTitle, array $pages ) {
155	155	$curTitle = "$archiveTitle/" . date( 'Y' );
156	156
157	157	$append = '';
158		- $archivedList = [];
	158	+ $archivedList = [ ];
159	159	foreach ( $pages as $page ) {
160	160	$append .= '{{' . $page->getTitle() . "}}\n";
161		- $archivedList[] = $page->getUserNum();
	161	+ $archivedList[ ] = $page->getUserNum();
162	162	}
163	163
164	164	if ( count( $archivedList ) > 1 ) {
165	165	$last = array_pop( $archivedList );
166	166	$userNums = implode( ', ', $archivedList ) . " e $last";
167	167	} else {
168		- $userNums = $archivedList[0];
	168	+ $userNums = $archivedList[ 0 ];
169	169	}
170	170
171	171	$summary = $this->msg( 'close-archive-summary' )
		@@ -184,15 +184,14 @@ discard block
		block discarded – undo
184	184	* @param PageRiconferma $page
185	185	* @see CreatePages::updateBasePage()
186	186	*/
187		- protected function updateBasePage( PageRiconferma $page ) {
	187	+ protected function updateBasePage ( PageRiconferma $page ) {
188	188	$this->getLogger()->info( "Updating base page for $page" );
189	189
190	190	$basePage = new Page( $page->getBaseTitle() );
191	191	$current = $basePage->getContent();
192	192
193	193	$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
194		- 'non riconfermato' :
195		- 'riconfermato';
	194	+ 'non riconfermato' : 'riconfermato';
196	195	$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
197	196
198	197	$newContent = str_replace( 'riconferma in corso', $text, $current );
		@@ -208,16 +207,16 @@ discard block
		block discarded – undo
208	207	* @param PageRiconferma[] $pages
209	208	* @see UpdatesAround::addVote()
210	209	*/
211		- protected function updateVote( array $pages ) {
	210	+ protected function updateVote ( array $pages ) {
212	211	$this->getLogger()->info(
213	212	'Updating votazioni: ' . implode( ', ', array_map( 'strval', $pages ) )
214	213	);
215	214	$votePage = new Page( $this->getConfig()->get( 'ric-vote-page' ) );
216	215	$content = $votePage->getContent();
217	216
218		- $titles = [];
	217	+ $titles = [ ];
219	218	foreach ( $pages as $page ) {
220		- $titles[] = preg_quote( $page->getTitle() );
	219	+ $titles[ ] = preg_quote( $page->getTitle() );
221	220	}
222	221
223	222	$titleReg = implode( '\|', array_map( 'preg_quote', $titles ) );
		@@ -248,7 +247,7 @@ discard block
		block discarded – undo
248	247	* @param array $pages
249	248	* @see UpdatesAround::addNews()
250	249	*/
251		- protected function updateNews( array $pages ) {
	250	+ protected function updateNews ( array $pages ) {
252	251	$simpleAmount = $voteAmount = 0;
253	252	foreach ( $pages as $page ) {
254	253	if ( $page->isVote() ) {
		@@ -268,12 +267,12 @@ discard block
		block discarded – undo
268	267	$simpleReg = '!(\\| riconferme[ _]tacite[ _]amministratori = *)(\d+)!';
269	268	$voteReg = '!(\\| riconferme[ _]voto[ _]amministratori = *)(\d+)!';
270	269
271		- $simpleMatches = $voteMatches = [];
	270	+ $simpleMatches = $voteMatches = [ ];
272	271	preg_match( $simpleReg, $content, $simpleMatches );
273	272	preg_match( $voteReg, $content, $voteMatches );
274	273
275		- $newSimp = (int)$simpleMatches[2] - $simpleAmount ?: '';
276		- $newVote = (int)$voteMatches[2] - $voteAmount ?: '';
	274	+ $newSimp = (int)$simpleMatches[ 2 ] - $simpleAmount ?: '';
	275	+ $newVote = (int)$voteMatches[ 2 ] - $voteAmount ?: '';
277	276	$newContent = preg_replace( $simpleReg, '${1}' . $newSimp, $content );
278	277	$newContent = preg_replace( $voteReg, '${1}' . $newVote, $newContent );
279	278
		@@ -293,7 +292,7 @@ discard block
		block discarded – undo
293	292	*
294	293	* @param PageRiconferma[] $pages
295	294	*/
296		- protected function updateAdminList( array $pages ) {
	295	+ protected function updateAdminList ( array $pages ) {
297	296	$this->getLogger()->info(
298	297	'Updating admin list: ' . implode( ', ', array_map( 'strval', $pages ) )
299	298	);
		@@ -301,17 +300,17 @@ discard block
		block discarded – undo
301	300	$newContent = $adminsPage->getContent();
302	301	$newDate = date( 'Ymd', strtotime( '+1 year' ) );
303	302
304		- $riconfNames = $removeNames = [];
	303	+ $riconfNames = $removeNames = [ ];
305	304	foreach ( $pages as $page ) {
306	305	$user = $page->getUser();
307	306	$reg = "!(\{\{Amministratore\/riga\\|$user.+\\| )\d+( \\|(?: pausa)? \}\}\n)!";
308	307	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
309	308	// Remove the line
310	309	$newContent = preg_replace( $reg, '', $newContent );
311		- $removeNames[] = $user;
	310	+ $removeNames[ ] = $user;
312	311	} else {
313	312	$newContent = preg_replace( $reg, '$1' . $newDate . '$2', $newContent );
314		- $riconfNames[] = $user;
	313	+ $riconfNames[ ] = $user;
315	314	}
316	315	}
317	316
		@@ -319,7 +318,7 @@ discard block
		block discarded – undo
319	318	$lastUser = array_pop( $riconfNames );
320	319	$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
321	320	} elseif ( $riconfNames ) {
322		- $riconfList = $riconfNames[0];
	321	+ $riconfList = $riconfNames[ 0 ];
323	322	} else {
324	323	$riconfList = 'nessuno';
325	324	}
		@@ -328,7 +327,7 @@ discard block
		block discarded – undo
328	327	$lastUser = array_pop( $removeNames );
329	328	$removeList = implode( ', ', $removeNames ) . " e $lastUser";
330	329	} elseif ( $removeNames ) {
331		- $removeList = $removeNames[0];
	330	+ $removeList = $removeNames[ 0 ];
332	331	} else {
333	332	$removeList = 'nessuno';
334	333	}
		@@ -351,13 +350,13 @@ discard block
		block discarded – undo
351	350	/**
352	351	* @param PageRiconferma[] $pages
353	352	*/
354		- protected function updateCUList( array $pages ) {
	353	+ protected function updateCUList ( array $pages ) {
355	354	$this->getLogger()->info( 'Checking if CU list needs updating.' );
356	355	$cuList = new Page( $this->getConfig()->get( 'cu-list-title' ) );
357	356	$admins = $this->getDataProvider()->getUsersList();
358	357	$newContent = $cuList->getContent();
359	358
360		- $riconfNames = $removeNames = [];
	359	+ $riconfNames = $removeNames = [ ];
361	360	foreach ( $pages as $page ) {
362	361	$user = $page->getUser();
363	362	if ( array_key_exists( 'checkuser', $admins[ $user ] ) ) {
		@@ -365,10 +364,10 @@ discard block
		block discarded – undo
365	364	if ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) {
366	365	// Remove the line
367	366	$newContent = preg_replace( $reg, '', $newContent );
368		- $removeNames[] = $user;
	367	+ $removeNames[ ] = $user;
369	368	} else {
370	369	$newContent = preg_replace( $reg, '$1{{subst:#time:j F Y}}$2', $newContent );
371		- $riconfNames[] = $user;
	370	+ $riconfNames[ ] = $user;
372	371	}
373	372	}
374	373	}
		@@ -385,7 +384,7 @@ discard block
		block discarded – undo
385	384	$lastUser = array_pop( $riconfNames );
386	385	$riconfList = implode( ', ', $riconfNames ) . " e $lastUser";
387	386	} elseif ( $riconfNames ) {
388		- $riconfList = $riconfNames[0];
	387	+ $riconfList = $riconfNames[ 0 ];
389	388	} else {
390	389	$riconfList = 'nessuno';
391	390	}
		@@ -394,7 +393,7 @@ discard block
		block discarded – undo
394	393	$lastUser = array_pop( $removeNames );
395	394	$removeList = implode( ', ', $removeNames ) . " e $lastUser";
396	395	} elseif ( $removeNames ) {
397		- $removeList = $removeNames[0];
	396	+ $removeList = $removeNames[ 0 ];
398	397	} else {
399	398	$removeList = 'nessuno';
400	399	}
		@@ -416,17 +415,17 @@ discard block
		block discarded – undo
416	415	/**
417	416	* @param PageRiconferma[] $pages
418	417	*/
419		- protected function updateBurList( array $pages ) {
	418	+ protected function updateBurList ( array $pages ) {
420	419	$this->getLogger()->info( 'Checking if bur list needs updating.' );
421	420	$admins = $this->getDataProvider()->getUsersList();
422	421
423		- $remove = [];
	422	+ $remove = [ ];
424	423	foreach ( $pages as $page ) {
425	424	$user = $page->getUser();
426	425	if ( array_key_exists( 'bureaucrat', $admins[ $user ] ) &&
427	426	$page->getOutcome() & PageRiconferma::OUTCOME_FAIL
428	427	) {
429		- $remove[] = $user;
	428	+ $remove[ ] = $user;
430	429	}
431	430	}
432	431
		@@ -445,7 +444,7 @@ discard block
		block discarded – undo
445	444	$lastUser = array_pop( $remove );
446	445	$removeList = implode( ', ', $remove ) . " e $lastUser";
447	446	} else {
448		- $removeList = $remove[0];
	447	+ $removeList = $remove[ 0 ];
449	448	}
450	449
451	450	$summary = $this->msg( 'bur-list-update-summary' )
		@@ -464,7 +463,7 @@ discard block
		block discarded – undo
464	463	*
465	464	* @param PageRiconferma[] $pages
466	465	*/
467		- protected function requestRemoval( array $pages ) {
	466	+ protected function requestRemoval ( array $pages ) {
468	467	$this->getLogger()->info(
469	468	'Requesting removal on meta for: ' . implode( ', ', array_map( 'strval', $pages ) )
470	469	);
		@@ -508,14 +507,14 @@ discard block
		block discarded – undo
508	507	*
509	508	* @param PageRiconferma[] $pages
510	509	*/
511		- protected function updateAnnunci( array $pages ) {
	510	+ protected function updateAnnunci ( array $pages ) {
512	511	$this->getLogger()->info( 'Updating annunci' );
513	512
514		- $names = [];
	513	+ $names = [ ];
515	514	$text = '';
516	515	foreach ( $pages as $page ) {
517	516	$user = $page->getUser();
518		- $names[] = $user;
	517	+ $names[ ] = $user;
519	518	$text .= "{{Breve\|admin\|{{subst:#time:j}}\|[[Utente:$user\|]] " .
520	519	"non è stato riconfermato [[WP:A\|amministratore]].}}\n";
521	520	}
		@@ -538,7 +537,7 @@ discard block
		block discarded – undo
538	537	$lastUser = array_pop( $names );
539	538	$namesList = implode( ', ', $names ) . " e $lastUser";
540	539	} else {
541		- $namesList = $names[0];
	540	+ $namesList = $names[ 0 ];
542	541	}
543	542
544	543	$summary = $this->msg( 'annunci-summary' )
		@@ -557,16 +556,16 @@ discard block
		block discarded – undo
557	556	*
558	557	* @param PageRiconferma[] $pages
559	558	*/
560		- protected function updateUltimeNotizie( array $pages ) {
	559	+ protected function updateUltimeNotizie ( array $pages ) {
561	560	$this->getLogger()->info( 'Updating ultime notizie' );
562	561	$notiziePage = new Page( $this->getConfig()->get( 'ultimenotizie-title' ) );
563	562
564		- $names = [];
	563	+ $names = [ ];
565	564	$text = '';
566	565	foreach ( $pages as $page ) {
567	566	$user = $page->getUser();
568	567	$title = $page->getTitle();
569		- $names[] = $user;
	568	+ $names[ ] = $user;
570	569	$text .= "'''{{subst:#time:j F}}''': [[Utente:$user\|]] non è stato [[$title\|riconfermato]] " .
571	570	'[[WP:A\|amministratore]]; ora gli admin sono {{subst:#expr: {{NUMBEROFADMINS}} - 1}}.';
572	571	}
		@@ -585,7 +584,7 @@ discard block
		block discarded – undo
585	584	$lastUser = array_pop( $names );
586	585	$namesList = implode( ', ', $names ) . " e $lastUser";
587	586	} else {
588		- $namesList = $names[0];
	587	+ $namesList = $names[ 0 ];
589	588	}
590	589
591	590	$summary = $this->msg( 'ultimenotizie-summary' )

Daimona / BotRiconferme

Push — master ( 8cfe0d...80c5b5 )

Status

Category

Spacing +53 added lines, -54 removed lines patch added patch discarded remove patch