Daimona / BotRiconferme

src/Task/Subtask/ClosePages.php

Spacing +5 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 
 		if ( !$pages ) {
@@ -35,7 +35,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ): void {
+	protected function addVoteCloseText ( PageRiconferma $page ): void {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!u';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -50,7 +50,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ): void {
+	protected function updateBasePage ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -62,8 +62,7 @@ 
 		$current = $basePage->getContent();
 
 		$outcomeText = ( $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ) ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione di riconferma: $outcomeText" : 'riconferma tacita';
 
 		$newContent = preg_replace( '/^(#: *)(votazione di )?riconferma in corso/m', '$1' . $text, $current );

src/Task/Subtask/OpenUpdates.php

Spacing +6 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 
 		if ( !$pages ) {
@@ -35,7 +35,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToMainPage( array $pages ): void {
+	protected function addToMainPage ( array $pages ): void {
 		$this->getLogger()->info(
 			'Adding the following to main: ' . implode( ', ', $pages )
 		);
@@ -68,7 +68,7 @@ 
 	 *
 	 * @param PageRiconferma[] $pages
 	 */
-	protected function addToVotazioni( array $pages ): void {
+	protected function addToVotazioni ( array $pages ): void {
 		$this->getLogger()->info(
 			'Adding the following to votes: ' . implode( ', ', $pages )
 		);
@@ -105,7 +105,7 @@ 
 	 * @param int $amount
 	 * @throws TaskException
 	 */
-	protected function addToNews( int $amount ): void {
+	protected function addToNews ( int $amount ): void {
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
 
@@ -118,7 +118,7 @@ 
 
 		$matches = $newsPage->getMatch( $reg );
 
-		$newNum = (int)$matches[2] + $amount;
+		$newNum = (int)$matches[ 2 ] + $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = $this->msg( 'news-page-summary' )

src/Task/Subtask/UserNotice.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -12,7 +12,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getCreatedPages();
 		$users = $this->getDataProvider()->getUsersToProcess();
 
@@ -20,7 +20,7 @@ 
 			return TaskResult::STATUS_NOTHING;
 		}
 
-		$ricNums = [];
+		$ricNums = [ ];
 		foreach ( $pages as $page ) {
 			$ricNums[ $page->getUserName() ] = $page->getNum();
 		}
@@ -38,7 +38,7 @@ 
 	 * @param User $user
 	 * @param int $ricNum
 	 */
-	protected function addMsg( User $user, int $ricNum ): void {
+	protected function addMsg ( User $user, int $ricNum ): void {
 		$this->getLogger()->info( "Leaving msg to $user" );
 		$msg = $this->msg( 'user-notice-msg' )->params( [ '$num' => $ricNum ] )->text();
 

src/Task/CloseOld.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,7 +15,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$orderedList = [
 			'close-pages',
 			'archive-pages',
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'archive-pages' => ArchivePages::class,
 			'close-pages' => ClosePages::class,

src/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -15,13 +15,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap(): array;
+	abstract protected function getSubtasksMap (): array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $subtask ): TaskResult {
+	protected function runSubtask ( string $subtask ): TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -34,7 +34,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final public function getOperationName(): string {
+	final public function getOperationName (): string {
 		return 'task';
 	}
 
@@ -44,7 +44,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ): Subtask {
+	private function getSubtaskInstance ( string $class ): Subtask {
 		return new $class(
 			$this->getLogger(),
 			$this->getWikiGroup(),

src/Task/TaskBase.php

Spacing +7 added lines, -7 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -17,7 +17,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -30,7 +30,7 @@ 
 	 * @param MessageProvider $mp
 	 * @param PageBotList $pbl
 	 */
-	final public function __construct(
+	final public function __construct (
 		LoggerInterface $logger,
 		WikiGroup $wikiGroup,
 		TaskDataProvider $dataProvider,
@@ -46,7 +46,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	final public function run(): TaskResult {
+	final public function run (): TaskResult {
 		$class = ( new ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -77,19 +77,19 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal(): int;
+	abstract protected function runInternal (): int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract public function getOperationName(): string;
+	abstract public function getOperationName (): string;
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider(): TaskDataProvider {
+	protected function getDataProvider (): TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

src/Task/StartVote.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,15 +14,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( !$pages ) {
@@ -36,13 +36,13 @@ 
 	 * @param PageRiconferma[] $pages
 	 * @return int a STATUS_* constant
 	 */
-	protected function processPages( array $pages ): int {
-		$donePages = [];
+	protected function processPages ( array $pages ): int {
+		$donePages = [ ];
 		foreach ( $pages as $page ) {
 			if ( $page->hasOpposition() && !$page->isVote() ) {
 				$this->openVote( $page );
 				$this->updateBasePage( $page );
-				$donePages[] = $page;
+				$donePages[ ] = $page;
 			}
 		}
 
@@ -60,7 +60,7 @@ 
 	 *
 	 * @param PageRiconferma $page
 	 */
-	protected function openVote( PageRiconferma $page ): void {
+	protected function openVote ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Starting vote on $page" );
 
 		$content = $page->getContent();
@@ -99,12 +99,12 @@ 
 	 * @see SimpleUpdates::updateVotazioni()
 	 * @see OpenUpdates::addToVotazioni()
 	 */
-	protected function updateVotazioni( array $pages ): void {
+	protected function updateVotazioni ( array $pages ): void {
 		$votePage = $this->getPage( $this->getOpt( 'vote-page-title' ) );
 
-		$users = [];
+		$users = [ ];
 		foreach ( $pages as $page ) {
-			$users[] = $this->getUser( $page->getUserName() );
+			$users[ ] = $this->getUser( $page->getUserName() );
 		}
 		$usersReg = RegexUtils::regexFromArray( '!', ...$users );
 
@@ -138,7 +138,7 @@ 
 	 * @param PageRiconferma $page
 	 * @see \BotRiconferme\Task\Subtask\ClosePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ): void {
+	protected function updateBasePage ( PageRiconferma $page ): void {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		if ( $page->getNum() === 1 ) {
@@ -165,7 +165,7 @@ 
 	 * @see SimpleUpdates::updateNews()
 	 * @see OpenUpdates::addToNews()
 	 */
-	protected function updateNews( int $amount ): void {
+	protected function updateNews ( int $amount ): void {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = $this->getPage( $this->getOpt( 'news-page-title' ) );
 
@@ -180,8 +180,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = ( (int)$newsPage->getMatch( $regTac )[2] - $amount ) ?: '';
-		$newVot = ( (int)$newsPage->getMatch( $regVot )[2] + $amount ) ?: '';
+		$newTac = ( (int)$newsPage->getMatch( $regTac )[ 2 ] - $amount ) ?: '';
+		$newVot = ( (int)$newsPage->getMatch( $regVot )[ 2 ] + $amount ) ?: '';
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );

src/Task/UpdateList.php

Spacing +30 added lines, -30 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -22,15 +22,15 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		// Everything is done here.
-		return [];
+		return [ ];
 	}
 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$this->actualList = $this->getActualAdmins();
 		$pageBotList = $this->getBotList();
 		$this->botList = $pageBotList->getDecodedContent();
@@ -58,7 +58,7 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function getActualAdmins(): array {
+	protected function getActualAdmins (): array {
 		$params = [
 			'action' => 'query',
 			'list' => 'allusers',
@@ -76,8 +76,8 @@ 
 	 * @return string[][]
 	 * @phan-return array<string,string[]>
 	 */
-	protected function extractAdmins( Generator $data ): array {
-		$ret = [];
+	protected function extractAdmins ( Generator $data ): array {
+		$ret = [ ];
 		$blacklist = $this->getOpt( 'exclude-admins' );
 		foreach ( $data as $u ) {
 			if ( in_array( $u->name, $blacklist, true ) ) {
@@ -94,16 +94,16 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getMissingGroups(): array {
-		$missing = [];
+	protected function getMissingGroups (): array {
+		$missing = [ ];
 		foreach ( $this->actualList as $adm => $groups ) {
-			$curMissing = array_diff( $groups, array_keys( $this->botList[$adm] ?? [] ) );
+			$curMissing = array_diff( $groups, array_keys( $this->botList[ $adm ] ?? [ ] ) );
 
 			foreach ( $curMissing as $group ) {
 				try {
 					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
 				} catch ( TaskException $e ) {
-					$this->errors[] = $e->getMessage();
+					$this->errors[ ] = $e->getMessage();
 				}
 			}
 		}
@@ -118,7 +118,7 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ): string {
+	protected function getFlagDate ( string $admin, string $group ): string {
 		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
 
 		$wiki = $this->getWiki();
@@ -153,7 +153,7 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( Generator $data, string $group ): ?string {
+	private function extractTimestamp ( Generator $data, string $group ): ?string {
 		$ts = null;
 		foreach ( $data as $entry ) {
 			if (
@@ -172,8 +172,8 @@ 
 	 *
 	 * @return string[][]
 	 */
-	protected function getExtraGroups(): array {
-		$extra = [];
+	protected function getExtraGroups (): array {
+		$extra = [ ];
 		foreach ( $this->botList as $name => $groups ) {
 			$groups = array_diff_key( $groups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) );
 			if ( !isset( $this->actualList[ $name ] ) ) {
@@ -189,7 +189,7 @@ 
 	 * @param string[] $names
 	 * @return Generator
 	 */
-	private function getRenameEntries( array $names ): Generator {
+	private function getRenameEntries ( array $names ): Generator {
 		$titles = array_map( static function ( string $x ): string {
 			return "Utente:$x";
 		}, $names );
@@ -213,14 +213,14 @@ 
 	 * @param string[] $names
 	 * @return string[] [ old_name => new_name ]
 	 */
-	protected function getRenamedUsers( array $names ): array {
+	protected function getRenamedUsers ( array $names ): array {
 		if ( !$names ) {
-			return [];
+			return [ ];
 		}
 		$this->getLogger()->info( 'Checking rename for ' . implode( ', ', $names ) );
 
 		$data = $this->getRenameEntries( $names );
-		$ret = [];
+		$ret = [ ];
 		foreach ( $data as $entry ) {
 			// 1 month is arbitrary
 			if ( strtotime( $entry->timestamp ) > strtotime( '-1 month' ) ) {
@@ -239,18 +239,18 @@ 
 	 * @phan-param array<string,array<string,string|string[]>> $newContent
 	 * @param string[][] $removed
 	 */
-	private function handleRenames( array &$newContent, array $removed ): void {
+	private function handleRenames ( array &$newContent, array $removed ): void {
 		$renameMap = $this->getRenamedUsers( array_keys( $removed ) );
 		foreach ( $removed as $oldName => $info ) {
 			if (
 				array_key_exists( $oldName, $renameMap ) &&
-				array_key_exists( $renameMap[$oldName], $newContent )
+				array_key_exists( $renameMap[ $oldName ], $newContent )
 			) {
 				// This user was renamed! Add this name as alias, if they're still listed
 				$newName = $renameMap[ $oldName ];
 				$this->getLogger()->info( "Found rename $oldName -> $newName" );
-				$aliases = array_unique( array_merge( $newContent[ $newName ]['aliases'], [ $oldName ] ) );
-				$newContent[ $newName ]['aliases'] = $aliases;
+				$aliases = array_unique( array_merge( $newContent[ $newName ][ 'aliases' ], [ $oldName ] ) );
+				$newContent[ $newName ][ 'aliases' ] = $aliases;
 				// Transfer overrides to the new name.
 				$overrides = array_diff_key( $info, [ 'override' => 1, 'override-perm' => 1 ] );
 				$newContent[ $newName ] = array_merge( $newContent[ $newName ], $overrides );
@@ -265,12 +265,12 @@ 
 	 * @param string[][] $extra
 	 * @return string[][] Removed users
 	 */
-	private function handleExtraAndMissing(
+	private function handleExtraAndMissing (
 		array &$newContent,
 		array $missing,
 		array $extra
 	): array {
-		$removed = [];
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			if ( isset( $missing[ $user ] ) ) {
 				$newContent[ $user ] = array_merge( $groups, $missing[ $user ] );
@@ -280,7 +280,7 @@ 
 				if ( array_diff_key( $newGroups, array_fill_keys( PageBotList::NON_GROUP_KEYS, 1 ) ) ) {
 					$newContent[ $user ] = $newGroups;
 				} else {
-					$removed[$user] = $newContent[$user];
+					$removed[ $user ] = $newContent[ $user ];
 					unset( $newContent[ $user ] );
 				}
 			}
@@ -297,7 +297,7 @@ 
 	 * @param string[][] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ): array {
+	protected function getNewContent ( array $missing, array $extra ): array {
 		$newContent = $this->botList;
 
 		$removed = $this->handleExtraAndMissing( $newContent, $missing, $extra );
@@ -316,12 +316,12 @@ 
 	 *
 	 * @param array[] &$newContent
 	 */
-	protected function removeOverrides( array &$newContent ): void {
-		$removed = [];
+	protected function removeOverrides ( array &$newContent ): void {
+		$removed = [ ];
 		foreach ( $newContent as $user => $groups ) {
 			if ( PageBotList::isOverrideExpired( $groups ) ) {
 				unset( $newContent[ $user ][ 'override' ] );
-				$removed[] = $user;
+				$removed[ ] = $user;
 			}
 		}
 

src/Task/StartNew.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal(): int {
+	public function runInternal (): int {
 		$orderedList = [
 			'create-pages',
 			'open-updates',
@@ -32,7 +32,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap(): array {
+	protected function getSubtasksMap (): array {
 		return [
 			'create-pages' => CreatePages::class,
 			'open-updates' => OpenUpdates::class,