Daimona / BotRiconferme

includes/TaskResult.php

Spacing +9 added lines, -9 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -21,7 +21,7 @@ 
 	 * @param int $status One of the Task::STATUS_* constants
 	 * @param string[] $errors
 	 */
-	public function __construct( int $status, array $errors = [] ) {
+	public function __construct ( int $status, array $errors = [ ] ) {
 		$this->status = $status;
 		$this->errors = $errors;
 	}
@@ -29,21 +29,21 @@ 
 	/**
 	 * @return int
 	 */
-	public function getStatus() : int {
+	public function getStatus () : int {
 		return $this->status;
 	}
 
 	/**
 	 * @return string[]
 	 */
-	public function getErrors() {
+	public function getErrors () {
 		return $this->errors;
 	}
 
 	/**
 	 * @param TaskResult $that
 	 */
-	public function merge( TaskResult $that ) {
+	public function merge ( TaskResult $that ) {
 		$this->status |= $that->status;
 		$this->errors = array_merge( $this->errors, $that->errors );
 	}
@@ -51,15 +51,15 @@ 
 	/**
 	 * @return string
 	 */
-	public function __toString() {
+	public function __toString () {
 		if ( $this->isOK() ) {
 			$stat = 'OK';
 			$errs = "\tNo errors.";
 		} else {
 			$stat = 'ERROR';
-			$formattedErrs = [];
+			$formattedErrs = [ ];
 			foreach ( $this->errors as $err ) {
-				$formattedErrs[] = "\t - $err";
+				$formattedErrs[ ] = "\t - $err";
 			}
 			$errs = implode( "\n", $formattedErrs );
 		}
@@ -71,7 +71,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isOK() : bool {
+	public function isOK () : bool {
 		return ( $this->status | self::STATUS_GOOD ) === self::STATUS_GOOD;
 	}
 }

includes/Task/StartNew.php

Spacing +3 added lines, -3 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$orderedList = [
 			'create-pages',
 			'updates-around',
@@ -32,7 +32,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function getSubtasksMap() : array {
+	protected function getSubtasksMap () : array {
 		return [
 			'create-pages' => CreatePages::class,
 			'updates-around' => UpdatesAround::class,

includes/Page/PageRiconferma.php

Spacing +18 added lines, -18 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Page;
 
@@ -21,7 +21,7 @@ 
 	/**
 	 * @param string $title
 	 */
-	public function __construct( string $title ) {
+	public function __construct ( string $title ) {
 		parent::__construct( $title );
 		$this->supportSection = $this->isVote() ? 3 : 0;
 		$this->opposeSection = $this->isVote() ? 4 : 3;
@@ -32,8 +32,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUser() : string {
-		return explode( '/', $this->title )[2];
+	public function getUser () : string {
+		return explode( '/', $this->title )[ 2 ];
 	}
 
 	/**
@@ -41,7 +41,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getNum() : int {
+	public function getNum () : int {
 		$bits = explode( '/', $this->getTitle() );
 		return intval( end( $bits ) );
 	}
@@ -51,8 +51,8 @@ 
 	 *
 	 * @return string
 	 */
-	public function getUserNum() : string {
-		return explode( '/', $this->getTitle(), 3 )[2];
+	public function getUserNum () : string {
+		return explode( '/', $this->getTitle(), 3 )[ 2 ];
 	}
 
 	/**
@@ -60,7 +60,7 @@ 
 	 *
 	 * @return string
 	 */
-	public function getBaseTitle() : string {
+	public function getBaseTitle () : string {
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal Phan bug
 		return substr( $this->getTitle(), 0, strrpos( $this->getTitle(), '/' ) );
 	}
@@ -70,7 +70,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getOpposingCount() : int {
+	public function getOpposingCount () : int {
 		return $this->getCountForSection( $this->opposeSection );
 	}
 
@@ -80,7 +80,7 @@ 
 	 * @return int
 	 * @throws \BadMethodCallException
 	 */
-	public function getSupportCount() : int {
+	public function getSupportCount () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get support for a non-vote page.' );
 		}
@@ -93,7 +93,7 @@ 
 	 * @param int $secNum
 	 * @return int
 	 */
-	protected function getCountForSection( int $secNum ) : int {
+	protected function getCountForSection ( int $secNum ) : int {
 		$content = $this->controller->getPageContent( $this->title, $secNum );
 		// Let's hope that this is good enough...
 		return substr_count( $content, "\n\# *(?![#*])" );
@@ -104,9 +104,9 @@ 
 	 *
 	 * @return int
 	 */
-	protected function getQuorum() : int {
+	protected function getQuorum () : int {
 		$reg = "!soddisfare il \[\[[^|\]]+\|quorum]] di '''(\d+) voti'''!";
-		return intval( $this->getMatch( $reg )[1] );
+		return intval( $this->getMatch( $reg )[ 1 ] );
 	}
 
 	/**
@@ -114,7 +114,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function hasOpposition() : bool {
+	public function hasOpposition () : bool {
 		return $this->getOpposingCount() >= 15;
 	}
 
@@ -124,7 +124,7 @@ 
 	 * @return int One of the OUTCOME_* constants
 	 * @throws \BadMethodCallException
 	 */
-	public function getOutcome() : int {
+	public function getOutcome () : int {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'Cannot get outcome for a non-vote page.' );
 		}
@@ -144,7 +144,7 @@ 
 	 * @throws \BadMethodCallException
 	 * @throws \LogicException
 	 */
-	public function getOutcomeText() : string {
+	public function getOutcomeText () : string {
 		if ( !$this->isVote() ) {
 			throw new \BadMethodCallException( 'No need for an outcome text.' );
 		}
@@ -178,7 +178,7 @@ 
 	 *
 	 * @return bool
 	 */
-	public function isVote() : bool {
+	public function isVote () : bool {
 		$sectionReg = '/<!-- SEZIONE DA UTILIZZARE PER/';
 		return !$this->matches( $sectionReg );
 	}
@@ -188,7 +188,7 @@ 
 	 *
 	 * @return int
 	 */
-	public function getEndTimestamp() : int {
+	public function getEndTimestamp () : int {
 		if ( $this->isVote() ) {
 			$reg = "!La votazione ha inizio il.+ e ha termine.+ '''([^']+)''' alle ore '''([^']+)'''!";
 			list( , $day, $hours ) = $this->getMatch( $reg );

includes/Exception/MissingSectionException.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 
@@ -10,7 +10,7 @@ 
 	 * @param string $title
 	 * @param int|string $section Number or title
 	 */
-	public function __construct( string $title = '[unavailable]', $section = '[unavailable]' ) {
+	public function __construct ( string $title = '[unavailable]', $section = '[unavailable]' ) {
 		parent::__construct( "The section $section in the page $title doesn't exist." );
 	}
 }

includes/Task/Subtask/Subtask.php

Spacing +2 added lines, -2 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -11,7 +11,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final protected function getOperationName(): string {
+	final protected function getOperationName (): string {
 		return 'subtask';
 	}
 }

includes/Task/Subtask/ClosePages.php

Spacing +5 added lines, -6 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task\Subtask;
 
@@ -14,7 +14,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function runInternal() : int {
+	public function runInternal () : int {
 		$pages = $this->getDataProvider()->getPagesToClose();
 		$protectReason = $this->msg( 'close-protect-summary' )->text();
 		foreach ( $pages as $page ) {
@@ -31,7 +31,7 @@ 
 	/**
 	 * @param PageRiconferma $page
 	 */
-	protected function addVoteCloseText( PageRiconferma $page ) {
+	protected function addVoteCloseText ( PageRiconferma $page ) {
 		$content = $page->getContent();
 		$beforeReg = '!è necessario ottenere una maggioranza .+ votanti\.!';
 		$newContent = preg_replace( $beforeReg, '$0' . "\n" . $page->getOutcomeText(), $content );
@@ -46,15 +46,14 @@ 
 	 * @param PageRiconferma $page
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( PageRiconferma $page ) {
+	protected function updateBasePage ( PageRiconferma $page ) {
 		$this->getLogger()->info( "Updating base page for $page" );
 
 		$basePage = new Page( $page->getBaseTitle() );
 		$current = $basePage->getContent();
 
 		$outcomeText = $page->getOutcome() & PageRiconferma::OUTCOME_FAIL ?
-			'non riconfermato' :
-			'riconfermato';
+			'non riconfermato' : 'riconfermato';
 		$text = $page->isVote() ? "votazione: $outcomeText" : 'riconferma tacita';
 
 		$newContent = str_replace( 'riconferma in corso', $text, $current );

includes/Task/TaskBase.php

Spacing +10 added lines, -10 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -11,7 +11,7 @@ 
  */
 abstract class TaskBase extends ContextSource {
 	/** @var string[] */
-	protected $errors = [];
+	protected $errors = [ ];
 	/** @var TaskDataProvider */
 	protected $dataProvider;
 
@@ -20,14 +20,14 @@ 
 	 *
 	 * @param TaskDataProvider $dataProvider
 	 */
-	final public function __construct( TaskDataProvider $dataProvider ) {
+	final public function __construct ( TaskDataProvider $dataProvider ) {
 		set_exception_handler( [ $this, 'handleException' ] );
 		set_error_handler( [ $this, 'handleError' ] );
 		parent::__construct();
 		$this->dataProvider = $dataProvider;
 	}
 
-	public function __destruct() {
+	public function __destruct () {
 		restore_error_handler();
 		restore_exception_handler();
 	}
@@ -37,7 +37,7 @@ 
 	 *
 	 * @return TaskResult
 	 */
-	final public function run() : TaskResult {
+	final public function run () : TaskResult {
 		$class = ( new \ReflectionClass( $this ) )->getShortName();
 		$opName = $this->getOperationName();
 		$this->getLogger()->info( "Starting $opName $class" );
@@ -68,14 +68,14 @@ 
 	 *
 	 * @return int One of the STATUS_* constants
 	 */
-	abstract protected function runInternal() : int;
+	abstract protected function runInternal () : int;
 
 	/**
 	 * How this operation should be called in logs
 	 *
 	 * @return string
 	 */
-	abstract protected function getOperationName() : string;
+	abstract protected function getOperationName () : string;
 
 	/**
 	 * Exception handler.
@@ -83,7 +83,7 @@ 
 	 * @param \Throwable $ex
 	 * @protected
 	 */
-	public function handleException( \Throwable $ex ) {
+	public function handleException ( \Throwable $ex ) {
 		$this->getLogger()->error(
 			get_class( $ex ) . ': ' .
 			$ex->getMessage() . "\nTrace:\n" .
@@ -100,14 +100,14 @@ 
 	 * @param int $errline
 	 * @protected
 	 */
-	public function handleError( $errno, $errstr, $errfile, $errline ) {
+	public function handleError ( $errno, $errstr, $errfile, $errline ) {
 		throw new \ErrorException( $errstr, 0, $errno, $errfile, $errline );
 	}
 
 	/**
 	 * @return TaskDataProvider
 	 */
-	protected function getDataProvider() : TaskDataProvider {
+	protected function getDataProvider () : TaskDataProvider {
 		return $this->dataProvider;
 	}
 }

includes/Task/Task.php

Spacing +5 added lines, -5 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -14,13 +14,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	abstract protected function getSubtasksMap() : array;
+	abstract protected function getSubtasksMap () : array;
 
 	/**
 	 * @param string $subtask Defined in self::SUBTASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runSubtask( string $subtask ) : TaskResult {
+	protected function runSubtask ( string $subtask ) : TaskResult {
 		$map = $this->getSubtasksMap();
 		if ( !isset( $map[ $subtask ] ) ) {
 			throw new \InvalidArgumentException( "'$subtask' is not a valid task." );
@@ -33,7 +33,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	final protected function getOperationName(): string {
+	final protected function getOperationName (): string {
 		return 'task';
 	}
 
@@ -43,7 +43,7 @@ 
 	 * @param string $class
 	 * @return Subtask
 	 */
-	private function getSubtaskInstance( string $class ) : Subtask {
+	private function getSubtaskInstance ( string $class ) : Subtask {
 		return new $class( $this->getDataProvider() );
 	}
 }

includes/Config.php

Spacing +13 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -12,12 +12,12 @@ 
 	/** @var self */
 	private static $instance;
 	/** @var array */
-	private $opts = [];
+	private $opts = [ ];
 
 	/**
 	 * Use self::init() and self::getInstance()
 	 */
-	private function __construct() {
+	private function __construct () {
 	}
 
 	/**
@@ -26,16 +26,16 @@ 
 	 * @param array $defaults
 	 * @throws ConfigException
 	 */
-	public static function init( array $defaults ) {
+	public static function init ( array $defaults ) {
 		if ( self::$instance ) {
 			throw new ConfigException( 'Config was already initialized' );
 		}
 
 		$inst = new self;
-		$inst->set( 'list-title', $defaults['list-title'] );
-		$inst->set( 'msg-title', $defaults['msg-title'] );
-		$inst->set( 'username', $defaults['username'] );
-		$inst->set( 'password', $defaults['password'] );
+		$inst->set( 'list-title', $defaults[ 'list-title' ] );
+		$inst->set( 'msg-title', $defaults[ 'msg-title' ] );
+		$inst->set( 'username', $defaults[ 'username' ] );
+		$inst->set( 'password', $defaults[ 'password' ] );
 		self::$instance = $inst;
 
 		// On-wiki values
@@ -54,7 +54,7 @@ 
 	 * @param string $key
 	 * @return string
 	 */
-	public function getWikiMessage( string $key ) : string {
+	public function getWikiMessage ( string $key ) : string {
 		static $messages = null;
 		if ( $messages === null ) {
 			try {
@@ -68,7 +68,7 @@ 
 			throw new ConfigException( "Message '$key' does not exist." );
 		}
 		// @phan-suppress-next-line PhanTypeArraySuspiciousNullable
-		return $messages[$key];
+		return $messages[ $key ];
 	}
 	/**
 	 * Set a config value.
@@ -76,7 +76,7 @@ 
 	 * @param string $key
 	 * @param mixed $value
 	 */
-	protected function set( string $key, $value ) {
+	protected function set ( string $key, $value ) {
 		$this->opts[ $key ] = $value;
 	}
 
@@ -86,7 +86,7 @@ 
 	 * @return self
 	 * @throws ConfigException
 	 */
-	public static function getInstance() : self {
+	public static function getInstance () : self {
 		if ( !self::$instance ) {
 			throw new ConfigException( 'Config not yet initialized' );
 		}
@@ -100,7 +100,7 @@ 
 	 * @return mixed
 	 * @throws ConfigException
 	 */
-	public function get( string $opt ) {
+	public function get ( string $opt ) {
 		if ( !isset( $this->opts[ $opt ] ) ) {
 			throw new ConfigException( "Config option '$opt' not set." );
 		}