Daimona / BotRiconferme

includes/Task/UpdatesAround.php

Spacing +13 added lines, -13 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -13,7 +13,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task UpdatesAround' );
 
 		$pages = $this->getDataProvider()->getCreatedPages();
@@ -37,7 +37,7 @@ 
 	 *
 	 * @param string[] $pages
 	 */
-	protected function addToMainPage( array $pages ) {
+	protected function addToMainPage ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to main: ' . implode( ', ', $pages )
 		);
@@ -54,7 +54,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -73,7 +73,7 @@ 
 	 *
 	 * @param string[] $pages
 	 */
-	protected function addVote( array $pages ) {
+	protected function addVote ( array $pages ) {
 		$this->getLogger()->info(
 			'Adding the following to votes: ' . implode( ', ', $pages )
 		);
@@ -84,7 +84,7 @@ 
 		$time = WikiController::getTimeWithArticle( time() + ( 60 * 60 * 24 * 7 ) );
 		$newLines = '';
 		foreach ( $pages as $page ) {
-			$user = explode( '/', $page )[2];
+			$user = explode( '/', $page )[ 2 ];
 			$newLines .= "*[[Utente:$user|]]. La [[$page|procedura]] termina $time;\n";
 		}
 
@@ -94,14 +94,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $content, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $content, $matches ) === false ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $content, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $content, 1 );
 		}
 
 		$summary = strtr(
@@ -111,7 +111,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -130,26 +130,26 @@ 
 	 *
 	 * @param int $amount
 	 */
-	protected function addNews( int $amount ) {
+	protected function addNews ( int $amount ) {
 		$this->getLogger()->info( "Increasing the news counter by $amount" );
 		$newsPage = $this->getConfig()->get( 'ric-news-page' );
 
 		$content = $this->getController()->getPageContent( $newsPage );
 		$reg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 
-		$matches = [];
+		$matches = [ ];
 		if ( preg_match( $reg, $content, $matches ) === false ) {
 			throw new TaskException( 'Param not found in news page' );
 		}
 
-		$newNum = (int)$matches[2] + $amount;
+		$newNum = (int)$matches[ 2 ] + $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = strtr( $this->getConfig()->get( 'ric-news-page-summary' ), [ '$num' => $amount ] );
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);

includes/Task/ClosePages.php

Spacing +23 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -16,7 +16,7 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task ClosePages' );
 
 		$titles = $this->getPagesList();
@@ -41,13 +41,13 @@ 
 	 *
 	 * @return string[]
 	 */
-	protected function getPagesList() : array {
+	protected function getPagesList () : array {
 		$allPages = $this->getDataProvider()->getOpenPages();
-		$ret = [];
+		$ret = [ ];
 		foreach ( $allPages as $page ) {
 			$created = $this->getController()->getPageCreationTS( $page );
 			if ( time() - $created <= 60 * 60 * 24 * 7 && !WikiController::hasOpposition( $page ) ) {
-				$ret[] = $page;
+				$ret[ ] = $page;
 			}
 		}
 		return $ret;
@@ -58,12 +58,12 @@ 
 	 * @param string[] $titles
 	 * @see UpdatesAround::addToMainPage()
 	 */
-	protected function removeFromMainPage( array $titles ) {
+	protected function removeFromMainPage ( array $titles ) {
 		$this->getLogger()->info( 'Removing from main: ' . implode( ', ', $titles ) );
 
 		$mainPage = $this->getConfig()->get( 'ric-main-page' );
 		$content = $this->getController()->getPageContent( $mainPage );
-		$translations = [];
+		$translations = [ ];
 		foreach ( $titles as $title ) {
 			$translations[ '{{' . $title . '}}' ] = '';
 		}
@@ -81,24 +81,24 @@ 
 	 *
 	 * @param string[] $titles
 	 */
-	protected function addToArchive( array $titles ) {
+	protected function addToArchive ( array $titles ) {
 		$this->getLogger()->info( 'Adding to archive: ' . implode( ', ', $titles ) );
 
 		$archiveTitle = $this->getConfig()->get( 'close-archive-title' );
 		$archiveTitle = "$archiveTitle/" . date( 'Y' );
 
 		$append = '';
-		$archivedList = [];
+		$archivedList = [ ];
 		foreach ( $titles as $page ) {
 			$append .= '{{' . $page . "}}\n";
-			$archivedList[] = explode( '/', $page, 3 )[2];
+			$archivedList[ ] = explode( '/', $page, 3 )[ 2 ];
 		}
 
 		if ( count( $archivedList ) > 1 ) {
 			$last = array_pop( $archivedList );
 			$userNums = implode( ', ', $archivedList ) . " e $last";
 		} else {
-			$userNums = $archivedList[0];
+			$userNums = $archivedList[ 0 ];
 		}
 
 		$summary = strtr(
@@ -119,7 +119,7 @@ 
 	 * @param string $title
 	 * @see CreatePages::updateBasePage()
 	 */
-	protected function updateBasePage( string $title ) {
+	protected function updateBasePage ( string $title ) {
 		$this->getLogger()->info( "Updating base page $title" );
 
 		// @phan-suppress-next-line PhanTypeMismatchArgumentInternal WTF Phan what's wrong w/ u?
@@ -140,7 +140,7 @@ 
 	 * @param string[] $titles
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVote( array $titles ) {
+	protected function updateVote ( array $titles ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
@@ -159,7 +159,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -178,19 +178,19 @@ 
 	 * @throws TaskException
 	 * @see UpdatesAround::addNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Decreasing the news counter by $amount" );
 		$newsPage = $this->getConfig()->get( 'ric-news-page' );
 
 		$content = $this->getController()->getPageContent( $newsPage );
 		$reg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 
-		$matches = [];
+		$matches = [ ];
 		if ( preg_match( $reg, $content, $matches ) === false ) {
 			throw new TaskException( 'Param not found in news page' );
 		}
 
-		$newNum = (int)$matches[2] - $amount;
+		$newNum = (int)$matches[ 2 ] - $amount;
 		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
 
 		$summary = strtr(
@@ -200,7 +200,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -219,15 +219,15 @@ 
 	 *
 	 * @param string[] $titles
 	 */
-	protected function updateAdminList( array $titles ) {
+	protected function updateAdminList ( array $titles ) {
 		$listTitle = $this->getConfig()->get( 'admins-list' );
 		$content = $this->getController()->getPageContent( $listTitle );
 		$newDate = date( 'Ymd', strtotime( '+1 year' ) );
 
-		$names = [];
+		$names = [ ];
 		foreach ( $titles as $title ) {
-			$user = explode( '/', $title )[2];
-			$names[] = $user;
+			$user = explode( '/', $title )[ 2 ];
+			$names[ ] = $user;
 			$reg = "!(\{\{Amministratore\/riga\|$user.+\| *)\d+(?= *\|(?: *pausa)? *\}\})!";
 			$content = preg_replace( $reg, '$1' . $newDate, $content );
 		}
@@ -236,7 +236,7 @@ 
 			$lastUser = array_pop( $names );
 			$usersList = implode( ', ', $names ) . " e $lastUser";
 		} else {
-			$usersList = $names[0];
+			$usersList = $names[ 0 ];
 		}
 
 		$summary = strtr(

includes/Task/StartVote.php

Spacing +15 added lines, -15 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -13,18 +13,18 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	public function run() : TaskResult {
+	public function run () : TaskResult {
 		$this->getLogger()->info( 'Starting task StartVote' );
 
 		$pages = $this->getDataProvider()->getOpenPages();
 
 		if ( $pages ) {
-			$actualPages = [];
+			$actualPages = [ ];
 			foreach ( $pages as $page ) {
 				if ( WikiController::hasOpposition( $page ) ) {
 					try {
 						$this->openVote( $page );
-						$actualPages[] = $page;
+						$actualPages[ ] = $page;
 					} catch ( TaskException $e ) {
 						$this->getLogger()->warning( $e->getMessage() );
 					}
@@ -51,7 +51,7 @@ 
 	 * @param string $title
 	 * @throws TaskException
 	 */
-	protected function openVote( string $title ) {
+	protected function openVote ( string $title ) {
 		$this->getLogger()->info( "Starting vote on $title" );
 
 		$content = $this->getController()->getPageContent( $title );
@@ -94,7 +94,7 @@ 
 	 * @see ClosePages::updateVote()
 	 * @see UpdatesAround::addVote()
 	 */
-	protected function updateVotePage( array $titles ) {
+	protected function updateVotePage ( array $titles ) {
 		$votePage = $this->getConfig()->get( 'ric-vote-page' );
 		$content = $this->getController()->getPageContent( $votePage );
 
@@ -109,7 +109,7 @@ 
 		$newLines = '';
 		$time = WikiController::getTimeWithArticle( time() + ( 60 * 60 * 24 * 14 ) );
 		foreach ( $titles as $title ) {
-			$user = explode( '/', $title )[2];
+			$user = explode( '/', $title )[ 2 ];
 			$newLines .= "*[[Utente:$user|]]. La [[$title|votazione]] termina $time;\n";
 		}
 
@@ -119,14 +119,14 @@ 
 			$newContent = preg_replace( $introReg, '$0' . "\n$newLines", $newContent, 1 );
 		} else {
 			// Start section
-			$matches = [];
+			$matches = [ ];
 			if ( preg_match( $introReg, $content, $matches ) === false ) {
 				throw new TaskException( 'Intro not found in vote page' );
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
 			// Replace semicolon with full stop
 			$newLines = substr( $newLines, 0, -2 ) . ".\n";
-			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[0]}\n$newLines", $newContent, 1 );
+			$newContent = preg_replace( $beforeReg, '$0' . "\n{$matches[ 0 ]}\n$newLines", $newContent, 1 );
 		}
 
 		$summary = strtr(
@@ -136,7 +136,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);
@@ -157,7 +157,7 @@ 
 	 * @see UpdatesAround::addNews()
 	 * @see ClosePages::updateNews()
 	 */
-	protected function updateNews( int $amount ) {
+	protected function updateNews ( int $amount ) {
 		$this->getLogger()->info( "Turning $amount pages into votes" );
 		$newsPage = $this->getConfig()->get( 'ric-news-page' );
 
@@ -165,7 +165,7 @@ 
 		$regTac = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 		$regVot = '!(\| *riconferme[ _]voto[ _]amministratori *= *)(\d+)!';
 
-		$tacMatches = $votMatches = [];
+		$tacMatches = $votMatches = [ ];
 		if ( preg_match( $regTac, $content, $tacMatches ) === false ) {
 			throw new TaskException( 'Param "tacite" not found in news page' );
 		}
@@ -173,8 +173,8 @@ 
 			throw new TaskException( 'Param "voto" not found in news page' );
 		}
 
-		$newTac = (int)$tacMatches[2] - $amount;
-		$newVot = (int)$votMatches[2] + $amount;
+		$newTac = (int)$tacMatches[ 2 ] - $amount;
+		$newVot = (int)$votMatches[ 2 ] + $amount;
 
 		$newContent = preg_replace( $regTac, '${1}' . $newTac, $content );
 		$newContent = preg_replace( $regVot, '${1}' . $newVot, $newContent );
@@ -186,7 +186,7 @@ 
 		$summary = preg_replace_callback(
 			'!\{\{$plur|(\d+)|([^|]+)|([^|]+)}}!',
 			function ( $matches ) {
-				return intval( $matches[1] ) > 1 ? trim( $matches[3] ) : trim( $matches[2] );
+				return intval( $matches[ 1 ] ) > 1 ? trim( $matches[ 3 ] ) : trim( $matches[ 2 ] );
 			},
 			$summary
 		);

includes/WikiController.php

Spacing +14 added lines, -14 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -19,7 +19,7 @@ 
 	/** @var string[] */
 	private $tokens;
 
-	public function __construct() {
+	public function __construct () {
 		$this->logger = new Logger;
 	}
 
@@ -30,7 +30,7 @@ 
 	 * @return string
 	 * @throws MissingPageException
 	 */
-	public function getPageContent( string $title ) : string {
+	public function getPageContent ( string $title ) : string {
 		$this->logger->debug( "Retrieving page $title" );
 		$params = [
 			'action' => 'query',
@@ -47,7 +47,7 @@ 
 			throw new MissingPageException( $title );
 		}
 
-		return $page->revisions[0]->slots->main->{ '*' };
+		return $page->revisions[ 0 ]->slots->main->{ '*' };
 	}
 
 	/**
@@ -56,7 +56,7 @@ 
 	 * @param array $params
 	 * @throws EditException
 	 */
-	public function editPage( array $params ) {
+	public function editPage ( array $params ) {
 		$this->login();
 
 		$params = [
@@ -78,7 +78,7 @@ 
 	 * @return string
 	 * @fixme Not the right place for this
 	 */
-	public static function getTimeWithArticle( int $timestamp ) : string {
+	public static function getTimeWithArticle ( int $timestamp ) : string {
 		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
 		$endTime = strftime( '%e %B alle %R', $timestamp );
 		// Remove the left space if day has a single digit
@@ -94,7 +94,7 @@ 
 	 * @return bool
 	 * @fixme Not the right place for this
 	 */
-	public static function hasOpposition( string $page ) : bool {
+	public static function hasOpposition ( string $page ) : bool {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -105,7 +105,7 @@ 
 		];
 		$res = RequestBase::newFromParams( $params )->execute();
 		$page = reset( $res->query->pages );
-		$content = $page->revisions[0]->slots->main->{ '*' };
+		$content = $page->revisions[ 0 ]->slots->main->{ '*' };
 		// Let's hope that this is good enough...
 		$votes = substr_count( $content, "\n\# *(?![#*])" );
 		return $votes >= 15;
@@ -115,7 +115,7 @@ 
 	 * Login wrapper. Checks if we're already logged in and clears tokens cache
 	 * @throws LoginException
 	 */
-	public function login() {
+	public function login () {
 		if ( self::$loggedIn ) {
 			$this->logger->debug( 'Already logged in' );
 			return;
@@ -142,7 +142,7 @@ 
 
 		self::$loggedIn = true;
 		// Clear tokens cache
-		$this->tokens = [];
+		$this->tokens = [ ];
 		$this->logger->info( 'Login succeeded' );
 	}
 
@@ -152,7 +152,7 @@ 
 	 * @param string $type
 	 * @return string
 	 */
-	public function getToken( string $type ) : string {
+	public function getToken ( string $type ) : string {
 		if ( !isset( $this->tokens[ $type ] ) ) {
 			$params = [
 				'action' => 'query',
@@ -175,7 +175,7 @@ 
 	 * @param string $title
 	 * @return int
 	 */
-	public function getPageCreationTS( string $title ) : int {
+	public function getPageCreationTS ( string $title ) : int {
 		$params = [
 			'action' => 'query',
 			'prop' => 'revisions',
@@ -188,7 +188,7 @@ 
 
 		$res = ( RequestBase::newFromParams( $params ) )->execute();
 		$data = $res->query->pages;
-		return strtotime( reset( $data )->revisions[0]->timestamp );
+		return strtotime( reset( $data )->revisions[ 0 ]->timestamp );
 	}
 
 	/**
@@ -197,7 +197,7 @@ 
 	 * @param string $title
 	 * @param string $reason
 	 */
-	public function protectPage( string $title, string $reason ) {
+	public function protectPage ( string $title, string $reason ) {
 		$this->logger->info( "Protecting page $title" );
 		$this->login();
 

includes/TaskDataProvider.php

Spacing +14 added lines, -16 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -12,20 +12,20 @@ 
 	private $users;
 
 	/** @var string[] */
-	private $createdPages = [];
+	private $createdPages = [ ];
 
 	/**
 	 * Get a list of users to execute tasks on.
 	 *
 	 * @return array[]
 	 */
-	public function getUsersToProcess() : array {
+	public function getUsersToProcess () : array {
 		if ( $this->users === null ) {
 			$this->getLogger()->debug( 'Retrieving users list' );
 			$content = $this->getController()->getPageContent( $this->getConfig()->get( 'list-title' ) );
 			$listUsers = json_decode( $content, true );
 
-			$this->users = [];
+			$this->users = [ ];
 			foreach ( $listUsers as $user => $groups ) {
 				$timestamp = $this->getValidTimestamp( $groups );
 
@@ -47,13 +47,11 @@ 
 	 * @param array $groups
 	 * @return int
 	 */
-	private function getValidTimestamp( array $groups ) : int {
+	private function getValidTimestamp ( array $groups ) : int {
 		$checkuser = isset( $groups[ 'checkuser' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() : 0;
 		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
-			0;
+			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() : 0;
 
 		$timestamp = max( $bureaucrat, $checkuser );
 		if ( $timestamp === 0 ) {
@@ -67,7 +65,7 @@ 
 	 *
 	 * @return string[] Their titles
 	 */
-	public function getOpenPages() : array {
+	public function getOpenPages () : array {
 		$baseTitle = $this->getConfig()->get( 'ric-main-page' );
 		$params = [
 			'action' => 'query',
@@ -79,10 +77,10 @@ 
 
 		$res = RequestBase::newFromParams( $params )->execute();
 		$pages = $res->query->pages;
-		$ret = [];
+		$ret = [ ];
 		foreach ( reset( $pages )->templates as $page ) {
 			if ( preg_match( "!$baseTitle\/[^\/]+\/\d!", $page->title ) !== false ) {
-				$ret[] = $page->title;
+				$ret[ ] = $page->title;
 			}
 		}
 		return $ret;
@@ -93,21 +91,21 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) {
+	public function removeUser ( string $name ) {
 		unset( $this->users[ $name ] );
 	}
 
 	/**
 	 * @return string[]
 	 */
-	public function getCreatedPages() : array {
+	public function getCreatedPages () : array {
 		return $this->createdPages;
 	}
 
 	/**
 	 * @param string $title
 	 */
-	public function addCreatedPages( string $title ) {
-		$this->createdPages[] = $title;
+	public function addCreatedPages ( string $title ) {
+		$this->createdPages[ ] = $title;
 	}
 }