Daimona / BotRiconferme

includes/Bot.php

Spacing +12 added lines, -12 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -16,14 +16,14 @@ 
 	 * Entry point for the whole process
 	 */
 	public function run() {
-		$this->logger->info( 'Starting full process.' );
+		$this->logger->info('Starting full process.');
 		$manager = new TaskManager;
-		$res = $manager->run( TaskManager::MODE_COMPLETE );
+		$res = $manager->run(TaskManager::MODE_COMPLETE);
 		$line = '---------------------------------------------------';
-		if ( $res->isOK() ) {
-			$this->logger->info( "Execution completed successfully.\n$line\n\n" );
+		if ($res->isOK()) {
+			$this->logger->info("Execution completed successfully.\n$line\n\n");
 		} else {
-			$this->logger->error( "Execution failed.\n$res\n$line\n\n" );
+			$this->logger->error("Execution failed.\n$res\n$line\n\n");
 		}
 	}
 
@@ -32,15 +32,15 @@ 
 	 *
 	 * @param string $task
 	 */
-	public function runSingle( string $task ) {
-		$this->logger->info( "Starting single task $task." );
+	public function runSingle(string $task) {
+		$this->logger->info("Starting single task $task.");
 		$manager = new TaskManager;
-		$res = $manager->run( TaskManager::MODE_SINGLE, $task );
+		$res = $manager->run(TaskManager::MODE_SINGLE, $task);
 		$line = '---------------------------------------------------';
-		if ( $res->isOK() ) {
-			$this->logger->info( "Execution of $task completed successfully.\n$line\n\n" );
+		if ($res->isOK()) {
+			$this->logger->info("Execution of $task completed successfully.\n$line\n\n");
 		} else {
-			$this->logger->error( "Execution of $task failed.\n$res\n$line\n\n" );
+			$this->logger->error("Execution of $task failed.\n$res\n$line\n\n");
 		}
 	}
 }

includes/Request/CurlRequest.php

Spacing +23 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -11,35 +11,35 @@ 
 	/**
 	 * @inheritDoc
 	 */
-	protected function reallyMakeRequest( string $params ) : string {
+	protected function reallyMakeRequest(string $params) : string {
 		$curl = curl_init();
-		if ( $curl === false ) {
-			throw new APIRequestException( 'Cannot open cURL handler.' );
+		if ($curl === false) {
+			throw new APIRequestException('Cannot open cURL handler.');
 		}
-		curl_setopt( $curl, CURLOPT_RETURNTRANSFER, true );
-		curl_setopt( $curl, CURLOPT_HEADER, true );
-		curl_setopt( $curl, CURLOPT_HEADERFUNCTION, [ $this, 'headersHandler' ] );
-		curl_setopt( $curl, CURLOPT_HTTPHEADER, $this->getHeaders() );
+		curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);
+		curl_setopt($curl, CURLOPT_HEADER, true);
+		curl_setopt($curl, CURLOPT_HEADERFUNCTION, [$this, 'headersHandler']);
+		curl_setopt($curl, CURLOPT_HTTPHEADER, $this->getHeaders());
 
 		$url = self::$url;
-		if ( $this->method === 'POST' ) {
-			curl_setopt( $curl, CURLOPT_URL, $url );
-			curl_setopt( $curl, CURLOPT_POST, true );
-			curl_setopt( $curl, CURLOPT_POSTFIELDS, $params );
+		if ($this->method === 'POST') {
+			curl_setopt($curl, CURLOPT_URL, $url);
+			curl_setopt($curl, CURLOPT_POST, true);
+			curl_setopt($curl, CURLOPT_POSTFIELDS, $params);
 		} else {
-			curl_setopt( $curl, CURLOPT_URL, "$url?$params" );
+			curl_setopt($curl, CURLOPT_URL, "$url?$params");
 		}
 
-		$result = curl_exec( $curl );
+		$result = curl_exec($curl);
 
-		if ( $result === false ) {
-			throw new APIRequestException( curl_error( $curl ) );
+		if ($result === false) {
+			throw new APIRequestException(curl_error($curl));
 		}
 
 		// Extract response body
-		$headerSize = curl_getinfo( $curl, CURLINFO_HEADER_SIZE );
-		$body = substr( $result, $headerSize );
-		curl_close( $curl );
+		$headerSize = curl_getinfo($curl, CURLINFO_HEADER_SIZE);
+		$body = substr($result, $headerSize);
+		curl_close($curl);
 
 		return $body;
 	}
@@ -52,12 +52,12 @@ 
 	 * @return int
 	 * @internal Only used as CB for cURL
 	 */
-	public function headersHandler( $ch, string $header ) : int {
-		$bits = explode( ':', $header, 2 );
-		if ( trim( $bits[0] ) === 'Set-Cookie' ) {
+	public function headersHandler($ch, string $header) : int {
+		$bits = explode(':', $header, 2);
+		if (trim($bits[0]) === 'Set-Cookie') {
 			$this->newCookies[] = $bits[1];
 		}
 		// @phan-suppress-next-line PhanTypeMismatchReturn WTF? Why does phan thinks this is a string?
-		return strlen( $header );
+		return strlen($header);
 	}
 }

includes/TaskManager.php

Spacing +23 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -30,7 +30,7 @@ 
 	 * Should only be used for debugging purpose.
 	 */
 	public static function resetLastRunDate() {
-		file_put_contents( self::LOG_FILE, '' );
+		file_put_contents(self::LOG_FILE, '');
 	}
 
 	/**
@@ -38,14 +38,14 @@ 
 	 * @param string|null $taskName Only used in MODE_SINGLE
 	 * @return TaskResult
 	 */
-	public function run( int $mode, string $taskName = null ) : TaskResult {
+	public function run(int $mode, string $taskName = null) : TaskResult {
 		$this->provider = new TaskDataProvider;
-		if ( $mode === self::MODE_COMPLETE ) {
+		if ($mode === self::MODE_COMPLETE) {
 			return $this->runAllTasks();
-		} elseif ( $taskName === null ) {
-			throw new BadMethodCallException( 'A task name must be specified in MODE_SINGLE' );
+		} elseif ($taskName === null) {
+			throw new BadMethodCallException('A task name must be specified in MODE_SINGLE');
 		} else {
-			return $this->runTask( $taskName );
+			return $this->runTask($taskName);
 		}
 	}
 
@@ -53,9 +53,9 @@ 
 	 * @return TaskResult
 	 */
 	protected function runAllTasks() : TaskResult {
-		if ( self::getLastFullRunDate() === date( 'd/m/Y' ) ) {
+		if (self::getLastFullRunDate() === date('d/m/Y')) {
 			// Really avoid executing twice the same day
-			return new TaskResult( TaskResult::STATUS_ERROR, [ 'A full run was already executed today.' ] );
+			return new TaskResult(TaskResult::STATUS_ERROR, ['A full run was already executed today.']);
 		}
 
 		// Order matters here
@@ -66,12 +66,12 @@ 
 			'user-notice'
 		];
 
-		$res = new TaskResult( TaskResult::STATUS_OK );
+		$res = new TaskResult(TaskResult::STATUS_OK);
 		do {
-			$res->merge( $this->runTask( current( $list ) ) );
-		} while ( $res->isOK() && next( $list ) );
+			$res->merge($this->runTask(current($list)));
+		} while ($res->isOK() && next($list));
 
-		if ( $res->isOK() ) {
+		if ($res->isOK()) {
 			self::setLastFullRunDate();
 		}
 
@@ -82,8 +82,8 @@ 
 	 * @return string|null d/m/Y or null if no last run registered
 	 */
 	public static function getLastFullRunDate() : ?string {
-		if ( file_exists( self::LOG_FILE ) ) {
-			return file_get_contents( self::LOG_FILE ) ?: null;
+		if (file_exists(self::LOG_FILE)) {
+			return file_get_contents(self::LOG_FILE) ?: null;
 		} else {
 			return null;
 		}
@@ -93,13 +93,13 @@ 
 	 * @param string $task Defined in self::TASKS_MAP
 	 * @return TaskResult
 	 */
-	protected function runTask( string $task ) : TaskResult {
-		if ( !isset( self::TASKS_MAP[ $task ] ) ) {
-			throw new \InvalidArgumentException( "'$task' is not a valid task." );
+	protected function runTask(string $task) : TaskResult {
+		if (!isset(self::TASKS_MAP[$task])) {
+			throw new \InvalidArgumentException("'$task' is not a valid task.");
 		}
 
-		$class = self::TASKS_MAP[ $task ];
-		return $this->getTaskInstance( $class )->run();
+		$class = self::TASKS_MAP[$task];
+		return $this->getTaskInstance($class)->run();
 	}
 
 	/**
@@ -108,11 +108,11 @@ 
 	 * @param string $class
 	 * @return Task
 	 */
-	private function getTaskInstance( string $class ) : Task {
-		return new $class( $this->provider );
+	private function getTaskInstance(string $class) : Task {
+		return new $class($this->provider);
 	}
 
 	public static function setLastFullRunDate() {
-		file_put_contents( self::LOG_FILE, date( 'd/m/Y' ) );
+		file_put_contents(self::LOG_FILE, date('d/m/Y'));
 	}
 }

includes/TaskDataProvider.php

Spacing +21 added lines, -23 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme;
 
@@ -18,20 +18,20 @@ 
 	 * @return array[]
 	 */
 	public function getUsersToProcess() : array {
-		if ( $this->users === null ) {
-			$this->getLogger()->debug( 'Retrieving users list' );
-			$content = $this->getController()->getPageContent( $this->getConfig()->get( 'list-title' ) );
-			$listUsers = json_decode( $content, true );
+		if ($this->users === null) {
+			$this->getLogger()->debug('Retrieving users list');
+			$content = $this->getController()->getPageContent($this->getConfig()->get('list-title'));
+			$listUsers = json_decode($content, true);
 
 			$this->users = [];
-			foreach ( $listUsers as $user => $groups ) {
-				$timestamp = $this->getValidTimestamp( $groups );
+			foreach ($listUsers as $user => $groups) {
+				$timestamp = $this->getValidTimestamp($groups);
 
-				if ( date( 'd/m', $timestamp ) === date( 'd/m' ) &&
+				if (date('d/m', $timestamp) === date('d/m') &&
 					// Don't trigger if the date is actually today
-					date( 'd/m/Y', $timestamp ) !== date( 'd/m/Y' )
+					date('d/m/Y', $timestamp) !== date('d/m/Y')
 				) {
-					$this->users[ $user ] = $groups;
+					$this->users[$user] = $groups;
 				}
 			}
 		}
@@ -45,17 +45,15 @@ 
 	 * @param array $groups
 	 * @return int
 	 */
-	private function getValidTimestamp( array $groups ) : int {
-		$checkuser = isset( $groups[ 'checkuser' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'checkuser' ] )->getTimestamp() :
-			0;
-		$bureaucrat = isset( $groups[ 'bureaucrat' ] ) ?
-			\DateTime::createFromFormat( 'd/m/Y', $groups[ 'bureaucrat' ] )->getTimestamp() :
-			0;
+	private function getValidTimestamp(array $groups) : int {
+		$checkuser = isset($groups['checkuser']) ?
+			\DateTime::createFromFormat('d/m/Y', $groups['checkuser'])->getTimestamp() : 0;
+		$bureaucrat = isset($groups['bureaucrat']) ?
+			\DateTime::createFromFormat('d/m/Y', $groups['bureaucrat'])->getTimestamp() : 0;
 
-		$timestamp = max( $bureaucrat, $checkuser );
-		if ( $timestamp === 0 ) {
-			$timestamp = \DateTime::createFromFormat( 'd/m/Y', $groups[ 'sysop' ] )->getTimestamp();
+		$timestamp = max($bureaucrat, $checkuser);
+		if ($timestamp === 0) {
+			$timestamp = \DateTime::createFromFormat('d/m/Y', $groups['sysop'])->getTimestamp();
 		}
 		return $timestamp;
 	}
@@ -65,8 +63,8 @@ 
 	 *
 	 * @param string $name
 	 */
-	public function removeUser( string $name ) {
-		unset( $this->users[ $name ] );
+	public function removeUser(string $name) {
+		unset($this->users[$name]);
 	}
 
 	/**
@@ -79,7 +77,7 @@ 
 	/**
 	 * @param string $title
 	 */
-	public function addCreatedPages( string $title ) {
+	public function addCreatedPages(string $title) {
 		$this->createdPages[] = $title;
 	}
 }

includes/Request/RequestBase.php

Spacing +50 added lines, -50 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Request;
 
@@ -37,8 +37,8 @@ 
 	 * @param array $params
 	 * @param bool $isPOST
 	 */
-	protected function __construct( array $params, bool $isPOST = false ) {
-		$this->params = [ 'format' => 'json' ] + $params;
+	protected function __construct(array $params, bool $isPOST = false) {
+		$this->params = ['format' => 'json'] + $params;
 		$this->method = $isPOST ? 'POST' : 'GET';
 	}
 
@@ -49,11 +49,11 @@ 
 	 * @param bool $isPOST
 	 * @return self
 	 */
-	public static function newFromParams( array $params, bool $isPOST = false ) : self {
-		if ( extension_loaded( 'curl' ) ) {
-			$ret = new CurlRequest( $params, $isPOST );
+	public static function newFromParams(array $params, bool $isPOST = false) : self {
+		if (extension_loaded('curl')) {
+			$ret = new CurlRequest($params, $isPOST);
 		} else {
-			$ret = new NativeRequest( $params, $isPOST );
+			$ret = new NativeRequest($params, $isPOST);
 		}
 		return $ret;
 	}
@@ -67,19 +67,19 @@ 
 		$curParams = $this->params;
 		$sets = [];
 		do {
-			$res = $this->makeRequestInternal( $curParams );
+			$res = $this->makeRequestInternal($curParams);
 
-			$this->handleErrorAndWarnings( $res );
+			$this->handleErrorAndWarnings($res);
 			$sets[] = $res;
 
 			$finished = true;
-			if ( isset( $res->continue ) ) {
-				$curParams = array_merge( $curParams, get_object_vars( $res->continue ) );
+			if (isset($res->continue)) {
+				$curParams = array_merge($curParams, get_object_vars($res->continue));
 				$finished = false;
 			}
-		} while ( !$finished );
+		} while (!$finished);
 
-		return $this->mergeSets( $sets );
+		return $this->mergeSets($sets);
 	}
 
 	/**
@@ -88,16 +88,16 @@ 
 	 * @param array $params
 	 * @return \stdClass
 	 */
-	private function makeRequestInternal( array $params ) : \stdClass {
-		if ( $this->method === 'POST' ) {
+	private function makeRequestInternal(array $params) : \stdClass {
+		if ($this->method === 'POST') {
 			$params['maxlag'] = self::MAXLAG;
 		}
-		$params = http_build_query( $params );
+		$params = http_build_query($params);
 
-		$body = $this->reallyMakeRequest( $params );
+		$body = $this->reallyMakeRequest($params);
 
-		$this->setCookies( $this->newCookies );
-		return json_decode( $body );
+		$this->setCookies($this->newCookies);
+		return json_decode($body);
 	}
 
 	/**
@@ -106,18 +106,18 @@ 
 	 * @param string $params
 	 * @return string
 	 */
-	abstract protected function reallyMakeRequest( string $params ) : string;
+	abstract protected function reallyMakeRequest(string $params) : string;
 
 	/**
 	 * After a request, set cookies for the next ones
 	 *
 	 * @param array $cookies
 	 */
-	protected function setCookies( array $cookies ) {
-		foreach ( $cookies as $cookie ) {
-			$bits = explode( ';', $cookie );
-			list( $name, $value ) = explode( '=', $bits[0] );
-			self::$cookiesToSet[ $name ] = $value;
+	protected function setCookies(array $cookies) {
+		foreach ($cookies as $cookie) {
+			$bits = explode(';', $cookie);
+			list($name, $value) = explode('=', $bits[0]);
+			self::$cookiesToSet[$name] = $value;
 		}
 	}
 
@@ -127,9 +127,9 @@ 
 	 * @param \stdClass $res
 	 * @throws APIRequestException
 	 */
-	protected function handleErrorAndWarnings( $res ) {
-		if ( isset( $res->error ) ) {
-			switch ( $res->error->code ) {
+	protected function handleErrorAndWarnings($res) {
+		if (isset($res->error)) {
+			switch ($res->error->code) {
 				case 'missingtitle':
 					$ex = new MissingPageException;
 					break;
@@ -137,13 +137,13 @@ 
 					$ex = new ProtectedPageException;
 					break;
 				default:
-					$ex = new APIRequestException( $res->error->code . ' - ' . $res->error->info );
+					$ex = new APIRequestException($res->error->code . ' - ' . $res->error->info);
 			}
 			throw $ex;
-		} elseif ( isset( $res->warnings ) ) {
-			$act = $this->params[ 'action' ];
+		} elseif (isset($res->warnings)) {
+			$act = $this->params['action'];
 			$warning = $res->warnings->$act;
-			throw new APIRequestException( reset( $warning ) );
+			throw new APIRequestException(reset($warning));
 		}
 	}
 
@@ -153,16 +153,16 @@ 
 	 * @param \stdClass[] $sets
 	 * @return array
 	 */
-	private function mergeSets( array $sets ) : array {
-		$sets = $this->objectToArray( $sets );
+	private function mergeSets(array $sets) : array {
+		$sets = $this->objectToArray($sets);
 		// Use the first set as template
-		$ret = array_shift( $sets );
+		$ret = array_shift($sets);
 		$act = $this->params['action'];
 
-		foreach ( $sets as $set ) {
+		foreach ($sets as $set) {
 			$ret[$act] = array_merge_recursive(
-				$this->objectToArray( $ret[$act] ),
-				$this->objectToArray( $set[$act] )
+				$this->objectToArray($ret[$act]),
+				$this->objectToArray($set[$act])
 			);
 		}
 		return $ret;
@@ -175,14 +175,14 @@ 
 	 * @param \stdClass|array $objOrArray
 	 * @return array
 	 */
-	private function objectToArray( $objOrArray ) : array {
+	private function objectToArray($objOrArray) : array {
 		$array = [];
-		if ( is_object( $objOrArray ) ) {
-			$objOrArray = get_object_vars( $objOrArray );
+		if (is_object($objOrArray)) {
+			$objOrArray = get_object_vars($objOrArray);
 		}
-		foreach ( $objOrArray as $key => $value ) {
-			if ( is_object( $value ) || is_array( $value ) ) {
-				$value = $this->objectToArray( $value );
+		foreach ($objOrArray as $key => $value) {
+			if (is_object($value) || is_array($value)) {
+				$value = $this->objectToArray($value);
 			}
 			$array[$key] = $value;
 		}
@@ -196,12 +196,12 @@ 
 	 */
 	protected function getHeaders() :array {
 		$ret = self::HEADERS;
-		if ( self::$cookiesToSet ) {
+		if (self::$cookiesToSet) {
 			$cookies = [];
-			foreach ( self::$cookiesToSet as $cname => $cval ) {
-				$cookies[] = trim( "$cname=$cval" );
+			foreach (self::$cookiesToSet as $cname => $cval) {
+				$cookies[] = trim("$cname=$cval");
 			}
-			$ret[] = 'Cookie: ' . implode( '; ', $cookies );
+			$ret[] = 'Cookie: ' . implode('; ', $cookies);
 		}
 		return $ret;
 	}
@@ -212,9 +212,9 @@ 
 	 * @param array $headers
 	 * @return string
 	 */
-	protected function buildHeadersString( array $headers ) : string {
+	protected function buildHeadersString(array $headers) : string {
 		$ret = '';
-		foreach ( $headers as $header ) {
+		foreach ($headers as $header) {
 			$ret .= "$header\r\n";
 		}
 		return $ret;

includes/Exception/MissingPageException.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 
@@ -9,9 +9,9 @@ 
 	/**
 	 * @param string|null $title If available
 	 */
-	public function __construct( string $title = null ) {
-		if ( $title ) {
-			parent::__construct( "The specified page doesn't exist: $title" );
+	public function __construct(string $title = null) {
+		if ($title) {
+			parent::__construct("The specified page doesn't exist: $title");
 		} else {
 			parent::__construct();
 		}

includes/Exception/ProtectedPageException.php

Spacing +4 added lines, -4 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Exception;
 
@@ -9,9 +9,9 @@ 
 	/**
 	 * @param string|null $title If available
 	 */
-	public function __construct( string $title = null ) {
-		if ( $title ) {
-			parent::__construct( "The specified page is protected: $title" );
+	public function __construct(string $title = null) {
+		if ($title) {
+			parent::__construct("The specified page is protected: $title");
 		} else {
 			parent::__construct();
 		}

includes/Task/UpdatesAround.php

Spacing +41 added lines, -41 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -13,19 +13,19 @@ 
 	 * @inheritDoc
 	 */
 	public function run() : TaskResult {
-		$this->getLogger()->info( 'Starting task UpdatesAround' );
+		$this->getLogger()->info('Starting task UpdatesAround');
 
-		foreach ( $this->getDataProvider()->getCreatedPages() as $page ) {
+		foreach ($this->getDataProvider()->getCreatedPages() as $page) {
 			// Wikipedia:Amministratori/Riconferma annuale
-			$this->addToMainPage( $page );
+			$this->addToMainPage($page);
 			// WP:Wikipediano/Votazioni
-			$this->addVote( $page );
+			$this->addVote($page);
 			// Template:VotazioniRCnews
-			$this->addNews( $page );
+			$this->addNews($page);
 		}
 
-		$this->getLogger()->info( 'Task UpdatesAround completed successfully' );
-		return new TaskResult( self::STATUS_OK );
+		$this->getLogger()->info('Task UpdatesAround completed successfully');
+		return new TaskResult(self::STATUS_OK);
 	}
 
 	/**
@@ -33,16 +33,16 @@ 
 	 *
 	 * @param string $page
 	 */
-	protected function addToMainPage( string $page ) {
-		$this->getLogger()->info( "Adding $page to main" );
+	protected function addToMainPage(string $page) {
+		$this->getLogger()->info("Adding $page to main");
 
 		$params = [
-			'title' => $this->getConfig()->get( 'ric-main-page' ),
+			'title' => $this->getConfig()->get('ric-main-page'),
 			'appendtext' => '{{' . $page . '}}',
-			'summary' => $this->getConfig()->get( 'ric-main-page-summary' )
+			'summary' => $this->getConfig()->get('ric-main-page-summary')
 		];
 
-		$this->getController()->editPage( $params );
+		$this->getController()->editPage($params);
 	}
 
 	/**
@@ -50,37 +50,37 @@ 
 	 *
 	 * @param string $page
 	 */
-	protected function addVote( string $page ) {
-		$this->getLogger()->info( "Adding $page to votes" );
-		$votePage = $this->getConfig()->get( 'ric-vote-page' );
+	protected function addVote(string $page) {
+		$this->getLogger()->info("Adding $page to votes");
+		$votePage = $this->getConfig()->get('ric-vote-page');
 
-		$content = $this->getController()->getPageContent( $votePage );
+		$content = $this->getController()->getPageContent($votePage);
 		// Remove comments etc.
-		$visibleContent = strip_tags( $content );
-		$user = explode( '/', $page )[2];
+		$visibleContent = strip_tags($content);
+		$user = explode('/', $page)[2];
 		$time = $this->getTimeWithArticle();
 
 		$newLine = "*[[Utente:$user|]]. La [[$page|procedura]] termina $time";
 
 		$introReg = '!^;È in corso la .*riconferma tacita.* degli .*amministratori.+!m';
-		if ( preg_match( $introReg, $visibleContent ) ) {
-			$newContent = preg_replace( $introReg, '$0' . "\n$newLine;", $content, 1 );
+		if (preg_match($introReg, $visibleContent)) {
+			$newContent = preg_replace($introReg, '$0' . "\n$newLine;", $content, 1);
 		} else {
 			$matches = [];
-			if ( preg_match( $introReg, $content, $matches ) === false ) {
-				throw new TaskException( 'Intro not found in vote page' );
+			if (preg_match($introReg, $content, $matches) === false) {
+				throw new TaskException('Intro not found in vote page');
 			}
 			$beforeReg = '!INSERIRE LA NOTIZIA PIÙ NUOVA IN CIMA.+!m';
-			$newContent = preg_replace( $beforeReg, "$0\n{$matches[0]}\n$newLine.", $content, 1 );
+			$newContent = preg_replace($beforeReg, "$0\n{$matches[0]}\n$newLine.", $content, 1);
 		}
 
 		$params = [
 			'title' => $votePage,
 			'text' => $newContent,
-			'summary' => $this->getConfig()->get( 'ric-vote-page-summary' )
+			'summary' => $this->getConfig()->get('ric-vote-page-summary')
 		];
 
-		$this->getController()->editPage( $params );
+		$this->getController()->editPage($params);
 	}
 
 	/**
@@ -89,13 +89,13 @@ 
 	 * @return string
 	 */
 	private function getTimeWithArticle() : string {
-		$oldLoc = setlocale( LC_TIME, 'it_IT', 'Italian_Italy', 'Italian' );
-		$endTS = time() + ( 60 * 60 * 24 * 7 );
-		$endTime = strftime( '%e %B alle %R', $endTS );
+		$oldLoc = setlocale(LC_TIME, 'it_IT', 'Italian_Italy', 'Italian');
+		$endTS = time() + (60 * 60 * 24 * 7);
+		$endTime = strftime('%e %B alle %R', $endTS);
 		// Remove the left space if day has a single digit
-		$endTime = ltrim( $endTime );
-		$artic = in_array( date( 'j', $endTS ), [ 8, 11 ] ) ? "l'" : "il ";
-		setlocale( LC_TIME, $oldLoc );
+		$endTime = ltrim($endTime);
+		$artic = in_array(date('j', $endTS), [8, 11]) ? "l'" : "il ";
+		setlocale(LC_TIME, $oldLoc);
 
 		return $artic . $endTime;
 	}
@@ -105,27 +105,27 @@ 
 	 *
 	 * @param string $page
 	 */
-	protected function addNews( string $page ) {
-		$this->getLogger()->info( "Adding $page to news" );
-		$newsPage = $this->getConfig()->get( 'ric-news-page' );
+	protected function addNews(string $page) {
+		$this->getLogger()->info("Adding $page to news");
+		$newsPage = $this->getConfig()->get('ric-news-page');
 
-		$content = $this->getController()->getPageContent( $newsPage );
+		$content = $this->getController()->getPageContent($newsPage);
 		$reg = '!(\| *riconferme[ _]tacite[ _]amministratori *= *)(\d+)!';
 
 		$matches = [];
-		if ( preg_match( $reg, $content, $matches ) === false ) {
-			throw new TaskException( 'Param not found in news page' );
+		if (preg_match($reg, $content, $matches) === false) {
+			throw new TaskException('Param not found in news page');
 		}
 
 		$newNum = (int)$matches[2] + 1;
-		$newContent = preg_replace( $reg, '${1}' . $newNum, $content );
+		$newContent = preg_replace($reg, '${1}' . $newNum, $content);
 
 		$params = [
 			'title' => $newsPage,
 			'text' => $newContent,
-			'summary' => $this->getConfig()->get( 'ric-news-page-summary' )
+			'summary' => $this->getConfig()->get('ric-news-page-summary')
 		];
 
-		$this->getController()->editPage( $params );
+		$this->getController()->editPage($params);
 	}
 }

includes/Task/UpdateList.php

Spacing +63 added lines, -63 removed lines

@@ -1,4 +1,4 @@ 
-<?php declare( strict_types=1 );
+<?php declare(strict_types=1);
 
 namespace BotRiconferme\Task;
 
@@ -19,18 +19,18 @@ 
 	 * @inheritDoc
 	 */
 	public function run() : TaskResult {
-		$this->getLogger()->info( 'Starting task UpdateList' );
+		$this->getLogger()->info('Starting task UpdateList');
 		$this->actualList = $this->getActualAdmins();
 		$this->botList = $this->getList();
 
 		$missing = $this->getMissingGroups();
 		$extra = $this->getExtraGroups();
 
-		if ( $missing || $extra ) {
-			$this->doUpdateList( $this->getNewContent( $missing, $extra ) );
+		if ($missing || $extra) {
+			$this->doUpdateList($this->getNewContent($missing, $extra));
 		}
 
-		if ( $this->errors ) {
+		if ($this->errors) {
 			// We're fine with it, but don't run other tasks
 			$msg = 'Task UpdateList completed with warnings.';
 			$status = self::STATUS_ERROR;
@@ -39,15 +39,15 @@ 
 			$status = self::STATUS_OK;
 		}
 
-		$this->getLogger()->info( $msg );
-		return new TaskResult( $status, $this->errors );
+		$this->getLogger()->info($msg);
+		return new TaskResult($status, $this->errors);
 	}
 
 	/**
 	 * @return array
 	 */
 	protected function getActualAdmins() : array {
-		$this->getLogger()->debug( 'Retrieving admins - API' );
+		$this->getLogger()->debug('Retrieving admins - API');
 		$params = [
 			'action' => 'query',
 			'list' => 'allusers',
@@ -56,23 +56,23 @@ 
 			'aulimit' => 'max',
 		];
 
-		$req = RequestBase::newFromParams( $params );
-		return $this->extractAdmins( $req->execute() );
+		$req = RequestBase::newFromParams($params);
+		return $this->extractAdmins($req->execute());
 	}
 
 	/**
 	 * @param array $data
 	 * @return array
 	 */
-	protected function extractAdmins( array $data ) : array {
+	protected function extractAdmins(array $data) : array {
 		$ret = [];
-		$blacklist = $this->getConfig()->get( 'exclude-admins' );
-		foreach ( $data['query']['allusers'] as $u ) {
-			if ( in_array( $u['name'], $blacklist ) ) {
+		$blacklist = $this->getConfig()->get('exclude-admins');
+		foreach ($data['query']['allusers'] as $u) {
+			if (in_array($u['name'], $blacklist)) {
 				continue;
 			}
-			$interestingGroups = array_intersect( $u['groups'], [ 'sysop', 'bureaucrat', 'checkuser' ] );
-			$ret[ $u['name'] ] = $interestingGroups;
+			$interestingGroups = array_intersect($u['groups'], ['sysop', 'bureaucrat', 'checkuser']);
+			$ret[$u['name']] = $interestingGroups;
 		}
 		return $ret;
 	}
@@ -81,10 +81,10 @@ 
 	 * @return array
 	 */
 	protected function getList() : array {
-		$this->getLogger()->debug( 'Retrieving admins - JSON list' );
-		$content = $this->getController()->getPageContent( $this->getConfig()->get( 'list-title' ) );
+		$this->getLogger()->debug('Retrieving admins - JSON list');
+		$content = $this->getController()->getPageContent($this->getConfig()->get('list-title'));
 
-		return json_decode( $content, true );
+		return json_decode($content, true);
 	}
 
 	/**
@@ -94,20 +94,20 @@ 
 	 */
 	protected function getMissingGroups() : array {
 		$missing = [];
-		foreach ( $this->actualList as $adm => $groups ) {
-			if ( !isset( $this->botList[ $adm ] ) ) {
+		foreach ($this->actualList as $adm => $groups) {
+			if (!isset($this->botList[$adm])) {
 				$groupsList = $groups;
-			} elseif ( count( $groups ) > count( $this->botList[$adm] ) ) {
+			} elseif (count($groups) > count($this->botList[$adm])) {
 				// Only some groups are missing
-				$groupsList = array_diff_key( $groups, $this->botList[$adm] );
+				$groupsList = array_diff_key($groups, $this->botList[$adm]);
 			} else {
 				continue;
 			}
 
-			foreach ( $groupsList as $group ) {
+			foreach ($groupsList as $group) {
 				try {
-					$missing[ $adm ][ $group ] = $this->getFlagDate( $adm, $group );
-				} catch ( TaskException $e ) {
+					$missing[$adm][$group] = $this->getFlagDate($adm, $group);
+				} catch (TaskException $e) {
 					$this->errors[] = $e->getMessage();
 				}
 			}
@@ -123,10 +123,10 @@ 
 	 * @return string
 	 * @throws TaskException
 	 */
-	protected function getFlagDate( string $admin, string $group ) : string {
-		$this->getLogger()->info( "Retrieving $group flag date for $admin" );
+	protected function getFlagDate(string $admin, string $group) : string {
+		$this->getLogger()->info("Retrieving $group flag date for $admin");
 
-		if ( $group === 'checkuser' ) {
+		if ($group === 'checkuser') {
 			// Little hack
 			$oldUrl = RequestBase::$url;
 			RequestBase::$url = 'https://meta.wikimedia.org/w/api.php';
@@ -142,19 +142,19 @@ 
 			'lelimit' => 'max'
 		];
 
-		$req = RequestBase::newFromParams( $params );
+		$req = RequestBase::newFromParams($params);
 		$data = $req->execute();
-		$ts = $this->extractTimestamp( $data, $group );
+		$ts = $this->extractTimestamp($data, $group);
 
-		if ( isset( $oldUrl ) ) {
+		if (isset($oldUrl)) {
 			RequestBase::$url = $oldUrl;
 		}
 
-		if ( $ts === null ) {
-			throw new TaskException( "$group flag date unavailable for $admin" );
+		if ($ts === null) {
+			throw new TaskException("$group flag date unavailable for $admin");
 		}
 
-		return date( "d/m/Y", strtotime( $ts ) );
+		return date("d/m/Y", strtotime($ts));
 	}
 
 	/**
@@ -164,15 +164,15 @@ 
 	 * @param string $group
 	 * @return string|null
 	 */
-	private function extractTimestamp( array $data, string $group ) : ?string {
+	private function extractTimestamp(array $data, string $group) : ?string {
 		$ts = null;
-		foreach ( $data['query']['logevents'] as $entry ) {
-			if ( !isset( $entry['params'] ) ) {
+		foreach ($data['query']['logevents'] as $entry) {
+			if (!isset($entry['params'])) {
 				// Old entries
 				continue;
 			}
-			if ( in_array( $group, $entry['params']['newgroups'] ) &&
-				!in_array( $group, $entry['params']['oldgroups'] )
+			if (in_array($group, $entry['params']['newgroups']) &&
+				!in_array($group, $entry['params']['oldgroups'])
 			) {
 				$ts = $entry['timestamp'];
 				break;
@@ -188,11 +188,11 @@ 
 	 */
 	protected function getExtraGroups() : array {
 		$extra = [];
-		foreach ( $this->botList as $name => $groups ) {
-			if ( !isset( $this->actualList[ $name ] ) ) {
-				$extra[ $name ] = $groups;
-			} elseif ( count( $groups ) > count( $this->actualList[ $name ] ) ) {
-				$extra[ $name ] = array_diff_key( $groups, $this->actualList[ $name ] );
+		foreach ($this->botList as $name => $groups) {
+			if (!isset($this->actualList[$name])) {
+				$extra[$name] = $groups;
+			} elseif (count($groups) > count($this->actualList[$name])) {
+				$extra[$name] = array_diff_key($groups, $this->actualList[$name]);
 			}
 		}
 		return $extra;
@@ -203,25 +203,25 @@ 
 	 *
 	 * @param array $newContent
 	 */
-	protected function doUpdateList( array $newContent ) {
-		ksort( $newContent );
+	protected function doUpdateList(array $newContent) {
+		ksort($newContent);
 
-		if ( $newContent !== $this->botList ) {
-			$this->getLogger()->info( 'Updating admin list' );
+		if ($newContent !== $this->botList) {
+			$this->getLogger()->info('Updating admin list');
 		} else {
-			$this->getLogger()->info( 'Admin list already up-to-date' );
+			$this->getLogger()->info('Admin list already up-to-date');
 			return;
 		}
 
-		$stringified = json_encode( $newContent );
+		$stringified = json_encode($newContent);
 
 		$params = [
-			'title' => $this->getConfig()->get( 'list-title' ),
+			'title' => $this->getConfig()->get('list-title'),
 			'text' => $stringified,
-			'summary' => $this->getConfig()->get( 'list-update-summary' )
+			'summary' => $this->getConfig()->get('list-update-summary')
 		];
 
-		$this->getController()->editPage( $params );
+		$this->getController()->editPage($params);
 	}
 
 	/**
@@ -231,19 +231,19 @@ 
 	 * @param array[] $extra
 	 * @return array[]
 	 */
-	protected function getNewContent( array $missing, array $extra ) : array {
+	protected function getNewContent(array $missing, array $extra) : array {
 		$newContent = $this->botList;
-		foreach ( $newContent as $user => $groups ) {
-			if ( isset( $missing[ $user ] ) ) {
-				$newContent[ $user ] = array_merge( $groups, $missing[ $user ] );
-				unset( $missing[ $user ] );
-			} elseif ( isset( $extra[ $user ] ) ) {
-				$newContent[ $user ] = array_diff_key( $groups, $extra[ $user ] );
+		foreach ($newContent as $user => $groups) {
+			if (isset($missing[$user])) {
+				$newContent[$user] = array_merge($groups, $missing[$user]);
+				unset($missing[$user]);
+			} elseif (isset($extra[$user])) {
+				$newContent[$user] = array_diff_key($groups, $extra[$user]);
 			}
 		}
 		// Add users which don't have an entry at all
-		$newContent = array_merge( $newContent, $missing );
+		$newContent = array_merge($newContent, $missing);
 		// And remove empty users
-		return array_filter( $newContent );
+		return array_filter($newContent);
 	}
 }