App\BashRestController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
B	__invoke()	0	28	6
B	flatten()	0	25	5

<?php

/**
 * This file is part of Lekarna.cz (http://www.lekarna.cz/)
 *
 * Copyright (c) 2014 Pears Health Cyber, s.r.o. (http://pearshealthcyber.cz)
 *
 * For the full copyright and license information, please view
 * the file LICENSE that was distributed with this source code.
 */

namespace App;

use Interop\Container\ContainerInterface;
use Slim\Http\Request;
use Slim\Http\Response;


final class BashRestController
{

	const SECRET_HEADER = 'X-Secret';

	/**
	 * @var Executor
	 */
	private $executor;

	/**
	 * @var string
	 */
	private $secret;

	/**
	 * @var array
	 */
	private $scripts;

	public function __construct(ContainerInterface $ci, Executor $executor)
	{
		$this->executor = $executor;
		$this->secret = $ci->get('settings')['secret'];
		$this->scripts = $ci->get('bashREST');

It seems like $ci->get('bashREST') of type * is incompatible with the declared type array of property $scripts.

	}


	public function __invoke(Request $request, Response $response, array $args)
	{
		$secured = FALSE;
		foreach ($request->getHeader(self::SECRET_HEADER) as $secret) {
			if ($secret == $this->secret) { // allow cast
				$secured = TRUE;
			}
		}

		if ($this->secret !== NULL && ! $secured) {
			return $response->withStatus(403);
		}

		$projectName = $args['group'] . '/' . $args['project'];
		$action = $args['action'];

		if ( ! isset($this->scripts[$projectName][$action])) {
			return $response->withStatus(404);
		}

		return $response->withStatus(200)
			->withJson([
				'result' => $this->executor->executeCommand(
					$this->scripts[$projectName][$action],
					$this->flatten($request->getParsedBody())

It seems like $request->getParsedBody() targeting Slim\Http\Request::getParsedBody() can also be of type null or object; however, App\BashRestController::flatten() does only seem to accept array, maybe add an additional type check?

				)
			]);
	}


	private function flatten(array $data)
	{
		$toProcess = [[
			'data' => $data,
			'prefix' => 'HOOK'
		]];

		$flattened = [];

		while ( ! empty($toProcess)) {
			$actual = array_pop($toProcess);
			foreach ($actual['data'] as $key => $value) {
				if (is_scalar($value)) {
					$flattened[$actual['prefix'] . '_' . $key] = $value;
				} else if (is_array($value)) {
					array_push($toProcess, [
						'data' => $value,
						'prefix' => $actual['prefix'] . '_' . $key
					]);
				}
			}
		}

		return $flattened;
	}

}