Controller::__construct() - Code Metrics - Inspection of "Update README.md" - DTForce/slim-hook - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (c65b3c)

by Jan

created 2016-08-19 09:18 UTC

Controller::__construct() A

↳ Parent: Controller

Complexity

Conditions	3
Paths	1

Size

Total Lines	22
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	3

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	22
ccs	16
cts	16
cp	1
rs	9.2
cc	3
eloc	12
nc	1
nop	2
crap	3

<?php

namespace App;

use Interop\Container\ContainerInterface;
use Slim\Http\Request;
use Slim\Http\Response;


final class Controller
{

	/**
	 * @var string
	 */
	private $secret;

	/**
	 * @var bool
	 */
	private $secured = FALSE;

	/**
	 * @var callable[]
	 */
	private $router;

	public function __construct(ContainerInterface $ci, Handler $handler)
	{
		$this->ci = $ci;
class MyClass { }

$x = new MyClass();
$x->foo = true;
		$this->secret = $ci->get('settings')['secret'];
		$this->scripts = $ci->get('scripts');
class MyClass { }

$x = new MyClass();
$x->foo = true;

		$this->router['pipeline'] = function (array $event) use($handler) {
			foreach ($event['builds'] as $build) {
				if ($build['stage'] === 'deploy') {
					$handler->handleDeploy($event, $build);
				}
			}
		};

		$this->router['push'] = function (array $event) use($handler) {
			$handler->handlePush($event);
		};

		$this->router['tag_push'] = function (array $event) use($handler) {
			$handler->handleTag($event);
		};
	}


	public function __invoke(Request $request, Response $response, $args)
	{
		$body = $request->getParsedBody();
		if ( ! isset($body['object_kind'])) {
			return $response->withStatus(500);
		}

		foreach ($request->getHeader('X-Gitlab-Token') as $secret) {
			if ($secret === $this->secret) {
				$this->secured = TRUE;
			}
		}

		if ($this->secret !== NULL && ! $this->secured) {
			return $response->withStatus(403);
		}

		if (isset($this->router[$body['object_kind']])) {
			$this->router[$body['object_kind']]($body);
		}


		return $response->withStatus(200);
	}

}


1		<?php
2
3		namespace App;
4
5		use Interop\Container\ContainerInterface;
6		use Slim\Http\Request;
7		use Slim\Http\Response;
8
9
10		final class Controller
11		{
12
13		/**
14		* @var string
15		*/
16		private $secret;
17
18		/**
19		* @var bool
20		*/
21		private $secured = FALSE;
22
23		/**
24		* @var callable[]
25		*/
26		private $router;
27
28	4	public function __construct(ContainerInterface $ci, Handler $handler)
29		{
30	4	$this->ci = $ci;
		0 ignored issues – show Bug introduced 2016-08-19 09:23 UTC by Report Bug Copy Issue Report The property `ci` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
31	4	$this->secret = $ci->get('settings')['secret'];
32	4	$this->scripts = $ci->get('scripts');
		0 ignored issues – show Bug introduced 2016-08-19 09:23 UTC by Report Bug Copy Issue Report The property `scripts` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
33
34		$this->router['pipeline'] = function (array $event) use($handler) {
35	1	foreach ($event['builds'] as $build) {
36	1	if ($build['stage'] === 'deploy') {
37	1	$handler->handleDeploy($event, $build);
38	1	}
39	1	}
40	1	};
41
42		$this->router['push'] = function (array $event) use($handler) {
43	1	$handler->handlePush($event);
44	1	};
45
46	1	$this->router['tag_push'] = function (array $event) use($handler) {
47	1	$handler->handleTag($event);
48	1	};
49	4	}
50
51
52	4	public function __invoke(Request $request, Response $response, $args)
53		{
54	4	$body = $request->getParsedBody();
55	4	if ( ! isset($body['object_kind'])) {
56	1	return $response->withStatus(500);
57		}
58
59	3	foreach ($request->getHeader('X-Gitlab-Token') as $secret) {
60	3	if ($secret === $this->secret) {
61	3	$this->secured = TRUE;
62	3	}
63	3	}
64
65	3	if ($this->secret !== NULL && ! $this->secured) {
66		return $response->withStatus(403);
67		}
68
69	3	if (isset($this->router[$body['object_kind']])) {
70	3	$this->router[$body['object_kind']]($body);
71	3	}
72
73
74	3	return $response->withStatus(200);
75		}
76
77		}
78

DTForce / slim-hook

Branch — master (c65b3c)

Controller::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like