Issues in EventStream.php (master) - Issues in master - DDDominio/event-sourcing - Measure and Improve Code Quality continuously with Scrutinizer

Issues (59)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/EventSourcing/Common/EventStream.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace DDDominio\EventSourcing\Common;

use DDDominio\Common\EventInterface;

class EventStream implements EventStreamInterface
{
    /**
     * @var EventInterface[]
     */
    private $events;

    /**
     * @param EventInterface[] $events
     */
    public function __construct(array $events)
    {
        $this->events = $events;
    }

    /**
     * @return EventStream
     */
    public static function buildEmpty()
    {
        return new self([]);
    }

    /**
     * @param EventInterface|EventInterface[] $events
     * @return EventStream
     */
    public function append($events)
    {
        if (!is_array($events)) {
            $events = [$events];
        }
        return new self(array_merge($this->events(), $events));
    }

    /**
     * @return EventInterface[]
     */
    public function events()
    {
        return $this->events;
    }

    /**
     * @param int $offset
     * @return EventInterface
     * @throws \OutOfBoundsException
     */
    public function get($offset)
    {
        if (!isset($this->events[$offset])) {
            throw new \OutOfBoundsException();
        }
        return $this->events[$offset];
    }

    /**
     * @return EventInterface
     * @throws \OutOfBoundsException
     */
    public function last()
    {
        if ($this->isEmpty()) {
            throw new \OutOfBoundsException();
        }
        return end($this->events);

    }

    /**
     * @return bool
     */
    public function isEmpty()
    {
        return empty($this->events);
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        return count($this->events);
    }

    /**
     * {@inheritdoc}
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->events());
    }

    /**
     * @param \Closure $closure
     */
    public function each(\Closure $closure)
    {
        foreach ($this->events as $event) {
            $closure($event);
        }
    }

    /**
     * @param \Closure $closure
     * @return EventStream
     */
    public function filter(\Closure $closure)
    {
        return new self(array_values(array_filter($this->events, $closure)));
    }

    /**
     * @param \Closure $closure
     * @return EventStream
     */
    public function map(\Closure $closure)
    {
        return new self(array_map($closure, $this->events));
    }

    /**
     * @param int $offset
     * @param int|null $length
     * @return EventStream
     */
    public function slice($offset, $length = null)
    {
        return new self(array_slice($this->events, $offset, $length));
    }
}


1		<?php
2
3		namespace DDDominio\EventSourcing\Common;
4
5		use DDDominio\Common\EventInterface;
6
7		class EventStream implements EventStreamInterface
8		{
9		/**
10		* @var EventInterface[]
11		*/
12		private $events;
13
14		/**
15		* @param EventInterface[] $events
16		*/
17	90	public function __construct(array $events)
18		{
19	90	$this->events = $events;
20	90	}
21
22		/**
23		* @return EventStream
24		*/
25	29	public static function buildEmpty()
26		{
27	29	return new self([]);
28		}
29
30		/**
31		* @param EventInterface\|EventInterface[] $events
32		* @return EventStream
33		*/
34	21	public function append($events)
35		{
36	21	if (!is_array($events)) {
37	16	$events = [$events];
38		}
39	21	return new self(array_merge($this->events(), $events));
40		}
41
42		/**
43		* @return EventInterface[]
44		*/
45	36	public function events()
46		{
47	36	return $this->events;
48		}
49
50		/**
51		* @param int $offset
52		* @return EventInterface
53		* @throws \OutOfBoundsException
54		*/
55	31	public function get($offset)
56		{
57	31	if (!isset($this->events[$offset])) {
58	2	throw new \OutOfBoundsException();
59		}
60	29	return $this->events[$offset];
61		}
62
63		/**
64		* @return EventInterface
65		* @throws \OutOfBoundsException
66		*/
67	8	public function last()
68		{
69	8	if ($this->isEmpty()) {
70	1	throw new \OutOfBoundsException();
71		}
72	7	return end($this->events);
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-03-04 16:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `end($this->events);` of type `DDDominio\Common\EventInterface\|false` adds `false` to the return on line 72 which is incompatible with the return type declared by the interface `DDDominio\EventSourcing\...ntStreamInterface::last` of type `DDDominio\Common\EventInterface`. It seems like you forgot to handle an error condition. Loading history...
73		}
74
75		/**
76		* @return bool
77		*/
78	18	public function isEmpty()
79		{
80	18	return empty($this->events);
81		}
82
83		/**
84		* {@inheritdoc}
85		*/
86	51	public function count()
87		{
88	51	return count($this->events);
89		}
90
91		/**
92		* {@inheritdoc}
93		*/
94	14	public function getIterator()
95		{
96	14	return new \ArrayIterator($this->events());
97		}
98
99		/**
100		* @param \Closure $closure
101		*/
102	1	public function each(\Closure $closure)
103		{
104	1	foreach ($this->events as $event) {
105	1	$closure($event);
106		}
107	1	}
108
109		/**
110		* @param \Closure $closure
111		* @return EventStream
112		*/
113	4	public function filter(\Closure $closure)
114		{
115	4	return new self(array_values(array_filter($this->events, $closure)));
116		}
117
118		/**
119		* @param \Closure $closure
120		* @return EventStream
121		*/
122	44	public function map(\Closure $closure)
123		{
124	44	return new self(array_map($closure, $this->events));
125		}
126
127		/**
128		* @param int $offset
129		* @param int\|null $length
130		* @return EventStream
131		*/
132	6	public function slice($offset, $length = null)
133		{
134	6	return new self(array_slice($this->events, $offset, $length));
135		}
136		}
137

DDDominio / event-sourcing

Issues (59)

Security Analysis no request data

src/EventSourcing/Common/EventStream.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like