DDDominio\EventSourcing\Common\EventStream

Complexity

Total Complexity

15

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	buildEmpty()	0	4	1
A	append()	0	7	2
A	events()	0	4	1
A	get()	0	7	2
A	last()	0	7	2
A	isEmpty()	0	4	1
A	count()	0	4	1
A	getIterator()	0	4	1
A	filter()	0	4	1
A	map()	0	4	1
A	slice()	0	4	1

<?php

namespace DDDominio\EventSourcing\Common;

use DDDominio\Common\EventInterface;

class EventStream implements EventStreamInterface
{
    /**
     * @var EventInterface[]
     */
    private $events;

    /**
     * @param EventInterface[] $events
     */
    public function __construct(array $events)
    {
        $this->events = $events;
    }

    /**
     * @return EventStream
     */
    public static function buildEmpty()
    {
        return new self([]);
    }

    /**
     * @param EventInterface|EventInterface[] $events
     * @return EventStream
     */
    public function append($events)
    {
        if (!is_array($events)) {
            $events = [$events];
        }
        return new self(array_merge($this->events(), $events));
    }

    /**
     * @return EventInterface[]
     */
    public function events()
    {
        return $this->events;
    }

    /**
     * @param int $offset
     * @return EventInterface
     * @throws \OutOfBoundsException
     */
    public function get($offset)
    {
        if (!isset($this->events[$offset])) {
            throw new \OutOfBoundsException();
        }
        return $this->events[$offset];
    }

    /**
     * @return EventInterface
     * @throws \OutOfBoundsException
     */
    public function last()
    {
        if ($this->isEmpty()) {
            throw new \OutOfBoundsException();
        }
        return end($this->events);

The expression end($this->events); of type DDDominio\Common\EventInterface|false adds false to the return on line 72 which is incompatible with the return type declared by the interface DDDominio\EventSourcing\Common\EventStreamInterface::last of type DDDominio\Common\EventInterface. It seems like you forgot to handle an error condition.

    }

    /**
     * @return bool
     */
    public function isEmpty()
    {
        return empty($this->events);
    }

    /**
     * {@inheritdoc}
     */
    public function count()
    {
        return count($this->events);
    }

    /**
     * {@inheritdoc}
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->events());
    }

    /**
     * @param \Closure $closure
     * @return EventStream
     */
    public function filter(\Closure $closure)
    {
        return new self(array_values(array_filter($this->events, $closure)));
    }

    /**
     * @param \Closure $closure
     * @return EventStream
     */
    public function map(\Closure $closure)
    {
        return new self(array_map($closure, $this->events));
    }

    /**
     * @param int $offset
     * @param int|null $length
     * @return EventStream
     */
    public function slice($offset, $length = null)
    {
        return new self(array_slice($this->events, $offset, $length));
    }
}