Issues in Player.php (master) - Issues in master - Cysha/casino-holdem - Measure and Improve Code Quality continuously with Scrutinizer

Issues (72)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Game/Player.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Cysha\Casino\Holdem\Game;

use Assert\Assertion;
use Cysha\Casino\Game\Chips;
use Cysha\Casino\Game\Client;
use Cysha\Casino\Game\Contracts\Player as PlayerContract;
use Ramsey\Uuid\Uuid;

class Player extends Client implements PlayerContract
{
    /**
     * @var Chips
     */
    private $chipStack;

    /**
     * PlayerTest constructor.
     *
     * @param string $name
     * @param Chips  $chips
     */
    public function __construct(Uuid $id, $name, Chips $wallet = null, Chips $chips = null)
    {
        parent::__construct($id, $name, $wallet);

        $this->chipStack = $chips ?? Chips::zero();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @param Client $client
     * @param Chips  $chipCount
     *
     * @return PlayerContract
     */
    public static function fromClient(Client $client, Chips $chipCount = null): PlayerContract
    {
        return new self($client->id(), $client->name(), $client->wallet(), $chipCount);
    }

    /**
     * @param PlayerContract $object
     *
     * @return bool
     */
    public function equals(PlayerContract $object): bool
    {
        return static::class === get_class($object)
        && $this->id() === $object->id()
        && $this->name() === $object->name()
        && $this->wallet() === $object->wallet()
        && $this->chipStack() === $object->chipStack();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    /**
     * @return Chips
     */
    public function chipStack(): Chips
    {
        return $this->chipStack;
    }

    /**
     * @param Chips $chips
     */
    public function bet(Chips $chips)
    {
        Assertion::greaterOrEqualThan($chips->amount(), 0);
        Assertion::lessOrEqualThan($chips->amount(), $this->chipStack()->amount());
        $this->chipStack()->subtract($chips);
    }
}


1		<?php
2
3		namespace Cysha\Casino\Holdem\Game;
4
5		use Assert\Assertion;
6		use Cysha\Casino\Game\Chips;
7		use Cysha\Casino\Game\Client;
8		use Cysha\Casino\Game\Contracts\Player as PlayerContract;
9		use Ramsey\Uuid\Uuid;
10
11		class Player extends Client implements PlayerContract
12		{
13		/**
14		* @var Chips
15		*/
16		private $chipStack;
17
18		/**
19		* PlayerTest constructor.
20		*
21		* @param string $name
22		* @param Chips $chips
23	145	*/
24		public function __construct(Uuid $id, $name, Chips $wallet = null, Chips $chips = null)
25	145	{
26		parent::__construct($id, $name, $wallet);
27	145
28	145	$this->chipStack = $chips ?? Chips::zero();
		0 ignored issues – show Documentation Bug introduced 2017-02-24 17:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$chips ?? \Cysha\Casino\Game\Chips::zero()` can also be of type `object<self>`. However, the property `$chipStack` is declared as type `object<Cysha\Casino\Game\Chips>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
29		}
30
31		/**
32		* @param Client $client
33		* @param Chips $chipCount
34		*
35		* @return PlayerContract
36	145	*/
37		public static function fromClient(Client $client, Chips $chipCount = null): PlayerContract
38	145	{
39		return new self($client->id(), $client->name(), $client->wallet(), $chipCount);
40		}
41
42		/**
43		* @param PlayerContract $object
44		*
45		* @return bool
46	27	*/
47		public function equals(PlayerContract $object): bool
48	27	{
49	27	return static::class === get_class($object)
50	27	&& $this->id() === $object->id()
51	27	&& $this->name() === $object->name()
52		&& $this->wallet() === $object->wallet()
53		&& $this->chipStack() === $object->chipStack();
		0 ignored issues – show Bug introduced 2017-02-24 17:28 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you code against a concrete implementation and not the interface `Cysha\Casino\Game\Contracts\Player` as the method `chipStack()` does only exist in the following implementations of said interface: `Cysha\Casino\Holdem\Game\Player`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
54		}
55
56		/**
57	45	* @return Chips
58		*/
59	45	public function chipStack(): Chips
60		{
61		return $this->chipStack;
62		}
63
64		/**
65	32	* @param Chips $chips
66		*/
67	32	public function bet(Chips $chips)
68	31	{
69	31	Assertion::greaterOrEqualThan($chips->amount(), 0);
70		Assertion::lessOrEqualThan($chips->amount(), $this->chipStack()->amount());
71		$this->chipStack()->subtract($chips);
72		}
73		}
74

Cysha / casino-holdem

Issues (72)

Security Analysis no request data

src/Game/Player.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like