Issues in ChipPot.php (master) - Issues in master - Cysha/casino-holdem - Measure and Improve Code Quality continuously with Scrutinizer

Issues (72)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Game/ChipPot.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Cysha\Casino\Holdem\Game;

use Cysha\Casino\Game\Chips;
use Cysha\Casino\Game\ChipStackCollection;
use Cysha\Casino\Game\Contracts\Player;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Cysha\Casino\Game\PlayerCollection;

class ChipPot
{
    /**
     * @var ChipStackCollection
     */
    private $chips;

    /**
     * @var PlayerCollection
     */
    private $players;

    private function __construct()
    {
        $this->chips = new ChipStackCollection();
        $this->players = new PlayerCollection();
    }

    /**
     * @return ChipPot
     */
    public static function create(): ChipPot
    {
        return new self();
    }

    /**
     * @param Chips  $chips
     * @param Player $player
     *
     * @return ChipPot
     */
    public function addChips(Chips $chips, Player $player): ChipPot
    {
        $existingChips = $this->chips()->get($player->name()) ?? Chips::zero();

        $this->chips->put($player->name(), Chips::fromAmount($existingChips->amount() + $chips->amount()));

        if ($this->players()->findByName($player->name()) === null) {
            $this->players->push($player);
        }

        return $this;
    }

    /**
     * @return ChipStackCollection
     */
    public function chips(): ChipStackCollection
    {
        return $this->chips;
    }

    /**
     * @return PlayerCollection
     */
    public function players(): PlayerCollection
    {
        return $this->players;
    }

    /**
     * @return Chips
     */
    public function total(): Chips
    {
        return $this->chips->total();
    }

    /**
     * @return int
     */
    public function totalAmount(): int
    {
        return $this->chips->total()->amount();
    }

    /**
     * @param ChipPot $object
     *
     * @return bool
     */
    public function equals(ChipPot $object): bool
    {
        return static::class === get_class($object)
        && $this->chips() === $object->chips()
        && $this->players() === $object->players()
        && $this->total() === $object->total();
    }

    /**
     * @return string
     */
    public function __toString()
    {
        $players = $this->players()
            ->map(function (Player $player) {
                return $player->name();
            })
            ->implode(', ');

        return sprintf('[%d] [%s]', $this->total()->amount(), $players);
    }
}


1		<?php
2
3		namespace Cysha\Casino\Holdem\Game;
4
5		use Cysha\Casino\Game\Chips;
6		use Cysha\Casino\Game\ChipStackCollection;
7		use Cysha\Casino\Game\Contracts\Player;
		0 ignored issues – show Bug introduced 2017-02-24 16:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this This use statement conflicts with another class in this namespace, `Cysha\Casino\Holdem\Game\Player`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
8		use Cysha\Casino\Game\PlayerCollection;
9
10		class ChipPot
11		{
12		/**
13		* @var ChipStackCollection
14		*/
15		private $chips;
16
17		/**
18		* @var PlayerCollection
19		*/
20		private $players;
21
22	52	private function __construct()
23		{
24	52	$this->chips = new ChipStackCollection();
25	52	$this->players = new PlayerCollection();
26	52	}
27
28		/**
29		* @return ChipPot
30		*/
31	52	public static function create(): ChipPot
32		{
33	52	return new self();
34		}
35
36		/**
37		* @param Chips $chips
38		* @param Player $player
39		*
40		* @return ChipPot
41		*/
42	21	public function addChips(Chips $chips, Player $player): ChipPot
43		{
44	21	$existingChips = $this->chips()->get($player->name()) ?? Chips::zero();
45
46	21	$this->chips->put($player->name(), Chips::fromAmount($existingChips->amount() + $chips->amount()));
47
48	21	if ($this->players()->findByName($player->name()) === null) {
49	21	$this->players->push($player);
50		}
51
52	21	return $this;
53		}
54
55		/**
56		* @return ChipStackCollection
57		*/
58	21	public function chips(): ChipStackCollection
59		{
60	21	return $this->chips;
61		}
62
63		/**
64		* @return PlayerCollection
65		*/
66	21	public function players(): PlayerCollection
67		{
68	21	return $this->players;
69		}
70
71		/**
72		* @return Chips
73		*/
74	13	public function total(): Chips
75		{
76	13	return $this->chips->total();
77		}
78
79		/**
80		* @return int
81		*/
82	3	public function totalAmount(): int
83		{
84	3	return $this->chips->total()->amount();
85		}
86
87		/**
88		* @param ChipPot $object
89		*
90		* @return bool
91		*/
92	11	public function equals(ChipPot $object): bool
93		{
94	11	return static::class === get_class($object)
95	11	&& $this->chips() === $object->chips()
96	11	&& $this->players() === $object->players()
97	11	&& $this->total() === $object->total();
98		}
99
100		/**
101		* @return string
102		*/
103	1	public function __toString()
104		{
105	1	$players = $this->players()
106	1	->map(function (Player $player) {
107	1	return $player->name();
108	1	})
109	1	->implode(', ');
110
111	1	return sprintf('[%d] [%s]', $this->total()->amount(), $players);
112		}
113		}
114

Cysha / casino-holdem

Issues (72)

Security Analysis no request data

src/Game/ChipPot.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like