CashGame - Code Metrics - Inspection of "added ability to remove player from a game" - Cysha/casino-holdem - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 92fb9d...3bde59 )

by Dan

created 2017-03-08 00:36 UTC

CashGame A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	165
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	13
lcom	1
cbo	10
dl	0
loc	165
ccs	41
cts	41
cp	1
rs	10
c	0
b	0
f	0

11 Methods

Rating	Name	Size	Complexity
A	__construct()	8	1
A	setUp()	4	1
A	id()	4	1
A	name()	4	1
A	rules()	4	1
A	players()	4	1
A	__toString()	4	1
A	tables()	4	1
A	registerPlayer()	22	3
A	removePlayer()	17	1
A	assignPlayersToTables()	14	1

<?php

namespace Cysha\Casino\Holdem\Game;

use Cysha\Casino\Cards\Deck;
use Cysha\Casino\Exceptions\GameException;
use Cysha\Casino\Game\Chips;
use Cysha\Casino\Game\Client;
use Cysha\Casino\Game\Contracts\Game;
use Cysha\Casino\Game\Contracts\GameParameters;
use Cysha\Casino\Game\PlayerCollection;
use Cysha\Casino\Game\TableCollection;
use Cysha\Casino\Holdem\Cards\Evaluators\SevenCard;
use Ramsey\Uuid\UuidInterface;

final class CashGame implements Game
{
    /**
     * @var UuidInterface
     */
    private $id;

    /**
     * @var string
     */
    private $name;

    /**
     * @var DefaultParameters
     */
    private $rules;

    /**
     * @var PlayerCollection
     */
    private $players;

    /**
     * @var TableCollection
     */
    protected $tables;

    /**
     * CashGame constructor.
     *
     * @param UuidInterface  $id
     * @param string         $name
     * @param GameParameters $rules
     */
    public function __construct(UuidInterface $id, string $name, GameParameters $rules)
    {
        $this->id = $id;
        $this->name = $name;
        $this->players = PlayerCollection::make();
        $this->tables = TableCollection::make();
        $this->rules = $rules;

    }

    /**
     * @param UuidInterface  $id
     * @param string         $name
     * @param GameParameters $rules
     *
     * @return CashGame
     */
    public static function setUp(UuidInterface $id, string $name, GameParameters $rules)
    {
        return new self($id, $name, $rules);
    }

    /**
     * @return UuidInterface
     */
    public function id(): UuidInterface
    {
        return $this->id;
    }

    /**
     * @return string
     */
    public function name(): string
    {
        return $this->name;
    }

    /**
     * @return GameParameters
     */
    public function rules(): GameParameters
    {
        return $this->rules;
    }

    /**
     * @return PlayerCollection
     */
    public function players(): PlayerCollection
    {
        return $this->players;
    }

    /**
     * @return string
     */
    public function __toString(): string
    {
        return $this->name;
    }

    /**
     * @return TableCollection
     */
    public function tables(): TableCollection
    {
        return $this->tables;
    }

    /**
     * @param Client $client
     * @param Chips  $buyinAmount
     *
     * @throws GameException
     */
    public function registerPlayer(Client $client, Chips $buyinAmount = null)
    {
        $buyinAmount = $buyinAmount ?? $this->rules()->minimumBuyIn();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $playerRegistered = $this->players()
            ->filter(function (Client $player) use ($client) {
                return $client->name() === $player->name();
            });

        if ($playerRegistered->count() !== 0) {
            throw GameException::alreadyRegistered($client, $this);
        }

        if ($buyinAmount->amount() > $client->wallet()->amount()) {
            throw GameException::insufficientFunds($client, $this);
        }

        $client->wallet()->subtract($buyinAmount);

        $addPlayer = Player::fromClient($client, $buyinAmount);
        $this->players()->push($addPlayer);
    }

    public function removePlayer(Client $client)
    {
        $player = $this->players()
            ->filter(function (Player $player) use ($client) {
                return $player->name() === $client->name();
            })
            ->first()
        ;

        $client->wallet()->add($player->chipstack());

        $this->players = $this->players()
            ->reject(function (Player $player) use ($client) {
                return $player->name() === $client->name();
            })
            ->values();
    }

    public function assignPlayersToTables()
    {
        $groupedPlayers = $this->players()
        //->shuffle()
            ->chunk($this->rules()->tableSize())
            ->map(function (PlayerCollection $players) {
                $dealer = Dealer::startWork(new Deck(), new SevenCard());

                return Table::setUp($dealer, $players);
            })
            ->toArray();

        $this->tables = TableCollection::make($groupedPlayers);
    }
}


1		<?php
2
3		namespace Cysha\Casino\Holdem\Game;
4
5		use Cysha\Casino\Cards\Deck;
6		use Cysha\Casino\Exceptions\GameException;
7		use Cysha\Casino\Game\Chips;
8		use Cysha\Casino\Game\Client;
9		use Cysha\Casino\Game\Contracts\Game;
10		use Cysha\Casino\Game\Contracts\GameParameters;
11		use Cysha\Casino\Game\PlayerCollection;
12		use Cysha\Casino\Game\TableCollection;
13		use Cysha\Casino\Holdem\Cards\Evaluators\SevenCard;
14		use Ramsey\Uuid\UuidInterface;
15
16		final class CashGame implements Game
17		{
18		/**
19		* @var UuidInterface
20		*/
21		private $id;
22
23		/**
24		* @var string
25		*/
26		private $name;
27
28		/**
29		* @var DefaultParameters
30		*/
31		private $rules;
32
33		/**
34		* @var PlayerCollection
35		*/
36		private $players;
37
38		/**
39		* @var TableCollection
40		*/
41		protected $tables;
42
43		/**
44		* CashGame constructor.
45		*
46		* @param UuidInterface $id
47		* @param string $name
48		* @param GameParameters $rules
49	66	*/
50		public function __construct(UuidInterface $id, string $name, GameParameters $rules)
51	66	{
52	66	$this->id = $id;
53	66	$this->name = $name;
54	66	$this->players = PlayerCollection::make();
55	66	$this->tables = TableCollection::make();
56	66	$this->rules = $rules;
		0 ignored issues – show Documentation Bug introduced 2017-02-26 14:50 UTC by Report Bug Copy Issue Report It seems like `$rules` of type `object<Cysha\Casino\Game...ntracts\GameParameters>` is incompatible with the declared type `object<Cysha\Casino\Hold...Game\DefaultParameters>` of property `$rules`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
57		}
58
59		/**
60		* @param UuidInterface $id
61		* @param string $name
62		* @param GameParameters $rules
63		*
64		* @return CashGame
65	66	*/
66		public static function setUp(UuidInterface $id, string $name, GameParameters $rules)
67	66	{
68		return new self($id, $name, $rules);
69		}
70
71		/**
72		* @return UuidInterface
73	1	*/
74		public function id(): UuidInterface
75	1	{
76		return $this->id;
77		}
78
79		/**
80		* @return string
81	1	*/
82		public function name(): string
83	1	{
84		return $this->name;
85		}
86
87		/**
88		* @return GameParameters
89	4	*/
90		public function rules(): GameParameters
91	4	{
92		return $this->rules;
93		}
94
95		/**
96		* @return PlayerCollection
97	63	*/
98		public function players(): PlayerCollection
99	63	{
100		return $this->players;
101		}
102
103		/**
104		* @return string
105		*/
106		public function __toString(): string
107		{
108	62	return $this->name;
109		}
110	62
111		/**
112	62	* @return TableCollection
113		*/
114	59	public function tables(): TableCollection
115	62	{
116		return $this->tables;
117	62	}
118	1
119		/**
120		* @param Client $client
121	62	* @param Chips $buyinAmount
122	1	*
123		* @throws GameException
124		*/
125	61	public function registerPlayer(Client $client, Chips $buyinAmount = null)
126		{
127	61	$buyinAmount = $buyinAmount ?? $this->rules()->minimumBuyIn();
		0 ignored issues – show Bug introduced 2017-02-26 14:50 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Cysha\Casino\Game\Contracts\GameParameters` as the method `minimumBuyIn()` does only exist in the following implementations of said interface: `Cysha\Casino\Holdem\Game...ters\CashGameParameters`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
128	61
129	61	$playerRegistered = $this->players()
130		->filter(function (Client $player) use ($client) {
131		return $client->name() === $player->name();
132		});
133
134	2	if ($playerRegistered->count() !== 0) {
135		throw GameException::alreadyRegistered($client, $this);
136	2	}
137
138		if ($buyinAmount->amount() > $client->wallet()->amount()) {
139		throw GameException::insufficientFunds($client, $this);
140		}
141
142	57	$client->wallet()->subtract($buyinAmount);
143
144		$addPlayer = Player::fromClient($client, $buyinAmount);
145	57	$this->players()->push($addPlayer);
146		}
147	57
148	57	public function removePlayer(Client $client)
149		{
150	57	$player = $this->players()
151	57	->filter(function (Player $player) use ($client) {
152	57	return $player->name() === $client->name();
153		})
154		->first()
155		;
156
157	54	$client->wallet()->add($player->chipstack());
158
159	54	$this->players = $this->players()
160		->reject(function (Player $player) use ($client) {
161		return $player->name() === $client->name();
162		})
163		->values();
164		}
165
166		public function assignPlayersToTables()
167		{
168		$groupedPlayers = $this->players()
169		//->shuffle()
170		->chunk($this->rules()->tableSize())
171		->map(function (PlayerCollection $players) {
172		$dealer = Dealer::startWork(new Deck(), new SevenCard());
173
174		return Table::setUp($dealer, $players);
175		})
176		->toArray();
177
178		$this->tables = TableCollection::make($groupedPlayers);
179		}
180		}
181

Cysha / casino-holdem

Push — master ( 92fb9d...3bde59 )

CashGame A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

11 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like