Issues in pluginstore.php (master) - Issues in master - Cyberbyte-Studios/CyberWorks - Measure and Improve Code Quality continuously with Scrutinizer

Issues (501)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

views/core/pluginstore.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
if (file_exists("plugins")) {
    $plugins = json_decode(file_get_contents('http://cyberbyte.org.uk/hooks/cyberworks/plugins.php?id=' . $settings['id']), true);

    function downloadFile($url) {
        $newfname = realpath('downloading') . '/plugin.zip';
        $folder = realpath('plugins');
        $file = fopen($url, "rb");
        if ($file) {
            $newf = fopen($newfname, "wb");
            if ($newf) {
                while (!feof($file)) {
                    fwrite($newf, fread($file, 1024 * 8), 1024 * 8);
            }
                }
        }

        if ($file) {
            fclose($file);
        }
        if ($newf) {
            fclose($newf);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
        }

        $zip = new ZipArchive;
        $zip->open($newfname);
        $zip->extractTo($folder);
        $zip->close();
        rrmdir(realpath('downloading'));
    }

    /**
     * @param string $dir
     */
    function rrmdir($dir) {
        if (is_dir($dir)) {
            $objects = scandir($dir);
            foreach ($objects as $object) {
                if ($object != "." && $object != "..") {
                    if (filetype($dir . "/" . $object) == "dir") {
                        rrmdir($dir . "/" . $object);
                    } else {
                        unlink($dir . "/" . $object);
                    }
                }
            }
            reset($objects);
            rmdir($dir);
        }
    }

    if (isset($_GET['install'])) {
        $install = $_GET['install'];
        $key = array_search($install, array_column($plugins, 'dirname'));
        downloadFile($plugins[$key + 1]['url']);
    }

    if (isset($_GET['activate'])) {
        if (!in_array($_GET['activate'], $settings['plugins'])) {
            array_push($settings['plugins'], $_GET['activate']);
            $json = json_decode(file_get_contents('plugins/' . $_GET['activate'] . '/plugin.json'), true);
            if (isset($json['language']) && isset($json['short'])) {
                $lang = array($json['language'], $json['short']);
                array_push($settings['installedLanguage'], $lang);
            }
            if (isset($json['defaultSettings'])) {
                foreach ($json['defaultSettings'] as $key => $setting) {
                    $settings[$key] = $setting;

                }
            }
            file_put_contents('config/settings.php', '<?php return ' . var_export($settings, true) . ';');
            message($lang['pluginActivated']);
        } message($lang['activeAlready']);
    }

    if (isset($_GET['deactivate'])) {
        if (in_array($_GET['deactivate'], $settings['plugins'])) {
            if (array_count_values($settings['plugins']) <= 1) {
                $settings['plugins'] = array();
            } else {
                $settings['plugins'] = array_diff($settings['plugins'], array($_GET['deactivate']));
            }
            
            $json = json_decode(file_get_contents('plugins/' . $_GET['deactivate'] . '/plugin.json'), true);
            if (isset($json['language']) && isset($json['short'])) {
                $key = array_search($_GET['deactivate'], array_column($settings['installedLanguage'], 0));
                unset($settings['installedLanguage'][$key]);
            }
            file_put_contents('config/settings.php', '<?php return ' . var_export($settings, true) . ';');
        } message($lang['notActive']);
    }

    if (isset($_GET['delete'])) {
        rrmdir(realpath('plugins') . '/' . $_GET['delete']);
    }
    ?>

        <div class="row">
            <div class="col-lg-8">
                <h1 class="page-header">
                    <?php echo $lang['pluginstore']; ?>
                </h1>
            </div>
        </div>
    <?php
    if (!isset($plugins['verify'])) {
        echo "<form method='post' action='plugins' name='plugins'>";

        $files = scandir("plugins");
        unset($files[0]);
        unset($files[1]);

        foreach ($files as &$file) {
            $path = 'plugins/' . $file . '/plugin.json';
            $installed[] = json_decode(file_get_contents($path), true);
        }

        $dropIn = array_diff($files, array_column($plugins, 'dirname'));
        if ($dropIn > 0) echo "<h2 style='margin-top: 0;'>" . $lang['dropIn'] . "</h2>";
        
        foreach ($dropIn as &$plugin) {
            $key = array_search($plugin, array_column($installed, 'dirname'));
            echo '<div class="col-sm-6 col-md-4"><div class="thumbnail"><div class="caption">';
            echo '<h3>' . $installed[$key]['name'] . ' - ' . $installed[$key]['version'];

            if (in_array($plugin, $settings['plugins']))
            echo '<small style="padding-left: 6px;"><span class="label label-success">' . $lang['active'] . '</span></small>';
            else echo '<small style="padding-left: 6px;"><span class="label label-default">' . $lang['installed'] . '</span></small>';

            echo '</h3><p><strong>' . $installed[$key]['author'] . '</strong> - ' . $installed[$key]['description'] . '</p>';

            if (in_array($plugin, $settings['plugins']))
            echo '<p><a href="?deactivate=' . $plugin . '" class="btn btn-primary" role="button">' . $lang['deactivate'] . '</a>';
            else echo '<p><a href="?activate=' . $plugin . '" class="btn btn-primary" role="button">' . $lang['activate'] . '</a>';

            if (isset($installed[$key]['authurl'])) echo '<a style="margin-left: 5px;" href="' . $installed[$key]['authurl'] . '" class="btn btn-default" role="button">' . $lang['visitSite'] . '</a>';
            echo '<a style="float: right;" href="?delete=' . $plugin . '" class="btn btn-danger" role="button">' . $lang['delete'] . '</a>';
            echo '</p></div></div></div>';
        }
        echo "<div class='row'></div><h2>" . $lang['pluginstore'] . "</h2>";

        foreach ($plugins as &$plugin) {
            echo '<div class="col-sm-6 col-md-4"><div class="thumbnail">';
            echo '<img  src="' . $plugin['image'] . '" alt="' . $plugin['name'] . '">';
            echo '<div class="caption">';
            echo '<h3>' . $plugin['name'] . ' - ' . $plugin['version'];

            $key = array_search($plugin['dirname'], array_column($installed, 'dirname'));

            if ($key !== false) {
                if (in_array($plugin['dirname'], $settings['plugins'])) {
                    if ($plugin['version'] > $installed[$key]['version']) {
                        echo '<small style="padding-left: 6px;"><span class="label label-info">' . $lang['updateAvalible'] . '</span></small>';
                    }
                    // Update avalible
                    else {
                        echo '<small style="padding-left: 6px;"><span class="label label-success">' . $lang['active'] . '</span>';
                    }
                    // Active plugin
                } elseif (in_array($plugin['dirname'], $files)) {
                    echo '<small style="padding-left: 6px;"><span class="label label-default">' . $lang['installed'] . '</span></small>';
                }
                // Installed not active
            }
            echo '</h3><p><strong>' . $plugin['author'] . '</strong> - ' . $plugin['description'] . '</p>';

            if ($key !== false) {
                if (in_array($plugin['dirname'], $settings['plugins'])) {
                    if ($plugin['version'] > $installed[$key]['version']) {
                        echo '<div><a href="?install=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['update'] . '</a>';
                    }
                    // Update avalible
                    else {
                        echo '<p><a href="?deactivate=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['deactivate'] . '</a>';
                    }
                    // Active plugin
                } elseif (in_array($plugin['dirname'], $files)) {

                    echo '<p><a href="?activate=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['activate'] . '</a>';
                }
                // Installed not active
            } else {
                echo '<p><a href="?install=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['install'] . '</a>';
            }
            // Not installed

            if (isset($plugin['authurl'])) {
                echo '<a style="margin-left: 5px;" href="' . $plugin['authurl'] . '" class="btn btn-default" role="button">' . $lang['visitSite'] . '</a>';
            }
            if (in_array($plugin['dirname'], $files)) {

                echo '<a style="float: right;" href="?delete=' . $plugin['dirname'] . '" class="btn btn-danger" role="button">' . $lang['delete'] . '</a></div>';
            }
            echo '</div></div></div>';
        }

        echo '</div></div></form>';
    } else {
        echo '<h2>' . $lang['notverified'] . '</h2>';
    }
    } else {
    echo '<h2>' . $lang['noPlugin'] . '</h2>';
}



Issues (501)

Security Analysis not enabled

views/core/pluginstore.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

1		<?php
2		if (file_exists("plugins")) {
3		$plugins = json_decode(file_get_contents('http://cyberbyte.org.uk/hooks/cyberworks/plugins.php?id=' . $settings['id']), true);
4
5		function downloadFile($url) {
6		$newfname = realpath('downloading') . '/plugin.zip';
7		$folder = realpath('plugins');
8		$file = fopen($url, "rb");
9		if ($file) {
10		$newf = fopen($newfname, "wb");
11		if ($newf) {
12		while (!feof($file)) {
13		fwrite($newf, fread($file, 1024 * 8), 1024 * 8);
14		}
15		}
16		}
17
18		if ($file) {
19		fclose($file);
20		}
21		if ($newf) {
22		fclose($newf);
		0 ignored issues – show Bug introduced 2015-12-23 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this The variable `$newf` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
23		}
24
25		$zip = new ZipArchive;
26		$zip->open($newfname);
27		$zip->extractTo($folder);
28		$zip->close();
29		rrmdir(realpath('downloading'));
30		}
31
32		/**
33		* @param string $dir
34		*/
35		function rrmdir($dir) {
36		if (is_dir($dir)) {
37		$objects = scandir($dir);
38		foreach ($objects as $object) {
39		if ($object != "." && $object != "..") {
40		if (filetype($dir . "/" . $object) == "dir") {
41		rrmdir($dir . "/" . $object);
42		} else {
43		unlink($dir . "/" . $object);
44		}
45		}
46		}
47		reset($objects);
48		rmdir($dir);
49		}
50		}
51
52		if (isset($_GET['install'])) {
53		$install = $_GET['install'];
54		$key = array_search($install, array_column($plugins, 'dirname'));
55		downloadFile($plugins[$key + 1]['url']);
56		}
57
58		if (isset($_GET['activate'])) {
59		if (!in_array($_GET['activate'], $settings['plugins'])) {
60		array_push($settings['plugins'], $_GET['activate']);
61		$json = json_decode(file_get_contents('plugins/' . $_GET['activate'] . '/plugin.json'), true);
62		if (isset($json['language']) && isset($json['short'])) {
63		$lang = array($json['language'], $json['short']);
64		array_push($settings['installedLanguage'], $lang);
65		}
66		if (isset($json['defaultSettings'])) {
67		foreach ($json['defaultSettings'] as $key => $setting) {
68		$settings[$key] = $setting;
69
70		}
71		}
72		file_put_contents('config/settings.php', '<?php return ' . var_export($settings, true) . ';');
73		message($lang['pluginActivated']);
74		} message($lang['activeAlready']);
75		}
76
77		if (isset($_GET['deactivate'])) {
78		if (in_array($_GET['deactivate'], $settings['plugins'])) {
79		if (array_count_values($settings['plugins']) <= 1) {
80		$settings['plugins'] = array();
81		} else {
82		$settings['plugins'] = array_diff($settings['plugins'], array($_GET['deactivate']));
83		}
84
85		$json = json_decode(file_get_contents('plugins/' . $_GET['deactivate'] . '/plugin.json'), true);
86		if (isset($json['language']) && isset($json['short'])) {
87		$key = array_search($_GET['deactivate'], array_column($settings['installedLanguage'], 0));
88		unset($settings['installedLanguage'][$key]);
89		}
90		file_put_contents('config/settings.php', '<?php return ' . var_export($settings, true) . ';');
91		} message($lang['notActive']);
92		}
93
94		if (isset($_GET['delete'])) {
95		rrmdir(realpath('plugins') . '/' . $_GET['delete']);
96		}
97		?>
98
99		<div class="row">
100		<div class="col-lg-8">
101		<h1 class="page-header">
102		<?php echo $lang['pluginstore']; ?>
103		</h1>
104		</div>
105		</div>
106		<?php
107		if (!isset($plugins['verify'])) {
108		echo "<form method='post' action='plugins' name='plugins'>";
109
110		$files = scandir("plugins");
111		unset($files[0]);
112		unset($files[1]);
113
114		foreach ($files as &$file) {
115		$path = 'plugins/' . $file . '/plugin.json';
116		$installed[] = json_decode(file_get_contents($path), true);
117		}
118
119		$dropIn = array_diff($files, array_column($plugins, 'dirname'));
120		if ($dropIn > 0) echo "<h2 style='margin-top: 0;'>" . $lang['dropIn'] . "</h2>";
121
122		foreach ($dropIn as &$plugin) {
123		$key = array_search($plugin, array_column($installed, 'dirname'));
124		echo '<div class="col-sm-6 col-md-4"><div class="thumbnail"><div class="caption">';
125		echo '<h3>' . $installed[$key]['name'] . ' - ' . $installed[$key]['version'];
126
127		if (in_array($plugin, $settings['plugins']))
128		echo '<small style="padding-left: 6px;"><span class="label label-success">' . $lang['active'] . '</span></small>';
129		else echo '<small style="padding-left: 6px;"><span class="label label-default">' . $lang['installed'] . '</span></small>';
130
131		echo '</h3><p><strong>' . $installed[$key]['author'] . '</strong> - ' . $installed[$key]['description'] . '</p>';
132
133		if (in_array($plugin, $settings['plugins']))
134		echo '<p><a href="?deactivate=' . $plugin . '" class="btn btn-primary" role="button">' . $lang['deactivate'] . '</a>';
135		else echo '<p><a href="?activate=' . $plugin . '" class="btn btn-primary" role="button">' . $lang['activate'] . '</a>';
136
137		if (isset($installed[$key]['authurl'])) echo '<a style="margin-left: 5px;" href="' . $installed[$key]['authurl'] . '" class="btn btn-default" role="button">' . $lang['visitSite'] . '</a>';
138		echo '<a style="float: right;" href="?delete=' . $plugin . '" class="btn btn-danger" role="button">' . $lang['delete'] . '</a>';
139		echo '</p></div></div></div>';
140		}
141		echo "<div class='row'></div><h2>" . $lang['pluginstore'] . "</h2>";
142
143		foreach ($plugins as &$plugin) {
144		echo '<div class="col-sm-6 col-md-4"><div class="thumbnail">';
145		echo '<img src="' . $plugin['image'] . '" alt="' . $plugin['name'] . '">';
146		echo '<div class="caption">';
147		echo '<h3>' . $plugin['name'] . ' - ' . $plugin['version'];
148
149		$key = array_search($plugin['dirname'], array_column($installed, 'dirname'));
150
151		if ($key !== false) {
152		if (in_array($plugin['dirname'], $settings['plugins'])) {
153		if ($plugin['version'] > $installed[$key]['version']) {
154		echo '<small style="padding-left: 6px;"><span class="label label-info">' . $lang['updateAvalible'] . '</span></small>';
155		}
156		// Update avalible
157		else {
158		echo '<small style="padding-left: 6px;"><span class="label label-success">' . $lang['active'] . '</span>';
159		}
160		// Active plugin
161		} elseif (in_array($plugin['dirname'], $files)) {
162		echo '<small style="padding-left: 6px;"><span class="label label-default">' . $lang['installed'] . '</span></small>';
163		}
164		// Installed not active
165		}
166		echo '</h3><p><strong>' . $plugin['author'] . '</strong> - ' . $plugin['description'] . '</p>';
167
168		if ($key !== false) {
169		if (in_array($plugin['dirname'], $settings['plugins'])) {
170		if ($plugin['version'] > $installed[$key]['version']) {
171		echo '<div><a href="?install=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['update'] . '</a>';
172		}
173		// Update avalible
174		else {
175		echo '<p><a href="?deactivate=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['deactivate'] . '</a>';
176		}
177		// Active plugin
178	View Code Duplication	} elseif (in_array($plugin['dirname'], $files)) {
		0 ignored issues – show Duplication introduced 2015-12-23 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
179		echo '<p><a href="?activate=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['activate'] . '</a>';
180		}
181		// Installed not active
182		} else {
183		echo '<p><a href="?install=' . $plugin['dirname'] . '" class="btn btn-primary" role="button">' . $lang['install'] . '</a>';
184		}
185		// Not installed
186
187		if (isset($plugin['authurl'])) {
188		echo '<a style="margin-left: 5px;" href="' . $plugin['authurl'] . '" class="btn btn-default" role="button">' . $lang['visitSite'] . '</a>';
189		}
190	View Code Duplication	if (in_array($plugin['dirname'], $files)) {
		0 ignored issues – show Duplication introduced 2015-12-23 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
191		echo '<a style="float: right;" href="?delete=' . $plugin['dirname'] . '" class="btn btn-danger" role="button">' . $lang['delete'] . '</a></div>';
192		}
193		echo '</div></div></div>';
194		}
195
196		echo '</div></div></form>';
197		} else {
198		echo '<h2>' . $lang['notverified'] . '</h2>';
199		}
200		} else {
201		echo '<h2>' . $lang['noPlugin'] . '</h2>';
202		}
		0 ignored issues – show Coding Style introduced 2015-12-23 09:33 UTC by Report Bug Copy Issue Report Show Similar Issues like this As per coding style, files should not end with a newline character. This check marks files that end in a newline character, i.e. an empy line. Loading history...
203

Cyberbyte-Studios / CyberWorks

Issues (501)

Security Analysis not enabled

views/core/pluginstore.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like