IpNetCalc\IpNetCalc

Complexity

Total Complexity

21

Size/Duplication

Total Lines	116
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Test Coverage

Coverage

98.55%

Importance

Changes	2
Bugs	0	Features	1

3 Methods

Rating	Name	Duplication	Size	Complexity
D	calcNetSum()	0	70	16
A	bitCalcIP()	0	16	3
A	handleV6()	0	11	2

<?php

namespace IpNetCalc;

/**
 * Class IpNetCalc
 *
 * Compute the common mask from multiple IP addresses
 *
 * @author Alexander Over <cyberline@php.net>
 */
class IpNetCalc
{
    /**
     * @param array $ips
     * @return string
     */
    public function calcNetSum(array $ips)

This operation has 9600 execution paths which exceeds the configured maximum of 200.

    {
        if (count($ips) < 2) {
            throw new \InvalidArgumentException('too few arguments');
        }

        $validated = $n = $s = [];

Avoid variables with short names like $n. Configured minimum length is 3.

Avoid variables with short names like $s. Configured minimum length is 3.

        $isV4 = $isV6 = false;

        foreach ($ips as $ip) {
            if (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4) && !$isV6) {
                $isV4 = true;
                $validated[] = $ip;
            } elseif (filter_var($ip, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6) && !$isV4) {
                $isV6 = true;
                $validated[] = $ip;
            } else {

The method calcNetSum uses an else expression. Else is never necessary and you can simplify the code to work without else.

                throw new \InvalidArgumentException('mixing of IPs not allowed');
            }
        }

        $mask = (($isV4) ? 32 : 128);
        $ipType = (($isV4) ? 4 : 6);

        asort($validated);

        // we need only smalest and biggest ip
        $compare = [
            array_shift($validated),
            array_pop($validated)
        ];

        foreach ($compare as $key => $ip) {
            $s[$key] = implode('', $this->bitCalcIP($ip, $ipType));
        }

        $t = '';

Avoid variables with short names like $t. Configured minimum length is 3.

        if ($s[0] === $s[1]) {
            $t = $s[0];
            $i = $mask;
        } else {

The method calcNetSum uses an else expression. Else is never necessary and you can simplify the code to work without else.

            $o = '';

Avoid variables with short names like $o. Configured minimum length is 3.

            for ($i = 0, $len = strlen($s[0]); $i < $len; $i++) {
                if (substr($s[0], $i, 1) == substr($s[1], $i, 1)) {
                    $o .= substr($s[0], $i, 1);
                } else {

The method calcNetSum uses an else expression. Else is never necessary and you can simplify the code to work without else.

                    $t = str_pad($o, $mask, 0, STR_PAD_RIGHT);
                    break;
                }
            }
        }

        $q = str_split($t, 8);

Avoid variables with short names like $q. Configured minimum length is 3.

        if ($isV4) {
            foreach ($q as $b) {
                $n[] = bindec($b);
            }
            $n = implode('.', $n);
        } else {

The method calcNetSum uses an else expression. Else is never necessary and you can simplify the code to work without else.

            for ($j = 0, $len = count($q); $j < $len; $j += 2) {
                $n[$j] = dechex(bindec($q[$j])) .
                    str_pad(dechex(bindec($q[$j + 1])), 2, 0, STR_PAD_LEFT);
            }
            $n = inet_ntop(inet_pton(implode(':', $n)));
        }

        return $n . '/' . $i;
    }

    /**
     * @param string $ip
     * @param integer $ipType
     *
     * @return array
     */
    private function bitCalcIP($ip, $ipType)

Avoid variables with short names like $ip. Configured minimum length is 3.

    {
        $r = [];

Avoid variables with short names like $r. Configured minimum length is 3.

        if (6 == $ipType) {
            $e = $this->handleV6($ip);

Avoid variables with short names like $e. Configured minimum length is 3.

        } else {

The method bitCalcIP uses an else expression. Else is never necessary and you can simplify the code to work without else.

            $e = explode('.', $ip);
        }

        foreach ($e as $b) {
            $r[] = str_pad(decbin($b), 8, 0, STR_PAD_LEFT);
        }

        return $r;
    }

    /**
     * @param string $ip
     * @return array
     */
    private function handleV6($ip)

Avoid variables with short names like $ip. Configured minimum length is 3.

    {
        $n = [];

Avoid variables with short names like $n. Configured minimum length is 3.

        $unpack = unpack('H*', inet_pton($ip));
        $e = str_split($unpack[1], 4);

Avoid variables with short names like $e. Configured minimum length is 3.

        for ($i = 0; $i < 8; $i++) {
            $n[] = hexdec(substr($e[$i], 0, 2));
            $n[] = hexdec(substr($e[$i], 2, 2));
        }
        return $n;
    }
}