MetaStalk.utils.parse.gps_parse() - Code Metrics - Inspection of "Fixed post release version issue" - Cyb3r-Jak3/MetaStalk - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 929827...929f74 )

by Cyb3r

created 2020-05-08 22:44 UTC

MetaStalk.utils.parse.gps_parse() A

↳ Parent: MetaStalk.utils.parse

Complexity

Conditions

Size

Total Lines	15
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	5.0729

Importance

Changes

Metric	Value
cc	5
eloc	14
nop	1
dl	0
loc	15
ccs	12
cts	14
cp	0.8571
crap	5.0729
rs	9.2333
c	0
b	0
f	0

"""utils.parse
---
Parse needed to make exifread dictionaries easier"""


def gps_parse(tags: dict):
    """Returns GPS degrees"""
    latitude = tags["GPS GPSLatitude"]
    latitude_ref = tags["GPS GPSLatitudeRef"]
    longitude = tags["GPS GPSLongitude"]
    longitude_ref = tags["GPS GPSLongitudeRef"]
    if latitude:
        lat_value = _convert_to_degrees(latitude)
        if latitude_ref.values != 'N':
            lat_value = -lat_value
    if longitude:
        lon_value = _convert_to_degrees(longitude)
        if longitude_ref.values != 'E':
            lon_value = -lon_value
    return {'latitude': lat_value, 'longitude': lon_value}



def _convert_to_degrees(value) -> float:
    """
    Helper function to convert the GPS coordinates stored in the EXIF to degrees in float format
    :param value:
    :type value: exifread.utils.Ratio
    """
    d = float(value.values[0].num) / float(value.values[0].den)
    m = float(value.values[1].num) / float(value.values[1].den)
    s = float(value.values[2].num) / float(value.values[2].den)

    return d + (m / 60.0) + (s / 3600.0)


1		"""utils.parse
2		---
3		Parse needed to make exifread dictionaries easier"""
4
5
6	1	def gps_parse(tags: dict):
7		"""Returns GPS degrees"""
8	1	latitude = tags["GPS GPSLatitude"]
9	1	latitude_ref = tags["GPS GPSLatitudeRef"]
10	1	longitude = tags["GPS GPSLongitude"]
11	1	longitude_ref = tags["GPS GPSLongitudeRef"]
12	1	if latitude:
13	1	lat_value = _convert_to_degrees(latitude)
14	1	if latitude_ref.values != 'N':
15		lat_value = -lat_value
16	1	if longitude:
17	1	lon_value = _convert_to_degrees(longitude)
18	1	if longitude_ref.values != 'E':
19		lon_value = -lon_value
20	1	return {'latitude': lat_value, 'longitude': lon_value}
		2 ignored issues – show introduced 2020-05-08 22:46 UTC by Report Bug Copy Issue Report The variable `lat_value` does not seem to be defined in case `latitude` on line `12` is `False`. Are you sure this can never be the case? Loading history... introduced 2020-05-08 22:46 UTC by Report Bug Copy Issue Report The variable `lon_value` does not seem to be defined in case `longitude` on line `16` is `False`. Are you sure this can never be the case? Loading history...
21
22
23	1	def _convert_to_degrees(value) -> float:
24		"""
25		Helper function to convert the GPS coordinates stored in the EXIF to degrees in float format
26		:param value:
27		:type value: exifread.utils.Ratio
28		"""
29	1	d = float(value.values[0].num) / float(value.values[0].den)
30	1	m = float(value.values[1].num) / float(value.values[1].den)
31	1	s = float(value.values[2].num) / float(value.values[2].den)
32
33		return d + (m / 60.0) + (s / 3600.0)
34

Cyb3r-Jak3 / MetaStalk

Push — master ( 929827...929f74 )

MetaStalk.utils.parse.gps_parse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like