NotificationFlexFormProcessor::getFlexFormDS_postProcessDS()

Complexity

Conditions	11
Paths	18

Size

Total Lines	47
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function getFlexFormDS_postProcessDS(&$flexFormArray, $conf, $row, $table, $fieldName)
    {
        $flag = false;

        foreach (self::$handledTables as $handledTable => $handledField) {
            if ($handledTable === $table
                && $handledField === $fieldName
                && 0 !== $row['sys_language_uid']
            ) {
                $flag = true;
                break;
            }
        }

        if (!$flag) {
            return;
        }

        $parent = $this->getDatabaseConnection()
            ->exec_SELECTgetSingleRow(
                'event',
                $table,
                'uid=' . (int)$row['l10n_parent']
            );

        if (!$parent) {
            return;
        }

        $event = $parent['event'];

        if (!isset($conf['ds'][$event])) {
            return;
        }

        $ds = $conf['ds'][$event];

        if (substr($ds, 0, 5) == 'FILE:') {
            $file = GeneralUtility::getFileAbsFileName(substr($ds, 5));

            if ($file && @is_file($file)) {
                $flexFormArray = GeneralUtility::xml2array(GeneralUtility::getUrl($file));

It seems like TYPO3\CMS\Core\Utility\GeneralUtility::getUrl($file) can also be of type false; however, parameter $string of TYPO3\CMS\Core\Utility\GeneralUtility::xml2array() does only seem to accept string, maybe add an additional type check?

            } else {
                $flexFormArray = 'The file "' . substr($ds, 5) . '" in ds-array key "' . $event . '" was not found ("' . $file . '")';
            }
        } else {
            $flexFormArray = GeneralUtility::xml2array($ds);
        }