ShowExceptionController::injectRuntimeService() - Code Metrics - Inspection of "[TASK] Extract exception handling to dedicated con..." - CuyZ/NotiZ - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 8c9c0f...ddad7d )

by Nathan

created 2018-09-25 16:39 UTC

ShowExceptionController::injectRuntimeService() A

↳ Parent: ShowExceptionController

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
rs	10
c	0
b	0
f	0

<?php

/*
 * Copyright (C) 2018
 * Nathan Boiron <[email protected]>
 * Romain Canon <[email protected]>
 *
 * This file is part of the TYPO3 NotiZ project.
 * It is free software; you can redistribute it and/or modify it
 * under the terms of the GNU General Public License, either
 * version 3 of the License, or any later version.
 *
 * For the full copyright and license information, see:
 * http://www.gnu.org/licenses/gpl-3.0.html
 */

namespace CuyZ\Notiz\Controller\Backend\Administration;

use CuyZ\Notiz\Controller\Backend\BackendController;
use CuyZ\Notiz\Controller\Backend\Menu;
use CuyZ\Notiz\Service\RuntimeService;
use Throwable;

class ShowExceptionController extends BackendController
{
    /**
     * @var RuntimeService
     */
    protected $runtimeService;

    /**
     * This action will be called if an exception was thrown during the building
     * of the definition. The exception will be displayed, using TYPO3 core
     * exception handling.
     *
     * @throws Throwable
     */
    public function processAction()
    {
        $exception = $this->runtimeService->getException();

        if (!$exception) {

            $this->forward('process', 'ShowDefinition');
        }

        throw $exception;
    }

    /**
     * @inheritdoc
     */
    protected function getMenu()
    {
        return Menu::ADMINISTRATION_DEFINITION;
    }

    /**
     * @param RuntimeService $runtimeService
     */
    public function injectRuntimeService(RuntimeService $runtimeService)
    {
        $this->runtimeService = $runtimeService;
    }
}


1			<?php
2
3			/*
4			* Copyright (C) 2018
5			* Nathan Boiron <[email protected]>
6			* Romain Canon <[email protected]>
7			*
8			* This file is part of the TYPO3 NotiZ project.
9			* It is free software; you can redistribute it and/or modify it
10			* under the terms of the GNU General Public License, either
11			* version 3 of the License, or any later version.
12			*
13			* For the full copyright and license information, see:
14			* http://www.gnu.org/licenses/gpl-3.0.html
15			*/
16
17			namespace CuyZ\Notiz\Controller\Backend\Administration;
18
19			use CuyZ\Notiz\Controller\Backend\BackendController;
20			use CuyZ\Notiz\Controller\Backend\Menu;
21			use CuyZ\Notiz\Service\RuntimeService;
22			use Throwable;
23
24			class ShowExceptionController extends BackendController
25			{
26			/**
27			* @var RuntimeService
28			*/
29			protected $runtimeService;
30
31			/**
32			* This action will be called if an exception was thrown during the building
33			* of the definition. The exception will be displayed, using TYPO3 core
34			* exception handling.
35			*
36			* @throws Throwable
37			*/
38			public function processAction()
39			{
40			$exception = $this->runtimeService->getException();
41
42			if (!$exception) {
			0 ignored issues – show introduced 2018-04-09 12:11 UTC by Report Bug Copy Issue Report `$exception` is of type `Throwable`, thus it always evaluated to `true`. Loading history...
43			$this->forward('process', 'ShowDefinition');
44			}
45
46			throw $exception;
47			}
48
49			/**
50			* @inheritdoc
51			*/
52			protected function getMenu()
53			{
54			return Menu::ADMINISTRATION_DEFINITION;
55			}
56
57			/**
58			* @param RuntimeService $runtimeService
59			*/
60			public function injectRuntimeService(RuntimeService $runtimeService)
61			{
62			$this->runtimeService = $runtimeService;
63			}
64			}
65

CuyZ / NotiZ

Push — master ( 8c9c0f...ddad7d )

ShowExceptionController::injectRuntimeService() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like