Link::formatCell() - Code Metrics - Inspection of "Adding renderer context" - CrossKnowledge/DataTableBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

unknown

created 2016-04-29 09:06 UTC

Link::formatCell() A

↳ Parent: Link

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	0
cts	4
cp	0
rs	9.4285
cc	1
eloc	4
nc	1
nop	3
crap	2

<?php

namespace CrossKnowledge\DataTableBundle\DataTable\Table\Element\Column;

use Symfony\Component\OptionsResolver\Options;
use Symfony\Component\OptionsResolver\OptionsResolver;

class Link extends Column
{
    public function configureOptions(OptionsResolver $resolver)
    {
        parent::configureOptions($resolver);
        $resolver->setRequired('LinkTextField');
        $resolver->setDefault('AltTextField', function (Options $options) {
            return $options['LinkTextField'];
        });
        $resolver->setDefault('UrlField', function (Options $options) {
            return $options['LinkTextField'];
        });
        $resolver->setDefault('UrlCallback', function($value, $row) {

            return $row[$this->options['UrlField']];
        });
        $resolver->setAllowedTypes('UrlCallback', ['\Closure']);
    }
    /**
     * Build a link
     */
    public function formatCell($value, array $rowData, $context)
    {
        $value = parent::formatCell($value, $rowData);

        $url = call_user_func_array($this->options['UrlCallback'], [$value, $rowData]);
        return '<a href="'.$url.'" alt="'.$rowData[$this->options['LinkTextField']].'">'.$rowData[$this->options['LinkTextField']].'</a>';
    }
}


1		<?php
2
3		namespace CrossKnowledge\DataTableBundle\DataTable\Table\Element\Column;
4
5		use Symfony\Component\OptionsResolver\Options;
6		use Symfony\Component\OptionsResolver\OptionsResolver;
7
8		class Link extends Column
9		{
10	3	public function configureOptions(OptionsResolver $resolver)
11		{
12	3	parent::configureOptions($resolver);
13	3	$resolver->setRequired('LinkTextField');
14	3	$resolver->setDefault('AltTextField', function (Options $options) {
15	3	return $options['LinkTextField'];
16	3	});
17	3	$resolver->setDefault('UrlField', function (Options $options) {
18	1	return $options['LinkTextField'];
19	3	});
20	3	$resolver->setDefault('UrlCallback', function($value, $row) {
		0 ignored issues – show Coding Style introduced 2016-03-25 09:52 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
21		return $row[$this->options['UrlField']];
22	3	});
23	3	$resolver->setAllowedTypes('UrlCallback', ['\Closure']);
24	3	}
25		/**
26		* Build a link
27		*/
28		public function formatCell($value, array $rowData, $context)
29		{
30		$value = parent::formatCell($value, $rowData);
		0 ignored issues – show Bug introduced 2016-04-29 09:17 UTC by Report Bug Copy Issue Report The call to `formatCell()` misses a required argument `$context`. This check looks for function calls that miss required arguments. Loading history...
31		$url = call_user_func_array($this->options['UrlCallback'], [$value, $rowData]);
32		return '<a href="'.$url.'" alt="'.$rowData[$this->options['LinkTextField']].'">'.$rowData[$this->options['LinkTextField']].'</a>';
33		}
34		}
35

CrossKnowledge / DataTableBundle

GitHub Access Token became invalid

Pull Request — master (#6)

Link::formatCell() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like