Overflowable - Code Metrics - Inspection of "Merge pull request #9 from CraftLogan/add-macro-re..." - CraftLogan/Laravel-Overflow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( feab26...f63281 )

by Logan H.

created 2020-01-29 16:15 UTC

Overflowable A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	20 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	5
lcom	1
cbo	0
dl	7
loc	35
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	allWithOverflow()	0	5	1
A	getColumns()	0	6	1
A	getTableColumns()	0	4	1
A	getColumnNames()	0	6	1
A	overflow()	7	7	1

How to fix Duplicated Code

<?php

namespace CraftLogan\LaravelOverflow;
use Illuminate\Support\Facades\Schema;

trait Overflowable{

    public function allWithOverflow()
    {
        $properties[$this->overflow_column] = $this->overflow();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return array_merge($properties, $this->getColumns());
    }

    public function getColumns()
    {
        $columnNames = $this->getColumnNames();
        $attributes = array_intersect_key($this->request->all(), $columnNames);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        return $attributes;
    }

    public function overflow()

    {
        $columnNames = $this->getColumnNames();
        $attributes = array_diff_key($this->request->all(), $columnNames);
        $attributes = json_encode($attributes);
        return $attributes;
    }

    public function getTableColumns()
    {
        return Schema::getColumnListing($this->model->getTable());
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    public function getColumnNames()
    {
        $columnNames = $this->getTableColumns();
        $columnNames = array_fill_keys($columnNames, "");
        return $columnNames;
    }
}


1		<?php
2
3		namespace CraftLogan\LaravelOverflow;
4		use Illuminate\Support\Facades\Schema;
5
6		trait Overflowable{
7
8		public function allWithOverflow()
9		{
10		$properties[$this->overflow_column] = $this->overflow();
		0 ignored issues – show Bug introduced 2020-01-09 19:34 UTC by Report Bug Copy Issue Report The property `overflow_column` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Coding Style Comprehensibility introduced 2020-01-09 19:34 UTC by Report Bug Copy Issue Report `$properties` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$properties = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
11		return array_merge($properties, $this->getColumns());
12		}
13
14		public function getColumns()
15		{
16		$columnNames = $this->getColumnNames();
17		$attributes = array_intersect_key($this->request->all(), $columnNames);
		0 ignored issues – show Bug introduced 2020-01-29 16:14 UTC by Report Bug Copy Issue Report The property `request` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18		return $attributes;
19		}
20
21	View Code Duplication	public function overflow()
		0 ignored issues – show Duplication introduced 2020-01-29 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
22		{
23		$columnNames = $this->getColumnNames();
24		$attributes = array_diff_key($this->request->all(), $columnNames);
25		$attributes = json_encode($attributes);
26		return $attributes;
27		}
28
29		public function getTableColumns()
30		{
31		return Schema::getColumnListing($this->model->getTable());
		0 ignored issues – show Bug introduced 2020-01-29 16:14 UTC by Report Bug Copy Issue Report The property `model` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
32		}
33
34		public function getColumnNames()
35		{
36		$columnNames = $this->getTableColumns();
37		$columnNames = array_fill_keys($columnNames, "");
38		return $columnNames;
39		}
40		}
41

CraftLogan / Laravel-Overflow

Push — master ( feab26...f63281 )

Overflowable A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like