App\Model\Picture

Complexity

Total Complexity

13

Size/Duplication

Total Lines	80
Duplicated Lines	0 %

Test Coverage

Coverage

60.71%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	getAbsolutePath()	0	3	1
A	getUploadDir()	0	5	1
A	getWebPath()	0	3	1
A	getFile()	0	3	1
A	setFile()	0	10	3
A	jsonSerialize()	0	4	1
A	getPath()	0	3	1
A	getName()	0	3	1
A	setName()	0	5	1
A	getUploadRootDir()	0	3	1
A	setPath()	0	5	1

<?php

namespace App\Model;

use Symfony\Component\HttpFoundation\File\UploadedFile;

abstract class Picture implements \JsonSerializable
{
    const UPLOAD_DIR = 'images/uploads';
    
    /** @var string **/
    protected $name;
    /** @var string **/
    protected $path;
    /** @var File */

The type App\Model\File was not found. Maybe you did not declare it correctly or list all dependencies?

    protected $file;
    /** @var resource **/
    protected $temp;
    
    public function setName(string $name): Picture
    {
        $this->name = $name;
        
        return $this;
    }

    public function getName(): string
    {
        return $this->name;
    }
    
    public function setPath(string $path): Picture
    {
        $this->path = $path;
        
        return $this;
    }
    
    public function getPath(): string
    {
        return $this->path;
    }
    
    public function setFile(UploadedFile $file = null): Picture
    {
        $this->file = $file;

It seems like $file can also be of type Symfony\Component\HttpFoundation\File\UploadedFile. However, the property $file is declared as type App\Model\File. Maybe add an additional type check?

        // check if we have an old image path
        if ($this->file !== null && is_file($this->getAbsolutePath())) {
            // store the old name to delete after the update
            $this->temp = $this->getAbsolutePath();

It seems like $this->getAbsolutePath() of type string is incompatible with the declared type resource of property $temp.

            $this->path = null;
        }
        return $this;
    }
    
    public function getFile(): UploadedFile
    {
        return $this->file;
    }
    
    public function getAbsolutePath(): string
    {
        return $this->getUploadRootDir() . '/' . $this->path;
    }
    
    public function getWebPath(): string
    {
        return $this->getUploadDir() . '/' . $this->path;
    }
    
    public function getUploadDir(): string
    {
        // the absolute directory path where uploaded
        // documents should be saved
        return '/' . self::UPLOAD_DIR;
    }
    
    public function getUploadRootDir(): string
    {
        return __DIR__ . '/../../public/' . self::UPLOAD_DIR;
    }
    
    public function jsonSerialize(): array
    {
        return [
            'path' => $this->getWebPath()
        ];
    }
    
}