ProjectConfig - Code Metrics - Inspection of "Merge pull request #99 from aadmathijssen/hotfix-u..." - Cotya/magento-composer-installer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.0 ( 624c58...bf7aea )

by Daniel

created 2016-03-08 20:22 UTC

ProjectConfig C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	449
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

52.45%

Importance

Changes	6
Bugs	1	Features	1

Metric	Value
wmc	56
c	6
b	1
f	1
lcom	1
cbo	3
dl	0
loc	449
ccs	75
cts	143
cp	0.5245
rs	6.5957

38 Methods

Rating	Name	Size	Complexity
A	fetchVarFromExtraConfig()	4	1
A	getLibraryPath()	4	1
A	getLibraryConfigByPackagename()	4	1
A	setMagentoRootDir()	4	1
A	hasMagentoRootDir()	4	1
A	getMagentoVarDir()	4	1
A	setDeployStrategy()	4	1
A	getDeployStrategy()	4	1
A	hasDeployStrategy()	4	1
A	hasDeployStrategyOverwrite()	4	1
A	hasMagentoDeployIgnore()	4	1
A	setMagentoForce()	4	1
A	getMagentoForce()	4	1
A	hasMagentoForce()	4	1
A	getMagentoForceByPackageName()	4	1
A	hasAutoAppendGitignore()	4	1
A	getPathMappingTranslations()	4	1
A	hasPathMappingTranslations()	4	1
A	hasExtraField()	4	1
A	transformArrayKeysToLowerCase()	4	1
A	getComposerRepositories()	4	1
A	mustApplyBootstrapPatch()	4	1
A	skipSuggestComposerRepositories()	4	1
A	getModuleSpecificDeployIgnores()	17	4
A	__construct()	9	2
A	fetchVarFromConfigArray()	10	2
A	applyMagentoConfig()	5	1
A	getMagentoRootDir()	12	1
A	getDeployStrategyOverwrite()	6	1
A	getModuleSpecificDeployStrategy()	10	2
A	getModuleSpecificSortValue()	13	3
A	getMagentoDeployIgnore()	6	1
A	getMagentoDeployOverwrite()	6	1
A	getMagentoMapOverwrite()	6	1
A	updateExtraConfig()	5	1
C	updateExtraJson()	32	8
A	updateFileCleanly()	16	3
A	getVendorDir()	8	2

How to fix Complexity

<?php
/**
 *
 *
 *
 *
 */

namespace MagentoHackathon\Composer\Magento;

use Composer\Factory;
use Composer\Json\JsonFile;
use Composer\Json\JsonManipulator;
use SebastianBergmann\Exporter\Exception;

class ProjectConfig
{
    // Config Keys
    const EXTRA_KEY = 'extra';

    const SORT_PRIORITY_KEY = 'magento-deploy-sort-priority';

    const MAGENTO_ROOT_DIR_KEY = 'magento-root-dir';

    const MAGENTO_PROJECT_KEY = 'magento-project';

    const MAGENTO_DEPLOY_STRATEGY_KEY = 'magento-deploystrategy';
    const MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY = 'magento-deploystrategy-overwrite';
    const MAGENTO_MAP_OVERWRITE_KEY = 'magento-map-overwrite';
    const MAGENTO_DEPLOY_IGNORE_KEY = 'magento-deploy-ignore';

    const MAGENTO_FORCE_KEY = 'magento-force';

    const AUTO_APPEND_GITIGNORE_KEY = 'auto-append-gitignore';

    const PATH_MAPPINGS_TRANSLATIONS_KEY = 'path-mapping-translations';

    // Default Values
    const DEFAULT_MAGENTO_ROOT_DIR = 'root';

    const EXTRA_WITH_BOOTSTRAP_PATCH_KEY = 'with-bootstrap-patch';

    const EXTRA_WITH_SKIP_SUGGEST_KEY = 'skip-suggest-repositories';

    protected $libraryPath;
    protected $libraryPackages;
    protected $extra;
    protected $composerConfig;

    /**
     * @param array $extra
     * @param array $composerConfig
     */
    public function __construct(array $extra, array $composerConfig)
    {
        $this->extra = $extra;
        $this->composerConfig = $composerConfig;

        if (!is_null($projectConfig = $this->fetchVarFromConfigArray($this->extra, self::MAGENTO_PROJECT_KEY))) {
            $this->applyMagentoConfig($projectConfig);
        }
    }

    /**
     * @param array $array
     * @param string|integer $key
     * @param mixed $default
     *
     * @return mixed
     */
    protected function fetchVarFromConfigArray($array, $key, $default = null)
    {
        $array = (array)$array;
        $result = $default;
        if (isset($array[$key])) {
            $result = $array[$key];
        }

        return $result;
    }

    /**
     * @param      $key
     * @param null $default
     *
     * @return null
     */
    protected function fetchVarFromExtraConfig($key, $default = null)
    {
        return $this->fetchVarFromConfigArray($this->extra, $key, $default);
    }

    /**
     * @param $config
     */
    protected function applyMagentoConfig($config)
    {
        $this->libraryPath = $this->fetchVarFromConfigArray($config, 'libraryPath');
        $this->libraryPackages = $this->fetchVarFromConfigArray($config, 'libraries');
    }

    /**
     * @return mixed
     */
    public function getLibraryPath()
    {
        return $this->libraryPath;
    }

    /**
     * @param $packagename
     *
     * @return null
     */
    public function getLibraryConfigByPackagename($packagename)
    {
        return $this->fetchVarFromConfigArray($this->libraryPackages, $packagename);
    }

    /**
     * @return string
     */
    public function getMagentoRootDir()
    {
        return rtrim(
            trim(
                $this->fetchVarFromExtraConfig(
                    self::MAGENTO_ROOT_DIR_KEY,
                    self::DEFAULT_MAGENTO_ROOT_DIR
                )
            ),
            DIRECTORY_SEPARATOR
        );
    }

    /**
     * @param $rootDir
     */
    public function setMagentoRootDir($rootDir)
    {
        $this->updateExtraConfig(self::MAGENTO_ROOT_DIR_KEY, rtrim(trim($rootDir), DIRECTORY_SEPARATOR));
    }

    /**
     * @return bool
     */
    public function hasMagentoRootDir()
    {
        return $this->hasExtraField(self::MAGENTO_ROOT_DIR_KEY);
    }

    public function getMagentoVarDir()
    {
        return $this->getMagentoRootDir().'var'.DIRECTORY_SEPARATOR;
    }

    /**
     * @param $deployStrategy
     */
    public function setDeployStrategy($deployStrategy)
    {
        $this->updateExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_KEY, trim($deployStrategy));
    }

    /**
     * @return string
     */
    public function getDeployStrategy()
    {
        return trim((string)$this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_KEY));
    }

    /**
     * @return bool
     */
    public function hasDeployStrategy()
    {
        return $this->hasExtraField(self::MAGENTO_DEPLOY_STRATEGY_KEY);
    }

    /**
     * @return array
     */
    public function getDeployStrategyOverwrite()
    {
        return (array)$this->transformArrayKeysToLowerCase(
            $this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY, array())
        );
    }

    /**
     * @return bool
     */
    public function hasDeployStrategyOverwrite()
    {
        return $this->hasExtraField(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY);
    }

    /**
     * @param $packagename
     *
     * @return integer
     */
    public function getModuleSpecificDeployStrategy($packagename)
    {
        $moduleSpecificDeployStrategies = $this->getDeployStrategyOverwrite();

        $strategyName = $this->getDeployStrategy();
        if (isset($moduleSpecificDeployStrategies[$packagename])) {
            $strategyName = $moduleSpecificDeployStrategies[$packagename];
        }
        return $strategyName;
    }

    /**
     * @param $packagename
     *
     * @return integer
     */
    public function getModuleSpecificSortValue($packagename)
    {
        $sortPriorityArray = $this->fetchVarFromExtraConfig(self::SORT_PRIORITY_KEY, array());
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
        if (isset($sortPriorityArray[$packagename])) {
            $sortValue = $sortPriorityArray[$packagename];
        } else {
            $sortValue = 100;
            if ($this->getModuleSpecificDeployStrategy($packagename) === 'copy') {

                $sortValue++;
            }
        }
        return $sortValue;
    }

    /**
     * @return array
     */
    public function getMagentoDeployIgnore()
    {
        return (array)$this->transformArrayKeysToLowerCase(
            $this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_IGNORE_KEY)
        );
    }

    /**
     * @param $packagename
     *
     * @return array
     */
    public function getModuleSpecificDeployIgnores($packagename)
    {
        $moduleSpecificDeployIgnores = array();
        if ($this->hasMagentoDeployIgnore()) {
            $magentoDeployIgnore = $this->getMagentoDeployIgnore();
            if (isset($magentoDeployIgnore['*'])) {
                $moduleSpecificDeployIgnores = $magentoDeployIgnore['*'];
            }
            if (isset($magentoDeployIgnore[$packagename])) {
                $moduleSpecificDeployIgnores = array_merge(
                    $moduleSpecificDeployIgnores,
                    $magentoDeployIgnore[$packagename]
                );
            }
        }
        return $moduleSpecificDeployIgnores;
    }

    /**
     * @return bool
     */
    public function hasMagentoDeployIgnore()
    {
        return $this->hasExtraField(self::MAGENTO_DEPLOY_IGNORE_KEY);
    }

    /**
     * @param $magentoForce
     */
    public function setMagentoForce($magentoForce)
    {
        $this->updateExtraConfig(self::MAGENTO_FORCE_KEY, trim($magentoForce));
    }

    /**
     * @return string
     */
    public function getMagentoForce()
    {
        return (bool)$this->fetchVarFromExtraConfig(self::MAGENTO_FORCE_KEY);
    }

    /**
     * @return bool
     */
    public function hasMagentoForce()
    {
        return $this->hasExtraField(self::MAGENTO_FORCE_KEY);
    }

    public function getMagentoForceByPackageName($packagename)

    {
        return $this->getMagentoForce();
    }

    /**
     * @return bool
     */
    public function hasAutoAppendGitignore()
    {
        return $this->hasExtraField(self::AUTO_APPEND_GITIGNORE_KEY);
    }

    /**
     * @return array
     */
    public function getPathMappingTranslations()
    {
        return (array)$this->fetchVarFromExtraConfig(self::PATH_MAPPINGS_TRANSLATIONS_KEY);
    }

    /**
     * @return bool
     */
    public function hasPathMappingTranslations()
    {
        return $this->hasExtraField(self::PATH_MAPPINGS_TRANSLATIONS_KEY);
    }

    /**
     * @return array
     */
    public function getMagentoDeployOverwrite()
    {
        return (array)$this->transformArrayKeysToLowerCase(
            $this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY)
        );
    }

    public function getMagentoMapOverwrite()
    {
        return $this->transformArrayKeysToLowerCase(
            (array)$this->fetchVarFromExtraConfig(self::MAGENTO_MAP_OVERWRITE_KEY)
        );
    }
    protected function hasExtraField($key)
    {
        return (bool)!is_null($this->fetchVarFromExtraConfig($key));
    }

    /**
     * @param $key
     * @param $value
     */
    protected function updateExtraConfig($key, $value)
    {
        $this->extra[$key] = $value;
        $this->updateExtraJson();
    }

    /**
     * @throws \Exception
     */
    protected function updateExtraJson()
    {
        $composerFile = Factory::getComposerFile();

        if (!file_exists($composerFile) && !file_put_contents($composerFile, "{\n}\n")) {
            throw new Exception(sprintf('%s could not be created', $composerFile));
        }

        if (!is_readable($composerFile)) {
            throw new Exception(sprintf('%s is not readable', $composerFile));
        }

        if (!is_writable($composerFile)) {
            throw new Exception(sprintf('%s is not writable', $composerFile));
        }

        $json = new JsonFile($composerFile);
        $composer = $json->read();

        $baseExtra = array_key_exists(self::EXTRA_KEY, $composer)
            ? $composer[self::EXTRA_KEY]
            : array();

        if (!$this->updateFileCleanly($json, $baseExtra, $this->extra, self::EXTRA_KEY)) {
            foreach ($this->extra as $key => $value) {
                $baseExtra[$key] = $value;
            }

            $composer[self::EXTRA_KEY] = $baseExtra;
            $json->write($composer);
        }
    }

    /**
     * @param JsonFile $json
     * @param array    $base
     * @param array    $new
     * @param          $rootKey
     *
     * @return bool
     */
    private function updateFileCleanly(JsonFile $json, array $base, array $new, $rootKey)

    {
        $contents = file_get_contents($json->getPath());

        $manipulator = new JsonManipulator($contents);

        foreach ($new as $childKey => $childValue) {
            if (!$manipulator->addLink($rootKey, $childKey, $childValue)) {
                return false;
            }
        }

        file_put_contents($json->getPath(), $manipulator->getContents());

        return true;
    }

    /**
     * @param array $array
     *
     * @return array
     */
    public function transformArrayKeysToLowerCase(array $array)
    {
        return array_change_key_case($array, CASE_LOWER);
    }

    public function getComposerRepositories()
    {
        return $this->fetchVarFromConfigArray($this->composerConfig, 'repositories', array());
    }

    /**
     * Get Composer vendor directory
     *
     * @return string
     */
    public function getVendorDir()
    {
        return $this->fetchVarFromConfigArray(
            isset($this->composerConfig['config']) ? $this->composerConfig['config'] : array(),
            'vendor-dir',
            getcwd() . '/vendor'
        );
    }

    /**
     * @return boolean
     */
    public function mustApplyBootstrapPatch()
    {
        return (bool) $this->fetchVarFromExtraConfig(self::EXTRA_WITH_BOOTSTRAP_PATCH_KEY, true);
    }

    /**
     * @return boolean
     */
    public function skipSuggestComposerRepositories()
    {
        return (bool) $this->fetchVarFromExtraConfig(self::EXTRA_WITH_SKIP_SUGGEST_KEY, false);
    }
}


1		<?php
2		/**
3		*
4		*
5		*
6		*
7		*/
8
9		namespace MagentoHackathon\Composer\Magento;
10
11		use Composer\Factory;
12		use Composer\Json\JsonFile;
13		use Composer\Json\JsonManipulator;
14		use SebastianBergmann\Exporter\Exception;
15
16		class ProjectConfig
17		{
18		// Config Keys
19		const EXTRA_KEY = 'extra';
20
21		const SORT_PRIORITY_KEY = 'magento-deploy-sort-priority';
22
23		const MAGENTO_ROOT_DIR_KEY = 'magento-root-dir';
24
25		const MAGENTO_PROJECT_KEY = 'magento-project';
26
27		const MAGENTO_DEPLOY_STRATEGY_KEY = 'magento-deploystrategy';
28		const MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY = 'magento-deploystrategy-overwrite';
29		const MAGENTO_MAP_OVERWRITE_KEY = 'magento-map-overwrite';
30		const MAGENTO_DEPLOY_IGNORE_KEY = 'magento-deploy-ignore';
31
32		const MAGENTO_FORCE_KEY = 'magento-force';
33
34		const AUTO_APPEND_GITIGNORE_KEY = 'auto-append-gitignore';
35
36		const PATH_MAPPINGS_TRANSLATIONS_KEY = 'path-mapping-translations';
37
38		// Default Values
39		const DEFAULT_MAGENTO_ROOT_DIR = 'root';
40
41		const EXTRA_WITH_BOOTSTRAP_PATCH_KEY = 'with-bootstrap-patch';
42
43		const EXTRA_WITH_SKIP_SUGGEST_KEY = 'skip-suggest-repositories';
44
45		protected $libraryPath;
46		protected $libraryPackages;
47		protected $extra;
48		protected $composerConfig;
49
50		/**
51		* @param array $extra
52		* @param array $composerConfig
53		*/
54	31	public function __construct(array $extra, array $composerConfig)
55		{
56	31	$this->extra = $extra;
57	31	$this->composerConfig = $composerConfig;
58
59	31	if (!is_null($projectConfig = $this->fetchVarFromConfigArray($this->extra, self::MAGENTO_PROJECT_KEY))) {
60		$this->applyMagentoConfig($projectConfig);
61		}
62	31	}
63
64		/**
65		* @param array $array
66		* @param string\|integer $key
67		* @param mixed $default
68		*
69		* @return mixed
70		*/
71	31	protected function fetchVarFromConfigArray($array, $key, $default = null)
72		{
73	31	$array = (array)$array;
74	31	$result = $default;
75	31	if (isset($array[$key])) {
76	23	$result = $array[$key];
77		}
78
79	31	return $result;
80		}
81
82		/**
83		* @param $key
84		* @param null $default
85		*
86		* @return null
87		*/
88	28	protected function fetchVarFromExtraConfig($key, $default = null)
89		{
90	28	return $this->fetchVarFromConfigArray($this->extra, $key, $default);
91		}
92
93		/**
94		* @param $config
95		*/
96		protected function applyMagentoConfig($config)
97		{
98		$this->libraryPath = $this->fetchVarFromConfigArray($config, 'libraryPath');
99		$this->libraryPackages = $this->fetchVarFromConfigArray($config, 'libraries');
100		}
101
102		/**
103		* @return mixed
104		*/
105	2	public function getLibraryPath()
106		{
107	2	return $this->libraryPath;
108		}
109
110		/**
111		* @param $packagename
112		*
113		* @return null
114		*/
115		public function getLibraryConfigByPackagename($packagename)
116		{
117		return $this->fetchVarFromConfigArray($this->libraryPackages, $packagename);
118		}
119
120		/**
121		* @return string
122		*/
123	19	public function getMagentoRootDir()
124		{
125	19	return rtrim(
126		trim(
127	19	$this->fetchVarFromExtraConfig(
128	19	self::MAGENTO_ROOT_DIR_KEY,
129	19	self::DEFAULT_MAGENTO_ROOT_DIR
130		)
131		),
132	19	DIRECTORY_SEPARATOR
133		);
134		}
135
136		/**
137		* @param $rootDir
138		*/
139		public function setMagentoRootDir($rootDir)
140		{
141		$this->updateExtraConfig(self::MAGENTO_ROOT_DIR_KEY, rtrim(trim($rootDir), DIRECTORY_SEPARATOR));
142		}
143
144		/**
145		* @return bool
146		*/
147	2	public function hasMagentoRootDir()
148		{
149	2	return $this->hasExtraField(self::MAGENTO_ROOT_DIR_KEY);
150		}
151
152		public function getMagentoVarDir()
153		{
154		return $this->getMagentoRootDir().'var'.DIRECTORY_SEPARATOR;
155		}
156
157		/**
158		* @param $deployStrategy
159		*/
160		public function setDeployStrategy($deployStrategy)
161		{
162		$this->updateExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_KEY, trim($deployStrategy));
163		}
164
165		/**
166		* @return string
167		*/
168	11	public function getDeployStrategy()
169		{
170	11	return trim((string)$this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_KEY));
171		}
172
173		/**
174		* @return bool
175		*/
176		public function hasDeployStrategy()
177		{
178		return $this->hasExtraField(self::MAGENTO_DEPLOY_STRATEGY_KEY);
179		}
180
181		/**
182		* @return array
183		*/
184	6	public function getDeployStrategyOverwrite()
185		{
186	6	return (array)$this->transformArrayKeysToLowerCase(
187	6	$this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY, array())
188		);
189		}
190
191		/**
192		* @return bool
193		*/
194	6	public function hasDeployStrategyOverwrite()
195		{
196	6	return $this->hasExtraField(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY);
197		}
198
199		/**
200		* @param $packagename
201		*
202		* @return integer
203		*/
204	5	public function getModuleSpecificDeployStrategy($packagename)
205		{
206	5	$moduleSpecificDeployStrategies = $this->getDeployStrategyOverwrite();
207
208	5	$strategyName = $this->getDeployStrategy();
209	5	if (isset($moduleSpecificDeployStrategies[$packagename])) {
210		$strategyName = $moduleSpecificDeployStrategies[$packagename];
211		}
212	5	return $strategyName;
213		}
214
215		/**
216		* @param $packagename
217		*
218		* @return integer
219		*/
220	1	public function getModuleSpecificSortValue($packagename)
221		{
222	1	$sortPriorityArray = $this->fetchVarFromExtraConfig(self::SORT_PRIORITY_KEY, array());
		0 ignored issues – show Bug introduced 2015-11-21 00:02 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$sortPriorityArray` is correct as `$this->fetchVarFromExtra..._PRIORITY_KEY, array())` (which targets `MagentoHackathon\Compose...tchVarFromExtraConfig()`) seems to always return null. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
223	1	if (isset($sortPriorityArray[$packagename])) {
224		$sortValue = $sortPriorityArray[$packagename];
225		} else {
226	1	$sortValue = 100;
227	1	if ($this->getModuleSpecificDeployStrategy($packagename) === 'copy') {
		0 ignored issues – show Unused Code Bug introduced 2015-11-21 00:02 UTC by Report Bug Copy Issue Report The strict comparison `===` seems to always evaluate to `false` as the types of `$this->getModuleSpecific...yStrategy($packagename)` (`integer`) and `'copy'` (`string`) can never be identical. Maybe you want to use a loose comparison `==` instead? Loading history...
228		$sortValue++;
229		}
230		}
231	1	return $sortValue;
232		}
233
234		/**
235		* @return array
236		*/
237		public function getMagentoDeployIgnore()
238		{
239		return (array)$this->transformArrayKeysToLowerCase(
240		$this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_IGNORE_KEY)
241		);
242		}
243
244		/**
245		* @param $packagename
246		*
247		* @return array
248		*/
249	11	public function getModuleSpecificDeployIgnores($packagename)
250		{
251	11	$moduleSpecificDeployIgnores = array();
252	11	if ($this->hasMagentoDeployIgnore()) {
253		$magentoDeployIgnore = $this->getMagentoDeployIgnore();
254		if (isset($magentoDeployIgnore['*'])) {
255		$moduleSpecificDeployIgnores = $magentoDeployIgnore['*'];
256		}
257		if (isset($magentoDeployIgnore[$packagename])) {
258		$moduleSpecificDeployIgnores = array_merge(
259		$moduleSpecificDeployIgnores,
260		$magentoDeployIgnore[$packagename]
261		);
262		}
263		}
264	11	return $moduleSpecificDeployIgnores;
265		}
266
267		/**
268		* @return bool
269		*/
270	11	public function hasMagentoDeployIgnore()
271		{
272	11	return $this->hasExtraField(self::MAGENTO_DEPLOY_IGNORE_KEY);
273		}
274
275		/**
276		* @param $magentoForce
277		*/
278		public function setMagentoForce($magentoForce)
279		{
280		$this->updateExtraConfig(self::MAGENTO_FORCE_KEY, trim($magentoForce));
281		}
282
283		/**
284		* @return string
285		*/
286	11	public function getMagentoForce()
287		{
288	11	return (bool)$this->fetchVarFromExtraConfig(self::MAGENTO_FORCE_KEY);
289		}
290
291		/**
292		* @return bool
293		*/
294		public function hasMagentoForce()
295		{
296		return $this->hasExtraField(self::MAGENTO_FORCE_KEY);
297		}
298
299	11	public function getMagentoForceByPackageName($packagename)
		0 ignored issues – show Unused Code introduced 2015-11-21 00:02 UTC by Report Bug Copy Issue Report The parameter `$packagename` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
300		{
301	11	return $this->getMagentoForce();
302		}
303
304		/**
305		* @return bool
306		*/
307	5	public function hasAutoAppendGitignore()
308		{
309	5	return $this->hasExtraField(self::AUTO_APPEND_GITIGNORE_KEY);
310		}
311
312		/**
313		* @return array
314		*/
315	1	public function getPathMappingTranslations()
316		{
317	1	return (array)$this->fetchVarFromExtraConfig(self::PATH_MAPPINGS_TRANSLATIONS_KEY);
318		}
319
320		/**
321		* @return bool
322		*/
323	2	public function hasPathMappingTranslations()
324		{
325	2	return $this->hasExtraField(self::PATH_MAPPINGS_TRANSLATIONS_KEY);
326		}
327
328		/**
329		* @return array
330		*/
331		public function getMagentoDeployOverwrite()
332		{
333		return (array)$this->transformArrayKeysToLowerCase(
334		$this->fetchVarFromExtraConfig(self::MAGENTO_DEPLOY_STRATEGY_OVERWRITE_KEY)
335		);
336		}
337
338	5	public function getMagentoMapOverwrite()
339		{
340	5	return $this->transformArrayKeysToLowerCase(
341	5	(array)$this->fetchVarFromExtraConfig(self::MAGENTO_MAP_OVERWRITE_KEY)
342		);
343		}
344	18	protected function hasExtraField($key)
345		{
346	18	return (bool)!is_null($this->fetchVarFromExtraConfig($key));
347		}
348
349		/**
350		* @param $key
351		* @param $value
352		*/
353		protected function updateExtraConfig($key, $value)
354		{
355		$this->extra[$key] = $value;
356		$this->updateExtraJson();
357		}
358
359		/**
360		* @throws \Exception
361		*/
362		protected function updateExtraJson()
363		{
364		$composerFile = Factory::getComposerFile();
365
366		if (!file_exists($composerFile) && !file_put_contents($composerFile, "{\n}\n")) {
367		throw new Exception(sprintf('%s could not be created', $composerFile));
368		}
369
370		if (!is_readable($composerFile)) {
371		throw new Exception(sprintf('%s is not readable', $composerFile));
372		}
373
374		if (!is_writable($composerFile)) {
375		throw new Exception(sprintf('%s is not writable', $composerFile));
376		}
377
378		$json = new JsonFile($composerFile);
379		$composer = $json->read();
380
381		$baseExtra = array_key_exists(self::EXTRA_KEY, $composer)
382		? $composer[self::EXTRA_KEY]
383		: array();
384
385		if (!$this->updateFileCleanly($json, $baseExtra, $this->extra, self::EXTRA_KEY)) {
386		foreach ($this->extra as $key => $value) {
387		$baseExtra[$key] = $value;
388		}
389
390		$composer[self::EXTRA_KEY] = $baseExtra;
391		$json->write($composer);
392		}
393		}
394
395		/**
396		* @param JsonFile $json
397		* @param array $base
398		* @param array $new
399		* @param $rootKey
400		*
401		* @return bool
402		*/
403		private function updateFileCleanly(JsonFile $json, array $base, array $new, $rootKey)
		0 ignored issues – show Unused Code introduced 2015-11-21 00:02 UTC by Report Bug Copy Issue Report The parameter `$base` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
404		{
405		$contents = file_get_contents($json->getPath());
406
407		$manipulator = new JsonManipulator($contents);
408
409		foreach ($new as $childKey => $childValue) {
410		if (!$manipulator->addLink($rootKey, $childKey, $childValue)) {
411		return false;
412		}
413		}
414
415		file_put_contents($json->getPath(), $manipulator->getContents());
416
417		return true;
418		}
419
420		/**
421		* @param array $array
422		*
423		* @return array
424		*/
425	11	public function transformArrayKeysToLowerCase(array $array)
426		{
427	11	return array_change_key_case($array, CASE_LOWER);
428		}
429
430	4	public function getComposerRepositories()
431		{
432	4	return $this->fetchVarFromConfigArray($this->composerConfig, 'repositories', array());
433		}
434
435		/**
436		* Get Composer vendor directory
437		*
438		* @return string
439		*/
440	7	public function getVendorDir()
441		{
442	7	return $this->fetchVarFromConfigArray(
443	7	isset($this->composerConfig['config']) ? $this->composerConfig['config'] : array(),
444	7	'vendor-dir',
445	7	getcwd() . '/vendor'
446		);
447		}
448
449		/**
450		* @return boolean
451		*/
452	7	public function mustApplyBootstrapPatch()
453		{
454	7	return (bool) $this->fetchVarFromExtraConfig(self::EXTRA_WITH_BOOTSTRAP_PATCH_KEY, true);
455		}
456
457		/**
458		* @return boolean
459		*/
460	5	public function skipSuggestComposerRepositories()
461		{
462	5	return (bool) $this->fetchVarFromExtraConfig(self::EXTRA_WITH_SKIP_SUGGEST_KEY, false);
463		}
464		}
465

Cotya / magento-composer-installer

Push — 3.0 ( 624c58...bf7aea )

ProjectConfig C

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

38 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like