Modelarium\Laravel\Console\Commands\ModelariumFrontendCommand

Complexity

Total Complexity

13

Size/Duplication

Total Lines	115
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	handle()	0	34	8
A	__construct()	0	3	1
A	generateFromModel()	0	36	4

<?php declare(strict_types=1);

namespace Modelarium\Laravel\Console\Commands;

use Formularium\FrameworkComposer;
use Formularium\Model;
use HaydenPierce\ClassFinder\ClassFinder;
use Illuminate\Console\Command;
use Modelarium\Frontend\FrontendGenerator;

class ModelariumFrontendCommand extends Command
{
    use WriterTrait;

The trait Modelarium\Laravel\Console\Commands\WriterTrait requires some properties which are not provided by Modelarium\Laravel\Console\Commands\ModelariumFrontendCommand: $filename, $onlyIfNewFile, $contents

    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'modelarium:frontend
        {name : The model name. Use "*" or "all" for all models}
        {--framework=* : The frameworks to use}
        {--overwrite : overwrite files if they exist}
        {--prettier : run prettier on files}
    ';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Creates frontend using Modelarium';

    /**
     * @var FrameworkComposer
     */
    protected $composer;

    /**
     * Create a new command instance.
     *
     * @return void
     */
    public function __construct()
    {
        parent::__construct();
    }

    /**
     * Execute the console command.
     *
     * @return mixed
     */
    public function handle()
    {
        $name = $this->argument('name');

        // setup stuff
        $frameworks = $this->option('framework');
        if (empty($frameworks)) {
            $this->error('If you are generating frontend you need to specify frameworks. Example: `--framework=HTML --framework=Bootstrap --framework=Vue`');
            return;
        }
        if (!is_array($frameworks)) {

The condition is_array($frameworks) is always true.

            $frameworks = [$frameworks];
        }
      
        $this->composer = FrameworkComposer::create($frameworks);

        if ($name === '*' || $name === 'all') {
            // TODO: all classes
            $classesInNamespace = ClassFinder::getClassesInNamespace('App\\Models');

            foreach ($classesInNamespace as $class) {
                $reflection = new \ReflectionClass($class);
                if (!$reflection->isInstantiable()) {
                    continue;
                }
                $this->generateFromModel($class);
            }
            return;
        } elseif (is_array($name)) {
            // TODO
        } else {
            $this->generateFromModel($name);

It seems like $name can also be of type null; however, parameter $name of Modelarium\Laravel\Console\Commands\ModelariumFrontendCommand::generateFromModel() does only seem to accept string, maybe add an additional type check?

        }
        $this->info('Finished frontend.');
    }

    protected function generateFromModel(string $name)
    {
        $model = $name::getFormularium();
        $generator = new FrontendGenerator($this->composer, $model);
        $collection = $generator->generate();
    
        if (!$collection) {

$collection is of type Modelarium\GeneratedCollection, thus it always evaluated to true.

            $this->info('Nothing generated.');
            return;
        }

        $basepath = base_path('resources/js/components/');

The function base_path was not found. Maybe you did not declare it correctly or list all dependencies?

        $writtenFiles = $this->writeFiles(
            $collection,
            $basepath,
            (bool)$this->option('overwrite')
        );
        $this->info('Files generated.');

        if ($this->option('prettier')) {
            $this->info('Running prettier on generated files.');
            $useYarn = file_exists(base_path('yarn.lock'));
            if ($useYarn) {
                $command = "cd $basepath && npx prettier --write ";
            } else {
                $command = "cd $basepath && yarn prettier --write ";
            }

            // this runs all prettier commands in parallel.
            $run = array_reduce(
                $writtenFiles,
                function ($carry, $f) use ($command) {
                    return $carry . '(' . $command . $f . ') & ';
                }
            );
            shell_exec($run . ' wait');
        }
    }
}