Modelarium\Laravel\Directives\CanDirective

Complexity

Total Complexity

12

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Test Coverage

Coverage

88.1%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	processPolicyTypeDirective()	0	4	1
B	processPolicyFieldDirective()	0	65	11

<?php declare(strict_types=1);

namespace Modelarium\Laravel\Directives;

use GraphQL\Language\AST\DirectiveNode;
use GraphQL\Type\Definition\NonNull;
use Modelarium\Laravel\Targets\PolicyGenerator;
use Modelarium\Laravel\Targets\Interfaces\PolicyDirectiveInterface;

class CanDirective implements PolicyDirectiveInterface
{
    public static function processPolicyTypeDirective(
        PolicyGenerator $generator,

The parameter $generator is not used and could be removed.

        \GraphQL\Language\AST\DirectiveNode $directive

The parameter $directive is not used and could be removed.

    ): void {
    }

    public static function processPolicyFieldDirective(
        PolicyGenerator $generator,
        \GraphQL\Type\Definition\FieldDefinition $field,
        \GraphQL\Language\AST\DirectiveNode $directive
    ): void {
        $ability = '';
        $find = '';
        $injected = false;
        $args = false;

        if ($field->type instanceof NonNull) {
            $type = $field->type->getWrappedType();
        } else {
            $type = $field->type;
        }

        /**
         * @var DirectiveNode $directive
         */

        $model = $type->name; /** @phpstan-ignore-line */
        
        foreach ($directive->arguments as $arg) {
            switch ($arg->name->value) {
                case 'ability':
                    // @phpstan-ignore-next-line
                    $ability = $arg->value->value;

Accessing value on the interface GraphQL\Language\AST\ValueNode suggest that you code against a concrete implementation. How about adding an instanceof check?

                break;
                case 'find':
                    // @phpstan-ignore-next-line
                    $find = $arg->value->value;
                break;
                case 'model':
                    // @phpstan-ignore-next-line
                    $model = $arg->value->value;
                break;
                case 'injectArgs':
                    $injected = true;
                break;
                case 'args':
                    $args = true;
                break;
            }
        }

        list($namespace, $modelClassName, $relativePath) = $generator->splitClassName($model);

        $class = $generator->getPolicyClass($modelClassName);

        $method = $class->addMethod($ability);
        $method->setPublic()
            ->setReturnType('bool')
            ->addBody(
                'return false;'
            );
        $method->addParameter('user')->setType('\\App\\Models\\User')->setNullable(true);

        if ($find) {
            $method->addParameter('model')->setType('\\App\\Models\\' . $modelClassName);
        }
        if ($injected) {
            $method->addParameter('injectedArgs')->setType('array');
        }
        if ($args) {
            $method->addParameter('staticArgs')->setType('array');
        }
    }
}