Modelarium\FormulariumUtils

Complexity

Total Complexity

10

Size/Duplication

Total Lines	84
Duplicated Lines	0 %

Test Coverage

Coverage

48.72%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getFieldFromDirectives()	0	66	8
A	directiveToExtradata()	0	13	2

<?php declare(strict_types=1);

namespace Modelarium;

use ErrorException;
use Formularium\Exception\ClassNotFoundException;
use Formularium\Extradata;
use Formularium\ExtradataParameter;
use Formularium\Field;
use Formularium\Factory\ValidatorFactory;
use Formularium\Metadata;
use GraphQL\Language\AST\DirectiveNode;
use GraphQL\Language\AST\NodeList;
use Modelarium\Exception\Exception;

class FormulariumUtils
{
    public static function getFieldFromDirectives(
        string $fieldName,
        string $datatypeName,
        NodeList $directives
    ): Field {
        $validators = [];
        $renderable = [];
        $extradata = [];
        foreach ($directives as $directive) {
            $name = $directive->name->value;

            if ($name === 'renderable') {
                foreach ($directive->arguments as $arg) {
                    /**
                     * @var \GraphQL\Language\AST\ArgumentNode $arg
                     */

                    $argName = $arg->name->value;
                    $argValue = $arg->value->value; /** @phpstan-ignore-line */

Accessing value on the interface GraphQL\Language\AST\ValueNode suggest that you code against a concrete implementation. How about adding an instanceof check?

                    $renderable[$argName] = $argValue;
                }
                continue;
            }

            $extradata[] = FormulariumUtils::directiveToExtradata($directive);

            $validator = null;

The assignment to $validator is dead and can be removed.

            try {
                $validator = ValidatorFactory::class($name);
            } catch (ClassNotFoundException $e) {
                continue;
            }

            /**
             * @var Metadata $metadata
             */
            $metadata = $validator::getMetadata();
            $arguments = [];

            foreach ($directive->arguments as $arg) {
                /**
                 * @var \GraphQL\Language\AST\ArgumentNode $arg
                 */

                $argName = $arg->name->value;
                $argValue = $arg->value->value; /** @phpstan-ignore-line */

                $argValidator = $metadata->parameter($argName);
                if (!$argValidator) {
                    throw new Exception("Directive $validator does not have argument $argName");
                }
                if ($argValidator->type === 'Int') {
                    $argValue = (int)$argValue;
                }
                $arguments[$argName] = $argValue;
            }

            $validators[$name] = $arguments;
        }

        return new Field(
            $fieldName,
            $datatypeName,
            $renderable,
            $validators,
            $extradata
        );
    }

    public static function directiveToExtradata(DirectiveNode $directive): Extradata
    {
        $metadataArgs = [];
        foreach ($directive->arguments as $arg) {
            $metadataArgs[] = new ExtradataParameter(
                $arg->name->value,
                // @phpstan-ignore-next-line
                $arg->value->value

Accessing value on the interface GraphQL\Language\AST\ValueNode suggest that you code against a concrete implementation. How about adding an instanceof check?

            );
        }
        return new Extradata(
            $directive->name->value,
            $metadataArgs
        );
    }
}