Corollarium /
Formularium
| Conditions | 10 |
| Paths | 96 |
| Total Lines | 32 |
| Code Lines | 21 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php declare(strict_types=1); |
||
| 21 | protected function fix($value, Field $field, HTMLElement $previous): HTMLElement |
||
|
|
|||
| 22 | { |
||
| 23 | foreach ($previous->get('.formularium-disabled') as $e) { |
||
| 24 | $e->addAttribute('class', 'disabled'); |
||
| 25 | } |
||
| 26 | foreach ($previous->get('.formularium-pagination-item') as $e) { |
||
| 27 | $e->addAttribute('class', 'page-item'); |
||
| 28 | } |
||
| 29 | foreach ($previous->get('.formularium-pagination-link') as $e) { |
||
| 30 | $e->addAttribute('class', 'page-link'); |
||
| 31 | } |
||
| 32 | foreach ($previous->get('.formularium-pagination-current') as $e) { |
||
| 33 | $e->addAttribute('class', 'disabled'); |
||
| 34 | } |
||
| 35 | foreach ($previous->get('.formularium-pagination') as $e) { |
||
| 36 | $e->addAttribute('class', 'pagination'); |
||
| 37 | } |
||
| 38 | |||
| 39 | $size = $field->getExtension(Renderable::SIZE, ''); |
||
| 40 | switch ($size) { |
||
| 41 | case Renderable::SIZE_LARGE: |
||
| 42 | foreach ($previous->get('.formularium-pagination') as $e) { |
||
| 43 | $e->addAttribute('class', 'pagination-lg'); |
||
| 44 | } |
||
| 45 | break; |
||
| 46 | case Renderable::SIZE_SMALL: |
||
| 47 | foreach ($previous->get('.formularium-pagination') as $e) { |
||
| 48 | $e->addAttribute('class', 'pagination-sm'); |
||
| 49 | } |
||
| 50 | break; |
||
| 51 | } |
||
| 52 | return $previous; |
||
| 53 | } |
||
| 55 |
This check looks for parameters that have been defined for a function or method, but which are not used in the method body.