Passed
Push — master ( 849c84...3dbed7 )
by Bruno
02:22
created

RenderableMaterializeInputTrait::_editable()   A

Complexity

Conditions 3
Paths 4

Size

Total Lines 24
Code Lines 17

Duplication

Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 1
Metric Value
cc 3
eloc 17
c 1
b 0
f 1
nc 4
nop 3
dl 0
loc 24
rs 9.7
1
<?php
2
3
namespace Formularium\Frontend\Materialize;
4
5
use Formularium\Field;
6
use Formularium\HTMLElement;
7
8
trait RenderableMaterializeInputTrait
9
{
10
    use RenderableMaterializeTrait;
11
12
    public function viewable($value, Field $field, HTMLElement $previous): HTMLElement
0 ignored issues
show
Unused Code introduced by
The parameter $field is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

12
    public function viewable($value, /** @scrutinizer ignore-unused */ Field $field, HTMLElement $previous): HTMLElement

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $value is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

12
    public function viewable(/** @scrutinizer ignore-unused */ $value, Field $field, HTMLElement $previous): HTMLElement

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
13
    {
14
        return $previous;
15
    }
16
17
    public function _editable($value, Field $field, HTMLElement $previous): HTMLElement
0 ignored issues
show
Unused Code introduced by
The parameter $value is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

17
    public function _editable(/** @scrutinizer ignore-unused */ $value, Field $field, HTMLElement $previous): HTMLElement

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
Unused Code introduced by
The parameter $field is not used and could be removed. ( Ignorable by Annotation )

If this is a false-positive, you can also ignore this issue in your code via the ignore-unused  annotation

17
    public function _editable($value, /** @scrutinizer ignore-unused */ Field $field, HTMLElement $previous): HTMLElement

This check looks for parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
18
    {
19
        // add extra classes
20
        $newContent = [];
21
        $input = $previous->get('input');
22
        $input[0]->setAttributes([
23
            'class' => 'validate',
24
        ]);
25
        $newContent[] = $input[0];
26
        $label = $previous->get('label');
27
        if ($label) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $label of type Formularium\HTMLElement[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
28
            $newContent[] = $label[0];
29
        }
30
        $comment = $previous->get('div.comment');
31
        if ($comment) {
0 ignored issues
show
Bug Best Practice introduced by
The expression $comment of type Formularium\HTMLElement[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.

Consider making the comparison explicit by using empty(..) or ! empty(...) instead.

Loading history...
32
            $comment[0]->setTag('span')->setAttributes([
33
                'class' => 'helper-text',
34
                'data-error' => "wrong",
35
                'data-success' => "right"
36
            ]);
37
            $newContent[] = $comment[0];
38
        }
39
        $previous->setContent($newContent);
40
        return $previous;
41
    }
42
}
43